> A sequence of
> pg_upgrade; amcheck; upgrade all extensions; amcheck;
> would make sense.
>
Is it possible to amcheck gist indexes?..
--
Victor Yegorov
es downtime for the project.
If I understand things right, session will release it's locks
when max_standby_streaming_delay is reached.
But it'd be much better if conflict is resolved faster,
around deadlock_timeout.
So — huge +1 from me for fixing it.
--
Victor Yegorov
t;
I am planning to look into this patch in the next few days.
--
Victor Yegorov
er has it in his patch.
Yes, it's possible to shorten this part. But readability is hurt — for
current code I just read it, for the suggested change I need to think about
it.
--
Victor Yegorov
ound no difference between patch and master whatsoever. Which makes me
think, that current
master is quite good at keeping better bloat control (not sure if this is
an effect of
4228817449 commit or deduplication).
I created another setup (see attached testcases). Basically, I emulated
queue operations(INSERT at the end and DELETE
--
Victor Yegorov
;
> Thought?
>
Honestly, I was thinking that this will not be backpatched at all
and really am glad we're getting this fixed in the back branches as well.
Therefore I think it's fine to skip 9.5, though I
would've mentioned this in the commit message.
--
Victor Yegorov
inning of the table,
this is especially true for the append-only tables.
After the delete, planning queries takes a long time, due to MergeJoin
estimates
are using IndexScans ( see
https://postgr.es/m/17467.1426090...@sss.pgh.pa.us )
Right now we have to disable MergeJoins via the ALTER SYSTEM to mitigate
this.
So I would, actually, like it very much for VACUUM to kick in sooner in
such cases.
--
Victor Yegorov
was some work in this area for 14, see
https://git.postgresql.org/pg/commitdiff/44fc6e259b
--
Victor Yegorov
)
+ {
+
+ }
I would rather add a comment, explaining that the empty body of the
clause is actually expected.
7. In the _bt_dedup_delete_finish_pending() you're setting ispromising to
false for both
posting and non-posting tuples. This contradicts comments before
function.
--
Victor Yegorov
ore
we are speaking of heapkeyspace indexes here.
If we'll conditionally raise this flag in the functions above, we can get
rid of blocks that drop it
in _bt_delitems_delete(), I think.
--
Victor Yegorov
ill probably help here,
> too.
>
I don't quite see this part. Do you mean top_block_groups_favorable() here?
--
Victor Yegorov
- queue in the table, with a high rate of INSERTs+DELETEs and a long
transaction.
Currently I've seen such conditions yield indexes of several GB in size
wil holding less
than a thousand of live records.
- upgraded cluster with !heapkeyspace indexes.
--
Victor Yegorov
ebugging purposes, and saves callers the trouble of
> telling _bt_delitems_delete() (and code like it) whether or not this
> is a heapkeyspace index.
>
OK. Can you explain what deprecation means here?
If this functionality is left as is, it is not really deprecation?..
--
Victor Yegorov
ization — then I consider this a very promising improvement!
I haven't done any testing so far since sending my last e-mail.
If you'll have a chance to send a new v10 version with
LP_DEAD-deletion-with-extra-TIDs thing,
I will do some tests (planned).
--
Victor Yegorov
rovements here, that was a general question about
how this works
(trying to clear up gaps in my understanding).
What I meant to ask — will LP_DEAD be set by IndexScan in the presence of
the long transaction?
--
Victor Yegorov
ore committing this.
Therefore I didn't perform any tests here, will wait for the next version.
--
Victor Yegorov
20210111-v13-regression.diffs
Description: Binary data
when I
> want "make installcheck" to pass that specifically accounts for this
> (and a few other similar things).
>
Oh, right, haven't thought of this. Thanks for pointing that out.
Now everything looks good!
--
Victor Yegorov
3f414b476e2c
silently shows another commit.
Is it possible to make the scheme above work?
Our gitweb (and also github) is using it, so I assume people are quite used
to it.
--
Victor Yegorov
hought maybe it's possible to rewrite requests in a form:
/cgit/*/commit/*
into
/cgit/*/commit/?id=&
?
--
Victor Yegorov
ed.
And this is main reason for current approach.
Again, this is my understanding and I hope I got it right.
--
Victor Yegorov
s being more, than actually flagged), this
can
have some positive effects.
Also, I'm not sure where to put it. We've deprecated the BTP_HAS_GARBAGE
flag, maybe it can be reused for this purpose?
--
Victor Yegorov
x27;s perfectly common to find indexes supporting
FK constraints
on highly skewed sets, with 80% of the index belonging to a single value
(say, huge business
customer vs several thousands of one-time buyers).
--
Victor Yegorov
ck-based
accounting provides a better estimate for the usefulness of the operation.
I suppose that 1% threshold should be configurable as a cluster-wide GUC
and also as a table storage parameter?
--
Victor Yegorov
he whole table (well, not really, but
still) to find the operator.
--
Victor Yegorov
~50% of the cases.
I would like to find out what's the real cause here, but I am not sure how
to do it.
If anybody could provide some guidance, I am open to investigate this case.
I'm on PostgreSQL 11.8 (Debian 11.8-1.pgdg90+1), debugging symbols
installed.
--
Victor Yegorov
s reproduces the error I get. One needs to create ltree
extension first.
I understand, that issue most likely comes from the length of the ltree
data stored in the columns.
But error is a bit misleading…
--
Victor Yegorov
lc.pgdump
Description: Binary data
stgreSQL provides only infrastructure, wrappers for different
remote systems are not supported by the PostgreSQL community,
except for postgres_fdw and csv_fdw provided by the project.
--
Victor Yegorov
stgresql.org/message-id/cab7npqtys6juqdxuczbjb0bnw0kprw8wdzuk11kaxqq6o98...@mail.gmail.com
- 2013
https://www.postgresql.org/message-id/cab7npqstfkuc7dzxcdx4hotu63yxhrronv2aouzyd-zz_8z...@mail.gmail.com
- https://commitfest.postgresql.org/16/1276/
--
Victor Yegorov
dn't be difficult to look into.
Peter, according to cfbot patch no longer compiles.
Can you send and update, please?
--
Victor Yegorov
s” is moved
here, I wanted
to mention that both patches should be committed together.
All is good, and the benefits are clearly visible (same setup used).
--
Victor Yegorov
is might be a source
for performance improvements in the core.
4. There's no user visible documentation, please, add one.
I've created a commitfest entry for the patch:
https://commitfest.postgresql.org/51/5432/
I was not able to find you, please, register a community account and set
y
> yourself as an author for the patch.
>
> Done.
>
I've marked this patch as Rejected, per discussion.
Still, I find this functionality nice to have, I'd be happy if you could
create an extension on github (or similar platform).
--
Victor Yegorov
Hey.
I find “Get rid of WALBufMappingLock" commit message misleading, 'cos Lock
it's being replaced by CV, actually.
Should the subject be changed to “Replace WALBufMappingLock with
ConditionVariable” instead?
--
Victor Yegorov
33 matches
Mail list logo
