Re: pg_upgrade check for invalid databases

2024-10-13 Thread Thomas Krennwallner
d databases unrecoverable, so I opted for a skip over invalid databases approach that would leave invalid databases in the old cluster. Apart from a missing --skip-invalid-databases test, does this attempt look OK? From e51f581ddc1158a9fb2840dfc04863618a390887 Mon Sep 17 00:00:0

pg_upgrade check for invalid databases

2024-09-29 Thread Thomas Krennwallner
the proposed patches? From c44f723c033573fa5da72721595bc135a00e3cbf Mon Sep 17 00:00:00 2001 From: Thomas Krennwallner Date: Fri, 20 Sep 2024 17:33:05 -0400 Subject: [PATCH] pg_upgrade: Add check for invalid databases. Currently, pg_upgrade fails to connect to the first invalid datab

Re: pg_upgrade check for invalid databases

2024-09-30 Thread Thomas Krennwallner
On 30/09/2024 17.29, Daniel Gustafsson wrote: On 30 Sep 2024, at 16:55, Tom Lane wrote: TBH I'm not finding anything very much wrong with the current behavior... this has to be a rare situation, do we need to add debatable behavior to make it easier? One argument would be to make the checks