Hi,
While browsing the code, noticed the extra spaces after the function name.
Removed the same in the attached patch.
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
remove_space_from_numeric_function.patch
Description: Binary data
Hi,
Noticed that an extra semicolon in a couple of test cases related to
postgres_fdw. Removed that in the attached patch. It can be backported till
v11 where we added those test cases.
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
remove_extra_semicolon_postgres_fdw.p
err_detail along with the error
> message?
>
Patch looks good to me. Current error message looks ok to me.
Do we need to add double quotes for RESTART word in the error message since
it is an option?
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
78049=#select * from foo;
no | id
+----
1 | *10*
(1 row)
Thoughts?
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
, I think it is breaking the OVERRIDING SYSTEM VALUE clause in INSERT
statement. i.e: without this clause, can insert the modified value from
trigger in identity column. I don't find any document reference for this
behavior.
Thoughts?
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB C
Hi,
The Commit 5955d934194c3888f30318209ade71b53d29777f has changed the logic
to avoid dumping creation and comment commands for the public schema.
>From v11 onwards, we are using the DUMP_COMPONENT_ infrastructure in
selectDumpableNamespace() to skip the public schema creation.
As reported by Pr
rong hour
value.
My suggestion is to match the exact characters from quoted literal string
in input string and if doesn't match then throw an error.
Attached is the POC patch which almost works for all scenarios except for
whitespace - as a quote character.
Suggestions?
--
--
Thanks & R
ormat that
> is known to you in advance.
>
> I hope that helps.
>
> Cheers
> Brendan
>
> On Wed, 24 Jul 2019 at 21:38, Suraj Kharage <
> suraj.khar...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> I noticed the issue in to_timestamp()/to_date() while hand
we
>> can't detect as things stand? I think the only case is an empty
>> directory. If it's not empty, we'd have some entries for the files in
>> that directory, and those files won't be able to exist unless the
>> directory does. But,
Hi Jeevan,
I have incorporated all the comments in the attached patch. Please review
and let me know your thoughts.
On Thu, Nov 21, 2019 at 2:51 PM Jeevan Chalke <
jeevan.cha...@enterprisedb.com> wrote:
>
>
> On Wed, Nov 20, 2019 at 11:05 AM Suraj Kharage <
> suraj.kha
backup by changing the contents of a file but
> not the size, the modification is detected if checksums are used.
> - Everything above still works if there is user-defined tablespace
> that contains a table.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enter
Thanks, Robert for the review.
On Wed, Dec 11, 2019 at 1:10 AM Robert Haas wrote:
> On Tue, Dec 10, 2019 at 6:40 AM Suraj Kharage
> wrote:
> > Please find attached patch for backup validator implementation (0004
> patch). This patch is based
> > on Rushabh's latest
nges that you
> proposed on the mentioned thread.
>
>
I have implemented the simplehash in backup validator patch as Robert
suggested. Please find attached 0002 patch for the same.
kindly review and let me know your thoughts.
Also attached the remaining patches. 0001 and 0003 are same
Thank you for review comments.
On Thu, Dec 19, 2019 at 2:54 AM Robert Haas wrote:
> On Tue, Dec 17, 2019 at 12:54 AM Suraj Kharage
> wrote:
> > I have implemented the simplehash in backup validator patch as Robert
> suggested. Please find attached 0002 patch for the same.
> &
Fixed some typos in attached v5-0002 patch. Please consider this patch for
review.
On Fri, Dec 20, 2019 at 6:54 PM Suraj Kharage <
suraj.khar...@enterprisedb.com> wrote:
> Thank you for review comments.
>
> On Thu, Dec 19, 2019 at 2:54 AM Robert Haas wrote:
>
>> On Tue,
Thank you for review comments.
On Fri, Dec 20, 2019 at 9:14 PM Robert Haas wrote:
> On Fri, Dec 20, 2019 at 8:24 AM Suraj Kharage
> wrote:
> > Thank you for review comments.
>
> Thanks for the new version.
>
> + --verify-backup
>
> Whitespace.
>
Corrected
Thank you for review comments.
On Mon, Dec 30, 2019 at 11:53 PM Robert Haas wrote:
> On Tue, Dec 24, 2019 at 5:42 AM Suraj Kharage
> wrote:
> > To examine the first word of each line, I am using below check:
> > if (strncmp(line, "File", 4) == 0)
> > {
>
On Sat, Oct 21, 2023 at 5:17 AM Andres Freund wrote:
> Hi,
>
> On 2023-09-12 15:27:21 +0530, Suraj Kharage wrote:
> > *[edb@9428da9d2137 postgres]$ cat /etc/redhat-release AlmaLinux release
> 9.2
> > (Turquoise Kodkod)[edb@9428da9d2137 postgres]$ lscpuArchitecture:
cases.
Did the same in the attached patch.
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
Fix_file_name_in_test_case.patch
Description: Binary data
Thanks Daniel and Michael.
On Wed, Sep 6, 2023 at 1:52 PM Daniel Gustafsson wrote:
> > On 6 Sep 2023, at 10:19, Michael Paquier wrote:
> >
> > On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
> >> While browsing the test cases, found that the inc
13fec34 in PostmasterMain (argc=argc@entry=3,
argv=argv@entry=0x19a59a0)
at postmaster.c:1466
#16 0x01096faa in main (argc=, argv=0x19a59a0) at
main.c:198
(gdb) p val
$1 = 0
```
Does anybody have any idea about this?
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
nnerslot for merge join, the value for
attnum 1 is not getting fetched correctly.
On Tue, Sep 12, 2023 at 3:27 PM Suraj Kharage <
suraj.khar...@enterprisedb.com> wrote:
> Hi,
>
> Found server crash on RHEL 9/s390x platform with below test case -
>
> *Machine details:*
>
aro Herrera PostgreSQL Developer —
> https://www.EnterpriseDB.com/
> "We’ve narrowed the problem down to the customer’s pants being in a
> situation
> of vigorous combustion" (Robert Haas, Postgres expert extraordinaire)
>
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
lsite and none in the function. It
> looked a bit schizoid otherwise.
>
yeah, looks good to me.
>
> --
> Álvaro Herrera 48°01'N 7°57'E —
> https://www.EnterpriseDB.com/
> "Postgres is bloatware by design: it was built to house
> PhD theses." (Joey Hellerstein, SIGMOD annual conference 2002)
>
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
|1 | 1 |
2 | row2 |2 | visible | f |2 | 1 |
(4 rows)
Any idea on this?
On Mon, Sep 18, 2023 at 11:20 AM Suraj Kharage <
suraj.khar...@enterprisedb.com> wrote:
> Few more details on this:
>
> (gdb) p val
> $1 = 0
> (gdb) p i
>
Here is clang version:
[edb@9428da9d2137]$ clang --version
clang version 15.0.7 (Red Hat 15.0.7-2.el9)
Target: s390x-ibm-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Let me know if any further information is needed.
On Mon, Oct 9, 2023 at 8:21 AM Suraj Kharage
wrote:
> It lo
27;t think this is committable just yet, but I think it's getting
> fairly close, so if anyone has major objections please speak up soon.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
ouple of very minor bugs which I discovered by writing those
>> tests.
>>
>> - I added documentation, in part based on a draft Mark Dilger shared
>> with me off-list.
>>
>> I don't think this is committable just yet, but I think it's getting
>> fairly close, so if anyone has major objections please speak up soon.
>>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> --
>
> Thanks & Regards,
> Suraj kharage,
> EnterpriseDB Corporation,
> The Postgres Database Company.
>
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
> If there are some others that happen to work, we probably shouldn't
> > remove them for fear of breaking poorly-written apps ... but that does
> > not imply that we need to support every case-variant.
> >
> > regards, tom lane
>
>
>
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
t;
> *"All non-template0 databases must allow connections, i.e. their
> pg_database.datallowconn must be true; database "mydb" has datallowconn set
> to false."*
>
>
>
> Regards,
>
> Jeevan Ladhe
>
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
all the databases other than
> template0
> that are having their pg_database.datallowconn to false in a file. Similar
> approach is seen in other functions like check_for_data_types_usage(),
> check_for_data_types_usage() etc. Thanks Suraj Kharage for the offline
> suggestion.
>
ne place in
> add_foreign_final_paths that uses NULL for List *. I changed it to NIL.
>
> Thanks
> Richard
>
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
8kb which took more time than others might be because of
noise at that time.
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
know your thoughts/suggestions on the same.
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
9.774s
sys 7m41.032s real 7m26.678s
user 0m54.833s
sys 6m20.057s real 19m5.218s
user 1m44.122s
sys 10m17.623s
2nd run real 11m30.500s
user 1m45.221s
sys 9m37.815s real 9m4.103s
user 1m6.893s
sys 7m49.393s real 7m26.713s
user 0m54.868s
sys 6m19.652s real 18m17.230s
user 1m42.749s
sys 9m53.704s
--
--
Hi,
There are some catalog views which do not show the partitioned table and
its index entry.
One of them is "pg_indexes" which failed to show the partitioned index.
Attached the patch which fixes the same.
Other views such as pg_stat*,pg_statio_* has the same problem for
partitioned tables and i
ng close to what Suraj is proposing if there are
> > no objections from others. At least we agree on that part ;)
>
> And this part is done.
> --
> Michael
>
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
*Are you updated: La
re.
>
> Thanks,
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [1]
> http://postgr.es/m/CA+Tgmob8oyh02NrZW=xCScB+5GyJ-jVowE3+TWTUmPF=fsg...@mail.gmail.com
>
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
rds,
>
Yeah, This handling is missing in the provided WIP patch. I believe Robert
will consider this fixing in upcoming version of validator patch.
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
ave tablespace
with no objects (empty tablespace) then backup_manifest does not have any
entry for this hence when you remove this tablespace directory, validator
could not detect it.
We can either document it or add the entry for directories in the manifest.
Robert may have a better idea on this.
with a slash-terminated pathname doesn't work
> as expected.
> Response: Fixed, thanks for the report.
>
> Off-List Report: You forgot a PG_BINARY flag.
> Response: Fixed. I thought I'd done this before but there were two
> places and I'd only fixed one of them.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
--
Thanks & Regards,
Suraj kharage,
EnterpriseDB Corporation,
The Postgres Database Company.
Thanks for the review comments.
On Wed, Nov 20, 2024 at 9:13 AM jian he wrote:
> On Thu, Nov 14, 2024 at 1:02 PM Suraj Kharage
> wrote:
> >
> > Hi,
> >
> > Upstream commit 14e87ffa5c543b5f30ead7413084c25f7735039f added the
> support for named NOT NULL constra
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com <https://www.enterprisedb.com/>
On Tue, Nov 19, 2024 at 6:52 PM jian he wrote:
> On Fri, Nov 15, 2024 at 11:15 AM Robert Haas
> wrote:
> >
> > On Thu, Nov 14, 2024 at 12:02 AM Suraj Kharage <
> sur
oing to be quite problematic because of the
number of weird cases to avoid, so for now that support is not added.
Please share your thoughts on the same.
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com <https://www.enterprisedb.com/>
diff --git a/doc/src/sgml/ref/alter_tab
Thanks, Alvaro, for the review.
I have addressed your comments per the above suggestions in the attached v4
patch.
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com <https://www.enterprisedb.com/>
On Wed, Feb 5, 2025 at 12:11 AM Alvaro Herrera
wrote:
> On 2025-Jan-13,
On Wed, Jan 8, 2025 at 2:43 PM Alvaro Herrera
wrote:
> On 2024-Nov-25, Suraj Kharage wrote:
>
> > Another case which needs conclusion is -
> > When changing from INHERIT to NO INHERIT, we need to walk all children
> and
> > decrement coninhcount for the corresponding
On Tue, Mar 25, 2025 at 9:32 PM Álvaro Herrera
wrote:
> With commit f4e53e10b6ce we introduced a way to flip the NO INHERIT bit
> on not-null constraints. However, because of the way the grammar
> dealt with ALTER CONSTRAINT, we were too blind to see a way to implement
> it using the existing pr
Thanks Alvaro for the review and fixup patch.
I agree with your changes and merged that into the main patch along with a
couple of other changes.
Please find attached v6 for further review.
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com <https://www.enterprisedb.com/>
On
Thanks, Alvaro.
I have revised the patch as per your last update.
Please find attached v5 for further review.
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com <https://www.enterprisedb.com/>
On Wed, Feb 19, 2025 at 9:16 PM Alvaro Herrera
wrote:
> On 2025-Feb-10, Suraj
| t| f
(2 rows)
=
Is there any way to sync up the replication slot after the catalog changes
have been made after creation?
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com <https://www.enterprisedb.com/>
pg_description, so that we retrieve only pg_extension entries
from pg_description.
Attaching the patch for the same.
Thoughts?
[1]
https://www.postgresql.org/message-id/cabueveytmyxc6ovcwkj+rpnhrfi8_rw_+dd_jzgffnpqgf+...@mail.gmail.com
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com &
Thanks, Magnus and Dilip.
--
Thanks & Regards,
Suraj kharage,
enterprisedb.com <https://www.enterprisedb.com/>
On Thu, Jun 5, 2025 at 1:34 PM Magnus Hagander wrote:
>
>
> On Thu, Jun 5, 2025 at 9:50 AM Dilip Kumar wrote:
>
>> On Thu, Jun 5, 2025 at 5:5
52 matches
Mail list logo
