RE: AIX support

Hi Team, We are pursuing to trim the changes wrt AIX. As of now we trimmed the changes with respect to XLC and currently with trimmed changes the buildfarm script passed (build and all the regression tests) The XLC changes were trimmed only in the below file modified: configure modified: co

RE: AIX support

Hi Laurenz, we are working on the other file changes, we shall post you the updates soon. Warm regards, Sriram.

RE: AIX support

Hi Team, Please find the attached patch, which resumes the AIX support with gcc alone. We have removed changes wrt to XLC on AIX. We are also continuing to work on the XLC and IBM-clang(openXLC) specific patch as well. Once we get an approval for the above patch we can submit a subsequent patch

RE: AIX support

akangas Date: Wednesday, 19 June 2024 at 8:45 PM To: Srirama Kucherlapati , Laurenz Albe , Bruce Momjian , Heikki Linnakangas Cc: Peter Eisentraut , Alvaro Herrera , pgsql-hack...@postgresql.org , Noah Misch , Michael Paquier , Andres Freund , Tom Lane , Thomas Munro , tvk1...@gmail.

RE: AIX support

We are continuing to work on the changes… > Do you still care about 32-bit binaries on AIX? If not, let's make that > the default in configure or a check for it, and remove the instructions > on building 32-bit binaries from the docs. As most of the products are moving towards 64bit, we wil

RE: AIX support

Hi Peter, thanks for your feedback. We are eager to extend our support in resolving the issues specific to AIX or corresponding compilers (XLC and cLang). But as there are no issues with the patch after reverting the changes(with the latest compilers gcc12 and xlc-16.0.1.18), we were wondering

RE: AIX support

Hi Heikki and Team, Thanks for your comments. Here are some more details > I still don't understand. We have Linux powerpc systems > running happily in the buildfarm. They are happy with the > current spinlock implementation. Why is this needed? > What happens without it? Not sur

RE: AIX support

> The PPC asm code was originally written in 2002, and the first use of > _ sync_lock_test_and_set(), for ARM, appeared in 2012. The commit that > made __sync_lock_test_and_set() be chosen automatically for platforms > that don't specify anything else was added in 2022. Thanks for

RE: AIX support

> Do you still need mkldexport.sh? Surely there's a better way to do that > in year 2024. Some quick googling says there's a '-bexpall' option to > 'ld', which kind of sounds like what we want. Will that work? How do > other programs do this? We have noticed couple of caveats with

RE: AIX support

Hi Heikki & Team, I tried to look at the assembly code changes with our team, in the below file. diff --git a/src/include/storage/s_lock.h b/src/include/storage/s_lock.h index 29ac6cdcd9..69582f4ae7 100644 --- a/src/include/storage/s_lock.h +++ b/src/include/storage/s_lock.h static __inli

RE: AIX support

Hi Heikki, I have attached the merged patch with all the changes, the earlier patch was just only the changes specific to older review comments. > I'm sorry, I don't understand what you're saying here. Do you mean that > we don't need to do anything here, and the code we have in s_lock.h

RE: AIX support

Hi Heikki and team, A few updates… > > Ok, if we don't need the assembler code at all, that's good. A patch to > > introduce AIX support should not change it for non-AIX powerpc systems > > though. That might be a good change, but would need to be justified > > separately, e.g. by some p

RE: AIX support

Hi Heikki & team, Could you please let me know your comments on the previous details? Attached are the individual patches for AIX and gcc(__sync) routines. Thanks, Sriram. 0001-AIX-support-revert-the-changes-from-0b16bb8776bb8.v5.patch Description: 0001-AIX-support-revert-the-changes-from-0b

RE: AIX support

Hi Heikki, As requested earlier, I need some assistance from the Postgres side to identify any tool or testcase to calibrate the sync routine performance in Postgres. I see the below tools for benchmarking. * Pgbench https://www.postgresql.org/docs/current/pgbench.html * Pg_test_fsync h

RE: AIX support

>> This is not an AIX-specific issue. It was fixed in commit >> af21152268317323480caa790c4a6347110f8085, committed October 30th. Thanks Robert, it worked after applying this change. Warm regards, Sriram.

RE: AIX support

Hi Team, here are few updates. As of now we have removed all the old changes and made the changes that are pretty much required by building from scratch. We had few issues with our hardware as a result it took a while to build the code. Below are the changes done as of now. commit d2b4b4c2259e

RE: AIX support

Hi Team, few more updates on the buildfarm, all the tests have passed and below is the gist of the logs. We are working on the cleaning up the changes and will post them for review. Tue Dec 3 04:08:29 2024: buildfarm run for CHANGEME:HEAD starting CHANGEME:HEAD [04:09:49

RE: AIX support

Hi Team, A few updates regarding the meson build. We have successfully resolved issues with the meson build on AIX, allowing the meson configure and build to succeed. A problem was addressed in the meson script wrt AIX (to build a nested shared libraries), specifically in the symbolextractor.py

RE: AIX support

> Meson appears to have AIX support, so it's worth trying out. Right, meson is supported on AIX, we have meson in our AIX toolbox. We are trying to build with meson as well. I shall update you. BTW, I would like to wish the entire Postgres community a Happy new year. Warm regards, Sriram.

RE: AIX support

Hello Team, In response to our previous discussions, we have refined the code to address only the necessary adjustments focusing solely on the essential modifications for AIX compatibility. The codebase was pulled from the GitHub repository (https://github.com/postgres/postgres.git) and we resolved

RE: AIX support

Hi Heikki, Thanks for your feedback. > Please generate the patches against 'master', rather than v17. We might > choose to backport this to v17 later, but let's focus on the current > development branch for now. All the changes were made on top of master(development) branch pulled from github re

RE: AIX support

Hi Team, Here are the updates on the meson on AIX. Our team had pushed the fixes meson github here … https://github.com/mesonbuild/meson/pull/14335 #14335 Enhance AIX shared library build to use an export List.

RE: AIX support

Hi Heikki, Please find the attached patch addressing the provided comments. Our responses are outlined below. >> - src/backend/port/aix/mkldexport.sh> > Oh, that's interesting. So if we do that, we don't need mkldepxort.sh > anymore? Here the better approach still would be to use the script to e

RE: AIX support

Here are some stats wrt to loop and native memset after enabling optimization with the same test tool(tested for long and long align using MemSetAligned). Corresponding glibc is linked on PPcle and AIX libc is linked on AIX. https://postgrespro.com/list/thread-id/1673194

RE: AIX support

Working on the patch. I will update you. -Sriram.

RE: AIX support

Hi Team, Please find the attached diff with the latest changes. The diff file changes that were done for memset and spinlock, are modified on top of the previous patch. New changes for review: 0001-AIX-support.tas.memset.diffs Previous patch: 0001-AIX-support.v8.patch >> diff --git a/src/includ

RE: AIX support

Hi Team, Our team has identified couple of issues with the meson build on AIX, primarily focusing on the following areas: 1. Symbol extraction and resolution in object files during binary creation. 2. Dynamic runtime library path resolution in shared libraries. We have resolved them and we

RE: AIX support

Hi Wenhui Qiu, May I know the freeze dates. We are nearly ready to deliver the patch. Currently, we have compiled the source using Meson and are investigating one test case issue. Once we pinpoint the cause, we will send you the patch. Notably, this test case behaves differently on AIX, opting fo

RE: AIX support

Hi Heikki and team, Thank you for considering our request. As discussed, we have revised the patch to incorporate all the review comments provided. Please find the attached patch, which focuses solely on the gmake changes. As discussed the meson specific changes would be provided as different pat

RE: Buildfarm setup for AIX

Hi Andrew, Thanks for looking into this. Attached are the log files, regress_log_001_password and 001_password_primary.log This is the error I see in the regress_log_001_password file. server started # Postmaster PID for node "primary" is 15663422 [22:28:33.832](1.867s) ok 1