Re: [Proposal] Add foreign-server health checks infrastructure

servers while reading messages. */ to /* * Skip checking foreign servers while reading messages. */ 4. In connection.c, There is a typo in line 1684, so "fucntion" should be changed to "

Re: Emit a warning if the extension's GUC is set incorrectly

cording to [1], we used the same function name, but the warning level was INFO. Therefore, I think it is OK to use the same function name. [1] https://www.postgresql.org/message-id/flat/200901051634.n05GYNr06169%40momjian.us#1d045374f014494e4b40a4862a000723 -- Regards, -- Shinya Kato A

Re: Emit a warning if the extension's GUC is set incorrectly

On 2021-12-17 01:55, Fujii Masao wrote: On 2021/12/16 16:31, Shinya Kato wrote: Thank you for the review and sorry for the late reply. On 2021-11-16 19:25, Bharath Rupireddy wrote: > I observed an odd behaviour: > 1) I set postgres_fdw.XXX = 'I_messed_up_conf_file' in pos

Re: Emit a warning if the extension's GUC is set incorrectly

On 2021-12-17 15:42, Peter Eisentraut wrote: On 17.12.21 03:25, Shinya Kato wrote: For now, I'v attached the patch that fixed the compilation error. I think it would be good if you could split the uncontroversial new EmitErrorsOnPlaceholders() calls into a separate patch. And please a

Re: Emit a warning if the extension's GUC is set incorrectly

On 2021-12-22 02:23, Tom Lane wrote: Kyotaro Horiguchi writes: At Mon, 20 Dec 2021 21:05:23 +0900, Shinya Kato wrote in We should use EmitWarningsOnPlaceholders when we use DefineCustomXXXVariable. I don't think there is any room for debate. Unfortunately, pltcl.c defines variables

Re: Emit a warning if the extension's GUC is set incorrectly

me. I'm tempted to propose that we also rename EmitWarningsOnPlaceholders to something like MarkGUCPrefixReserved, to more clearly reflect what it does now. (We could provide the old name as a macro alias to avoid breaking extensions needlessly.) +1 -- Regards, -- Shinya Kato Advanced Computing

Re: [Proposal] Add foreign-server health checks infrastructure

*/ 4. In connection.c, There is a typo in line 1684, so "fucntion" should be changed to "function". Maybe all of them were fixed. Thanks! Thank you, and it looks good to me. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

) IS 'test_success'; COMMENT --- So, I think as with \do command, you do not need to complete the operators. Do you think? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: CREATEROLE and role ownership hierarchies

CT]" like "DROP TABLE [ IF EXISTS ] name [, ...] [ CASCADE | RESTRICT ]". What do you think? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

On 2021-10-15 17:49, Ken Kato wrote: 2021-10-15 13:29 に Shinya Kato さんは書きました: On 2021-10-14 14:30, katouknl wrote: It is very good, but it seems to me that there are some tab-completion missing in COMMENT command. For example, - CONSTRAINT ... ON DOMAIN - OPERATOR CLASS - OPERATOR FAMILY

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

On 2021-10-27 14:45, Michael Paquier wrote: On Tue, Oct 26, 2021 at 05:04:24PM +0900, Shinya Kato wrote: Barring any objection, I will change status to Ready for Committer. + else if (Matches("COMMENT", "ON", "PROCEDURAL")) + COMPLETE_WITH("LANGUA

Re: CREATEROLE and role ownership hierarchies

On 2021-10-28 07:21, Mark Dilger wrote: On Oct 25, 2021, at 10:09 PM, Shinya Kato wrote: Hi! Thank you for the patch. I too think that CREATEROLE escalation attack is problem. I have three comments. 1. Is there a function to check the owner of a role, it would be nice to be able to check

Re: CREATEROLE and role ownership hierarchies

. Thank you for the detailed explanation. I now understand what you said. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: CREATEROLE and role ownership hierarchies

On 2021-10-28 07:21, Mark Dilger wrote: On Oct 25, 2021, at 10:09 PM, Shinya Kato wrote: Hi! Thank you for the patch. I too think that CREATEROLE escalation attack is problem. I have three comments. 1. Is there a function to check the owner of a role, it would be nice to be able to check

Emit a warning if the extension's GUC is set incorrectly

-14 18:18:16.486 JST [487067] WARNING: unrecognized configuration parameter "auth_delay.xxx" --- What do you think? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/contrib/auth_delay/auth_delay.c

Re: Emit a warning if the extension's GUC is set incorrectly

riables in src/pl/tcl/pltcl.c which probably should get this treatment as well, it would align it with the pl/perl counterpart. I'll have a closer look and test tomorrow. Thank you for the review! I have missed src/pl/tcl/pltcl.c, so I created the new patch. -- Regards, -- Shinya Kato Adv

Re: [Proposal] Add foreign-server health checks infrastructure

t should not be attached because cfbot cannot understand such a dependency and will throw build error. Do you know how to deal with them in this case? I don't know how to deal with them, but I hope you will attach the PoC, as it may be easier to review. -- Regards, -- Shinya Kato Advanced

Re: Emit a warning if the extension's GUC is set incorrectly

ird party extensions. I plan to change to emit an error when an invalid custom GUC is set in the SET or ALTER SYSTEM SET commands, but I haven't tackled this yet. The patch as of now is attached. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development He

Re: [Proposal] Add foreign-server health checks infrastructure

the rest of the code, it is a good idea to enclose the server name in double quotes. I'll get back to you once I've read all the code. [1] https://www.postgresql.org/docs/devel/error-style-guide.html -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Fix bugs not to discard statistics when changing stats_fetch_consistency

wal_bytes -+-+--- 23592 | 628 | 5939027 (1 row) -- I can see similar cases in pg_stat_archiver, pg_stat_bgwriter, pg_stat_checkpointer, pg_stat_io, and pg_stat_slru. Is it a bug? I fixed it, and do you think? -- Regards, Shinya Kato NTT DATA GROUP CORPORATION

Re: Fix bugs not to discard statistics when changing stats_fetch_consistency

On 2024-02-01 17:33, Michael Paquier wrote: On Thu, Jan 11, 2024 at 06:18:38PM +0900, Shinya Kato wrote: Hi, hackers (Sorry for the delay, this thread was on my TODO list for some time.) There is below description in docs for stats_fetch_consistency. "Changing this parameter in a transa

Remove duplicates of membership from results of \du

 16403 |  16401 |  16400 |   16400 | f    | t | t (2 rows) --- Attached patch resolves this issue. Do you think? Regards, Shinya Kato diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index 058e41e749..8aeb669100 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe

Add --{no-,}bypassrls flags to createuser

? Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref/createuser.sgml b/doc/src/sgml/ref/createuser.sgml index 17579e50af..6c2ee1e0c6 100644 --- a/doc/src/sgml/ref/createuser.sgml +++ b/doc/sr

Re: Add --{no-,}bypassrls flags to createuser

far as schedules are concerned, I don't think this has anything to do with 15. I have registered this patch for the July commit fest. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref

Re: Add --{no-,}bypassrls flags to createuser

On 2022-04-14 18:57, Daniel Gustafsson wrote: On 14 Apr 2022, at 09:42, Shinya Kato wrote: To add the ROLE clause, the originally existing --role option (corresponding to the IN ROLE clause) is changed to the --in-role option. Would this not be good from a backward compatibility standpoint

Re: Add --{no-,}bypassrls flags to createuser

k "-m / --member" is the best choice, although it is ambiguous:( I'd like to hear others' opinions. regards -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref/createuser.sgml b/

Re: Set log_lock_waits=on by default

lock detector". I don't know if we want to go there. Personally, I thought it was a good idea to separate log_lock_waits and deadlock_timeout, but I have not checked how that is implemented. -- Regards, Shinya Kato NTT DATA GROUP CORPORATION

Re: Fix bug in VACUUM and ANALYZE docs

rgument of BUFFER_USAGE_LIMIT can accept. You can see the patch in the attached file. Thanks for the patch. You're right. It looks good to me. -- Regards, Shinya Kato NTT DATA GROUP CORPORATION

Re: Add --{no-,}bypassrls flags to createuser

n about the new DB user. psql is scary for some. :-) Since the createuser command is a wrapper for the CREATE ROLE command, I do not think it is appropriate to add options that the CREATE ROLE command does not have. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research

Re: Add --{no-,}bypassrls flags to createuser

On 2022-05-21 06:45, Nathan Bossart wrote: On Thu, May 19, 2022 at 10:35:23AM +0900, Shinya Kato wrote: I created a new patch to test the new options! Thanks for the new patch! I attached a new version with a few small changes. What do you think? Thanks for updating the patch! It looks

Re: Add --{no-,}bypassrls flags to createuser

k fancier string patterns, while on it, to look after the use of fmtId(), say with role names that include whitespaces or such. Thanks! I changed to the test that describes multiple "-m". It seems to be working without any problems, how about it? -- Regards, -- Shinya Kato Advanced

Re: Add --{no-,}bypassrls flags to createuser

, this means to extend the tests to process lists for --admin with more name patterns. And while on it, we could do the same for the existing command for --role, but this one is on me, being overly-pedantic while looking at the patch :) Thanks! I fixed it. -- Regards, -- Shinya Kato Advanced

Re: Add --{no-,}bypassrls flags to createuser

es but this is not. Sorry, I didn't quite understand the "fancier" pattern. Is a string like this patch correct? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref/createuser.

Fix inconsistencies GUC categories

and subcategory is none at postgresql.conf.sample. -- Trivial changes were made to the following short_desc. -- recovery_prefetch enable_group_by_reordering stats_fetch_consistency -- I've attached a patch. Thoghts? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development

Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

uot; UNION SELECT 'TABLE'" " UNION SELECT 'ONLY'"); warning: 1 line adds whitespace errors. --- 2. The command "LOCK TABLE a, b;" can be executed, but tab-completion doesn't work properly. Is it OK? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

PERATOR FAMILY - POLICY ... ON - [PROCEDURAL] - RULE ... ON - TRIGGER ... ON I think these tab-comletion also can be improved and it's a good timing for that. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Fix typo in func.sgml

Hi hackers, I've found a duplicate "a a" in func.sgml and fixed it. Patch is attached. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml i

Re: Fix typo in func.sgml

On 2022-08-24 20:47, David Rowley wrote: On Wed, 24 Aug 2022 at 22:44, Shinya Kato wrote: I've found a duplicate "a a" in func.sgml and fixed it. Patch is attached. Thanks. Pushed. David Thanks for pushing! -- Regards, -- Shinya Kato Advanced Computing Technology Cent

Fix japanese translation of log messages

Hi hackers, I've found typos in ja.po, and fixed them. The patch is attached. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/backend/po/ja.po b/src/backend/po/ja.po index 0925465d22..189000792c 1

Re: Fix japanese translation of log messages

On 2022-08-26 14:07, Kyotaro Horiguchi wrote: At Fri, 26 Aug 2022 10:23:01 +0900, Shinya Kato wrote in I've found typos in ja.po, and fixed them. The patch is attached. (This is not for -hackers but I'm fine with it being posted here;p) Sorry, I didn't know there was an pg

Re: [PATCH] Tab completion for SET COMPRESSION

"ALTER TABLE NOT OF"? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH] Tab completion for SET COMPRESSION

tch! A minor modification has been made so that the composite type is also completed after "ALTER TABLE OF". Thought? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c

Re: [PATCH] Tab completion for SET COMPRESSION

t as ready for committer. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH]Feature improvement for MERGE tab completion

WHEN") || TailMatches("USING", MatchAny, "AS", MatchAny, "ON", MatchAny, "WHEN") || TailMatches("USING", MatchAny, MatchAny, "ON", MatchAny, "WHEN")) COMPLETE_WITH("MATCHED", "NOT MATCHED"); There are similar redundancies in the tab completion of MERGE statement, so why not fix that as well? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH]Feature improvement for MERGE tab completion

you to fix them. For example, else if (TailMatches("WHEN", "MATCHED")) COMPLETE_WITH("THEN", "AND"); else if (TailMatches("WHEN", "NOT", "MATCHED")) COMPLETE_WITH("THEN", "AND"); above statement can be converted to the statement below. else if (TailMatches("WHEN", "MATCHED") || TailMatches("WHEN", "NOT", "MATCHED")) COMPLETE_WITH("THEN", "AND"); -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH]Feature improvement for MERGE tab completion

ilMatches("WHEN", "MATCHED") || warning: 4 lines add whitespace errors. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH]Feature improvement for MERGE tab completion

On 2022-09-14 18:12, bt22kawamotok wrote: I fixed it in v6. Thanks for updating. + COMPLETE_WITH("UPDATE", "DELETE", "DO NOTHING"); "UPDATE" is always followed by "SET", so why not complement it with "UPDATE SET"?

Set AUTOCOMMIT to on in script output by pg_dump

AUTOCOMMIT on to the scripts created by pg_dump/pg_dumpall/pg_restore, they will work fine. A patch is attached No documentation has been added as we could not find any documentation on the details in the script. Do you think? Regards, Shinya Kato NTT DATA GROUP CORPORATIONFrom

Re: Set AUTOCOMMIT to on in script output by pg_dump

On 2024-10-10 14:56, Shinya Kato wrote: A new patch is attached. I am not a native English, so corrections to the texts are welcome. I created a commit fest entry. https://commitfest.postgresql.org/50/5306/ -- Regards, Shinya Kato NTT DATA GROUP CORPORATION

Re: Set AUTOCOMMIT to on in script output by pg_dump

: > >> On Wed, 09 Oct 2024 11:10:37 +0900 > >> Shinya Kato wrote: > >>> When SQL scripts created with pg_dump/pg_dumpall/pg_restore are > executed > >>> in psql with AUTOCOMMIT turned off, they will not succeed in many > cases. > > > Agreed.

Re: Set AUTOCOMMIT to on in script output by pg_dump

f -h and other short-form switches. We can write the added paragraphs like It is generally recommended to use the -X (--no-psqlrc) option when restoring a database ... to provide clarity about what the switch does. I agree to it and fixed the patch. -- Regards, Shinya Kato NTT D

Re: Set AUTOCOMMIT to on in script output by pg_dump

On 2025-01-26 02:45, Tom Lane wrote: Robert Treat writes: On Wed, Jan 22, 2025 at 8:02 AM Shinya Kato wrote: I agree to it and fixed the patch. LGTM LGTM too. Pushed with a couple of very minor tweaks. regards, tom lane Thank you for pushing! -- Regards

Re: [PATCH] New predefined role pg_manage_extensions

ension the application admins (or whoever) > may create, but that is another topic I think. To use a certain extension, you may need to install the postgresql-contrib package. In that case, is there a way to restrict extensions other than the required one? Or is it unnecessary to impose such restrictions? Regards, Shinya Kato