Re: Add comment explaining why queryid is int64 in pg_stat_statements

2025-05-16 Thread Shaik Mohammad Mujeeb
is might misinterpret it as an unintentional overflow or bug and raise unnecessary concerns. Therefore, it’s worth adding a brief comment clarifying the intent behind this assignment. Thanks & Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho Corp On Fri, 16 May 2025 15

Re: Add comment explaining why queryid is int64 in pg_stat_statements

2025-05-17 Thread Shaik Mohammad Mujeeb
ul to include a similar one in pg_stat_statements_internal() as well. Of course, if this still seems unnecessary, I’m happy to drop the suggestion - just wanted to put it forward in case it helps reduce ambiguity for future readers or contributors. Thanks and Regards, Shaik Mohammad Mujeeb

Add comment explaining why queryid is int64 in pg_stat_statements

2025-05-15 Thread Shaik Mohammad Mujeeb
match the bigint type of the queryid column in the pg_stat_statements view. Please find the attached patch, which adds a clarifying comment to make the rationale explicit and avoid potential confusion for future readers. Thanks and Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho

[Util] Warn and Remove Invalid GUCs

2025-05-21 Thread Shaik Mohammad Mujeeb
d patch for your consideration. Thanks & Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho Corp warn_and_remove_invalid_prefix_gucs.patch Description: Binary data

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Shaik Mohammad Mujeeb
se cases, giving users the choice to opt in to this feedback. Thoughts on this approach?   Thanks & Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho Corp On Thu, 22 May 2025 02:01:25 +0530 David G. Johnston wrote --- On Wednesday, May 21, 2025, Shaik Mo

Re: [Util] Warn and Remove Invalid GUCs

2025-05-22 Thread Shaik Mohammad Mujeeb
his approach. Thanks & Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho Corp On Thu, 22 May 2025 02:08:58 +0530 Tom Lane wrote --- Shaik Mohammad Mujeeb <mailto:mujeeb...@zohocorp.com> writes: > Currently, if there's a typo in an extension name

Re: [Util] Warn and Remove Invalid GUCs

2025-05-23 Thread Shaik Mohammad Mujeeb
has a reserved prefix. 2025-05-23 13:48:21 GMT::@:[29146]:LOG:  redirecting log output to logging collector process 2025-05-23 13:48:21 GMT::@:[29146]:HINT:  Future log output will appear in directory "pg_log". done server started So I felt this approach might be beneficial to others

Re: [Util] Warn and Remove Invalid GUCs

2025-05-23 Thread Shaik Mohammad Mujeeb
tion to spend more time with the current behaviour seriously and will make sure any future proposals are better informed. Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho Corp On Thu, 22 May 2025 22:22:41 +0530 Robert Haas wrote --- On Thu, May 22, 2025 at 12:10 PM Sha

Suggestion: Update Copyright Year to 2025 in Recently Added Files

2025-05-18 Thread Shaik Mohammad Mujeeb
Hi Hackers, I noticed that in the recently added files (waiteventset.h and pg_localeconv_r.c), the copyright notice still mentions the year range as 1996-2024. Just wanted to check - should this be updated to reflect 1996-2025 instead? Thanks & Regards, Shaik Mohammad Mujeeb Member Techn

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Shaik Mohammad Mujeeb
, but to make the message more meaningful and reflective of the actual scenario. If we can reliably detect that it’s a non-PostgreSQL server, we could adjust the warning accordingly and avoid doing a (client-server)version comparison that doesn’t apply in this context. Thanks & Regards, Sha

Re: Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Shaik Mohammad Mujeeb
might be better to adjust the warning accordingly, rather than relying on a client-server version comparison in such cases. Thanks & Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho Corp On Wed, 28 May 2025 04:07:40 +0530 Shaik Mohammad Mujeeb w

Clarification on warning when connecting to 'pgbouncer' database via Pgbouncer

2025-05-27 Thread Shaik Mohammad Mujeeb
Appreciate any insights! Thanks & Regards, Shaik Mohammad Mujeeb Member Technical Staff Zoho Corp