Re: Extend postgres_fdw_get_connections to return remote backend pid

Hi Fujii, On Tue, Feb 18, 2025 at 10:25 PM Fujii Masao wrote: > > I assume you're planning to extend postgres_fdw_get_connections() to > also return the result of PQbackendPID(entry->conn). > However, the patch you attached doesn't seem to include that change. > Did you attach the wrong patch?

Re: Extend postgres_fdw_get_connections to return remote backend pid

Added a CF entry for the same https://commitfest.postgresql.org/patch/5581/ -- Sagar Dilip Shedge, SDE AWS

Extend postgres_fdw_get_connections to return remote backend pid

Dear Hackers, I want to propose to extend existing postgres_fdw_get_connections functionality to return remote server backend pid. Using postgres_fdw extension, backend can establish connections to remote postgres servers. Recently we added functionality to get connection status which can help use

Re: Extend postgres_fdw_get_connections to return remote backend pid

> For now, I think it makes sense to keep postgres_fdw_get_connections() > aligned with the current implementation. Otherwise, explaining what > remote_backend_pid = NULL means could be confusing, especially since > pipeline mode isn't supported yet in postgres_fdw. Make sense. I have created a pa

Re: Extend postgres_fdw_get_connections to return remote backend pid

Hi Fujii, Thanks for updates. Looks good to me. We can proceed with latest potch. -- Sagar Dilip Shedge, SDE AWS

Re: Extend postgres_fdw_get_connections to return remote backend pid

Hi Fujii, > Could you update that? I apologize. Updated documentation. Please review and let me know if you have suggestions to improve wording. On Fri, Feb 21, 2025 at 7:56 PM Fujii Masao wrote: > > > > On 2025/02/21 22:43, Sagar Shedge wrote: > > Hi Fujii, > > &

Re: Extend postgres_fdw_get_connections to return remote backend pid

t; > On 2025/02/21 0:54, Sagar Shedge wrote: > > Hi Fujii, > > > >> Naming is always tricky, but remote_backend_pid feels a bit too long. > > Would remote_pid be sufficient? > > Point looks valid. I had another perspective is to align the naming > > con

Re: Extend postgres_fdw_get_connections to return remote backend pid

Hi Team, Created patch as per recommendation in postgres wiki. -- Sagar Dilip Shedge, SDE AWS v1-0001-Extend-postgres_fdw_get_connections-to-return-rem.patch Description: Binary data

Re: Extend postgres_fdw_get_connections to return remote backend pid

if it's still failing on your setup. On Wed, Feb 19, 2025 at 2:19 PM Fujii Masao wrote: > > > > On 2025/02/19 2:06, Sagar Shedge wrote: > > Hi Fujii, > > > > On Tue, Feb 18, 2025 at 10:25 PM Fujii Masao > > wrote: > > > >> > >> I as

Re: Extend postgres_fdw_get_connections to return remote backend pid

> However, if PGconn is NULL, it seems like postgres_fdw_get_connections() > wouldn't include that connection in the result. If the connection status > is not CONNECTION_OK, it looks like the connection would be closed by > pgfdw_reset_xact_state() before the local backend processes the query > cal