Preserve versions of initdb-created collations in pg_upgrade

2019-10-28 Thread Peter Eisentraut
ame in the new cluster is the same as the one in the old cluster. So it seems more robust to just delete all existing collations and create them from scratch. Thoughts? [0]: https://www.postgresql.org/message-id/ca+hukgkde98dfwkjos7e4z+oamzc-1szfpl3v3ppgi1unvq...@mail.gmail.com -- Peter

Re: Remove one use of IDENT_USERNAME_MAX

2019-10-29 Thread Peter Eisentraut
On 2019-10-28 14:45, Tom Lane wrote: Kyotaro Horiguchi writes: At Sat, 26 Oct 2019 08:55:03 +0200, Peter Eisentraut wrote in IDENT_USERNAME_MAX is the maximum length of the information returned by an ident server, per RFC 1413. Using it as the buffer size in peer authentication is

Re: MinGW compiler warnings in ecpg tests

2019-10-29 Thread Peter Eisentraut
rth it for a single test case, or in other words, if you ask me go ahead with your patch. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Remove unused function argument

2019-10-29 Thread Peter Eisentraut
have an unused function argument without a clear purpose. It would trivial to put it back if needed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 942a2a9fd19fdeb79e82b9849a55daf7fa5b9bff Mon Sep 17 00:00:

Add support for automatically updating Unicode derived files

2019-10-29 Thread Peter Eisentraut
. [0]: https://www.postgresql.org/message-id/flat/bbb19114-af1e-513b-08a9-61272794bd5c%402ndquadrant.com [1]: https://www.postgresql.org/message-id/flat/77f69366-ca31-6437-079f-47fce69bae1b%402ndquadrant.com -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development

Re: Join Correlation Name

2019-10-29 Thread Peter Eisentraut
/ ? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Add const qualifiers to internal range type APIs

2019-10-29 Thread Peter Eisentraut
On 2019-10-28 14:05, Robert Haas wrote: On Mon, Oct 28, 2019 at 5:01 AM Peter Eisentraut wrote: This patch adds const qualifiers to internal range type APIs. It doesn't require any new casts or remove any old ones. Just out of curiosity, what is the motivation for this? I don'

Re: alternative to PG_CATCH

2019-10-29 Thread Peter Eisentraut
ernal use without much care about namespacing. If it becomes a problem, it's easy to address. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: RFC: split OBJS lines to one object per line

2019-10-29 Thread Peter Geoghegan
On Tue, Oct 29, 2019 at 1:09 PM Andres Freund wrote: > Comments? I think that this is a good idea. I see no downside. -- Peter Geoghegan

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7)

2019-10-29 Thread Peter Geoghegan
ry important to be clear about exactly how the key space works. The nbtree work for v12 greatly benefitted from defining comparisons in a way that didn't really change how nbtree worked, while at the same time minimizing I/O and making nbtree faithful to Lehman & Yao's original design. It isn't obvious how valuable it is to really carefully define how invariants and key comparisons work, but it seems possible to solve a lot of problems that way. -- Peter Geoghegan

Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug

2019-10-29 Thread Peter Geoghegan
tted one field from that record, for no good reason. I backpatched a bugfix to the output format for nbtree page splits a few weeks ago, fixing that problem. I agree that we should also backpatch this bugfix. -- Peter Geoghegan

Re: Remove one use of IDENT_USERNAME_MAX

2019-10-30 Thread Peter Eisentraut
On 2019-10-29 15:34, Tom Lane wrote: Peter Eisentraut writes: On 2019-10-28 14:45, Tom Lane wrote: Kyotaro Horiguchi writes: In think one of the reasons for the coding is the fact that *pw is described to be placed in the static area, which can be overwritten by succeeding calls to getpw

Re: Unix-domain socket support on Windows

2019-10-30 Thread Peter Eisentraut
s and prepares the Unix-domain socket specific code to compile cleanly on Windows. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From adcad11992f4fde0a1eda4f96fef4abeb8570cdc Mon Sep 17 00:00:00 2001 From: Peter E

Remove HAVE_LONG_LONG_INT

2019-10-30 Thread Peter Eisentraut
HAVE_LONG_LONG_INT is now implied by the requirement for C99, so the separate Autoconf check can be removed. The uses are almost all in ecpg code, and AFAICT the check was originally added specifically for ecpg. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL

Re: Proposal: Global Index

2019-10-30 Thread Peter Geoghegan
ly complicated new code required for global indexes will be in places like vacuumlazy.c. -- Peter Geoghegan

Re: Parallel leader process info in EXPLAIN

2019-10-30 Thread Peter Geoghegan
k on this now, but perhaps you have time for it. -- Peter Geoghegan

Re: Thoughts on nbtree with logical/varwidth table identifiers, v12 on-disk representation

2019-10-30 Thread Peter Geoghegan
On Mon, Apr 22, 2019 at 9:35 AM Andres Freund wrote: > On 2019-04-21 17:46:09 -0700, Peter Geoghegan wrote: > > Andres has suggested that I work on teaching nbtree to accommodate > > variable-width, logical table identifiers, such as those required for > > indirect indexes,

Re: Thoughts on nbtree with logical/varwidth table identifiers, v12 on-disk representation

2019-10-30 Thread Peter Geoghegan
es etc benefit users? Global indexes seem doable. I don't see how "indirect" indexes can ever work in Postgres. I don't know exactly what zedstore needs here, but maybe it can work well with a less ambitious design for varwidth TIDs along the lines I've sketched. -- Peter Geoghegan

Re: Thoughts on nbtree with logical/varwidth table identifiers, v12 on-disk representation

2019-10-30 Thread Peter Geoghegan
x27;t be able to tolerate having to widen every TID in the posting list all at once when new tuples are inserted that have TIDs that are one byte wider, that go in the same posting list (as I said, keeping the space accounting simple is particularly important for nbtree). This even seems hard for GIN, which thinks of TIDs as an array of fixed width ints in many contexts. Also, BRIN revmap pages are also mostly just arrays of 6 byte item pointers, that rely on simple pointer arithmetic to do random access. -- Peter Geoghegan

Re: Add const qualifiers to internal range type APIs

2019-10-30 Thread Peter Eisentraut
On 2019-10-29 21:11, Andres Freund wrote: On 2019-10-29 16:48:24 +0100, Peter Eisentraut wrote: On 2019-10-28 14:05, Robert Haas wrote: Just out of curiosity, what is the motivation for this? I don't remember. :-) I had this code lying around from earlier "adventures in const&

Re: ICU for global collation

2019-10-31 Thread Peter Eisentraut
backend/tsearch/ts_locale.c for starting points. These APIs spread out to a lot of places, so it will take some time to finish. In the meantime, I'm pausing this thread and will set the CF entry as RwF. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Remove configure --disable-float4-byval and --disable-float8-byval

2019-10-31 Thread Peter Eisentraut
once since PG9.2 already. float4 is now always pass-by-value; the pass-by-reference code path is completely removed. float8 and related types are now hardcoded to pass-by-value or pass-by-reference depending on whether the build is 64- or 32-bit, as was previously also the default. -- Peter

Refactor parse analysis of EXECUTE command

2019-11-01 Thread Peter Eisentraut
there are any problems. [0]: https://www.postgresql.org/message-id/flat/ed2767e5-c506-048d-8ddf-280ecbc9e1b7%402ndquadrant.com -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: alternative to PG_CATCH

2019-11-01 Thread Peter Eisentraut
On 2019-10-29 17:10, Tom Lane wrote: Peter Eisentraut writes: On 2019-10-28 13:45, Robert Haas wrote: In theory, the do_rethrow variable could conflict with a symbol declared in the surrounding scope, but that doesn't seem like it's a problem worth getting worked up about. Right.

Re: [PATCH] Add some useful asserts into View Options macroses

2019-11-01 Thread Peter Eisentraut
called in proper context, and we do the convertation properly. At least when running tests with asserts turned on. Committed. I simplified the parentheses by one level from your patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA

Re: pglz performance

2019-11-01 Thread Peter Eisentraut
oceed with this. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pause recovery if pitr target not reached

2019-11-01 Thread Peter Eisentraut
? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Add a GUC variable that control logical replication

2019-11-01 Thread Peter Eisentraut
to do this with a USERSET setting. If we need different hooks or more DDL commands do this better, then that can be considered. But this seems to be the wrong way to do it. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Tra

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-01 Thread Peter Geoghegan
nough to justify keeping all the SIZEOF_DATUM crud around. -- Peter Geoghegan

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-01 Thread Peter Geoghegan
t for us. We maintain non-trivial 32-bit only code for numeric abbreviated keys. We also have to worry about pfree()'ing memory when USE_FLOAT8_BYVAL within heapam_index_validate_scan(). How confident are we that there isn't some place that leaks memory on !USE_FLOAT8_BYVAL builds because somebody forgot to add a pfree() in an #ifdef block? -- Peter Geoghegan

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-01 Thread Peter Geoghegan
ng that we should go out of our way to eliminate on general principle. All good portable C codebases go to great lengths to encapsulate platform differences, if necessary by adding a compatibility layer. One of the worst things about the OpenSSL codebase is that it makes writing portable code everybody's problem. -- Peter Geoghegan

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-01 Thread Peter Geoghegan
ig hit for > > a 32-bit platform --- more instructions, more memory consumed for > > things like Datum arrays, all in a memory space that's not that big. > > I don't agree as well with the line of arguments to just remove 32b > support. Clearly you didn't read what I actually wrote, Michael. -- Peter Geoghegan

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-02 Thread Peter Eisentraut
On 2019-10-31 14:36, Tom Lane wrote: Peter Eisentraut writes: float4 is now always pass-by-value; the pass-by-reference code path is completely removed. I think this is OK. OK, here is a patch for just this part, and we can continue the discussion on the rest in the meantime. -- Peter

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-02 Thread Peter Eisentraut
--++--+-- macaddr8 | 8 | f| i (1 row) This might be a case of the above issue: It's easier to just make it pass by reference always than deal with a bunch of #ifdefs. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Develo

Re: Index Skip Scan

2019-11-02 Thread Peter Geoghegan
he latter, but I find the naming a little bit confusing. Maybe rename _bt_skip() to something that is a little bit more suggestive of its purpose. * Suggest running pgindent on the patch. [1] https://wiki.postgresql.org/wiki/Index_Maintenance#Summarize_keyspace_of_a_B-Tree_index -- Peter Geoghegan

Re: Index Skip Scan

2019-11-02 Thread Peter Geoghegan
On Sat, Nov 2, 2019 at 11:56 AM Peter Geoghegan wrote: > On Wed, Sep 25, 2019 at 2:33 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > v27-0001-Index-skip-scan.patch > > Some random thoughts on this: And now some more: * I'm confused about this code in _bt_skip():

Re: Refactor parse analysis of EXECUTE command

2019-11-03 Thread Peter Eisentraut
On 2019-11-02 16:00, Tom Lane wrote: Peter Eisentraut writes: This patch moves the parse analysis component of ExecuteQuery() and EvaluateParams() into a new transformExecuteStmt() that is called from transformStmt(). Uhmm ... no actual patch attached? Oops, here it is. -- Peter

Re: alternative to PG_CATCH

2019-11-04 Thread Peter Eisentraut
s not clear why only a handful of cases cause warnings, but my guess is that the functions are above some size/complexity threshold beyond which those older compilers give up doing a full analysis. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: adding partitioned tables to publications

2019-11-04 Thread Peter Eisentraut
ny work in table DDL to keep the list of published tables up to date. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: v12 and pg_restore -f-

2019-11-05 Thread Peter Eisentraut
rom introducing PG12 into their environment. This is very complicated and risky for them. I think we should revert the part that requires using -f - at least for PG12. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)

2019-11-05 Thread Peter Eisentraut
se after session start either. Both of these options are not without problems. We should have a complete plan for this before implementing the feature in the server. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: v12 and pg_restore -f-

2019-11-05 Thread Peter Eisentraut
a generous transition period. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: alternative to PG_CATCH

2019-11-05 Thread Peter Eisentraut
Here is a patch to fix it. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From aa758de0919e2356bf46390b89d8b17d20b8c09e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 5 Nov 2019 22:01:18 +0100 Subject: [PAT

Re: Remove unused function argument

2019-11-05 Thread Peter Eisentraut
On 2019-10-30 06:51, vignesh C wrote: On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut wrote: The cache_plan argument to ri_PlanCheck has not been used since e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it. That commit said "I left it alone in case there is any future

Re: pause recovery if pitr target not reached

2019-11-05 Thread Peter Eisentraut
%40postgrespro.ru -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [proposal] recovery_target "latest"

2019-11-05 Thread Peter Eisentraut
ot;. What does that mean? It means until restore_command errors. Let's think of a name that reflects that better. Maybe "all_archive" or something like that. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Removing pg_pltemplate and creating "trustable" extensions

2019-11-05 Thread Peter Eisentraut
rolled by the CREATE privilege on the containing database, so a separate setting for database owner vs. regular user might not be necessary. Regular users would need both the role membership (given by the overall superuser) and the privilege within the database (given by the database owner).

Re: pglz performance

2019-11-06 Thread Peter Eisentraut
o be the opposite of, or at least inconsistent with, results earlier in the thread. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pglz performance

2019-11-06 Thread Peter Eisentraut
of months old, and the recent posts attach just a single patch. Andrey, can you post current versions of both patches? OK, waiting on some independent verification of benchmark numbers. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: tableam vs. TOAST

2019-11-06 Thread Peter Eisentraut
t, though. Providing that mechanism can be a separate subproject of pluggable storage. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: ICU for global collation

2019-11-06 Thread Peter Eisentraut
measure to support extensions like you mention above. But our own internal code should not have to rely on that. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Collation versioning

2019-11-06 Thread Peter Eisentraut
he column -> type dependency. Obviously, a lot more work would have to be done to make this work, but I think the concept of this catalog is sound. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: segmentation fault when cassert enabled

2019-11-06 Thread Peter Eisentraut
ook like a major problem, it just allocates more memory than needed. Right. I have committed a fix for this. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: alternative to PG_CATCH

2019-11-07 Thread Peter Eisentraut
On 2019-11-06 15:49, Tom Lane wrote: Peter Eisentraut writes: On 2019-11-04 16:01, Tom Lane wrote: Now that I've actually looked at the patched code, there's a far more severe problem with it. Namely, that use of PG_FINALLY means that the "finally" segment is run witho

Re: tableam vs. TOAST

2019-11-07 Thread Peter Eisentraut
plementation concern of the AM. How much more work would it be to refactor TOAST into a separate API that an AM implementation could use or not? How much more complicated would the result be? I guess you would like to at least have it explored. -- Peter Eisentraut http://w

Re: Remove HAVE_LONG_LONG_INT

2019-11-07 Thread Peter Eisentraut
On 2019-10-30 14:49, Peter Eisentraut wrote: HAVE_LONG_LONG_INT is now implied by the requirement for C99, so the separate Autoconf check can be removed. The uses are almost all in ecpg code, and AFAICT the check was originally added specifically for ecpg. committed -- Peter Eisentraut

Re: Refactor parse analysis of EXECUTE command

2019-11-07 Thread Peter Eisentraut
ensure that side effects of parser hooks happen at the expected time." So there appears to be a generally uneasy situation still about how to do this correctly. Perhaps something could be done about the issue "because we don't attempt to re-acquire locks for utility state

Re: Refactor parse analysis of EXECUTE command

2019-11-08 Thread Peter Eisentraut
ly on SQL level is not possible do prepare on execute. So execute should be evaluate as one step. Well, that's kind of the question that is being discussed in this thread. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: CountDBSubscriptions check in dropdb

2019-11-09 Thread Peter Eisentraut
good time to commit this. Let me know if anyone has objections? I think the change makes sense for master, but I don't think it should be backpatched. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: base backup client as auxiliary backend process

2019-11-09 Thread Peter Eisentraut
s but done server-side. See attached patch for a demonstration. Any reason not to do that? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From 6ae76011ece6a5900cc06e2350b0ccb930eb41a0 Mon Sep 17 00:00:

Re: adding partitioned tables to publications

2019-11-11 Thread Peter Eisentraut
o allow further combinations. What situation are you trying to address here? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: tableam vs. TOAST

2019-11-11 Thread Peter Eisentraut
about "chunk %d" or "chunk number %d", they usually mean the "seq" and not the "id". -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

RE: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-11-12 Thread Smith, Peter
From: Andres Freund Sent: Wednesday, 13 November 2019 6:01 AM >Peter Smith: > > Is there a reason to not just make StaticAssertExpr and StaticAssertStmt be > the same? I don't want to proliferate variants that users have to understand > if there's no compelling >

RE: New SQL counter statistics view (pg_stat_sql)

2019-11-12 Thread Smith, Peter
. An updated patch which fixes the docs issue is attached. Kind Regards. Peter Smith --- Fujitsu Australia 0001-pg_stat_sql.patch Description: 0001-pg_stat_sql.patch

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2019-11-13 Thread Peter Geoghegan
On Wed, Nov 13, 2019 at 11:33 AM Robert Haas wrote: > On Tue, Nov 12, 2019 at 6:22 PM Peter Geoghegan wrote: > > * Disabled deduplication in system catalog indexes by deeming it > > generally unsafe. > > I (continue to) think that deduplication is a terrible name, because

Re: Building infrastructure for B-Tree deduplication that recognizes when opclass equality is also equivalence

2019-11-13 Thread Peter Geoghegan
1.patch". That is our policy. (A catversion bump is generally supposed to be done at the last minute, just as the patch is committed. This avoids unnecessary conflicts against the master branch over time, as a patch is developed.) -- Peter Geoghegan

could not stat promote trigger file leads to shutdown

2019-11-14 Thread Peter Eisentraut
this happens in the startup process, the ERROR is turned into a FATAL and the whole instance shuts down. That seems like a harsh penalty. Would it be better to turn this ERROR into a WARNING? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Supp

Re: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-11-14 Thread Peter Eisentraut
on to compile, so it worked(tm) at some point, but I probably didn't try it with a not-gcc compatible compiler at the time. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: could not stat promote trigger file leads to shutdown

2019-11-15 Thread Peter Eisentraut
run mkdir /srv/foobar and, depending circumstances such as root's umask or the permissions of /srv, your PostgreSQL server crashes immediately. That can't be good. Also imagine the above steps being run by a configuration management system. -- Peter Eisentraut h

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2019-11-15 Thread Peter Geoghegan
ves compression and > just put enough other words in there to make it clear e.g. duplicate > value compression, or something of that sort. Does anyone else want to weigh in on this? Anastasia? I will go along with whatever the consensus is. I'm very close to the problem we're trying to solve, which probably isn't helping me here. -- Peter Geoghegan

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2019-11-15 Thread Peter Geoghegan
On Wed, Sep 11, 2019 at 2:04 PM Peter Geoghegan wrote: > > I haven't measured how these changes affect WAL size yet. > > Do you have any suggestions on how to automate testing of new WAL records? > > Is there any suitable place in regression tests? > > I don't

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2019-11-15 Thread Peter Geoghegan
On Fri, Nov 15, 2019 at 5:43 PM Mark Dilger wrote: > On 11/13/19 11:51 AM, Peter Geoghegan wrote: > > Can you suggest an alternative? > > Dupression This suggestion makes me feel better about "deduplication". -- Peter Geoghegan

Re: [HACKERS] [PROPOSAL] Effective storage of duplicates in B-tree index.

2019-11-15 Thread Peter Geoghegan
://daslab.seas.harvard.edu/rum-conjecture/ -- Peter Geoghegan

Re: adding partitioned tables to publications

2019-11-19 Thread Peter Eisentraut
dump. What happens when you add a leaf table directly to a publication? Is it replicated under its own identity or under its ancestor partitioned table? (What if both the leaf table and a partitioned table are publication members?) -- Peter Eisentraut http://www.2ndQuadran

Re: adding partitioned tables to publications

2019-11-19 Thread Peter Eisentraut
\" as logical replication target", + rv->schemaname, rv->relname), It doesn't seem necessary. What happens if you remove it? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: could not stat promote trigger file leads to shutdown

2019-11-20 Thread Peter Eisentraut
On 2019-11-15 19:23, Tom Lane wrote: Peter Eisentraut writes: Say you want to set up promote_trigger_file to point to a file outside of the data directory, maybe because you want to integrate it with some external tooling. So you go into your configuration and set promote_trigger_file

Why is get_actual_variable_range()'s use of SnapshotNonVacuumable safe during recovery?

2019-11-20 Thread Peter Geoghegan
-log lastBlockVacuumed (we also don't need to call _bt_delitems_vacuum() one last time in the case where we don't have anything to kill on the last block, just so the pin scan can happen -- it won't ever happen). -- Peter Geoghegan

Re: an OID >= 8000 in master

2019-11-20 Thread Peter Geoghegan
m OID from this range, so this will probably be very common soon. -- Peter Geoghegan

Re: an OID >= 8000 in master

2019-11-20 Thread Peter Geoghegan
On Wed, Nov 20, 2019 at 6:07 PM Michael Paquier wrote: > Yep, agreed. This looks like an oversight. Peter? It's not an oversight. See the commit message of a6417078, and the additions that were made to the RELEASE_CHANGES file. -- Peter Geoghegan

Re: an OID >= 8000 in master

2019-11-20 Thread Peter Geoghegan
to use the non-reserved/development OID ranges directly. For example, a committer may prefer to use an OID that is close to the OIDs already used for a set of related objects, if the related objects are already in a stable release. (I'm not sure that it's really worth doing that, but that's what the policy is.) -- Peter Geoghegan

RE: Proposal: Make use of C99 designated initialisers for nulls/values arrays

2019-11-20 Thread Smith, Peter
say in support of my patch; it will live or it will die according to the community wish. If nothing else, at least I've learned a new term - "bike shedding" :-) Kind Regards. --- Peter Smith Fujitsu Australia

Re: fix "Success" error messages

2019-11-21 Thread Peter Eisentraut
oblem, so retrying wouldn't actually help much. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: tableam vs. TOAST

2019-11-21 Thread Peter Eisentraut
you state that this assertion replaces a run-time check, but I couldn't quite make out which one you are referring to because all the existing run-time checks are kept, with slightly refactored conditions. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [proposal] recovery_target "latest"

2019-11-21 Thread Peter Eisentraut
separate discussion. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pause recovery if pitr target not reached

2019-11-21 Thread Peter Eisentraut
arget, that currently does not respect the recovery_target_action setting, but perhaps it should. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-21 Thread Peter Eisentraut
On 2019-11-02 08:39, Peter Eisentraut wrote: On 2019-10-31 14:36, Tom Lane wrote: Peter Eisentraut writes: float4 is now always pass-by-value; the pass-by-reference code path is completely removed. I think this is OK. OK, here is a patch for just this part, and we can continue the

Re: base backup client as auxiliary backend process

2019-11-22 Thread Peter Eisentraut
temporary slot use on the walreceiver side, essentially mirroring what pg_basebackup already does. I think this patch set might be useful on its own, even without the base backup stuff to follow. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote

Re: adding partitioned tables to publications

2019-11-22 Thread Peter Eisentraut
goal of being able to add partitioned tables to publications and have that implicitly expand to all member partitions on the publication side seemed quite useful, self-contained, and uncontroversial. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Supp

Re: pause recovery if pitr target not reached

2019-11-22 Thread Peter Eisentraut
recovery_target_action into account. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] WAL logging problem in 9.4.3?

2019-11-22 Thread Peter Eisentraut
roach involving unlogged tables to get a similar performance benefit? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [PATCH][BUG FIX] Pointer var initilialized with boolean.

2019-11-22 Thread Peter Geoghegan
On Fri, Nov 22, 2019 at 9:30 AM Ranier Vilela wrote: > > Hi, > Typo mystake? > Pointer var initilialized with boolean. This was already fixed by commit 0cafdd03a850265006c0ada1b0bf4f83e087a409. -- Peter Geoghegan

Re: [PATCH] Fix possible underflow in expression (maxoff - 1)

2019-11-24 Thread Peter Geoghegan
using a static analysis tool? -- Peter Geoghegan

Re: [PATCH] Fix possible underflow in expression (maxoff - 1)

2019-11-24 Thread Peter Geoghegan
ouldn't make any sense to fix it in this specific esoteric function, which is called when we've already decided to split the page (but only sometimes). Sanitization needs to happen at some central choke point. > Yes,two static tools, but reviewed by me. I strongly suggest confining all of this to a single thread, and stating your reasoning upfront. -- Peter Geoghegan

Re: [PATCH] Fix possible underflow in expression (maxoff - 1)

2019-11-24 Thread Peter Geoghegan
>stating your reasoning upfront. > I don't know what that means. Instead of starting new email threads for each issue, confine the entire discussion to just one thread. This makes the discussion much more manageable for everyone else. This is a high traffic mailing list. -- Peter Geoghegan

Re: pglz performance

2019-11-26 Thread Peter Eisentraut
On 2019-11-26 10:43, Tomas Vondra wrote: In general, I think the results for both patches seem clearly a win, but maybe patch 1 is bit better, especially on the newer (xeon) CPU. So I'd probably go with that one. Patch 1 is also the simpler patch, so it seems clearly preferable. --

Re: Remove configure --disable-float4-byval and --disable-float8-byval

2019-11-26 Thread Peter Eisentraut
. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 8ae788d3dd6bfea1b386955b8f161897691d6100 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 26 Nov 2019 21:15:25 +0100 Subject: [PATCH v3] Move confi

Re: [HACKERS] Regression tests vs existing users in an installation

2019-11-26 Thread Peter Eisentraut
ests" in the attached. I found this directory, and it seems like a good place to add some more tests (other thread), but I'm puzzled why it's hidden under modules/, since it's not, well, a module. Why is it not in src/test/? -- Peter Eisentraut http://www.

Re: Collation versions on Windows (help wanted, apply within)

2019-11-26 Thread Peter Eisentraut
a non-NULL string or return * NULL (if it doesn't support versions). It must not return NULL for some * collcollate and not NULL for others. I'm not sure why, or if that really makes sense. Peter E, do you have any thoughts on this question? Doesn't make sense to me eit

RE: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-11-27 Thread Smith, Peter
; StaticAssertStmt(condition, errmessage) ^ ../../src/include/c.h:1184:3: note: in expansion of macro 'StaticAssertExpr' (StaticAssertExpr(__builtin_types_compatible_p(__typeof(expr), const underlying_type), \ ^ path.c:127:11: note: in expansion of macro 'unconstify' return unconstify(char *, p); ^ Kind Regards. --- Peter Smith Fujitsu Australia

RE: Proposal: Add more compile-time asserts to expose inconsistencies.

2019-11-27 Thread Smith, Peter
patch to achieve; my use-cases are C code only * It is too risky for me to simply cut/paste my C version of StaticAssertDecl and hope it will work OK for C++. It needs lots of testing because there seems evidence that bad things can happen. E.g. Peter Eisentraut wrote "if you're asking,

<    19   20   21   22   23   24   25   26   27   28   >