Re: Add 64-bit XIDs into PostgreSQL 15

xander, thanks for your attention to the patchset. Your questions and review are very much welcome! The participation of other hackers is highly appreciated as always! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Add 64-bit XIDs into PostgreSQL 15

We try to do changes in small batches so I consider we can manage parallel changes. At least I read this thread very often and can answer soon, even if our new versions of patches are not ready. Again I consider the work you propose useful and big thanks to you, Alexander! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Add 64-bit XIDs into PostgreSQL 15

;ve answered is still not visible in the thread and to CFbot. Can something be done in hackers' moderation engine to make new versions patches become visible hassle-free? -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Problem with moderation of messages with patched attached.

reason for such inconvenience. The problem still exists as of today. Can someone make changes in a moderation engine to make it more liberal and convenient for authors? [1] https://www.postgresql.org/message-id/flat/CACG%3DezZe1NQSCnfHOr78AtAZxJZeCvxrts0ygrxYwe%3DpyyjVWA%40mail.gmail.com -- Best regards

Re: Problem with moderation of messages with patched attached.

> > Message to list pgsql-hackers held for moderation due to 'Size 1MB > (1061796 bytes) is larger than threshold 1000KB (1024000 bytes)', notice > queued for 2 moderators > Could you make this limit 2MB at least for authorized commitfest members? Thanks! -- Best regards

Re: Problem with moderation of messages with patched attached.

w.postgresql.org/message-id/flat/CACG%3DezZe1NQSCnfHOr78AtAZxJZeCvxrts0ygrxYwe%3DpyyjVWA%40mail.gmail.com -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Problem with moderation of messages with patched attached.

> > There's a FAQ link on the cfbot main page that answers this kind of > questions. > Good to know! I'll try [.gz] next time then. Thanks!

Re: Add 64-bit XIDs into PostgreSQL 15

xt time. I've requested increasing threshold to 2 MB [1] [1] https://www.postgresql.org/message-id/flat/CALT9ZEGbAR84q_emsf1TUMPqXT%3Dc8CxN16g-HQCxgkLzekM%2BQg%40mail.gmail.com -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Problem with moderation of messages with patched attached.

> > On Thu, 3 Mar 2022 at 13:28, Pavel Borisov wrote: > >> The mail system doesn't have the capability to apply different moderation >>> rules for people in that way I'm afraid. >>> >> Maybe then 2MB for everyone? Otherwise it's not so conv

[PATCH] Double declaration in pg_upgrade.h

Hi, hackers! I've noticed that check_ok() in pg_upgrade.h has been declared two times. Here's a one-line patch correcting this. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v1-0001-Fix-double-declaration

Re: Add 64-bit XIDs into PostgreSQL 15

and 0002) as RfC. All activity, improvement, review, etc. related to the whole patchset is also very much appreciated. Big thanks to Alexander for working on the patch set! [1] https://www.postgresql.org/message-id/20220115063925.GS14051%40telsasoft.com -- Best regards, Pavel Borisov

Re: Add 64-bit XIDs into PostgreSQL 15

for working on the > patch set! > > [1] > https://www.postgresql.org/message-id/20220115063925.GS14051%40telsasoft.com > Also, the patch v17 (0005) returns SLRU_PAGES_PER_SEGMENT to the previous value of 32. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

ery much understood by us. We'll deliver a patchset soon with localization based on %lld/%llu format and explicit casts to unsigned/signed long long. Alexander Alexeev could you wait a little bit and give us time to deliver v20 patch which will address localization (I propose concurrent work should stop until that to avoid conflicts) Advice and discussion help us a lot. Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Add 64-bit XIDs into PostgreSQL 15

03, 0004 and 0005 are not supposed to be committed without 0001 and 0002 anyway. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

ander, as of now we're preparing a new version that addresses a thing mentioned by Tom&Kyotaro. We'll try to add what you've done in v21, but please check. We're going to send a patch very soon, most probably today in several hours. -- Best regards, Pavel Bo

Probable CF bot degradation

ntenance though. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Add 64-bit XIDs into PostgreSQL 15

Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Fix unsigned output for signed values in SLRU error reporting

Hi, hackers! I've noticed that in SRLU error reporting both signed and unsigned values are output as %u. I think it is worth correcting this with the very simple patch attached. Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgre

Re: Probable CF bot degradation

at failure very well and it was > waiting for a long timeout before scheduling more jobs. It's going > again now, and I'll try to make it more resilient against that type of > failure... > Thanks a lot! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Probable CF bot degradation

ymore. Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

> On 2022-03-18 18:14:52 +0300, Maxim Orlov wrote: > > Subject: [PATCH v22 3/6] Use 64-bit pages in SLRU > > > > This is one step toward 64-bit XIDs. > > I think this should explain in more detail why this move is done. Neither > the > commit message nor the rest of the thread does so afaics. It's

Re: Add 64-bit XIDs into PostgreSQL 15

> > > Do you know that you can test a branch on cirrus without using CF bot or > mailing the patch to the list ? See src/tools/ci/README > Yes, sure! The main reason to post updates of this patchset is for hackers that are interested in the progress have relevant version with updates. This patch

Re: Problem with moderation of messages with patched attached.

> > оf course we could get complaints no matter what level we set the limit > at. I think raising it to 2Mb would be a reasonable experiment. If no > observable evil ensues then leave it that way. If it does then roll it > back. I agree that plain uncompressed patches are easier to deal with in > g

Re: [PATCH] Remove workarounds to format [u]int64's

lly - no warnings; passes all the > tests. > > [1] > https://www.postgresql.org/message-id/771048.1647528068%40sss.pgh.pa.us > > Hi, Alexander! Probably you can do (long long) instead of (long long int). It is shorter and this is used elsewhere in the code. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Remove workarounds to format [u]int64's

is in a good shape to be committed. ( Maybe some strings that don't fit screen cloud be reflowed: (long long int)seqdataform->last_value, (long long int)seqform->seqmax))); ) -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Fix unsigned output for signed values in SLRU error reporting

> > Afaics offset etc can't be negative, so I don't think this really improves > matters. I think there's quite a few other places where we use %u to print > integers that we know aren't negative. > > If anything I think we should change the signed integers to unsigned ones. > It > might be worth d

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

xids later ( https://postgr.es/m/CACG%3DezZe1NQSCnfHOr78AtAZxJZeCvxrts0ygrxYwe%3DpyyjVWA%40mail.gmail.com ) The thing that needs to change then is suppressing output of Epoch. It should be done when 64-xids are committed and it is done by 0006 in the mentioned thread. Until that I've left Epoch

Re: [PATCH] Remove workarounds to format [u]int64's

g%40mail.gmail.com#d7068b9d25a2f8a1064d2ea4815df23d [2] https://www.postgresql.org/message-id/flat/CACG%3DezZe1NQSCnfHOr78AtAZxJZeCvxrts0ygrxYwe%3DpyyjVWA%40mail.gmail.com -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Corner-case bug in pg_rewind

ts I left were purely cosmetic. It's a pity to me that this bugfix delayed for such a small reason and outdated, therefore. It would be nice to complete this fix on the next CF. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Covering SPGiST index

I've noticed CI error due to the fact that MSVC doesn't allow arrays of flexible size arrays and made a fix for the issue. Also did some minor refinement in tuple creation. PFA v12 of a patch. чт, 26 нояб. 2020 г. в 21:48, Pavel Borisov : > > The way that seems acceptable

Re: Corner-case bug in pg_rewind

> > Ok, pushed and backpatched this now. > Very nice! Thanks to you all! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Corner-case bug in pg_rewind

чт, 3 дек. 2020 г. в 19:15, Heikki Linnakangas : > On 03/12/2020 16:49, Pavel Borisov wrote: > > Ok, pushed and backpatched this now. > > > > Very nice! > > Thanks to you all! > > Thanks for the review, Pavel! I just realized that I forgot to credit >

Re: [PATCH] Covering SPGiST index

> > The cfbot's still unhappy --- looks like you omitted a file from the > patch? > You are right, thank you. Corrected this. PFA v13 -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v13-0001-Covering-SP-GiST-in

Re: Speeding up GIST index creation for tsvectors

is good. Still optimize index structure, minimizing disc pages access, etc. seems better in many cases. Thank you for your proposal! [1] https://commitfest.postgresql.org/29/2276/ [2] https://commitfest.postgresql.org/31/2824/ [3] https://github.com/postgrespro/rum -- Best regards, Pavel Bo

Re: [PATCH] Automatic HASH and LIST partition creation

syntax. I'm planning also to add RANGE partitioning syntax to this in the future and I will be happy if all three types of the syntax could come along easily. I very much appreciate your views on this especially regarding that changes can be still made easily because the patch is not committed ye

Re: [PATCH] Automatic HASH and LIST partition creation

ostgresql.org/message-id/flat/alpine.DEB.2.21.1907150711080.22273%40lancre -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Automatic HASH and LIST partition creation

ar enough. BTW could you tell me a couple of words about pros and cons of c-code syntax parsing comparing to parsing using gram.y trees? I think both are possible but my predisposition was that we'd better use the later if possible. Best regards, Pavel Borisov >

Re: [PATCH] Automatic HASH and LIST partition creation

nsider it possible to change the syntax of declarative partitioning too? It is problematic as it is already committed but also is very tempting to have the same type of syntax both in automatic partitioning and in manual (PARTITION OF...) -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Automatic HASH and LIST partition creation

se than my proposal above. Still other opinions are highly valued. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

of a patch to check? I've made tests portable in v3, probably, you've checked not the last version. Thanks for your attention to the patch -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

much bigger and harder to review. Anyway, your and Peter's further considerations are always welcome. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

an be used now as a 2-variant regression test for 32 and 64 bit systems. Thank you for your consideration! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v4-0001-Make-amcheck-checking-UNIQUE-constraint-for-btree.patch Description: Binary data

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

to stop checking at the first violation. But I can make them reported in a current amcheck style if it is necessary. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: POC: GROUP BY optimization

> Regression (stats_ext) is failing because you forgot to drop the table > created in a test > case (aggregates), It's a bit minor change so the attached patch fixes > that issue. > > https://cirrus-ci.com/task/6704792446697472 > > Thank you very much! -- Best reg

Valgrind run error with Postgres on OSX

ou. If you have ideas on the issue please share. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v1-0001-Fix-for-bug-when-running-Valgrind-on-OSX.patch Description: Binary data

Re: POC: GROUP BY optimization

notice, is that some useful changes which I've mentioned before, are discarded now. But as long as they are planned to be put in later it is completely fine. I agree to discuss the thing in any thread, though I don't quite understand the reason for a switch. Still I don't see a

Re: [PATCH] Automatic HASH and LIST partition creation

itted. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Bogus documentation for bogus geometric operators

t have the same name and I'm planning to review the patch soon. What are your ideas on the possibility to backpatch it also? It seems a little bit weird that the operator can change its name between versions of PG. -- Best regards, Pavel Borisov Postgres Professional: http://p

Re: Bogus documentation for bogus geometric operators

Emre, could you please again rebase your patch on top of 2f70fdb0644c32c4154236c2b5c241bec92eac5e ? It is not applied anymore. > -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Bogus documentation for bogus geometric operators

x <<| '((0,1),(1,2))'::box; -- f select '((0,0),(1,1))'::box <^ '((0,1),(1,2))'::box; -- t So I've only reverted the changes in the documentation on geometric functions in your patch. PFA v3 of your patch. I'd mark it ready to commit if you

Re: Bogus documentation for bogus geometric operators

are right. We need to keep the documentation for box operators, > but remove the lines for the point operators. > Indeed you are right. PFA v4 with documentation removed for <^ and >^ for point Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v4-0001-Deprecate-and-replace-and-operators-for-points.patch Description: Binary data

Re: Corner-case bug in pg_rewind

e passes and I'd recommend it to commit after a minor improvement described. Thank you! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Bogus documentation for bogus geometric operators

nuking <^ for point type (but this is not the only way so I haven't done this in v5). What do you think? -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v5-0001-Deprecate-and-replace-and-operators-for-points.patch Description: Binary data

[PATCH] Combine same ternary types in GIN and TSearch

of header files inclusion in some modules. What do you think about this? -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v1-0001-Combine-same-types-GinTernaryValue-and-TSTernaryV.patch Description: Binary data

Re: [PATCH] Combine same ternary types in GIN and TSearch

a was to combine them and use them like we use other global data types. We may declare it somewhere outside both gin and search. Or just leave as it is. Thank you, Heikki for your feedback! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Corner-case bug in pg_rewind

nge it also. But I don't insist. > Note that the patch may require reworking for HEAD due to changes in > commit 9c4f5192f6. I'll try to take another look this week. > Thank you! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Evaluate expression at planning time for two more cases

the thread should be a must-do for this patch. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com The new status of this patch is: Waiting on Author

Re: Heads-up: macOS Big Sur upgrade breaks EDB PostgreSQL installations

will not generally modify its contents during migration betweeb osx versions and/or different machines. It is not only the question of permissions. Any options inside user homedir are equally suitable IMO. --- Best regards, Pavel Borisov Postgres professional: http://postgrespro.com

Re: [PATCH] Covering SPGiST index

вт, 17 нояб. 2020 г. в 11:36, Pavel Borisov : > I've started to review this, and I've got to say that I really disagree >> with this choice: >> >> + * If there are INCLUDE columns, they are stored after a key value, each >> + * starting from its own typali

Re: Is postgres ready for 2038?

here. > How about just a mention in the future documentation to never ever define _USE_32BIT_TIME_T when compiling PG under Windows? Should be enough, I suppose. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Is postgres ready for 2038?

Yes, I agree. ср, 18 нояб. 2020 г. в 18:44, Tom Lane : > Pavel Borisov writes: > >> Maybe we need to dig a little more to see what's going on here. > > > How about just a mention in the future documentation to never ever define > > _USE_32BIT_TIME_T when compi

Re: Is postgres ready for 2038?

latforms, we simply do not have a choice. I suppose that some 10+ years later the number of users willing to compile on 32-bit with dinosaur-aged Perl distribution will be nearly zero. So I suppose just mention this would be a funny fact in the documentation. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: bad logging around broken restore_command

x27;s patch and found it perfectly working with installcheck-world passed, code is clean. As for the feature I agree with Jeff and Fuji that this ENOENT case is worth logging under LOG priority. I consider the last (Fuji's) patch is now ready to be committed. Best regards, Pavel Borisov The

Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted

ing on to the disk space */ 349 do_truncate(path); . 356 * Delete any additional segments. 357 */ 358 if (ret >= 0) --^^^ -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Bogus documentation for bogus geometric operators

x27;t even deprecated the old > names yet. So for now, we have to support both names in the opclasses. > I extended the patch to do that. > > This version seems committable to me --- any thoughts? > The wording seems no problem to me. I looked into a patch and changes also seem sensib

Re: Bogus documentation for bogus geometric operators

apply and make the final checks soon. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Bogus documentation for bogus geometric operators

it is ready to be pushed. Pavel Borisov

Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted

finalize my own review and mark the patch as ready for committer if nobody has objections. Thank you! Pavel Borisov The new status of this patch is: Ready for Committer

Re: Is postgres ready for 2038?

> There are no 32bit Windows version builds since Postgres 11, see: > > https://www.postgresql.org/download/windows/ > > but Postgres 13 still has the same 2038 problems. > > > > As @Pavel Borisov hints , I can find `_USE_32BIT_TIME_T` code here: > > https://gith

Re: [PATCH] Covering SPGiST index

d big chunks that were shifted in spgist_private.h to their initial places where possible and made other cosmetic changes to improve the patch. PFA v.11 of the patch. Do you think the proposed changes are in the right direction? Thank you! -- Best regards, Pavel Borisov Postgres Professional: http:

Re: [PATCH] Automatic HASH and LIST partition creation

odify the syntax were seconded by anyone, I return the previous Ready-for-committer CF status. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> 0001-Auto-generated-HASH-and-LIST-partitions-v4.patch Description: Binary data

[PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

ndex page entry and 2nd, 3d and next current index page entries. In this case, there would be a message that recommends doing VACUUM to remove the invisible entries from the index and repeat the check. (Generally, it is recommended to do vacuum before the check, but for the testing purpose I'd re

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

On Mon, 8 Feb 2021, 14:46 Pavel Borisov Hi, hackers! > > It seems that if btree index with a unique constraint is corrupted by > duplicates, amcheck now can not catch this. Reindex becomes impossible as > it throws an error but otherwise the index will let the user know that it &g

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

вт, 9 февр. 2021 г. в 01:46, Mark Dilger : > > > > On Feb 8, 2021, at 2:46 AM, Pavel Borisov > wrote: > > > > 0002 - is a temporary hack for testing. It will allow inserting > duplicates in a table even if an index with the exact name "idx" has a > un

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

To make tests stable I also removed lsn output under warning level. PFA v3 of a patch -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v3-0001-Make-amcheck-checking-UNIQUE-constraint-for-btree.patch Description: Binary data

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

tely, converting the regression test to TAP would be a pain for > me. Hope it can be used now as a 2-variant regression test for 32 and 64 > bit systems. > >> > >> Thank you for your consideration! > >> > >> -- > >> Best regards, > >> Pavel

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

heck.pl . It is only smoke test that just verifies new functions. - added test contrib/amcheck/t/004_verify_nbtree_unique.pl it is more extensive test based on opclass damage which was intended to be main test for amcheck, but which I've forgotten to add to commit in v5. 005_opclass_damage.p

Re: Pre-allocating WAL files

performance gain makes me think again before adding this feature. I did tests myself a couple of months ago and got similar results. Really don't know whether is it worth the effort. Wish you and all hackers happy New Year! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

ation-after-statement] > [17:21:26.926] 634 | int vmaj = 0, > [17:21:26.926] | ^~~ > Corrected this, thanks! Also added more comments on this part of the code. PFA v8 of a patch -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Stream replication test fails of cfbot/windows server 2019

s://cirrus-ci.com/task/4599128897355776 Is it known cfbot problem? Do I need to do something to my amcheck СF branch mentioned above for it to become green on cfbot eventually? -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: Add 64-bit XIDs into PostgreSQL 15

add a solution for archs without 64-bit atomic values. 5A. Provide XID 8-byte alignment for systems where 64-bit atomics is provided for 8-byte aligned values. 5B. Wrap XID reading into PG atomic locks for remaining 32-bit ones (they are expected to be rare). -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

By the way I've forgotten to add one part of my code into the CF patch related to the treatment of NULL values in checking btree unique constraints. PFA v9 of a patch with this minor code and tests additions. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com

Re: Stream replication test fails of cfbot/windows server 2019

ity I still have no idea about the source of the problems besides my look at different cfbot behavior sometimes. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: UNIQUE null treatment option

+1 for commiting this feature. Consider this useful. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: UNIQUE null treatment option

> feels more natural to me because a NULL key column in a NULLS NOT > DISTINCT unique constraint is very similar to a NULL non-key column in > an INCLUDE index, as far as our requirements go -- and so both cases > should probably be dealt with at the same point. > A good point,

Re: Add 64-bit XIDs into PostgreSQL 15

ways, I very much appreciate your ideas on this readme patch, on overall 64xid patch [1], and on the roadmap on its improvement quoted above. [1] https://www.postgresql.org/message-id/CACG%3DezZe1NQSCnfHOr78AtAZxJZeCvxrts0ygrxYwe%3DpyyjVWA%40mail.gmail.com -- Best regards, Pavel Borisov Post

Re: [PATCH] Covering SPGiST index

is not removed, it calls fetch_att. And I find this suitable as the address for the first tuple attribute is MAXALIGNed). Thanks again for your consideration. From now I hope to be able to work on the feature with not so big delay. -- Best regards, Pavel Borisov Postgres Professional: http://post

Re: [PATCH] Covering SPGiST index

In a v14 I forgot to add the test. PFA v15 -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v15-0001-Covering-SP-GiST-index-support-for-INCLUDE-colum.patch Description: Binary data

[PATCH] Improve treatment of page special and page header alignment during page init.

think? -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v1-0001-Ensure-same-treatment-of-page-header-and-page-spe.patch Description: Binary data

Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?

se my very small patch on this in another discussion branch: https://www.postgresql.org/message-id/calt9zeffq2-n5lmfg59l6hm3zrgcexyhr9eqme7v1jodtxg...@mail.gmail.com If you want, feel free to discuss it and push if consider the change relevant. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] Improve treatment of page special and page header alignment during page init.

ср, 7 апр. 2021 г. в 17:55, Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com>: > On Wed, Apr 7, 2021 at 5:32 PM Pavel Borisov > wrote: > > > > I was looking at changes in Sp-Gist by commit > 4c0239cb7a7775e3183cb575e62703d71bf3302d > > (dis

Re: [PATCH] Improve treatment of page special and page header alignment during page init.

7;d call off the proposal. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Add ORDER BY to stabilize tablespace test for partitioned index

er of parent and child. PFA small patch that stabilizes that test in the same style by adding ORDER BY. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> v1-0001-Stabilize-tablespaces-test-for-partitioned-indexe.patch Description: Binary data

Re: Add ORDER BY to stabilize tablespace test for partitioned index

reate_function_3.sql which the commit 7e3c54168 > missed to add. I will post the patch there in [1] and see if it gets > picked up. > Thanks! I think the patch you mentioned in [1] is also good, and it's worth being committed as well. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Re: [PATCH] fix GIN index search sometimes losing results

ср, 22 июл. 2020 г. в 19:10, Tom Lane : > Pavel Borisov writes: > > For 0002-remove-calc-not-flag.patch > > The patch changes the behavior which is now considered default. This is > true in RUM module and maybe in some other tsearch side modules. Applying > the patch can mak

Re: Building 12.3 from source on Mac

I'd like to add that MacPorts installs everything to /opt/ and /opt/local unless someone configures other path. You can also easily check is something from homebrew installation by running 'brew config' and looking at HOMEBREW_PREFIX entry. Regards, Pavel чт, 23 июл. 2020 г. в 19:05, Paul Förster

[PATCH] Covering SPGiST index

ough. All this changes only affect private index structures so all outside behavior like WAL, vacuum etc will remain unchanged. As usual I very much appreciate your feedback -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> spgi

Re: [PATCH] Covering SPGiST index

orting for the case when user wants to invoke index build with not one column. Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> spgist-covering-0002.diff Description: Binary data

Re: [PATCH] Covering SPGiST index

Also little bit corrected code formatting. > Best regards, > Pavel Borisov > > Postgres Professional: http://postgrespro.com <http://www.postgrespro.com> > spgist-covering-0003.diff Description: Binary data

Re: [PATCH] Covering SPGiST index

Same code formatted as a patch. пн, 10 авг. 2020 г. в 17:45, Pavel Borisov : > Also little bit corrected code formatting. > >> Best regards, >> Pavel Borisov >> >> Postgres Professional: http://postgrespro.com >> <http://www.postgrespro.com> >&g

  1   2   3   4   >