[PATCH] Add native windows on arm64 support

2022-02-23 Thread Niyas Sait
Hello, I have created a patch that adds support for building Postgres for the windows/arm64 platform using the MSVC toolchain. Following changes have been included 1. Extend MSVC scripts to handle ARM64 platform. 2. Add arm64 definition of spin_delay function. 3. Exclude arm_acle.h import with MS

Re: [PATCH] Add native windows on arm64 support

2022-03-22 Thread Niyas Sait
into providing a build machine. Do you have any reference to what the CI system looks like now for PostgresSQL and how to add new workers etc.? Niyas On Fri, 18 Mar 2022 at 20:50, Thomas Munro wrote: > On Wed, Feb 23, 2022 at 11:09 PM Niyas Sait wrote: > > I have created a patch tha

Re: [PATCH] Add native windows on arm64 support

2022-12-12 Thread Niyas Sait
Hi, On 05/12/2022 18:14, Andres Freund wrote: With meson gaining in maturity, perhaps that's not the most urgent thing as we will likely remove src/tools/msvc/ soon but I'd rather do that right anyway as much as I can to avoid an incorrect state in the tree at any time in its history. I'd act

Re: [PATCH] Add native windows on arm64 support

2022-12-16 Thread Niyas Sait
On 12/12/2022 23:56, Michael Paquier wrote: On Mon, Dec 12, 2022 at 01:38:37PM +, Niyas Sait wrote: On 05/12/2022 18:14, Andres Freund wrote: I think the old build system specific part is really minimal in the patch. I can strip out those if that's preferred. Removing all the changes

Re: [PATCH] Add native windows on arm64 support

2023-01-17 Thread Niyas Sait
On 16/12/2022 10:52, Niyas Sait wrote: On 12/12/2022 23:56, Michael Paquier wrote: On Mon, Dec 12, 2022 at 01:38:37PM +, Niyas Sait wrote: On 05/12/2022 18:14, Andres Freund wrote: I think the old build system specific part is really minimal in the patch. I can strip out those if

Re: [PATCH] Add native windows on arm64 support

2023-01-19 Thread Niyas Sait
On 17/01/2023 22:51, Andres Freund wrote: Hi, On 2022-12-16 10:52:23 +, Niyas Sait wrote: Subject: [PATCH v7] Enable postgres native build for windows-arm64 platform elif host_cpu == 'arm' or host_cpu == 'aarch64' - prog = ''' + if c

Re: [PATCH] Add native windows on arm64 support

2023-05-02 Thread Niyas Sait
On 19/01/2023 10:09, Niyas Sait wrote: On 17/01/2023 22:51, Andres Freund wrote:   int main(void) @@ -1960,18 +1966,19 @@ int main(void)   }   ''' -  if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and __crc32cd without -march=armv8-a+crc', -  args

Re: [PATCH] Add native windows on arm64 support

2023-05-11 Thread Niyas Sait
On 11/05/2023 00:34, Michael Paquier wrote: On Wed, May 10, 2023 at 09:24:39AM -0400, Andrew Dunstan wrote: We will definitely want buildfarm support. I don't have such a machine and am not likely to have one any time soon. I do run drongo and fairywren on an EC2 instance, but AWS doesn't seem t

Re: [PATCH] Add native windows on arm64 support

2022-04-19 Thread Niyas Sait
> Niyas, any updates on that? Sorry for the delay! Configuring the scripts took some time. I have successfully run the builfarm animal script using my git repository [1] which contains the proposed patch on a Windows Arm64 machine. I made a request to add a new machine to build farm through [2].

Re: [PATCH] Add native windows on arm64 support

2022-04-20 Thread Niyas Sait
> Have you tested with the amount of coverage provided by vcregress.pl? I built and ran the relevant tests with the help of run_build.pl. I think following tests are executed - check, contribcheck, ecpgcheck, installcheck, isolationcheck, modulescheck, and upgradecheck. > Another thing I was won

Re: [PATCH] Add native windows on arm64 support

2022-04-21 Thread Niyas Sait
chael Paquier wrote: > On Wed, Apr 20, 2022 at 10:43:06AM +0100, Niyas Sait wrote: > >> This issue is still lying around, and you may have been lucky. Would > >> there be any issues to remove this change to get a basic support in? > >> As mentioned upthread, there

Re: [PATCH] Add native windows on arm64 support

2022-12-01 Thread Niyas Sait
On 05/11/2022 18:31, Andres Freund wrote: On 2022-11-03 11:06:46 +, Niyas Sait wrote: I've attached a new version of the patch which excludes the already merged ASLR changes and add small changes to handle latest changes in the build scripts. Note that we're planning to remove

Re: [PATCH] Add native windows on arm64 support

2022-12-01 Thread Niyas Sait
On 07/11/2022 06:58, Michael Paquier wrote: #if defined(_WIN64) static __forceinline void spin_delay(void) { +#ifdef _M_ARM64 + /* +* arm64 way of hinting processor for spin loops optimisations +* ref: https://community.arm.com/support-forums/f/infrastructure-solu

Re: [PATCH] Add native windows on arm64 support

2022-12-01 Thread Niyas Sait
support for meson build system V2->V3: Removed ASLR enablement and rebased on master. V1->V2: Rebased on top of master -- NiyasFrom 872f538f6261b36a32cbcecae82e99778b747799 Mon Sep 17 00:00:00 2001 From: Niyas Sait Date: Tue, 22 Feb 2022 13:07:24 + Subject: [PATCH v4] Enable postgres na

Re: [PATCH] Add native windows on arm64 support

2022-12-02 Thread Niyas Sait
On 02/12/2022 05:02, Michael Paquier wrote: Thanks for the updated version. I have been looking at it closely and it looks like it should be able to do the job (no arm64 machine for Windows here, sigh). I have one tiny comment about this part: - USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK => u

Re: [PATCH] Add native windows on arm64 support

2022-12-02 Thread Niyas Sait
On 02/12/2022 05:41, John Naylor wrote: I couldn't find something more official for the sse2neon library part. Not quite sure what this is referring to, but it seems we can just point to the __aarch64__ section in the same file, which uses the same instruction: spin_delay(void) { __asm__ __v

Re: [PATCH] Add native windows on arm64 support

2022-12-02 Thread Niyas Sait
Rebased on top of master -- NiyasFrom 58b82107088456fc71d239f4e1b995d91a94b4ef Mon Sep 17 00:00:00 2001 From: Niyas Sait Date: Tue, 22 Feb 2022 13:07:24 + Subject: [PATCH v5] Enable postgres native build for windows-arm64 platform Following changes are included - Extend MSVC scripts to hand

Re: [PATCH] Add native windows on arm64 support

2022-12-05 Thread Niyas Sait
On 05/12/2022 05:12, Michael Paquier wrote: - Last comes OpenSSL, that supports amd64_arm64 as build target (see NOTES-WINDOWS.md), and the library names are libssl.lib and libcrypto.lib. Looking at https://slproweb.com/products/Win32OpenSSL.html, there are experimental builds for arm64 with O

Re: [PATCH] Add native windows on arm64 support

2022-11-03 Thread Niyas Sait
is an entry for this thread > in the current CF > previously marked "Needs review": > > https://commitfest.postgresql.org/40/3561/ > > I've gone ahead and marked it as "Committed", as that appears to have > happened > back in August as 36389a060c. > > If for whatever reason that was the Wrong Thing To Do, please let me know. > > Regards > > Ian Barwick > -- Niyas Sait Linaro Limited v3-0001-Enable-postgres-native-build-for-windows-arm64-pl.patch Description: Binary data

Re: [PATCH] Add native windows on arm64 support

2022-05-09 Thread Niyas Sait
gt; /DYNAMICBASE:NO isn't supported for these targets. Thanks Niyas [1] https://docs.microsoft.com/en-us/cpp/build/reference/dynamicbase?view=msvc-170 On Mon, 25 Apr 2022 at 02:17, Michael Paquier wrote: > On Thu, Apr 21, 2022 at 10:21:04AM +0100, Niyas Sait wrote: > > The fol

Re: [PATCH] Add native windows on arm64 support

2022-07-14 Thread Niyas Sait
Hello, Please find a new patch (no further changes) rebased on top of the master. On Tue, 10 May 2022 at 02:02, Michael Paquier wrote: > On Mon, May 09, 2022 at 12:44:22PM +0100, Niyas Sait wrote: > > Microsoft updated documentation [1] and clarified that ASLR cannot be > > dis

Re: [PATCH] Add native windows on arm64 support

2023-06-14 Thread Niyas Sait
Hello, Just wanted to give a heads up that I am moving to a new role outside Linaro and as a result wouldn't be able to continue contributing. Anthony Roberts from Linaro is going to support the enablement work. -- Niyas