[PATCH] (Windows) psql echoes password when reading from pipe

2018-05-21 Thread Matthew Stickney
the echo is low. -Matt Stickney From 27a0f9b2036680564ef6dfa54f3961af221cbc50 Mon Sep 17 00:00:00 2001 From: Matthew Stickney Date: Mon, 21 May 2018 23:24:34 -0400 Subject: [PATCH] Disable input echo on the console, not stdin. When data is piped to psql, a handle to stdin will no longer b

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Matthew Stickney
le on the underlying handle that you retrieve from termin, but I doubt it's worth it. I'll do up a modified patch tonight, if that sounds like it'd be better. -Matt Stickney On Tue, May 22, 2018 at 2:55 PM, Tom Lane wrote: > Matthew Stickney writes: >> On windows, i

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Matthew Stickney
On Tue, May 22, 2018 at 4:09 PM, Tom Lane wrote: > [ please don't top-post ] Sorry, I'm used to using a better mail client than this. > Hm. The failure mode I was thinking about was insufficient resources > to allocate another handle You have a point here; CreateFile does create a new handle (

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Matthew Stickney
On Tue, May 22, 2018 at 6:14 PM, Tom Lane wrote: > Well, the question that ought to be answered first is whether to do > anything at all, beyond not-crashing. It doesn't seem to me that > refusing to accept a password if we can't disable echo is a net win, > so I'm inclined to think it's okay to

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-23 Thread Matthew Stickney
llback in terms of a mintty-type environment, but I wanted to get this patch out there in the meantime. -Matt Stickney From 734b979e64947e1b820f5c1a40454bb35c03 Mon Sep 17 00:00:00 2001 From: Matthew Stickney Date: Mon, 21 May 2018 23:24:34 -0400 Subject: [PATCH] Disable input echo on the con