Make gaps array static

Looking over the recently committed work for btree tuple deletion (d168b66) should this variable not be declared static as in the attached patch? Thanks, Mark. diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index faffbb1..bbdc1ce 100644 --- a/src/backend/access/he

Keyword table constness in jsonpath scanner.

Hello all, While looking over the new jsonpath stuff I noticed the keyword table wasn't declared const. Shouldn't the table and the actual keyword strings both be declared const? Perhaps something like the attached (untested) patch. -Mark diff --git a/src/backend/utils/adt/jsonpath_scan.l b/src/b

Small const correctness patch

Hello all, Please find attached a trivial patch making a few arrays const (in addition to the data they point to). diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index f553523857..aafc7187b0 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access

Re: Small const correctness patch

On Thu, Aug 8, 2019 at 8:51 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > How did you find this? Any special compiler settings? > 16 hours stuck in a plane on an international flight. I was just eyeballing the code to kill the boredom. -Mark

Re: Small const correctness patch

On Thu, Aug 8, 2019 at 8:25 PM Ibrar Ahmed wrote: > +1 > > Patch successfully applied to the master ( > 43211c2a02f39d6568496168413dc00e0399dc2e) > That change looks like an unrelated patch for initdb. I'm still not seeing my patch there. -Mark

Missing const in DSA.

While looking at some of the recent churn in DSA I noticed that dsa_size_class_map should probably be declared const. diff --git a/src/backend/utils/mmgr/dsa.c b/src/backend/utils/mmgr/dsa.c index 33ab8d05d3..70ce7ce7da 100644 --- a/src/backend/utils/mmgr/dsa.c +++ b/src/backend/utils/mmgr/dsa.c @@