[WIP] Reduce likelihood of fdw prepared statement collisions

development team be open to a patch which somehow makes this less likely? Something like the attached patch works, but probably isn't ideal? Perhaps there is a better unique identifier I can use here. I am very new to the postgres codebase. Best *Marco Montagna*

Re: How is this possible "publication does not exist"

binary=binary@entry=true) at logicalfuncs.c:309 #11 0x55819566c35d in pg_logical_slot_get_binary_changes (fcinfo=) at logicalfuncs.c:391 cheers, Marco

Re: autovacuum: change priority of the vacuumed tables

ng it lower on the target table should give an implicit higher priority to that table. *Distinti Saluti / *Kind Regards *Marco Garavello* | IoT Cloud Operations Specialist Il giorno ven 14 gen 2022 alle ore 12:55 Tomas Vondra < tomas.von...@2ndquadrant.com> ha scritto: > > On 03/03/

Re: remove some ancient port hacks

in 1998. No problem at all to remove it Regards Marco Cygwin Package Maintainer

ltree_plpython failure test on Cygwin for 12.4 test

FAIL postgresql-12.4-1-check.log test python3/hstore_plpython ... FAILED 423 ms test python3/jsonb_plpython ... FAILED 172 ms test python3/ltree_plpython ... FAILED 163 ms never had problem with python2.7 Suggestion ? Regards Marco 2020-08-12 18:35:43.891 CEST [1

Re: [PATCH] session_replication_role = replica with TRUNCATE

Hi, Il 30/12/17 08:42, Craig Ringer ha scritto: > On 30 December 2017 at 03:32, Petr Jelinek <mailto:petr.jeli...@2ndquadrant.com>> wrote: > > On 29/12/17 16:53, Marco Nenciarini wrote: > > Il 29/12/17 15:14, Petr Jelinek ha scritto: > >> >

Re: [PATCH] Logical decoding of TRUNCATE

Hi, Il 29/12/17 20:55, Andres Freund ha scritto: > Hi, > > On 2017-12-29 14:15:22 +0100, Marco Nenciarini wrote: >> This patch implements support for TRUNCATE statements >> in logical replication. The work has mainly done by Simon Riggs then >> finished by

Re: [PATCH] Logical decoding of TRUNCATE

Hi, I've found some SGML errors in the version v10 of the patch. I've fixed it in version v11 that is attached. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git

Re: [PATCH] Logical decoding of TRUNCATE

Patch rebased on the current master. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git a/contrib/test_decoding/expected/ddl.out b/contrib/test_decoding/expected/ddl.out index

Re: [PATCH] Logical decoding of TRUNCATE

Attached here there is the complete list of patches required to pass all the tests. The 0001 patch is discussed in a separate thread, but I've posted it also here to ease the review of the 0002. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Su

Re: [PATCH] Logical decoding of TRUNCATE

l.org/16/1447/, but I've posted it also here to ease the review of the 0002. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.

Re: [PATCH] Logical decoding of TRUNCATE

only close those and the rest should be >> closed by caller? That should also remove the other ugly part which is >> that the ExecuteTruncateGuts modifies the input list. What if caller >> wanted to use those relations it sent as parameter later? > > Agreed > Attache

Re: [PATCH] session_replication_role = replica with TRUNCATE

e between replicated and not replicated changes. > > I have committed some documentation updates and tests to cover this a > bit better. > Thanks, the documentation is a lot clearer now. This superseded the documentation change that was in the patch, so I've removed it from the v3 ve

pg_upgrade tests failing on current master

uot;rtest_emplog" ("ename", "who", "action", "newsal", "oldsal") VALUES ("old"."ename", CURRENT_USER, 'fired'::"bpchar", '$0.00'::"money", "old"."salary"); I&

Re: [PATCH] session_replication_role = replica with TRUNCATE

Il 22/01/18 19:41, Petr Jelinek ha scritto: > On 19/01/18 12:41, Marco Nenciarini wrote: >> Hi Peter, >> >> Il 18/01/18 17:30, Peter Eisentraut ha scritto: >>> On 1/17/18 11:33, Petr Jelinek wrote: >>>>> P.S: I'm strugglin

Re: [PATCH] Logical decoding of TRUNCATE

uncateGuts(). > > It may mean more list(s) but the current interface is still not clean. > Now ExecuteTruncateGuts unconditionally closes the relations that it opens. The caller has now always the responsibility to close the relations passed with the explicit_rels list. Version 15 attached

Re: [PATCH] Logical decoding of TRUNCATE

Il 23/01/18 18:13, Petr Jelinek ha scritto: > Hi, > > On 23/01/18 15:38, Marco Nenciarini wrote: >> Il 22/01/18 23:18, Petr Jelinek ha scritto: >>> On 22/01/18 19:45, Petr Jelinek wrote: >>> >>> Actually on second look, I don't like the new boolean

Re: [PATCH] Logical decoding of TRUNCATE

Il 23/01/18 18:25, Petr Jelinek ha scritto: > On 23/01/18 18:19, Marco Nenciarini wrote: >> Il 23/01/18 18:13, Petr Jelinek ha scritto: >>> Hi, >>> >>> On 23/01/18 15:38, Marco Nenciarini wrote: >>>> Il 22/01/18 23:18, Petr Jelinek ha scri

Re: [PATCH] Logical decoding of TRUNCATE

Il 25/01/18 13:18, Petr Jelinek ha scritto: > On 25/01/18 08:26, Thomas Munro wrote: >> On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini >> wrote: >>> Version 16 attached. >> >> Hi Marco, >> >> FYI this version doesn't compile: >> >&g

Re: [Incident report]Backend process crashed when executing 2pc transaction

actions happened on the coordinator since the server started, which quite possibly resulted in 4 billion prepared transactions on this particular server. I'm wondering if some counter is overflowing. cheers, Marco

Re: Disallow cancellation of waiting for synchronous replication

synchronous replication is still required? Marco

Re: Disallow cancellation of waiting for synchronous replication

AL instead of PANIC, since PANIC restarts the database and I don't think there is a reason to do that. Marco

Re: Disallow cancellation of waiting for synchronous replication

ndary can be overwritten/discarded if it turns out they did not commit on the primary. Marco

Re: meson vs Cygwin

this request so late how are you configuring the build ? Marco Atzeri Postgresql package manager for Cygwin

Re: Exposing the lock manager's WaitForLockers() to SQL

sequence value + lock-and-release approach is still the only reliable scheme I've found for reliably and efficiently processing new inserts in PostgreSQL. I'm wondering whether it could be an option of the LOCK command. (LOCK WAIT ONLY?) Marco

Re: Planning counters in pg_stat_statements (using pgss_store)

oviding the query text. But there's also citus extension, > which don't keep around the query string at least when distributing > plans, which makes sense since it's of no use and they're heavily > modifying the original Query. I think that citus folks opinion on the &g

Re: Resolving the python 2 -> python 3 mess

situation. Regards Marco

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

and can be used as a replica identity when no unique index exists Any thoughts? cheers, Marco

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

e apply worker can use an index, the data migration tool can tactically create one on a high cardinality column, which would practically always be better than doing a sequential scan for non-trivial workloads. cheers, Marco

Re: How is this possible "publication does not exist"

test" LOGICAL 0/0 (proto_version '2', publication_names '"local_pub"') (fails in the same way when setting up the subscription on a different node) The local_pub does appear in pg_publication, but it seems a bit like the change_cb is using an old snapshot when reading from the catalog in GetPublicationByName. cheers, Marco

Re: Extension security improvement: Add support for extensions with an owned schema

;m involved in, I consider this to be a hard requirement. I think Jelte's solution is preferable going forward, because it preserves the flexibility that extension schemas were meant to provide, and makes the potential hazards of reusing a schema more explicit. cheers, Marco

Re: PostgreSQL 16 Beta 1 Released!

at 'snowball_create.sql': No such file or directory make[2]: *** [Makefile:110: install] Error 1 for what I can see the file is in the source tree, not in the build tree $ tar -tf postgresql-16beta1.tar.bz2 | grep snowball_create.sql postgresql-16beta1/src/backend/snowball/snowball_create.sql Regards Marco

Re: pspg - psql pager

EW queue for manual review from Debian's FTP Master. https://ftp-master.debian.org/new/pspg_0.5-1.html Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it signature.asc Description: OpenPGP digital signature

Re: [HACKERS] PATCH: Keep one postmaster monitoring pipe per process

on the pipe, that's just one systemcall. I did not bother to weed the postmaster_alive_fds yet, but this change works fine for me. Regards, Marco diff --git a/src/backend/storage/ipc/pmsignal.c b/src/backend/storage/ipc/pmsignal.c index 85db6b21f8..a0596c61fd 100644 --- a/src/backe

[PATCH] session_replication_role = replica with TRUNCATE

. I'm attaching a simple patch to make TRUNCATE match behavior of DELETE for session_replication_role = replica. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support marco.nenciar...@2ndquadrant.it | www.2ndQuadrant.it diff --git a/src/backend/com

[PATCH] Logical decoding of TRUNCATE

when session_replication_role = replica"[1] patch is required from this patch to work correctly with tables referenced by foreign keys. [1] https://commitfest.postgresql.org/16/1447/ Regards, Marco -- Marco Nenciarini - 2ndQuadrant Italy PostgreSQL Training, Services and Support mar

Re: [PATCH] session_replication_role = replica with TRUNCATE

about foreign keys or referential integrity, but only about triggers and rules. I don't think that it's worth to add a special case for truncate, unless we want to expand/rewrite the documentation to specify all the effects in the details. Regards, Marco -- Marco Nenciarini - 2ndQuadrant Ita

Segfault when creating partition with a primary key and sql_drop trigger exists

nection unexpectedly This probably means the server terminated abnormally before or while processing the request. The connection to the server was lost. Attempting reset: Failed. Marco

Re: Cygwin linking rules

Am 29.09.2018 um 19:03 schrieb Andrew Dunstan: On 09/29/2018 12:09 PM, Andrew Dunstan wrote: On 09/29/2018 11:35 AM, Tom Lane wrote: Most of the buildfarm is now happy with the changes I made to have libpq + ecpg get src/port and src/common files via libraries ... but lorikeet isn't.  It ge

Re: Cygwin linking rules

Am 02.10.2018 um 19:07 schrieb Tom Lane: Andrew Dunstan writes: On 09/29/2018 02:13 PM, Marco Atzeri wrote: [ proposed patch ] Yes. So there are a couple of things here. First, the dll has SO_MAJORVERSION in the name. And second it stops building any static libraries and instead builds

Re: Potential ABI breakage in upcoming minor releases

problem here is that because TimescaleDB compiled against 17.0 assumes a struct size of 376 (on my laptop) while PostgreSQL allocated the array with a struct size of 384, so the pointer math no longer holds and the whichrel value becomes nonsense. (1736263376 for whatever reason) cheers, Marco

Have an encrypted pgpass file

tp://passwords/really-unsecure-pgpass"; PGPASSCOMMAND="my-own-secure-pgpass-script" The submitted patch does it's job, though the command could throw errors. What do you think of this solution? Best regards, Marco van Eck pgpasscommand_v1.patch Description: Binary data

Re: Have an encrypted pgpass file

ing arguments (actually my first implementation) but it will make the usage more complex since you have to write a command to deliver the password. The content of the pgpass-file is already well defined, making it easy to use. I have no idea why it shouldn't work on Windows, it's just running a command or script, just like 'type .pgpass' or 'psql -At -F, -c "select 'localhost',5432,'db','db','db'"' Regards, Marco van Eck

Re: Have an encrypted pgpass file

to use the feature, and if not defined ignore the feature? I can make a new patch, if this is the direction we want to go. Best regards, Marco van Eck On Sat, Jul 21, 2018 at 7:29 AM Tom Lane wrote: > Isaac Morland writes: > >>> It would also provide a *very* fertile source of

Re: Have an encrypted pgpass file

. Please let me know of doing this would make sense. Regards, Marco On Tue, Jul 24, 2018 at 4:56 AM Thomas Munro wrote: > On Tue, Jul 24, 2018 at 2:10 PM, Craig Ringer > wrote: > >> Grabbing it from a process's memory is a bit harder than grabbing > contents > >>

Re: Have an encrypted pgpass file

able, which can only be defined by the executing user, and will be executed by the same user. It only reduces the need of unencrypted password's in a file. I think this solution is secure enough, shall we solve this feature-request? Regards, Marco On Tue, Jul 24, 2018 at 4:00 PM Tom Lane