Should program exit, When close() failed for O_RDONLY mode

2020-04-13 Thread Lin, Cuiping
Hi, I find that most of the code does not check the return value of close(), When open a file for reading(O_RDONLY). But I find that it checks the return value of close() in code "src/bin/pg_rewind/copy_fetch.c" When open a file for reading(O_RDONLY). And it will call pg_fatal to cause pre

Build errors in VS

2020-04-17 Thread Lin, Cuiping
Hi all I build postgers with VS in windows, and the following message output “ Unable to determine Visual Studio version: The nmake version could not be determined.” I investigated the VSObjectFactory.pm, and found the match string “if ($output =~ /(\d+)\.(\d+)\.\d+(\.\d+)?$/m)” It works fine