Re: Truncate logs by max_log_size

2024-10-01 Thread Kirill Gavrilov
On Tue, Oct 1, 2024 at 2:46 PM Jim Jones wrote: > > On 27.09.24 12:36, Andrey M. Borodin wrote: > > Consider max_log_size = 10Mb. The perspective might look very different. > > It’s not about WHERE anymore. It's a guard against heavy abuse. > > > > The feature looks very important for me. > I ha

Re: Truncate logs by max_log_size

2024-11-29 Thread Kirill Gavrilov
On Fri, Nov 29, 2024 at 3:24 AM Jim Jones wrote: > > > On 28.11.24 20:20, Kirill Gavrilov wrote: > > Here is version 3 of this patch. I found another place where this > > setting can be applied. > > Also added some documentation and specified that this setting &g

Re: Truncate logs by max_log_size

2024-11-28 Thread Kirill Gavrilov
On Thu, Nov 28, 2024 at 5:23 PM Jim Jones wrote: > > > On 25.11.24 17:52, Kirill Reshke wrote: > > Hello! Please deliver the most recent patch version and fix the issues > > Jim identified [0] as the current commitfest draws to a close. > > Do not forget to include both parts of this patch (This

Re: Truncate logs by max_log_size

2024-11-30 Thread Kirill Gavrilov
> > > Hi > > > +for (my $attempts = 0; $attempts < $max_attempts; $attempts++) > > +{ > > + eval { > > + $current_logfiles = slurp_file($node->data_dir . '/current_logfiles'); > > + }; > > + last unless $@; > > + usleep(100_000); > > +} > > > `usleep` in tap tests is usually a bad pattern. Do we ha

Re: Truncate logs by max_log_size

2024-11-29 Thread Kirill Gavrilov
On Fri, Nov 29, 2024 at 10:12 PM Jim Jones wrote: > > > On 29.11.24 12:05, Kirill Gavrilov wrote: > > Setting max_log_size to 0 already disables truncation. > > I changed guc units to bytes, just to make it more human-friendly. > > Did some refactoring and fixe

Re: Truncate logs by max_log_size

2025-01-31 Thread Kirill Gavrilov
On Mon, Dec 2, 2024 at 1:09 PM Jim Jones wrote: > > > On 29.11.24 21:57, Kirill Gavrilov wrote: > > Same thing applies to log_parameter_max_length, for example. > > > > postgres=# set log_parameter_max_length = '1foo'; > > ERROR: invalid value for