Re: [PATCH] LockAcquireExtended improvement

2024-01-31 Thread Jingxian Li
Hello Robert, Thank you for your advice. It is very helpful to me. On 2024/1/16 3:07, Robert Haas wrote: > Hello Jingxian Li! > > I agree with you that this behavior seems surprising. I don't think > it's quite a bug, more of a limitation. However, I think it would be >

Re: [PATCH] LockAcquireExtended improvement

2024-02-08 Thread Jingxian Li
Hello Robert, On 2024/2/2 5:05, Robert Haas wrote: > On Thu, Feb 1, 2024 at 2:16 AM Jingxian Li wrote: >> According to what you said, I resubmitted a patch which splits the ProcSleep >> logic into two parts, the former is responsible for inserting self to >> WaitQu

Re: [PATCH] LockAcquireExtended improvement

2024-02-08 Thread Jingxian Li
Hello Robert, On 2024/2/2 5:05, Robert Haas wrote: > On Thu, Feb 1, 2024 at 2:16 AM Jingxian Li wrote: >> According to what you said, I resubmitted a patch which splits the ProcSleep >> logic into two parts, the former is responsible for inserting self to >> WaitQu

Re: [PATCH] LockAcquireExtended improvement

2024-03-11 Thread Jingxian Li
_ps_display_remove_suffix(); + if (!dontWait) + { + /* reset ps display to remove the suffix */ + set_ps_display_remove_suffix(); + } LOCK_PRINT("WaitOnLock: wakeup on lock", locallock->lock, locallock->tag.mode); -- Jingxian Li

[PATCH] LockAcquireExtended improvement

2023-11-28 Thread Jingxian Li
Hi hackers, I found a problem when doing the test shown below: Time Session A Session B T1 postgres=# create table test(a int); CREATE TABLE postgres=# insert into test values (1); INSERT 0 1   T2

Re: [PATCH] LockAcquireExtended improvement

2023-11-29 Thread Jingxian Li
Hi Andres, Thanks for your quick reply! On 2023/11/29 0:51, Andres Freund wrote: > Hi, > > On 2023-11-28 20:52:31 +0800, Jingxian Li wrote: >> postgres=*# lock table test in exclusive mode ; >> >> >> T4 >> >> Case 1: >> >> postgre

[PATCH] Fix bug when calling strncmp in check_authmethod_valid

2024-04-29 Thread Jingxian Li
Hi all, Attached is a patch that fixes bug when calling strncmp function, in which case the third argument (authmethod - strchr(authmethod, ' ')) may be negative, which is not as expected.. With Regards, Jingxian Li. v1-0001-Fix-bug-when-calling-strncmp-in-check_authmethod_v

Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid

2024-05-06 Thread Jingxian Li
Hi Daniel, Thank you for explaining the ins and outs of this problem. On 2024/4/30 17:14, Daniel Gustafsson wrote: >> On 30 Apr 2024, at 04:41, Jingxian Li wrote: > >> Attached is a patch that fixes bug when calling strncmp function, in >> which case the third argument

Re: [PATCH] LockAcquireExtended improvement

2024-05-18 Thread Jingxian Li
y status. If dontWait = true, this is an >> * expected case; otherwise, it will open happen if something in the >> * ipc communication doesn't work correctly. >> >> "open" should be "only". > > Here's a patch fixing those typos. Nice catch! The patch looks good to me. -- Jingxian Li