Re: Concurrent deadlock scenario with DROP INDEX on partitioned index

2022-03-16 Thread Jimmy Yih
nd point 1 addressed, the fix seems to look okay in RangeVarCallbackForDropRelation. Thanks for the feedback. Attached new patch with feedback addressed. -- Jimmy Yih (VMware) Gaurab Dey (VMware) v2-0001-Fix-concurrent-deadlock-scenario-with-DROP-INDEX-.patch Description: v2-0001-Fix-concurrent-deadlock-scenario-with-DROP-INDEX-.patch

Re: Concurrent deadlock scenario with DROP INDEX on partitioned index

2022-03-16 Thread Jimmy Yih
th feedback addressed. -- Jimmy Yih (VMware) Gaurab Dey (VMware) v3-0001-Fix-concurrent-deadlock-scenario-with-DROP-INDEX-.patch Description: v3-0001-Fix-concurrent-deadlock-scenario-with-DROP-INDEX-.patch

Re: Concurrent deadlock scenario with DROP INDEX on partitioned index

2022-03-21 Thread Jimmy Yih
a test case that does > deadlock with unpatched code. The proposed patches look great and make much more sense. I see you've already squashed and committed in 7b6ec86532c2ca585d671239bba867fe380448ed. Thanks! -- Jimmy Yih (VMware) Gaurab Dey (VMware)

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2023-08-28 Thread Jimmy Yih
e their Postgres without knowing they were going to enable WAL archiving later on. The user would need to configure archiving and force a failover which may not be straightforward. Regards, Jimmy Yih v2-0001-Archive-current-timeline-history-file-after-recovery.patch Description: v2-0001-Ar

Concurrent deadlock scenario with DROP INDEX on partitioned index

2022-01-25 Thread Jimmy Yih
ition tables beneath the partitioned index's partitioned table before attempting to lock the sub-partition and partition indexes. Attached is a patch (+isolation test) which fixes the issue. We observed this on latest head of Postgres. Regards, Jimmy Yih and Gaurab Dey 0001-Fix-concurren

Should the archiver process always make sure that the timeline history files exist in the archive?

2023-08-09 Thread Jimmy Yih
ily fixed if we determine that the recovery_target_timeline numeric value is equal to the control file's timeline id (compare rtli and recoveryTargetTLI in validateRecoveryParameters()?) but I wasn't sure if maybe the opposite was true where we should make 'current' and 'lates

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2023-08-16 Thread Jimmy Yih
to archive the current timeline history file if it has not been archived yet when the archiver process starts up. Regards, Jimmy Yih From: Jimmy Yih Sent: Wednesday, August 9, 2023 5:00 PM To: pgsql-hack...@postgresql.org Subject: Should the archiver

Re: New committers: Melanie Plageman, Richard Guo

2024-04-29 Thread Jimmy Yih
Big congrats to you two!!! - Jimmy -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidenti

possible issue with array type created for every heap relation composite type

2018-07-10 Thread Jimmy Yih
Hello, In Postgres 8.3, it was decided that an array type would be automatically created for every heap relation's composite type. Reference thread: https://www.postgresql.org/message-id/flat/20070302234016.GF3665%40fetter.org The possible issue I would like to note is related to how the array t

Prevent concurrent DROP SCHEMA when certain objects are being initially created in the namespace

2018-09-04 Thread Jimmy Yih
Hello, When an empty namespace is being initially populated with certain objects, it is possible for a DROP SCHEMA operation to come in and delete the namespace without using CASCADE. These objects would be created but are left unusable. This is capable of leaving behind pg_class, pg_type, and o

Re: Prevent concurrent DROP SCHEMA when certain objects are being initially created in the namespace

2018-09-05 Thread Jimmy Yih
> > Something which would be good to have for all those queries is a set of > isolation tests. No need for multiple specs, you could just use one > spec with one session defining all the object types you would like to > work on. How did you find this object list? Did you test all the > objects a

Obtaining a more consistent view definition when a UNION subquery contains undecorated constants

2018-09-27 Thread Jimmy Yih
pg_get_viewdef('fooview'); pg_get_viewdef SELECT t.a FROM ( SELECT 1 AS a, 'foo'::text AS baz UNION SELECT 0 AS a, 'bar'::text AS baz) t; (1 row) Nested subqueries also work with the patch. We're not sure how this could break. Is this an acceptable change that should be pursued? Regards, Jimmy Yih and Jim Doty view_union_subquery_constant.patch Description: Binary data