Re: setLastTid() and currtid()

2019-03-26 Thread Inoue, Hiroshi
Hi Andres, Sorry for the late reply. On 2019/03/26 9:44, Andres Freund wrote: Hi, For the tableam work I'd like to remove heapam.h from nodeModifyTable.c. The only remaining impediment to that is a call to setLastTid(), which is defined in tid.c but declared in heapam.h. That doesn't seem like

Re: Removal of currtid()/currtid2() and some table AM cleanup

2020-06-03 Thread Inoue, Hiroshi
Hi, On 2020/06/03 11:14, Michael Paquier wrote: Hi all, I have been looking at the ODBC driver and the need for currtid() as well as currtid2(), and as mentioned already in [1], matching with my lookup of things, these are actually not needed by the driver as long as we connect to a server ne

Re: Removal of currtid()/currtid2() and some table AM cleanup

2020-06-05 Thread Inoue, Hiroshi
On 2020/06/05 15:22, Michael Paquier wrote: On Wed, Jun 03, 2020 at 10:10:21PM +0900, Inoue, Hiroshi wrote: On 2020/06/03 11:14, Michael Paquier wrote: I have been looking at the ODBC driver and the need for currtid() as well as currtid2(), and as mentioned already in [1], matching with my

Re: Removal of currtid()/currtid2() and some table AM cleanup

2020-06-15 Thread Inoue, Hiroshi
Sorry for the reply. On 2020/06/08 15:52, Michael Paquier wrote: On Fri, Jun 05, 2020 at 10:25:00PM +0900, Inoue, Hiroshi wrote: Keyset-driven cursors always detect changes made by other applications (and themselves). currtid() is necessary to detect the changes. CTIDs are changed by updates

Re: Removal of currtid()/currtid2() and some table AM cleanup

2020-06-24 Thread Inoue, Hiroshi
Hi Michael, Where do you test, on Windows or on *nix? How do you test there? regards, Hiroshi Inoue On 2020/06/24 11:11, Michael Paquier wrote: On Tue, Jun 23, 2020 at 02:02:33PM +0900, Michael Paquier wrote: Actually, while reviewing the code, the only code path where we use currtid2() invol

Re: Removal of currtid()/currtid2() and some table AM cleanup

2020-06-25 Thread Inoue, Hiroshi
Hi, I seem to have invalidated KEYSET-DRIVEN cursors used in positioned-update test . It was introduced by the commit 4a272fd but was invalidated by the commit 2be35a6. I don't object to the removal of currtid(2) because keyset-driven cursors in psqlodbc are changed into static cursors in ma