RE: Integer undeflow in fprintf in dsa.c

2024-02-20 Thread Ilyasov Ian
Sorry for not answering quickly. Thank you for your comments. I attached a patch to the letter with changes to take into account Daniel Gustafsson's comment. Kind regards, Ian Ilyasov. Juniour Software Developer at Postgres Professional Subject: [PATCH] Integer underflow fix in fprintf in dsa

Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled

2024-05-14 Thread Ilyasov Ian
Hello, hackers! Recently I've been building postgres with different cflags and cppflags. And suddenly on REL_15_STABLE, REL_16_STABLE and master I faced a failure of a src/test/subscription/t/029_on_error.pl test when   CPPFLAGS="-DWAL_DEBUG" and   printf "wal_debug = on\n" >> "${TEMP_CONF

RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled

2024-05-15 Thread Ilyasov Ian
Dear Hayato, > I made a patch for confirmation purpose. This worked well on my environment. > Ian, how about you? I checked this patch on my environment. It also works well. I like this change, but as I see it makes a different approach from Michael's advice. Honesly, I do not know what would be

RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled

2024-05-22 Thread Ilyasov Ian
Dear Michael, Amit, Hayato I corrected my patch according to what I think Michael wanted. I attached the new patch to the letter. -- Kind regards, Ian Ilyasov. Junior Software Developer at Postgres Professional 0002-Fix-subscription-029_on_error.pl-test-when-wal_debug.patch Description: 0002-

RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled

2024-05-23 Thread Ilyasov Ian
> It seems to me that we should keep the 'for replication target relation "public.tbl" in transaction \d+,', before the "finished at" so as it is possible to make a difference with the context that has a column name and the context where there is no target relation. I agree. Attached the updated p

RE: SIGSEGV, FPE fix in pg_controldata

2025-02-04 Thread Ilyasov Ian
Thank you for your answer, Alexander! I like your patch and it looks similar to my first version of it before I came up to the possible segment size problem. >Also, I don't think we should change segment size to uint32 as it's already defined as int in awfully a lot of places I agree that changi

SIGSEGV, FPE fix in pg_controldata

2024-12-12 Thread Ilyasov Ian
Hello, hackers! Recently I've faced an issue when playing with pg_controldata. I made some rubbish pg_control files and caught a SIGSEGV. Then I tried fuzzing REL_17_STABLE pg_controldata with AFL++ and got 7 crash cases. Also, it is not necessary to use fuzzing. You can simply generate any pg_co