The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I have checked new version. Although I can miss something, t
ersonally I don't
> have better ideas :)
Teodor, Alexander, thanks for review. In new version I have added the
optimization in spgist using level variable and also got rid of magic
numbers.
About the operator it's actually ^@ (not @^ :)), I thought about it and
don't really have
hould be renamed to DebugLevel that looks
nicer, also there DEBUGLEVEl (where last letter is in lower case) which
is very confusing.
I have checked overall functionality of this patch, but haven't checked
any special cases yet.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
ation too. I was going to add btree support but it would
require a new strategy so it will be matter of another patch. I think
this operator could be used in LIKE instead of current weird comparison
operators.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On Sun, 22 Apr 2018 16:21:31 +0300
Alexander Korotkov wrote:
> On Fri, Apr 20, 2018 at 7:45 PM, Konstantin Knizhnik <
> k.knizh...@postgrespro.ru> wrote:
>
> > On 30.03.2018 19:50, Ildus Kurbangaliev wrote:
> >
> >> On Mon, 26 Mar 2018 20:38:25
d be time series
compression described in [1]. [2] contains an example of an extension
that adds lz4 compression using this patch.
[1] http://www.vldb.org/pvldb/vol8/p1816-teller.pdf
[2] https://github.com/zilder/pg_lz4
--
Regards,
Ildus Kurbangaliev
gid "setval: value %s is out of bounds for sequence
\"%\" (%..%)"
msgstr "setval передано значение %s вне пределов последовательности
\"%s\" (%s..%s)"
And still this string will be translatable. I found a bunch of places
when PRIx64 macros can simplify the code
ionary) or UseSharedMemory, the boolean
option called SharedMemory sounds weird.
Overall the patches look good, all tests passed. I tried to broke it in
few places where I thought it could be unsafe but not succeeded.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russia
;
Thank you!
About cmdrop, I checked that's is called manually, but going to check
it thoroughly in my extension.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
used in LIKE queries instead of ~>=~ and ~<~ in the
future. But it would require new strategy for btree.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
diff --git a/src/backend/access/spgist/spgtextproc.c b/src/backend/access/spgist/spg
ovacuum process.
--
---
Regards,
Ildus Kurbangaliev
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index c45979dee4..b7383a7136 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -6250,6 +6250,21 @@ COPY postgres_log FROM '/full/path/to/l
On Fri, 16 Feb 2018 17:42:34 +0900
Masahiko Sawada wrote:
> On Thu, Feb 15, 2018 at 10:16 PM, Grigory Smolkin
> wrote:
> > On 02/15/2018 09:28 AM, Masahiko Sawada wrote:
> >
> >> Hi,
> >>
> >> On Thu, Feb 8, 2018 at 11:01 PM, Ild
On Mon, 19 Feb 2018 15:06:51 +0300
Arthur Zakirov wrote:
> Hello,
>
> On Fri, Feb 02, 2018 at 06:03:27PM +0300, Ildus Kurbangaliev wrote:
> > Hi,
> >
> > Attached patch introduces prefix operator ^@ for text type. For 'a
> > ^@ b' it returns true i
On Fri, 16 Feb 2018 21:48:14 +0900
Masahiko Sawada wrote:
> On Fri, Feb 16, 2018 at 7:50 PM, Ildus Kurbangaliev
> wrote:
> > On Fri, 16 Feb 2018 17:42:34 +0900
> > Masahiko Sawada wrote:
> >
> >> On Thu, Feb 15, 2018 at 10:16 PM, Grigory Smolkin
> >&g
;t v11 material, and should be marked as 'returned with
> feedback'?
Hi, I agree, this patch definitely needs more thinking.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
on tests
(becauses it adds new field in \d+) and new tests.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
ussed before it seems inconsistent without ROLLBACK
support. There was a little discussion about it, but no replies. Maybe
the status of the patch should be changed to 'Waiting on author' until
the end of discussion.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On Tue, 6 Mar 2018 19:27:21 +0300
Arthur Zakirov wrote:
> On Mon, Feb 19, 2018 at 05:19:15PM +0300, Ildus Kurbangaliev wrote:
> > At brief look at this place seems better to move this block into
> > pattern_fixed_prefix function. But there is also `vartype` variable
> > wh
On Tue, 13 Mar 2018 11:08:36 -0400
Peter Eisentraut wrote:
> On 3/6/18 07:48, Ildus Kurbangaliev wrote:
> > Although as was discussed before it seems inconsistent without
> > ROLLBACK support. There was a little discussion about it, but no
> > replies. Maybe the status o
l possibly require new
folder in data directory and management above bunch of new files, with
additional issues related with pg_upgrade and etc. Also in dsm approach
if someone needs to update dictionaries then he (or his package
manager) can just replace files and be done with it.
--
linked to compression options, not the compression
method and this method can be safely dropped.
So in the next version of the patch I can just unlink the options from
compression methods and dropping compression method will not affect
already compressed tuples. They still could be de
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation:tested, failed
The patch looks good. It just removes repetitive code and I t
On Fri, 17 Nov 2017 15:05:31 +
Ildus Kurbangaliev wrote:
> The following review has been posted through the commitfest
> application: make installcheck-world: tested, failed
> Implements feature: tested, failed
> Spec compliant: tested, failed
>
On Mon, 20 Nov 2017 00:23:23 +0100
Tomas Vondra wrote:
> On 11/15/2017 02:13 PM, Robert Haas wrote:
> > On Wed, Nov 15, 2017 at 4:09 AM, Ildus Kurbangaliev
> > wrote:
> >> So in the next version of the patch I can just unlink the options
> >> from compression
27;s why i
decided to only to disable it and the data could be decompressed using
compression options.
My idea was to keep compression options forever, since there will not
be much of them in one database. Still that requires that extension is
not removed.
I will try to find a way how to recompress data first in case it moves
to another table.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
repeat(md5(i::text),300) from
generate_series(1,10) s(i);
\d+
List of relations
Schema | Name | Type | Owner | Size | Description
+--+---+---+-+-
public | t1 | table | ildus | 18 MB |
public | t2 | table | ildus | 1011 MB |
eeded, the complete tool is here:
>
> https://bitbucket.org/tvondra/archie
>
Hi. This looks like a serious bug, but I couldn't reproduce
it yet. Did you upgrade some old database or this bug happened after
insertion of all data to new database? I tried using your 'archie'
to
eap_prepare_insert uses this chunk of code
>
> + else if (HeapTupleHasExternal(tup)
> +|| RelationGetDescr(relation)->tdflags &
> TD_ATTR_CUSTOM_COMPRESSED
> +|| HeapTupleHasCustomCompressed(tup)
> +|| tup->t_len > TOAST_TUPLE_THRESHOLD)
>
>
could be nicer than CREATE COMPRESSION METHOD. I just don't
know that compression could go as access method or not. Anyway
it's easy to change syntax and I don't mind to do it, if it will be
neccessary for the patch to be commited.
--
Regards,
Ildus Kurbangaliev
but it could be
unusable.
--
----
Regards,
Ildus Kurbangaliev
t and which
ones should be kept.
--
----
Regards,
Ildus Kurbangaliev
onder if the patch should instead provide infrastructure for
> doing that in the datatype code directly.
>
> The other question is if the patch should introduce some
> infrastructure for handling the column context (e.g. column
> dictionary). Right now, whoever implements the compression has to
> implement this bit too.
Column specific storage sounds optional to me. For example compressing
timestamp[] using some delta compression will not require it.
--
Regards,
Ildus Kurbangaliev
to keep extra compression options, for example pglz can be
configured with them. Syntax would be slightly changed:
SET COMPRESSION pglz WITH (min_comp_rate=25) PRESERVE awesome;
Setting the same compression method with different options will create
new compression options record for future tuples but will not
rewrite table.
--
Regards,
Ildus Kurbangaliev
On Thu, 14 Dec 2017 10:29:10 -0500
Robert Haas wrote:
> On Wed, Dec 13, 2017 at 7:18 AM, Ildus Kurbangaliev
> wrote:
> > Since we agreed on ALTER syntax, i want to clear things about
> > CREATE. Should it be CREATE ACCESS METHOD .. TYPE СOMPRESSION or
> > CREATE COMPRE
34 matches
Mail list logo
