Re: ALTER tbl rewrite loses CLUSTER ON index

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I tested the patch on the master branch (a77315fdf2a197a925e670b

Re: pgbench - extend initialization phase control

Does both client/server side data generation in a single command make sense?

Re: pgbench - add \aset to store results of a combined query

> SELECT 1 AS one \; > SELECT 2 AS two UNION SELECT 2 \; > SELECT 3 AS three \aset > > will set both "one" and "three", while "two" is not set because there were > two rows. It is a kind of more permissive \gset. Are you sure two is not set :)? SELECT 2 AS two UNION SELECT 2; -- only return

Re: pgbench - extend initialization phase control

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Other than that, the patch looks good to me. The new status of t

Re: block-level incremental backup

r > information. > > 3. Now, we can write the output file - reading each block in turn from the > correct backup and writing it to the write output file, using the map we > constructed in the previous step. We should probably keep all of the input > files open over steps 2 and 3 and then close them at the end because > repeatedly closing and opening them is going to be expensive. When that's > done, > go on to the next file and start over at step 1. > > > At what stage you will apply the WAL generated in between the START/STOP backup. > We are already started working on this design. > > -- > Jeevan Chalke > Technical Architect, Product Development > EnterpriseDB Corporation > > -- Ibrar Ahmed

Re: block-level incremental backup

On Wed, Jul 17, 2019 at 6:43 PM Jeevan Chalke < jeevan.cha...@enterprisedb.com> wrote: > On Wed, Jul 17, 2019 at 2:15 PM Ibrar Ahmed wrote: > >> >> At what stage you will apply the WAL generated in between the START/STOP >> backup. >> > > In this design

Re: Log query parameters for terminated execute

INTO tbl_libpq_test (id, name) VALUES ($1::integer, $2::varchar) lock_timeout: For this I a use the same program to insert into table. I lock the table in other session and try to execute the program. It does not log any params at all here is the log. 2018-07-23 14:21:19.165 PKT [30006] ERROR: canceling statement due to lock timeout at character 13 2018-07-23 14:21:19.165 PKT [30006] STATEMENT: INSERT INTO tbl_libpq_test (id, name) VALUES ($1::integer, $2::varchar) -- Ibrar Ahmed

Re: Log query parameters for terminated execute

(without "at character") ereport in > src/backend/tcop/postgres.c > Maybe try .. catch in parse state, not in execute? > Its really easy to reproduce, just lock the table form another session and run a "c" program to insert row in the same table. > > regards, Sergei > -- Ibrar Ahmed

Re: Log query parameters for terminated execute

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Review submitted The new status of this patch is: Waiting on Author

Re: Log query parameters for terminated execute

Changed the status as per last email of Tom Lane.

Re: pgbench's expression parsing & negative numbers

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Patch does not apply cleanly on the master branch, anyways I managed

Re: [PATCH] SET search_path += octopus

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Thanks for the patch. The patch works on my machine as per specs

Re: pgbench - test whether a variable exists

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: tested, failed Documentation:not tested I am not very convinced to have that, but I have performed some testing o

Re: pgbench's expression parsing & negative numbers

Patch is good to go from my side. The new status of this patch is: Ready for Committer

<    1   2   3