t I'll continue reviewing after the rebased patch.
>
>
>
> Regards,
>
> Kirk Jamison
>
>
>
> [1]
> https://www.postgresql.org/message-id/flat/CAGTBQpbDCaR6vv9%3DscXzuT8fSbckf%3Da3NgZdWFWZbdVugVht6Q%40mail.gmail.com
>
Hi,
Yes, I am working on that. I will send the rebased and updated patch.
--
Ibrar Ahmed
I start looking at the patch, there is a couple of problems with the patch. The
first one is the OID conflict, which I fixed on my machine. The second problem
is assertion failure. I think you have not compiled the PostgreSQL code with
the assertion.
...
postgres=# SELECT *
FROM (projects p1 N
Is this the intended behavior? SIGTERM is received.
test=# begin;
BEGIN
test=# create table test(a int);
CREATE TABLE
In another terminal drop the database.
test=# begin;
psql: FATAL: terminating connection due to administrator command
server closed the connection unexpectedly
This pro
gt;pid, SIGTERM);
On Tue, Apr 9, 2019 at 3:06 PM Ibrar Ahmed wrote:
>
> Is this the intended behavior? SIGTERM is received.
>
> test=# begin;
> BEGIN
> test=# create table test(a int);
> CREATE TABLE
>
>
> In another terminal drop the database.
>
> test=# begin;
>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
The feature works fine on my machine. The code is well-written.
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation:not tested
Patch works perfectly and the code is well-written. I have one mi
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Please ignore the last email.
Patch works perfectly and the code
ed to be consistent.
> And why not "drop tables" and "create tables"
>
> The new status of this patch is: Waiting on Author
--
Ibrar Ahmed
Hi,
Is it possible to have commit-message or at least git hash in
commitfest. It will be very easy to track commit against commitfest
item.
--
Ibrar Ahmed
On Thu, Apr 11, 2019 at 2:44 PM Erikjan Rijkers wrote:
>
> On 2019-04-11 11:36, Ibrar Ahmed wrote:
> > Hi,
> >
> > Is it possible to have commit-message or at least git hash in
> > commitfest. It will be very easy to track commit against commitfest
> > item.
&
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Patch works fine on my machine.
The new status of this patch is:
r2.o_custkey)) AND
((r2.o_orderdate < '1995-03-22')) AND ((r1.c_mktsegment = 'BUILDING')))
ORDER BY r2.o_orderkey, r2.o_orderdate, r2.o_shippriority
...
--
Ibrar Ahmed
On Wed, Apr 24, 2019 at 1:15 AM Tom Lane wrote:
> Ibrar Ahmed writes:
> > I am working on an FDW where the database does not support any operator
> > other than "=" in JOIN condition. Some queries are genrating the plan
> with
> > JOIN having "<"
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Patch looks good to me, and work fine on my machine. One mino
Now the patch is good now.
The new status of this patch is: Ready for Committer
xactly zero. Probably want to put
> back something like that.
>
> * Another thought is that the non-text formats tend to prize output
> consistency over readability, so maybe we should just always use 2
> fractional digits there, rather than trying to minimize visible changes.
>
> In that, we need to adjust a lot of test case outputs.
* We need some doc adjustments, surely, to explain what the heck this
> means.
>
> regards, tom lane
>
--
Ibrar Ahmed
anks, please see the updated and rebased patch. (master
17a28b03645e27d73bf69a95d7569b61e58f06eb)
--
Ibrar Ahmed
diff --git a/contrib/pg_visibility/expected/pg_visibility.out b/contrib/pg_visibility/expected/pg_visibility.out
index f0dcb897c4..6ac3e525eb 100644
--- a/contrib/pg_visibility/expected
On Tue, Mar 24, 2020 at 10:06 PM Ibrar Ahmed wrote:
>
>
> On Fri, Mar 13, 2020 at 6:58 AM Justin Pryzby
> wrote:
>
>>
>> Thanks for picking up this patch. There's a minor typo:
>>
>> +* readable outside of this sessoin. There
On Mon, Mar 16, 2020 at 6:35 PM David Steele wrote:
> On 1/28/20 1:36 PM, Ibrar Ahmed wrote:
> > On Wed, Jan 22, 2020 at 11:17 AM k.jami...@fujitsu.com
> > I might have missed something more,
> >
> > but I'll continue reviewing after the rebased patc
On Thu, Feb 4, 2021 at 1:13 AM Stephen Frost wrote:
> Greetings,
>
> * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote:
> > Anyone else already volunteers that? It is my first time so need some
> > access, if all agree.
>
> Thanks for volunteering!
>
> That said, ou
..
>
> Ibrar, Hamid, have the checklist rewrites been helpful so far? Are you
> planning on doing an (optional!) triage, and if so, are there any
> pieces in particular you'd like me to document?
>
> --Jacob
>
I think we are good now, thanks Jacob, for the effort.
--
Ibrar Ahmed
with Feedback" and send the appropriate email
- For patches marked "Needs review
* If it received at least one good review, move it to the next CF
(removing the current reviewer reservation)
* Otherwise, leave them pending
--
Ibrar Ahmed
next CF: 8.
Returned with Feedback: 5.
Rejected: 2. Withdrawn: 8.
--
Ibrar Ahmed.
On Wed, 5 Oct 2022 at 1:43 PM, Alvaro Herrera
wrote:
> On 2022-Oct-03, Ibrar Ahmed wrote:
>
> > The date of the current commitfest is over, here is the current status of
> > the "September 2022 commitfest."
> > There were 296 patches in the commitfest and
On Wed, Oct 5, 2022 at 3:01 PM Julien Rouhaud wrote:
> Hi,
>
> On Wed, Oct 05, 2022 at 02:50:58PM +0500, Ibrar Ahmed wrote:
> > On Wed, 5 Oct 2022 at 1:43 PM, Alvaro Herrera
> > wrote:
> >
> > > On 2022-Oct-03, Ibrar Ahmed wrote:
> > >
> > >
> role is not filled and there are no objections.
>
> Ibrar Ahmed has already volunteered since a while back, so let's see if he
> is
> still keen to take it on:
>
>
> https://postgr.es/m/caltqxtcgbfeuwg-8mgmsaojp8te61_qaedjbnexjbybeeyz...@mail.gmail.com
>
&
On Fri, 2 Jul 2021 at 1:47 PM, David Rowley wrote:
> On Fri, 2 Jul 2021 at 15:04, vignesh C wrote:
> > I'm interested in assisting Ibrar Ahmed.
>
> It might be worth talking to Ibrar to see where you can lend a hand. I
> think in terms of the number of patches, th
On Fri, 2 Jul 2021 at 7:06 PM, vignesh C wrote:
> On Fri, Jul 2, 2021 at 6:05 PM Ibrar Ahmed wrote:
> >
> >
> >
> > On Fri, 2 Jul 2021 at 1:47 PM, David Rowley
> wrote:
> >>
> >> On Fri, 2 Jul 2021 at 15:04, vignesh C wrote:
> >> >
On Fri, Jul 2, 2021 at 7:15 PM Ibrar Ahmed wrote:
>
>
> On Fri, 2 Jul 2021 at 7:06 PM, vignesh C wrote:
>
>> On Fri, Jul 2, 2021 at 6:05 PM Ibrar Ahmed wrote:
>> >
>> >
>> >
>> > On Fri, 2 Jul 2021 at 1:47 PM, David Rowley
>> wrot
On Tue, Jul 6, 2021 at 3:58 PM Michael Paquier wrote:
> On Tue, Jul 06, 2021 at 03:38:23PM +0500, Ibrar Ahmed wrote:
> > Any update and decision on this? so I can start working on this.
>
> Working on the CF does not strongly require the admin permissions. I
> have already sw
orry about this.
>
> >As I understand, this is a backpatchable bug-fix.
>
> Yes.
>
> Thanks.
>
> Patch does not apply successfully,
http://cfbot.cputube.org/patch_33_2161.log
Can you please rebase the patch.
--
Ibrar Ahmed
ically
> possible to have a false negative but the chances of the LSN ascending N
> times but staying within the backup LSN range due to corruption seems to
> be approaching zero.
>
> I think Michael's method is unlikely to throw false positives, but it
> seems at least possible that a block would be hot enough to be appear
> torn N times in a row. Torn pages themselves are really easy to reproduce.
>
> If we do go forward with this method I would likely propose the
> LSN-based approach as a future improvement.
>
> Regards,
> --
> -David
> da...@pgmasters.net
>
>
>
I am changing the status to "Waiting on Author" based on the latest
comments of @David Steele
and secondly the patch does not apply cleanly.
http://cfbot.cputube.org/patch_33_2719.log
--
Ibrar Ahmed
: 342.
If you are a patch author, please check http://commitfest.cputube.org to be
sure your patch still applies, compiles, and passes tests.
We need your involvement and participation in reviewing the patches. Let's
try and make this happen.
--
Regards.
Ibrar Ahmed
o your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>
> Hi,
Do we still have some interest in this? People generally like that
the idea, if yes I am happy to work on that and can send the complete
design first.
--
Ibrar Ahmed
.72.434 rows=1 loops=1
Workers Planned: 2
Workers Launched: 2
-> Parallel Seq Scan on bar (cost=0.00..7094.27 rows=1
width=4) (actual time=41.931..65.382 rows=0.33 loops=3)
Filter: (c = 1)
Rows Removed by Filter: 245457
Plan
On Thu, Jun 23, 2022 at 1:04 AM David G. Johnston <
david.g.johns...@gmail.com> wrote:
> On Wed, Jun 22, 2022 at 12:11 PM Ibrar Ahmed
> wrote:
>
>> On Thu, Jun 23, 2022 at 12:01 AM Tom Lane wrote:
>>
>>> Robert Haas writes:
>>> > On Jun 2, 200
ure moving forward more
> > "easily", what do you think?
> >
> > Thanks
> >
> > Bertrand
> >
> I'm going to re-create a CF entry for it, as:
>
> - It seems there is a clear interest for the feature (given the time
> already spend on it and the number of people that worked on)
>
> - I've in mind to resume working on it
>
> I have already done some research on that, I can definitely look at it.
> - It would give more visibility in case others want to jump in
>
> Hope that makes sense,
>
> Thanks,
>
> Bertrand
>
>
--
Ibrar Ahmed
On Mon, Jul 4, 2022 at 6:12 PM Drouvot, Bertrand
wrote:
> Hi,
> On 7/1/22 10:03 PM, Ibrar Ahmed wrote:
>
>
> On Thu, Jun 30, 2022 at 1:49 PM Drouvot, Bertrand
> wrote:
>
>> I'm going to re-create a CF entry for it, as:
>>
>> - It seems there is a cl
If nobody has already volunteered for the next upcoming commitfest.
I'd like to volunteer. I think early to say is better as always.
--
Ibrar Ahmed
On Tue, Jul 5, 2022 at 8:50 AM Michael Paquier wrote:
> On Tue, Jul 05, 2022 at 08:17:26AM +0500, Ibrar Ahmed wrote:
> > If nobody has already volunteered for the next upcoming commitfest.
> > I'd like to volunteer. I think early to say is better as always.
>
> Jac
On Thu, Jul 7, 2022 at 2:41 PM Amit Kapila wrote:
> On Thu, Jun 23, 2022 at 2:25 AM Ibrar Ahmed wrote:
> >
> > On Thu, Jun 23, 2022 at 1:04 AM David G. Johnston <
> david.g.johns...@gmail.com> wrote:
> >>
> >> - WRITE_FLOAT_FIELD(rows, &qu
On Thu, Jul 7, 2022 at 3:14 PM vignesh C wrote:
> On Thu, Jun 23, 2022 at 2:25 AM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Jun 23, 2022 at 1:04 AM David G. Johnston <
> david.g.johns...@gmail.com> wrote:
> >>
> >> On Wed, Jun 22, 2022 at
--
> greg
>
+ -> Parallel Seq Scan on tenk1 (actual rows=1960.00
I have added a new check to remove any ".00" from the output because in
the case of parallel queries we are getting that. Secondly, it is
disturbing many test case outputs.
--
Ibrar Ahmed
0.007..6.500 rows=10 loops=1)
Output: objectid, fire_name, fire_year, discovery_date,
discovery_time, stat_cause_descr, fire_size, fire_size_class, latitude,
longitude, state, county,
discovery_date_j, discovery_date_d
Planning Time: 0.094 ms
Execution Time: 13.201 ms
(6 rows)
--
Ibrar Ahmed
-Wimplicit-function-declaration*]
(void) *memset_s*(buf, len, 0, len);
*^~~~*
Attached is the patch to define that in the case of Solaris.
--
Ibrar Ahmed
solaris_memset_s_v1.patch
Description: Binary data
On Sat, Jul 9, 2022 at 6:46 AM Tom Lane wrote:
> Ibrar Ahmed writes:
> > While compiling the PostgreSQL I have found that *memset_s function
> > requires a define "*__STDC_WANT_LIB_EXT1__*" *
> > *explicit_bzero.c:* In function ‘*explicit_bzero*’:
> &
On Sat, Jul 9, 2022 at 10:28 AM Thomas Munro wrote:
> On Sat, Jul 9, 2022 at 2:02 PM Ibrar Ahmed wrote:
> > Thanks for looking at that, yes you are right, the attached patch do
> that now
> >
> > if test "$PORTNAME" = "solaris"; then
> >
>
count based on IP and application
name. I did some POC and had a patch. But before sharing the patch.
I need to know if there has been any previous discussion about this topic;
by the way,
I did some Googling to find that but failed.
Thoughts?
--
Ibrar Ahmed.
Senior Software Engineer, Postg
On Mon, Aug 8, 2022 at 10:11 PM Julien Rouhaud wrote:
> Hi,
>
> On Mon, Aug 08, 2022 at 08:21:06PM +0500, Ibrar Ahmed wrote:
> > While working on pg_stat_stements, I got some questions from customers to
> > have statistics by application and IP address.
> > [...]
>
On Tue, Jul 5, 2022 at 4:31 PM Ibrar Ahmed wrote:
>
>
> On Tue, Jul 5, 2022 at 8:50 AM Michael Paquier
> wrote:
>
>> On Tue, Jul 05, 2022 at 08:17:26AM +0500, Ibrar Ahmed wrote:
>> > If nobody has already volunteered for the next upcoming commitfest.
>> >
was my mistake.
>
> Regards,
> --
> -David
> da...@pgmasters.net
>
>
>
The status of the patch is "Need Review" which was previously "Ready for
Committer ''. After @David G
and @David Steele comments, it's not clear whether it
should be "Read for commit" or "Need Review".
--
Ibrar Ahmed
postgres_fdw ... FAILED 2782 ms
== shutting down postmaster ==
==
1 of 1 tests failed.
==
The differences that caused some tests to fail can be viewed in the
file "/tmp/cirrus-ci-build/contrib/postgres_fdw/regression.diffs". A copy
of the test summary that you see
above is saved in the file
"/tmp/cirrus-ci-build/contrib/postgres_fdw/regression.out".
--
Ibrar Ahmed
above mentioned
> shortcoming of the previous approach, but here is a rebased version in
> the meantime.
>
>
> --
> Amit Langote
> EDB: http://www.enterprisedb.com
>
@Amit patch is not successfully applying, can you please rebase that.
Masahiko Sawada, it's been a bit long since you reviewed the patch, are you
still interested to review that?
--
Ibrar Ahmed
see if
> there are other interesting pathkeys (that's the expectation for
> get_useful_pathkeys_for_relation).
>
>
> regards
>
> --
> Tomas Vondra
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
The patch does not apply successfully, can you please take a look at that
http://cfbot.cputube.org/patch_33_1651.log
=== applying patch ./0001-v12-20210309.patch
atching file src/include/utils/selfuncs.h
Hunk #1 FAILED at 198.
1 out of 1 hunk FAILED -- saving rejects to file
src/include/utils/selfuncs.h.rej
Based on @Tomas Vondra comments, and patch does not apply, I am changing
the status to "Waiting On Author".
--
Ibrar Ahmed
On Wed, Jul 14, 2021 at 1:41 AM Tom Lane wrote:
> Ibrar Ahmed writes:
> > The patch is failing the regression, @Tom Lane can
> you
> > please take a look at that.
>
> Seems to just need an update of the expected-file to account for test
> cases added recently. (I
t; Your feature requires specifying a fixed column or columns to update, so
> it cannot react differently to what column actually updated. In fact,
> you might want different referential actions depending on what columns
> are updated, like what you can do with general triggers.
>
> So, unless I'm missing an angle here, I would suggest leaving out the ON
> UPDATE variant of this feature.
>
>
>
Patch does not apply on head, I am marking the status "Waiting on author"
http://cfbot.cputube.org/patch_33_2932.log
--
Ibrar Ahmed
Software Center
>
>
> Yes, rebase is required, therefore I am changing the status to "Waiting On
Author"
http://cfbot.cputube.org/patch_33_2113.log
--
Ibrar Ahmed
On Thu, Jul 15, 2021 at 2:35 PM Etsuro Fujita
wrote:
> On Thu, Jul 15, 2021 at 4:17 AM Ibrar Ahmed wrote:
> > On Wed, Jul 14, 2021 at 1:41 AM Tom Lane wrote:
> >> Seems to just need an update of the expected-file to account for test
> >> cases added recently. (I
n of the patch).
> Also, choosing of a cheapest path after appendrel creation was added.
> Unstable tests were fixed.
>
> --
> regards,
> Andrey Lepikhov
> Postgres Professional
>
Patch is failing the regression, can you please take a look at that.
partition_join ... FAILED 6328 ms
--
Ibrar Ahmed
;
> Regards,
> --
> -David
> da...@pgmasters.net
Based on last comments of Paul and David S I am changing the status to
"Waiting on Author".
--
Ibrar Ahmed
ery_until() and
> > timeout
> >
> > - remove the useless eval()
> >
> > - remove the "Catalog xmins should advance after standby logical slot
> > fetches the changes" test
> >
> > One thing that's not clear to me is your remark "There's also no test
> > for a recovery conflict due to row removal": Don't you think that the
> > "vacuum full" conflict test is enough? if not, what kind of additional
> > tests would you like to see?
> >
> >>
> >> There is also the 10s delay to work on, do you already have an idea
> >> on how we should handle it?
> >>
> >> Thanks
> >>
> >> Bertrand
> >>
> > Thanks
> >
> > Bertrand
> >
> Please find enclosed v20 a needed rebase (nothing serious worth
> mentioning) of v19.
>
> FWIW, just to sum up that v19 (and so v20):
>
> - contained the changes (see details above) related to your TAP tests
> remarks
>
> - contained the changes (see details above) related to your code remarks
>
> There is still the 10s delay thing that need work: do you already have
> an idea on how we should handle it?
>
> And still one thing that's not clear to me is your remark "There's also
> no test for a recovery conflict due to row removal": Don't you think
> that the "vacuum full" conflict test is enough? if not, what kind of
> additional tests would you like to see?
>
> Thanks
>
> Bertrand
>
>
>
>
>
The patch does not apply and an updated patch is required.
patching file src/include/replication/slot.h
Hunk #1 FAILED at 214.
1 out of 2 hunks FAILED -- saving rejects to file
src/include/replication/slot.h.rej
--
Ibrar Ahmed
st check PG15 version).
>
> Regards,
> Greg Nancarrow
> Fujitsu Australia
>
The patch does not apply, and rebase is required.
Hunk #1 FAILED at 93.
1 out of 1 hunk FAILED -- saving rejects to file
src/test/regress/expected/sysviews.out.rej
I am not changing the status because it is a minor change and the
patch is already "Ready for Committer".
--
Ibrar Ahmed
attached backtrace.
>>
>>
> Thank you for the report, This is fixed in the attached version, now all
> publication
> function calls accept the PublicationTableInfo list.
>
> Thank you,
> Rahila Syed
>
>
>
The patch does not apply, and an rebase is required
Hunk #8 succeeded at 1259 (offset 99 lines).
Hunk #9 succeeded at 1360 (offset 99 lines).
1 out of 9 hunks FAILED -- saving rejects to file
src/backend/replication/pgoutput/pgoutput.c.rej
patching file src/include/catalog/pg_publication.h
Changing the status to "Waiting on Author"
--
Ibrar Ahmed
offset 34 lines).
patching file src/backend/postmaster/checkpointer.c
Hunk #3 succeeded at 496 with fuzz 1.
Hunk #4 FAILED at 576.
1 out of 6 hunks FAILED -- saving rejects to file
src/backend/postmaster/checkpointer.c.rej
patching file src/backend/postmaster/pgstat.c
I am changing the status to "Waiting on Author".
--
Ibrar Ahmed
Hi Tomas,
> Thank you for review of my patch.
> My primary attention was to implement some kid of adaptive query
> optimization based online_analyze extension and building extended
> statistic on demand.
> I have change clausesel.c because right now extended statistic is not
> used for join selectivity estimation and manual or automatic adding such
> statistic can help to
> choose more efficient plan for queries with joins.
> I agree wit you that it can be done in better way, handling more use cases.
> I will be glad to cooperate with you in improving join selectivity
> estimation using extended statistic.
>
>
>
> The patch does not compile, and needs your attention.
https://cirrus-ci.com/task/6397726985289728
clausesel.c:74:28: error: too few arguments to function
‘choose_best_statistics’
StatisticExtInfo *stat = choose_best_statistics(rel->statlist,
STATS_EXT_DEPENDENCIES,
^~
In file included from clausesel.c:24:
../../../../src/include/statistics/statistics.h:123:26: note: declared here
exter
I am changing the status to "Waiting on Author".
--
Ibrar Ahmed
On Mon, Jul 12, 2021 at 4:59 PM Ibrar Ahmed wrote:
>
> Hackers,
>
> The Commitfest 2021-07 is now in progress. It is one of the biggest one.
> Total number of patches of this commitfest is 342.
>
> Needs review: 204.
> Waiting on Author: 40.
> Ready for Committer: 18.
On Mon, Jul 19, 2021 at 4:37 PM Ibrar Ahmed wrote:
>
>
> On Mon, Jul 12, 2021 at 4:59 PM Ibrar Ahmed wrote:
>
>>
>> Hackers,
>>
>> The Commitfest 2021-07 is now in progress. It is one of the biggest one.
>> Total number of patches of this commitfest i
On Mon, Jul 26, 2021 at 5:52 PM Ibrar Ahmed wrote:
>
>
> On Mon, Jul 19, 2021 at 4:37 PM Ibrar Ahmed wrote:
>
>>
>>
>> On Mon, Jul 12, 2021 at 4:59 PM Ibrar Ahmed
>> wrote:
>>
>>>
>>> Hackers,
>>>
>>> The Commitfest
anywhere. Maybe there
> should be a time limit on how many CFs a patch is allowed to just
> automatically slide through?
>
+1 for the idea of allowed CFs. Secondly we can think about the patches
which
have not had a response from the author since long.
>
> regards, tom lane
>
>
>
--
Ibrar Ahmed
an ?50% of
> patches can be moved forwards. Any in excess of that need to join the
> kill list.
>
> I would still ask for someone to spend a little time triaging things,
> so as to direct people who volunteer to be so directed. Many will not
> want to be directed, but I'm sure there must be 5-10 people who would
> do that? (Volunteers?)
>
Count me as a Volunteer.
> --
> Simon Riggshttp://www.EnterpriseDB.com/
>
>
>
--
Ibrar Ahmed
gt; --Jacob
>
> [1] https://wiki.postgresql.org/wiki/CommitFest_Checklist
>
>
> Thanks, I will start working.
--
Ibrar Ahmed.
Senior Software Engineer, PostgreSQL Consultant.
On Tue, Aug 23, 2022 at 1:46 AM Hamid Akhtar wrote:
>
>
> On Tue, 23 Aug 2022 at 1:26 AM, Ibrar Ahmed
> wrote:
>
>>
>>
>> On Mon, Aug 22, 2022 at 9:47 PM Jacob Champion
>> wrote:
>>
>>> On Mon, Aug 22, 2022 at 9:40 AM Tom Lane wrote:
>&
?
>
> - Remove all the hints like this from foreign data commands.
>
> - Don't show the hint when there are more than N valid options.
>
> - Do some kind of "did you mean" like we have for column names.
>
> Thoughts?
--
Ibrar Ahmed
into PostgreSQL 15)
22.
Unit tests for SLRU
Currently, we have 31 patches which require the author's attention.
If you already fixed and replied, change the status.
I'll send out reminders this week to get your patches
registered/rebased, I'll update stale statuses in the CF app.
Thanks,
--
Ibrar Ahmed.
reviewer list for this patch. Of course, you are still welcome to
review it if you can
find the time. We're removing your name so that other reviewers know the
patch still needs
attention. We understand that day jobs and other things get in the way of
doing patch
reviews when you want to, so please come back and review a patch or two
later when you
have more time.
--
Ibrar Ahmed
src/backend/access/heap/rewriteheap.c
Hunk #1 FAILED at 113.
Hunk #2 FAILED at 1213.
Hunk #3 FAILED at 1221.
3 out of 3 hunks FAILED -- saving rejects to file
src/backend/access/heap/rewriteheap.c.rej
--
Ibrar Ahmed
On Sat, Sep 3, 2022 at 12:09 PM Julien Rouhaud wrote:
> Hi,
>
> On Sat, Sep 03, 2022 at 10:36:37AM +0500, Ibrar Ahmed wrote:
> >
> > Hi Kyotaro Horiguchi, Fabien Coelho, Daniel Gustafsson,
> >
> > Since you haven't had time to write a review the last many d
-effects we
> > *don't* want.
>
> This is still listed in the CF as needing review, so I went and marked
> it rejected.
>
> +1, Thanks
> --
> John Naylor
> EDB: http://www.enterprisedb.com
>
--
Ibrar Ahmed
n this scope
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
[03:08:46.087] | ^~
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:40: error:
expected primary-expression before ‘scanbuflen’
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
...
--
Ibrar Ahmed
ED at 12906.
1 out of 4 hunks FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/include/miscadmin.h
--
Ibrar Ahmed
rebase the patch with the latest code.
Hunk #5 succeeded at 147 with fuzz 2 (offset -3 lines).
Hunk #6 FAILED at 170.
Hunk #7 succeeded at 165 (offset -69 lines).
2 out of 7 hunks FAILED -- saving rejects to file
src/include/portability/instr_time.h.rej
patching file src/tools/msvc/Mkvcbuild.pm
--
Ibrar Ahmed
%s %s: " INT64_FORMAT INT64_FORMAT
> "kB\n",
> +sortMethod, spaceType, avgSpaceUsed,
> peakSpaceUsed);
>
>
>
>
> ⚠ External Email: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender.
>
The patch failed different regression tests on all platforms. Please
correct that and send an updated patch.
[06:40:02.370] Test Summary Report
[06:40:02.370] ---
[06:40:02.370] t/002_pg_upgrade.pl (Wstat: 256 Tests: 13 Failed: 1)
[06:40:02.370] Failed test: 4
[06:40:02.370] Non-zero exit status: 1
[06:40:02.370] Files=2, Tests=21, 45 wallclock secs ( 0.02 usr 0.00 sys +
3.52 cusr 2.06 csys = 5.60 CPU)
--
Ibrar Ahmed
6:17:08.194] Result: FAIL
[06:17:08.194] make[2]: *** [Makefile:23: check] Error 1
[06:17:08.194] make[1]: *** [Makefile:52: check-recovery-recurse] Error 2
[06:17:08.194] make: *** [GNUmakefile:71: check-world-src/test-recurse]
Error 2
--
Ibrar Ahmed
ailed and the same query had been executed before the SET ROLE.
>
>
> I left that last query in place as a sanity check to ensure that
> role_read_12's privileges were indeed not in effect after the call to SET
> ROLE.
>
> As we appear to now be working through the minutiae, it is my hope that
> this will soon be ready for merge.
>
> - Kenaniah
>
The patch requires a rebase, please do that.
Hunk #5 succeeded at 454 (offset 28 lines). 1 out of 5 hunks FAILED
-- saving rejects to file doc/src/sgml/ref/grant.sgml.rej
...
...
--
Ibrar Ahmed
d-kernel issue. Perhaps, futex was much slower than this
> days.
>
>
>
> The patch requires a rebase; please do that.
Hunk #1 FAILED at 231.
Hunk #2 succeeded at 409 (offset 82 lines).
1 out of 2 hunks FAILED -- saving rejects to file
src/include/storage/buf_internals.h.rej
--
Ibrar Ahmed
e number.
I will keep sending the emails for the reminder and change the status
of the patches entries accordingly.
Thanks to everyone who is participating in commitfest.
--
Ibrar Ahmed.
Senior Software Engineer, PostgreSQL Consultant.
y; please rebase the patch.
patching file src/backend/utils/misc/guc.c
Hunk #1 FAILED at 642.
Hunk #2 FAILED at 3943.
2 out of 2 hunks FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/backend/utils/misc/postgresql.conf.sample
patching file src/include/jit/jit.h
--
Ibrar Ahmed
7;s what's typical on these
> > lists (and the list tool is smart enough not to send duplicates to
> > people who are direct recipients).
>
> Ok - will do, thanks.
>
> --
> Reid Thompson
> Senior Software Engineer
> Crunchy Data, Inc.
>
> reid.thomp...@crunchydata.com
> www.crunchydata.com
>
>
> The patch does not apply; please rebase the patch.
patching file src/backend/utils/misc/guc.c
Hunk #1 FAILED at 3664.
1 out of 1 hunk FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/backend/utils/misc/postgresql.conf.sample
--
Ibrar Ahmed
end/postmaster/fork_process.c.rej
patching file src/backend/storage/file/fd.c
Hunk #1 FAILED at 2503.
1 out of 1 hunk FAILED -- saving rejects to file
src/backend/storage/file/fd.c.rej
patching file src/backend/utils/error/elog.c
Hunk #1 FAILED at 643.
Hunk #2 FAILED at 670.
--
Ibrar Ahmed
On Mon, Mar 20, 2023 at 7:56 PM Gregory Stark (as CFM)
wrote:
> On Wed, 4 Jan 2023 at 10:05, Ibrar Ahmed wrote:
> >
> > Thanks, I have modified everything as suggested, except one point
> >
> > > Don't use variable format strings. They're hard to read and
est of moving things
> along.
> > I've switched the 2023-07 CF to in-progress and 2023-09 to open, let's
> try to
> > close patches!
>
> Thanks, Daniel!
> --
> Michael
>
If nobody taking that, I can take the responsibility.--
Ibrar Ahmed
roject
and found that you are already working on it. The last message is almost
six months old. I want to check with you that are you still working on
that, if yes I can help on that by reviewing the patch etc. If you are not
working on that anymore, can you share your done work (if possible)?
--
Ibrar Ahmed
| Default
-+--+---+--+-
temporal_id | oid | | |
hist_id | oid | | |
start_date_name | text | | |
end_date_name | text | | |
--
Ibrar Ahmed
Hi Paul,
On Sat, Feb 23, 2019 at 2:16 AM Paul Jungwirth
wrote:
> On 2/22/19 11:31 AM, Euler Taveira wrote:
> > Em sex, 22 de fev de 2019 às 15:41, Ibrar Ahmed
> > escreveu:
> >>
> >> While working on another PostgreSQL feature, I was thinking that we
> coul
ioned storage both for logs and for data pages).
>
> regards,
> Yura.
>
Hi,
Do we still want to see the patch of that paper (
http://www.vldb.org/pvldb/vol11/p648-tian.pdf)?
--
Ibrar Ahmed
we need that for plain inserts?
2 - Andres: I think we should remove the WAL logging from
visibilitymap_set(), and
move it to a separate, heap specific, function. Right now different
tableams e.g. would have to reimplement visibilitymap_set(), so that's a
second need to separate that functionality. Let me try to come up with
a proposal.
--
Ibrar Ahmed
0003-copy-freeze-should-actually-freeze-right.patch
Description: Binary data
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: not tested
Documentation:not tested
Please fix the regression test cases.
The new status of this patch i
On Mon, Mar 2, 2020 at 12:45 PM Ahsan Hadi wrote:
>
>
> On Sat, Feb 29, 2020 at 2:38 AM Alvaro Herrera
> wrote:
>
>> On 2020-Feb-28, ahsan hadi wrote:
>>
>>
>> > Tested the pg_dump patch for dumping "ALTER .. DEPENDS ON EXTENSION" in
>> case of indexes, functions, triggers etc. The "ALTER .. DEP
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
It works for me
On Thu, Mar 5, 2020 at 11:38 PM Alvaro Herrera
wrote:
> On 2020-Mar-05, Ibrar Ahmed wrote:
>
> > Is this intentional that there is no error when removing a non-existing
> > dependency?
>
> Hmm, I think we can do nothing silently if nothing is called for.
> So, yes,
101 - 200 of 214 matches
Mail list logo
