Re: Fix for parallel BTree initialization bug

2020-09-10 Thread Hunter, James
Nice repro, thanks! -- James Hunter, Amazon Web Services (AWS) On 9/10/20 7:37 PM, Justin Pryzby wrote: Against all odds, I was able to reproduce this. begin; CREATE TABLE t AS SELECT generate_series(1,99)i; ALTER TABLE t SET (parallel_workers=2, autovacuum_enabled=off); CREATE INDEX ON t(i

Re: Fix for parallel BTree initialization bug

2020-09-09 Thread Jameson, Hunter 'James'
James On 9/9/20, 6:14 AM, "Amit Kapila" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Tue, Sep 8, 2020 at 11:55 PM Jameson, Hunter 'Jam

Re: [UNVERIFIED SENDER] Re: Fix for parallel BTree initialization bug

2020-09-09 Thread Jameson, Hunter 'James'
seems to be a pretty simple oversight: in 6 out of 7 cases in _bt_first(), we call _bt_parallel_done() before returning "false"; but in the 7th case (fixed in this bug fix), we do not. The fix is to make case #7 the same as the other 6. James On 9/9/20, 7:11 AM, "Jameson, Hunter

Re: Fix for parallel BTree initialization bug

2020-09-10 Thread Jameson, Hunter 'James'
nts unless you can confirm the sender and know the content is safe. On Tue, Sep 08, 2020 at 06:25:03PM +, Jameson, Hunter 'James' wrote: > Hi, I ran across a small (but annoying) bug in initializing parallel BTree scans, which causes the parallel-scan state machine to

Re: Fix for parallel BTree initialization bug

2020-09-10 Thread Jameson, Hunter 'James'
Answers inline below: On 9/10/20, 4:58 AM, "Amit Kapila" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Tue, Sep 8, 2020 at 11:55 PM James