Re: Unaccent extension python script Issue in Windows

2019-03-12 Thread Hugh Ranalli
On Mon, 11 Mar 2019 at 22:29, Michael Paquier wrote: > On Mon, Mar 11, 2019 at 09:54:45PM +0530, Ramanarayana wrote: > > I went through the python script and found that the stdout encoding is > set > > to utf-8 only if python version is <=2. The same needs to be done for > > python 3 > > If you s

Re: Unaccent extension python script Issue in Windows

2019-03-17 Thread Hugh Ranalli
Hi Ram, Thanks for doing this; I've been overestimating my ability to get to things over the last couple of weeks. I've looked at the patch and have made one minor change. I had moved all the imports up to the top, to keep them in one place (and I think some had originally been used only by the Py

Re: Unaccent extension python script Issue in Windows

2019-03-18 Thread Hugh Ranalli
On Mon, 18 Mar 2019 at 01:14, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > This patch contains irrelevant changes. The minimal required > change would be the attached. If you want refacotor the > UnicodeData reader or rearrange import sutff, it should be > separate patches. > I'm

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-11 Thread Hugh Ranalli
On Sun, 10 Feb 2019 at 15:07, raam narayana wrote: > Hi, > > After the latest commit in master branch, I was trying to test the python > script. Ironically I still see that the output from the script is > completely different from the unaccent.rules file content. Am I missing > anything.My testin

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-12 Thread Hugh Ranalli
On Tue, 12 Feb 2019 at 08:54, Ramanarayana wrote: > Hi Michael, > The issue was that the python script was working in python 2 but not in > python 3 in Windows. This is because the python script writes the final > output to stdout and stdout encoding is set to utf-8 only for python 2 but > not py

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-16 Thread Hugh Ranalli
On Mon, 11 Feb 2019 at 15:57, Ramanarayana wrote: > Hi Hugh, > > I tested the script in python 2.7 and it works perfect. The problem is in > python 3.7(and may be only in windows as you were not getting the issue) > and I was getting the following error > > UnicodeEncodeError: 'charmap' codec can