Re: Libpq support to connect to standby server as priority

2018-07-16 Thread Haribabu Kommi
On Wed, Jul 11, 2018 at 6:00 PM Haribabu Kommi wrote: > > > On Wed, Jul 4, 2018 at 11:14 PM Laurenz Albe > wrote: > >> Haribabu Kommi wrote: >> >> > - I think the construction with "read_write_host_index" makes the code >> even more >

Re: Libpq support to connect to standby server as priority

2018-07-17 Thread Haribabu Kommi
On Tue, Jul 17, 2018 at 12:42 AM Laurenz Albe wrote: > Haribabu Kommi wrote: > > > On Wed, Jul 4, 2018 at 11:14 PM Laurenz Albe > wrote: > > > > Haribabu Kommi wrote: > > > > > > > > - I think the construction with "read_write_host_index&q

Re: Pluggable Storage - Andres's take

2018-07-17 Thread Haribabu Kommi
On Mon, Jul 16, 2018 at 11:35 PM Andres Freund wrote: > On 2018-07-04 20:11:21 +1000, Haribabu Kommi wrote: > > On Tue, Jul 3, 2018 at 5:06 PM Andres Freund wrote: > > > > The most fundamental issues I had with Haribabu's last version from [2] > > > are the

Re: [bug fix] Produce a crash dump before main() on Windows

2018-07-17 Thread Haribabu Kommi
process, if no one present to observe the scenario? Doesn't this change can generate backward compatibility problems to particular users? I don't have any other comments with the current patch. Regards, Haribabu Kommi Fujitsu Australia

Re: [bug fix] Produce a crash dump before main() on Windows

2018-07-18 Thread Haribabu Kommi
On Wed, Jul 18, 2018 at 4:10 PM Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Haribabu Kommi [mailto:kommi.harib...@gmail.com] > > I reviewed patch and it works as per the subject, but I am not able to > verify > > the actual > > bug that is

Re: [bug fix] Produce a crash dump before main() on Windows

2018-07-19 Thread Haribabu Kommi
On Wed, Jul 18, 2018 at 6:39 PM Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Haribabu Kommi [mailto:kommi.harib...@gmail.com] > > May be I can give a try by modifying the source code to get the crash. > > > Thank you, that would be great if you c

Re: Libpq support to connect to standby server as priority

2018-07-19 Thread Haribabu Kommi
will work on the code refactoring first and then provide the prefer-read option on top it. Regards, Haribabu Kommi Fujitsu Australia

Re: Pluggable Storage - Andres's take

2018-07-24 Thread Haribabu Kommi
On Tue, Jul 17, 2018 at 11:01 PM Haribabu Kommi wrote: > > On Mon, Jul 16, 2018 at 11:35 PM Andres Freund wrote: > >> On 2018-07-04 20:11:21 +1000, Haribabu Kommi wrote: >> > On Tue, Jul 3, 2018 at 5:06 PM Andres Freund >> wrote: >> > >> > >

Re: Pluggable Storage - Andres's take

2018-08-02 Thread Haribabu Kommi
On Tue, Jul 24, 2018 at 11:31 PM Haribabu Kommi wrote: > On Tue, Jul 17, 2018 at 11:01 PM Haribabu Kommi > wrote: > >> >> I added new API in the tableam.h to get all the page visible tuples to > abstract the bitgetpage() function. > > >>- Merge tableam.h and

Re: Fallout from PQhost() semantics changes

2018-08-03 Thread Haribabu Kommi
c98 into v10, because the problems of libpq-internal-PQhost-usage-1.patch fix are present in v10 when the connected host is of CHT_HOST_ADDRESS. In fact, I think there's probably a good case for doing something > comparable to libpq-internal-PQhost-usage-1.patch all the way back. > In exactly what scenario is it sane to be comparing "/tmp" or > "localhost" to a server's SSL certificate? > Yes, I agree that this problem present from a long, but may be till now everyone using along with host only? Regards, Haribabu Kommi Fujitsu Australia

Re: Postgres 11 release notes

2018-05-21 Thread Haribabu Kommi
ing the release notes. >Have pg_dump dump all aspects of a database (Haribabu Kommi) > >pg_dump and pg_restore, without --clean, no longer dump/restore database > comments and security labels. There is small change in option name, the option to print database comments is --create not --cl

Re: Postgres 11 release notes

2018-05-22 Thread Haribabu Kommi
On Wed, May 23, 2018 at 11:34 AM, Bruce Momjian wrote: > On Mon, May 21, 2018 at 06:28:36PM +1000, Haribabu Kommi wrote: > > On Sat, May 12, 2018 at 1:08 AM, Bruce Momjian wrote: > > > > I have committed the first draft of the Postgres 11 release notes. I > >

Re: Column store in Greenplum

2018-06-07 Thread Haribabu Kommi
oups.google.com/a/greenplum.org/d/msg/gpdb-dev/ > 73LOuQFkIps/1TNHW0lGAwAJ > > Unique indexes are not supported on column oriented tables. > Identifying a concurrent transaction that might be inserting duplicate > tuples becomes hard because (1) lack of MVCC information in tuples and > (2) one block directory tuple covers multiple row numbers. > Thanks for sharing your design details, I will go through them clearly to understand with the current proposed pluggable table access method interfaces can handle all the other storage methods that are implemented outside PostgreSQL. [1] - https://www.postgresql.org/message-id/CAJrrPGfRGtRz_-Qyt_hK9KCQYdN%3DpbpjPooAHM9dZhJmqwN8fg%40mail.gmail.com [2] - https://www.postgresql.org/message-id/cajrrpgfac7wc9nk6ptty6yn-nn+hcy8xolah2doyhvg5d6h...@mail.gmail.com Regards, Haribabu Kommi Fujitsu Australia

Does logical replication supports cross platform servers?

2018-06-11 Thread Haribabu Kommi
the above scenarios in [1]. But I am unable find this support mentioning in the docs, Do we support? or any problems? If it supports it is better to update the docs. [1] - https://stackoverflow.com/questions/46603257/can-we-replicate-postgres-data-between-two-os/46603426#46603426 Regards, Harib

Re: Does logical replication supports cross platform servers?

2018-06-12 Thread Haribabu Kommi
On Tue, Jun 12, 2018 at 1:29 PM Craig Ringer wrote: > On 12 June 2018 at 11:04, Haribabu Kommi wrote: > >> Hi All, >> >> I am not able to find any docs suggesting that PostgreSQL logical >> replication supports >> cross platform servers (windows --> Lin

Re: Libpq support to connect to standby server as priority

2018-06-18 Thread Haribabu Kommi
options needs to take as two different options. prefer-read is simple to support than read-only. Here I attached an updated patch that is rebased to the latest master and also fixed some of the corner scenarios. Regards, Haribabu Kommi Fujitsu Australia 0001-Allow-target-session-attrs-to-accept-prefer-read-opti.patch Description: Binary data

New function pg_stat_statements_reset_query() to reset statistics of a specific query

2018-06-20 Thread Haribabu Kommi
useful if we a function that resets the stats of a single query, instead of reseting all the queries. Attached is a simple patch with implementation. Comments? Regards, Haribabu Kommi Fujitsu Australia 0001-Function-to-reset-statistics-of-a-specific-statement.patch Description: Binary data

Re: [HACKERS] Pluggable storage

2018-06-21 Thread Haribabu Kommi
On Thu, Jun 14, 2018 at 12:25 PM Amit Kapila wrote: > On Thu, Jun 14, 2018 at 1:50 AM, Haribabu Kommi > wrote: > > > > On Fri, Apr 20, 2018 at 4:44 PM Haribabu Kommi > > > wrote: > > > > VACUUM: > > Not much changes are done in this apart moving t

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

2018-06-22 Thread Haribabu Kommi
On Sat, Jun 23, 2018 at 5:45 AM Euler Taveira wrote: > 2018-06-22 12:06 GMT-03:00 Robert Haas : > > On Wed, Jun 20, 2018 at 10:19 AM, Euler Taveira > wrote: > >> 2018-06-20 4:30 GMT-03:00 Haribabu Kommi : > >>> Attached is a simple patch with implementation. C

Re: I'd like to discuss scaleout at PGCon

2018-06-22 Thread Haribabu Kommi
gable buffer pool and lock manager, how about adding many instances and all share the buffers using RDMA to provide better scaling with shared everything. Currently I didn't know have any idea whether is it possible or not and also the problems in using RDMA. Just want to check whether is it worth idea to consider in supporting scale out? Regards, Haribabu Kommi Fujitsu Australia

Re: [HACKERS] SERIALIZABLE with parallel query

2017-11-23 Thread Haribabu Kommi
On Tue, Sep 26, 2017 at 4:41 PM, Haribabu Kommi wrote: > > > On Mon, Sep 25, 2017 at 6:57 PM, Thomas Munro < > thomas.mu...@enterprisedb.com> wrote: > >> On Mon, Sep 25, 2017 at 8:37 PM, Haribabu Kommi >> wrote: >> > After I tune the GUC to go with se

Re: [HACKERS] pg_stat_wal_write statistics view

2017-11-26 Thread Haribabu Kommi
On Wed, Nov 8, 2017 at 8:46 AM, Robert Haas wrote: > On Tue, Nov 7, 2017 at 4:31 AM, Haribabu Kommi > wrote: > >> Updated patch attached. > > Patch rebased. > > I think the earlier concerns about the performance impact of this are > probably very valid concern

Re: [HACKERS] pg_stat_wal_write statistics view

2017-12-12 Thread Haribabu Kommi
On Mon, Nov 27, 2017 at 2:12 PM, Haribabu Kommi wrote: > > On Wed, Nov 8, 2017 at 8:46 AM, Robert Haas wrote: > >> On Tue, Nov 7, 2017 at 4:31 AM, Haribabu Kommi >> wrote: >> >> Updated patch attached. >> > Patch rebased. >> >> I think the

Re: [HACKERS] SERIALIZABLE with parallel query

2017-12-12 Thread Haribabu Kommi
On Fri, Dec 8, 2017 at 11:33 AM, Thomas Munro wrote: > On Thu, Nov 30, 2017 at 2:44 PM, Thomas Munro > wrote: > > On Thu, Nov 30, 2017 at 2:32 PM, Michael Paquier > > wrote: > >> Could this question be answered? The patch still applies so I am > >> moving it to next CF. > > Rebased, 'cause it b

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-12-12 Thread Haribabu Kommi
On Wed, Nov 29, 2017 at 4:25 PM, Michael Paquier wrote: > On Wed, Nov 8, 2017 at 8:50 AM, Haribabu Kommi > wrote: > > Ok. Removed the documentation changes that it cannot be used for normal > > scenarios, and also added a Note section explaining the problem of using > >

Enhance pg_stat_wal_receiver view to display connected host

2017-12-21 Thread Haribabu Kommi
Hi Hackers, With the multi host connection string feature, it is possible to specify multiple hosts in primary_conninfo that is used in streaming replication to make sure that WAL streaming is not affected. Currently there is no information that is available in the standby node to find out to whi

Re: force parallel mode vs CTAS

2017-12-21 Thread Haribabu Kommi
On Fri, Dec 22, 2017 at 2:34 AM, Tom Lane wrote: > Robert Haas writes: > > Great subject line! > > fixed ... > Thanks for the fix Robert. This could have been caught, if I have test that creates toast table using CTAS during development of the patch. Regards, Hari Babu Fujitsu Australia

Re: Enhance pg_stat_wal_receiver view to display connected host

2017-12-21 Thread Haribabu Kommi
On Thu, Dec 21, 2017 at 11:12 PM, Michael Paquier wrote: > On Thu, Dec 21, 2017 at 8:16 PM, Haribabu Kommi > wrote: > > The current connected host details are already available in the PGconn > > structure, > > Exposing those details in the view will suffice this

Re: Pluggable Storage - Andres's take

2018-08-20 Thread Haribabu Kommi
> with. I plan to push a tree including a lot of fixes and improvements > soon. > Sorry for coming late to this thread. That's good. Did you find any problems in porting zheap into pluggable storage? Does it needs any API changes or new API requirement? > On 2018-08-03 12:35

Re: Pluggable Storage - Andres's take

2018-08-23 Thread Haribabu Kommi
On Tue, Aug 21, 2018 at 6:59 PM Andres Freund wrote: > On 2018-08-21 16:55:47 +1000, Haribabu Kommi wrote: > > On Sun, Aug 5, 2018 at 7:48 PM Andres Freund wrote: > > > I'm currently in the process of rebasing zheap onto the pluggable > > > storage wor

Re: Pluggable Storage - Andres's take

2018-08-27 Thread Haribabu Kommi
On Fri, Aug 24, 2018 at 12:50 PM Andres Freund wrote: > Hi, > > On 2018-08-24 11:55:41 +1000, Haribabu Kommi wrote: > > On Tue, Aug 21, 2018 at 6:59 PM Andres Freund > wrote: > > > > > On 2018-08-21 16:55:47 +1000, Haribabu Kommi wrote: > > > >

Re: Pluggable Storage - Andres's take

2018-09-03 Thread Haribabu Kommi
On Tue, Aug 28, 2018 at 1:48 PM Haribabu Kommi wrote: > On Fri, Aug 24, 2018 at 12:50 PM Andres Freund wrote: > >> Hi, >> >> On 2018-08-24 11:55:41 +1000, Haribabu Kommi wrote: >> > On Tue, Aug 21, 2018 at 6:59 PM Andres Freund >> wrote: >> > >

Re: Pluggable Storage - Andres's take

2018-09-04 Thread Haribabu Kommi
On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote: > Hi, > > Thanks for the patches! > > On 2018-09-03 19:06:27 +1000, Haribabu Kommi wrote: > > I found couple of places where the zheap is using some extra logic in > > verifying > > whether it is zheap AM or n

Re: Pluggable Storage - Andres's take

2018-09-10 Thread Haribabu Kommi
On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi wrote: > > On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote: > >> Hi, >> >> Thanks for the patches! >> >> On 2018-09-03 19:06:27 +1000, Haribabu Kommi wrote: >> > I found couple of pla

View to get all the extension control file details

2018-09-16 Thread Haribabu Kommi
ke "pg_available_extension_details" to display all extension control file columns? or Adding them to the existing view is good? Regards, Haribabu Kommi Fujitsu Australia

Re: Pluggable Storage - Andres's take

2018-09-20 Thread Haribabu Kommi
On Mon, Sep 10, 2018 at 5:42 PM Haribabu Kommi wrote: > On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi > wrote: > >> >> On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote: >> >>> Hi, >>> >>> Thanks for the patches! >>> >&g

Re: View to get all the extension control file details

2018-09-21 Thread Haribabu Kommi
On Thu, Sep 20, 2018 at 3:18 PM Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello. > > At Mon, 17 Sep 2018 16:49:41 +1000, Haribabu Kommi < > kommi.harib...@gmail.com> wrote in > > > Hi Hackers, > > > > Currently PostgreSQL

Re: Pluggable Storage - Andres's take

2018-09-21 Thread Haribabu Kommi
On Fri, Sep 21, 2018 at 5:05 PM Andres Freund wrote: > Hi, > > On 2018-09-21 16:57:43 +1000, Haribabu Kommi wrote: > > > For example, in the sequential scan, the heap returns the slot with > > the tuple or with value array of all the columns and then the data gets > &

Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role

2018-09-23 Thread Haribabu Kommi
-bVweK8GjpOipWh3rAAstMqoUfz7qBFrs8Tuw%40mail.gmail.com [3] - https://www.postgresql.org/message-id/CAJrrPGdre9CqaHsbgtsc3LmJSRFg41fOZ%2BZVpX9zu3D1fGqAeQ%40mail.gmail.com Regards, Haribabu Kommi Fujitsu Australia 0001-Revoke-pg_stat_statements_reset-permissions_v2.patch Description: Binary data

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

2018-09-23 Thread Haribabu Kommi
On Sat, Sep 22, 2018 at 11:23 PM Amit Kapila wrote: > On Mon, Jul 9, 2018 at 11:28 AM Haribabu Kommi > wrote: > > > > On Mon, Jul 9, 2018 at 3:39 PM Haribabu Kommi > wrote: > >> > >> > >> On Mon, Jul 9, 2018 at 12:24 PM Michael Paquier > wr

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

2018-09-23 Thread Haribabu Kommi
On Mon, Sep 24, 2018 at 11:13 AM Haribabu Kommi wrote: > On Sat, Sep 22, 2018 at 11:23 PM Amit Kapila > wrote: > >> On Mon, Jul 9, 2018 at 11:28 AM Haribabu Kommi >> wrote: >> > >> > On Mon, Jul 9, 2018 at 3:39 PM Haribabu Kommi >> wrote: >

Re: Pluggable Storage - Andres's take

2018-09-23 Thread Haribabu Kommi
mail (August 24)... > The code is latest, but the commit time is older, I feel that is because of commit squash. pluggable-storage is the branch where the pluggable storage code is present and pluggable-zheap branch where zheap is rebased on top of pluggable storage. Regards, Haribabu Kommi Fujitsu Australia

Re: Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role

2018-09-24 Thread Haribabu Kommi
ry for the incorrect reference pointing to a > commit of REL9_6_STABLE. As the patch only needs to be applied down to > v10, there is no need to do anything more complicated than what Hari has > proposed. So, committed after a bit of comment and format tweaks. > Thanks for the changes and commit. Regards, Haribabu Kommi Fujitsu Australia

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

2018-09-24 Thread Haribabu Kommi
On Tue, Sep 25, 2018 at 1:39 AM Michael Paquier wrote: > On Mon, Sep 24, 2018 at 12:19:44PM +1000, Haribabu Kommi wrote: > > Attached new rebased version of the patch that enhances the > > pg_stat_statements_reset() > > function. This needs to be applied on top of the pa

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

2018-09-27 Thread Haribabu Kommi
On Tue, Sep 25, 2018 at 3:09 PM Michael Paquier wrote: > On Tue, Sep 25, 2018 at 01:49:09PM +1000, Haribabu Kommi wrote: > > Thanks for the review. > > Fixed in the attached patch as per your suggestion. > Thanks for the review. Hmm. I see a problem with the tests and the

Re: Pluggable Storage - Andres's take

2018-09-27 Thread Haribabu Kommi
On Fri, Sep 21, 2018 at 5:40 PM Haribabu Kommi wrote: > > On Fri, Sep 21, 2018 at 5:05 PM Andres Freund wrote: > >> Hi, >> >> On 2018-09-21 16:57:43 +1000, Haribabu Kommi wrote: >> >> > For example, in the sequential scan, the heap returns the slot with

Re: Libpq support to connect to standby server as priority

2018-09-28 Thread Haribabu Kommi
On Thu, Jul 19, 2018 at 10:59 PM Haribabu Kommi wrote: > > On Wed, Jul 18, 2018 at 10:53 PM Robert Haas > wrote: > >> On Wed, Jul 4, 2018 at 9:14 AM, Laurenz Albe >> wrote: >> > What about keeping the first successful connection open and storing >&g

<    1   2   3