This looks like it needs a rebase.
=== Applying patches on top of PostgreSQL commit ID
71a75626d5271f2bcdbdc43b8c13065c4634fd9f ===
=== applying patch ./v11-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch
patching file src/interfaces/libpq/fe-auth-scram.c
patching file src/interfaces/libpq/fe-auth
It looks like this patch received some feedback from Andres and hasn't
had any further work posted. I'm going to move it to "Waiting on
Author".
It doesn't sound like this is likely to get committed this release
cycle unless responding to Andres's points simpler than I expect.
ething
particular about the test environment that is either not set up right
or is exposing a bug?
Please check if this is a real failure or a cfbot failure.
--
Gregory Stark
As Commitfest Manager
On Wed, 11 Jan 2023 at 04:00, Jelte Fennema wrote:
>
> I'm working on a new patchset for my commitfest entry.
So I'll set it to "Waiting on Author" pending that new patchset...
--
Gregory Stark
As Commitfest Manager
CT DO [NOTHING|UPDATE .. ]
> > [ALLOWING|FORBIDDING] SELF CONFLICTS;
> > ```
> >
> > ... if we really want to.
Something like that might be what I mean about new insights though I
suspect this is overly complex. It looks like having the ON CONFLICT
UPDATE happen before
e. Thought?
This patch appears to need a rebase. Is there really any feedback
needed or is it ready for committer once it's rebased?
--
Gregory Stark
As Commitfest Manager
On Wed, 1 Mar 2023 at 14:48, Jelte Fennema wrote:
> > > This looks like it needs a rebase.
>
> done
Great. Please update the CF entry to Needs Review or Ready for
Committer as appropriate :)
--
Gregory Stark
As Commitfest Manager
>
> Makes sense.
>
> > And it looks to me that removing PgStat_BackendFunctionEntry can be done
> > independently
>
> It's imo the function version of 1), just a bit simpler to implement due to
> the much simpler reconciliation. It could be done together with it, or
> separately.
--
Gregory Stark
As Commitfest Manager
i and
you have a path forward. It's not currently building in the build farm
either.
I'll set the patch to Waiting on Author for now.
--
Gregory Stark
As Commitfest Manager
eds a (perhaps trivial) rebase.
It sounds like all the design questions are resolved so perhaps this
can be set to Ready for Committer once it's rebased?
--
Gregory Stark
As Commitfest Manager
e for release that would be great but if
not then feel free to move it to the next commitfest (which means next
release).
--
Gregory Stark
As Commitfest Manager
nly trying to apply the first (the MacOS one) and it's
failing to apply even that.
--
Gregory Stark
As Commitfest Manager
t's rebased
if you think it's ready set it to Ready for Committer or if you still
need feedback then Needs Review -- but it's usually more helpful to do
that with an email expressing what questions you're blocked on.
--
Gregory Stark
As Commitfest Manager
(offset 37 lines).
Hunk #5 succeeded at 3117 (offset 146 lines).
patching file src/include/optimizer/clauses.h
patching file src/include/optimizer/pathnode.h
Hunk #2 FAILED at 311.
Hunk #3 FAILED at 344.
2 out of 3 hunks FAILED -- saving rejects to file
src/include/optimizer/pathnode.h.rej
--
G
less 5 hours as of the moment of this
> > message:
> > https://www.timeanddate.com/time/zones/aoe
>
> Note: I have switched this CF as "In Process" a few hours ago.
> --
> Michael
--
Gregory Stark
As Commitfest Manager
RROR: function
> pg_input_error_info(unknown, unknown) does not exist" in the regression.diff).
>
> Documentation exists for the new feature
>
> The new status of this patch is: Ready for Committer
--
Gregory Stark
As Commitfest Manager
ybe it can just be solved with multiple one-line scripts
that call to a master script?
--
Gregory Stark
As Commitfest Manager
It looks like this needs a rebase and at a quick glance it looks like
more than a trivial conflict. I'll mark it Waiting on Author. Please
update it back when it's rebased
--
Gregory Stark
As Commitfest Manager
|+++ b/contrib/pg_stat_statements/sql/pg_stat_statements.sql
--
No file to patch. Skipping patch.
--
Gregory Stark
As Commitfest Manager
: terminating any
other active server processes
--
Gregory Stark
As Commitfest Manager
ght and whether
the hand-written parser is sensible. And if so then can a committer
step up to actual review and commit the patch? The last review said it
might need a native English speaker to tweak some wording but
otherwise looked good.
--
Gregory Stark
As Commitfest Manager
x27;s time after 2 1/2 years to get this one committed?
--
Gregory Stark
As Commitfest Manager
It looks like this needs a big rebase in fea-uth.c fe-auth-scram.c and
fe-connect.c. Every hunk is failing which perhaps means the code
you're patching has been moved or refactored?
It does look like a rebase for meson.build would be helpful. I'm not
marking it waiting on author just for meson.build conflicts but it
would be perhaps more likely to be picked up by a committer if it's
showing green in cfbot.
The pgindent run in b6dfee28f is causing this patch to need a rebase
for the cfbot to apply it.
So I was seeing that this patch needs a rebase according to cfbot.
However it looks like the review feedback you're looking for is more
of design questions. What jumbling is best to include in the feature
set and which is best to add in later patches. It sounds like you've
gotten conflicting feedb
So what is the status of this patch?
It looks like you received some feedback from Emre, Tom, Ronan, and
Alvaro but it also looks like you responded to most or all of that.
Are you still blocked waiting for feedback? Anything specific you need
help with?
Or is the patch ready for commit now? In w
FYI this looks like it needs a rebase due to a conflict in copy.c and
an offset in pgoutput.c.
Is there anything specific that still needs review or do you think
you've handled all Peter's concerns? In particular, is there "a
comprehensive description of what it is trying to do"? :)
CFBot is failing with this test failure... I'm not sure if this just
represents a timing dependency or a bad test or what?
[09:44:49.937] --- stdout ---
[09:44:49.937] # executing test in
/tmp/cirrus-ci-build/build-32/testrun/authentication/001_password
group authentication test 001_password
[09:
It looks like the patch is failing a test by not dumping
login_event_trigger_func? I'm guessing there's a race condition in the
test but I don't know. I also don't see the tmp_test_jI6t output file
being preserved in the artifacts anywhere :(
https://cirrus-ci.com/task/6391161871400960?logs=test_w
So, sorry I've been a bit under the weather but can concentrate on the
commitfest now. I tried to recapitulate the history but the activity
log only goes back a certain distance on the web. If I can log in to
the database I guess I could construct the history from sql queries if
it was important.
x27;s actually the kind of code cleanup changes I'm reluctant to bump a
patch for. It's not like a committer can't make these kinds of changes
when committing. But there are so many patches they're likely to just
focus on a different patch when there are adjustments like this
pending.
--
Gregory Stark
As Commitfest Manager
Should we move it to next release at this
point? Even if you get time to work on it this commitfest do you think
it's likely to be committable in the next few weeks?
--
Gregory Stark
As Commitfest Manager
nk
it is then shout otherwise I'll mark it Returned with Feedback and
move it on to the next release.
--
Gregory Stark
As Commitfest Manager
would be good to get this in. Is someone else interested in finishing
this if Jeite isn't available?
--
Gregory Stark
As Commitfest Manager
ied as a
> bug fix, I have moved this patch to next CF, waiting on author for the
> moment.
Kyotoro Horiguchi, any chance you'll be able to work on this for this
commitfest? If so shout (or anyone else is planning to push it over
the line Andres?) otherwise I'll move it on to the next release.
--
Gregory Stark
As Commitfest Manager
lso seems like
the feedback has not been really sufficient for Marina Polyakova to
make progress either.
--
Gregory Stark
As Commitfest Manager
Pruning bouncing email address -- please respond from this point in
thread, not previous messages.
--
Gregory Stark
As Commitfest Manager
On Mon, 20 Mar 2023 at 14:34, Gregory Stark (as CFM)
wrote:
>
> Pruning bouncing email address -- please respond from this point in
> thread, not previous messages.
Oh for heaven's sake. Trying again to prune bouncing email address.
Please respond from *here* on the th
ived real feedback and it looks like it's clear
where there's more work needed. I'll move this to the next commitfest.
If you plan to work on it this month we can always move it back.
--
Gregory Stark
As Commitfest Manager
ve a chance to wrap it up this commitfest for this release?
--
Gregory Stark
As Commitfest Manager
chance
of being ready for commit this month?
It looks to me like you have some good feedback and can progress and
are unlikely to finish this patch for this release. In which case
maybe we can move it forward to the next release?
--
Gregory Stark
As Commitfest Manager
tty sure
> that's not the current state.
Are we still waiting on these two items? Egor, do you think you'll
have a chance to work it for this month?
--
Gregory Stark
As Commitfest Manager
x27;ll mark it Rejected then?
--
Gregory Stark
As Commitfest Manager
received useful feedback and it wouldn't take
much to push it over the line. But it's been Waiting On Author since
last September.
Martin, any chance of getting these last bits of feedback resolved so
it can be Ready for Commit?
--
Gregory Stark
As Commitfest Manager
then
we can revisit this.
--
Gregory Stark
As Commitfest Manager
and Kyotaro
Horiguchi was addressed.
If there's any specific questions remaining you need feedback on it
would be good to ask explicitly. Otherwise if you think it's ready you
could mark it Ready for Commit.
--
Gregory Stark
As Commitfest Manager
this been addressed? Do you think you'll
get a chance to resolve those issues this month in time for this
release?
--
Gregory Stark
As Commitfest Manager
On Tue, 14 Mar 2023 at 14:54, Gregory Stark (as CFM)
wrote:
>
> CFBot is failing with this test failure... I'm not sure if this just
> represents a timing dependency or a bad test or what?
CFBot is now consistently showing these test failures. I think there
might actually be
s patch isn't the direction to go in. I don't know
if IF NOT EXISTS is better but that design discussion should probably
happen after this commitfest.
I'm sorry but I guess I'll mark this patch Rejected.
--
Gregory Stark
As Commitfest Manager
en changing the
status again to "Move to next CF". (Don't forget the second step;
hopefully we will have streamlined this in the near future!)
--
Gregory Stark
As Commitfest Manager
;m going to mark this Rejected for now. Perhaps a fresh approach
next release cycle starting with a discussion of the specific goals
rather than starting with a patch would be better.
--
Gregory Stark
As Commitfest Manager
ch seems to be perhaps committable?
* pg_stats and range statistics
- Updated patch as of March 24, should be Needs Review I guess?
* TDE key management patches
- Actively under discussion
* Reconcile stats in find_tabstat_entry() and get rid of
PgStat_BackendFunctionEntry
- Actively under discussion
--
Gregory Stark
As Commitfest Manager
asn't received much discussion since August 2022. If I'm wrong say
something but otherwise I'll mark it Returned With Feedback. It can be
resurrected (and moved to the next commitfest) when you're free to
work on it again.
--
Gregory Stark
As Commitfest Manager
FYI I attached this thread to
https://commitfest.postgresql.org/42/3777 which I believe is the same
issue. I mistakenly had this listed as a CF entry with no discussion
for a long time due to that missing link.
--
Gregory Stark
As Commitfest Manager
t into v16;
> it'll have to wait till there's something solid from the committee.
I guess I'll mark this Rejected in the CF then. Who knows when the SQL
committee will look at this...
--
Gregory Stark
As Commitfest Manager
It looks like this remaining work isn't going to happen this CF and
therefore this release. There hasn't been an update since January when
Dean Rasheed posted a review.
Unless there's any updates soon I'll move this on to the next
commitfest or mark it returned with feedback
Ah, another thread with a bouncing email address...
Please respond to to thread from this point to avoid bounces.
--
Gregory Stark
As Commitfest Manager
this release or should
I move it forward again?
--
Gregory Stark
As Commitfest Manager
ail so that the patch can be considered.
Given this feedback I'm going to mark this Returned with Feedback. I
think it'll be clearer to start with a new thread explaining the
intent of the patch as it is now.
--
Gregory Stark
As Commitfest Manager
re are large
hunks failing in the guts of analyzejoins.c as well as minor failures
elsewhere and lots of offsets which need to be reviewed.
I think given the lack of activity it's out of time for this release
at this point. I'm moving it ahead to the next CF.
--
Gregory Stark
As Commitfest Manager
hat both the startup process and single-user mode touch.
Is this still a WIP? Is it targeting this release? There are only a
few days left before the feature freeze. I'm guessing it should just
move to the next CF for the next release?
--
Gregory Stark
As Commitfest Manager
> range_get_typcache's logic and replace the error message?
> Okay. I've corrected the examples a bit.
It sounds like you've addressed Tomas's feedback and still have one
open question.
Fwiw I rebased it, it seemed to merge fine automatically.
I've updated the CF entry to
Given that there's been no updates since September 22 I'm going to
make this patch Returned with Feedback. The patch can be resurrected
when there's more work done -- don't forget to move it to the new CF
when you do that.
--
Gregory Stark
As Commitfest Manager
y
should be either Needs Review or Ready for Commit.
That said, I suspect this patch has missed the boat for this CF.
Hopefully it will get more attention next release.
I'll move it to the next CF but set it to Needs Review even though it
needs a rebase.
--
Gregory Stark
As Commitfest Manager
ctions with Macros ([1]) was committed March 27.
There's only a few days left in this CF. Would you like to leave this
here? Should it be marked Needs Review or Ready for Commit? Or should
we move it to the next CF now?
--
Gregory Stark
As Commitfest Manager
With Feedback?
--
Gregory Stark
As Commitfest Manager
e CF started. It was never set to
Waiting on Author but I think that may be the right state for it.
--
Gregory Stark
As Commitfest Manager
Only a few more days remain before feature freeze. We've now crossed
over 100 patches committed according to the CF app:
Status summary: March 15March 22March 28April 4
Needs review: 152 128 116 96
Waiting on Author: 42 36
Hm. The cfbot has a fairly trivial issue with this with a unused variable:
18:36:17.405] In file included from ../../src/include/access/nbtree.h:1184,
[18:36:17.405] from verify_nbtree.c:27:
[18:36:17.405] verify_nbtree.c: In function ‘palloc_btree_page’:
[18:36:17.405] ../../src/include/access/nb
05:11.398] # at t/030_sequences.pl line 175.
[19:05:11.398] # got: '1|0|f'
[19:05:11.398] # expected: '231|0|t'
[19:05:11.398]
[19:05:11.398] # Failed test 'advance sequence in a subtransaction'
[19:05:11.398] # at t/030_sequences.pl line 198.
[19:05:11.398] # got: &#
pursuing it since 2022 so I
guess it's not going to happen.
I don't want to keep moving patches forward release to release that
nobody's interested in committing. So I'm going to mark this one
rejected for now. We can always update that if it comes up again.
--
Gregory Stark
As Commitfest Manager
category, are challenging for me to
determine. If I move forward a patch of yours that you think makes
sense to treat as an open issue that should be resolved in this
release then feel free to say.
--
Gregory Stark
As Commitfest Manager
commitfest. Hopefully a starting over
from a different approach might target i/o that is more amenable to
fadvise. I'll mark it RwF.
--
Gregory Stark
As Commitfest Manager
eing pushed. Maybe we should just
close the CF entry? Is this further change relevant?
--
Gregory Stark
As Commitfest Manager
75 matches
Mail list logo
