On 2021/04/05 21:03, torikoshia wrote:
On 2021-04-05 12:59, Fujii Masao wrote:
On 2021/04/05 12:20, Zhihong Yu wrote:
Thanks for reviewing!
+ * On receipt of this signal, a backend sets the flag in the signal
+ * handler, and then which causes the next CHECK_FOR_INTERRUPTS()
I think
On 2021/04/05 16:30, Maxim Orlov wrote:
Well done! In my view is just what it's needed.
Thanks for the review! I pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
table
+which is the root of the partitioning hierarchy, this approach should
+allow access to all the data without creating extra objects.
Now "this approach" in the above is not clear? What about replacing it with
something like "importing only partitioned tables"?
Reg
and
added the following note into the docs.
Note that changing wal_level to
minimal makes any base backups taken before
unavailable for archive recovery and standby server, which may
lead to database loss.
Attached is the updated version of the patch.
Regards,
--
Fujii Masao
Advanc
On 2021/04/06 10:57, torikoshia wrote:
I don't have any objections to your improvements.
Thanks for the check! I pushed the patch. Thanks a lot!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/04/06 13:57, vignesh C wrote:
Hi,
While reviewing replication statistics I found a small typo. Attached
patch for a typo in:
src/backend/postmaster/pgstat.c
Thanks for the report and patch! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and
nking to push the latest version at first.
Then we can improve the docs if required.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/04/06 16:05, Amit Langote wrote:
On Tue, Apr 6, 2021 at 8:34 AM Fujii Masao wrote:
For now I have no objection to this feature.
-IMPORT FOREIGN SCHEMA import_source EXCEPT (t1, "x 4", nonesuch)
+IMPORT FOREIGN SCHEMA import_source EXCEPT (t1, "x 4", nonesuch
On 2021/04/06 20:44, David Steele wrote:
On 4/6/21 7:13 AM, Fujii Masao wrote:
On 2021/04/06 15:59, osumi.takami...@fujitsu.com wrote:
I just wanted to write why the error was introduced,
but it was not necessary.
We should remove and fix the first part of the sentence.
So the consensus
On 2021/04/06 22:02, Michael Paquier wrote:
On Tue, Apr 06, 2021 at 02:39:54PM +0200, Matthias van de Meent wrote:
On Tue, 6 Apr 2021 at 14:29, Fujii Masao wrote:
Attached is the updated version of the patch. Barring any objection,
I'm thinking to commit this.
Sorry for the late
On 2021/04/06 23:01, Fujii Masao wrote:
On 2021/04/06 20:44, David Steele wrote:
On 4/6/21 7:13 AM, Fujii Masao wrote:
On 2021/04/06 15:59, osumi.takami...@fujitsu.com wrote:
I just wanted to write why the error was introduced,
but it was not necessary.
We should remove and fix the first
On 2021/04/07 3:03, Fujii Masao wrote:
On 2021/04/06 23:01, Fujii Masao wrote:
On 2021/04/06 20:44, David Steele wrote:
On 4/6/21 7:13 AM, Fujii Masao wrote:
On 2021/04/06 15:59, osumi.takami...@fujitsu.com wrote:
I just wanted to write why the error was introduced,
but it was not
On 2021/04/07 5:01, Tom Lane wrote:
Fujii Masao writes:
Thanks! So I pushed the patch.
Seems like the test case added by this commit is not
working on Windows.
Thanks for the report! My analysis is [1], and I pushed the proposed patch.
[1]
https://postgr.es/m/3cc3909d-f779-7a74-c201
ry in relids_extra to either of them, not the combination of
them. So we can define them as enum?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/04/08 10:56, Kohei KaiGai wrote:
2021年4月8日(木) 4:19 Fujii Masao :
On 2021/04/06 21:06, Kazutaka Onishi wrote:
Thank you for checking v13, and here is v14 patch.
1) Are we using all of these macros? I see that we are setting them
but we only use TRUNCATE_REL_CONTEXT_ONLY. If not
specified in TRUNCATE
command, i.e., local parent table (1). For now this also looks good to me.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/04/08 15:48, Kohei KaiGai wrote:
2021年4月8日(木) 15:04 Fujii Masao :
On 2021/04/08 13:43, Kohei KaiGai wrote:
In case when a local table (with no children) has same contents,
TRUNCATE command
witll remove the entire table contents.
But if there are local child tables that inherit the
On 2021/04/08 18:25, Fujii Masao wrote:
Anyway, attached is the updated version of the patch. This is still based on
the latest Kazutaka-san's patch. That is, extra list for ONLY is still passed
to FDW. What about committing this version at first? Then we can continue the
discussio
is truncated in remote server side,
and the tables inheriting that are not truncated. Is this behavior desirable?
Seems Michael and I think this behavior is OK. But Kaigai-san does not.
4. Tab-completion for TRUNCATE should be updated so that also foreign tables
are displayed.
Regards,
--
Fuj
On 2021/04/09 11:05, Zhihong Yu wrote:
On Thu, Apr 8, 2021 at 6:47 PM Bharath Rupireddy mailto:bharath.rupireddyforpostg...@gmail.com>> wrote:
On Thu, Apr 8, 2021 at 6:44 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote:
> The followings are the open items
On 2021/04/09 12:33, Kohei KaiGai wrote:
2021年4月8日(木) 22:14 Fujii Masao :
On 2021/04/08 22:02, Kohei KaiGai wrote:
Anyway, attached is the updated version of the patch. This is still based on
the latest Kazutaka-san's patch. That is, extra list for ONLY is still passed
to FDW. What
))
continue;
Well yes, the patch looks pretty much reasonable to be.
LGTM, too. I will commit this patch.
Though that code exists even in older version, I'm not thinking
to back-patch that because it's not a bug.
Regards,
--
Fujii Masao
Advanced Computing Technol
On 2021/04/10 11:32, Bharath Rupireddy wrote:
On Fri, Apr 9, 2021 at 9:23 PM Fujii Masao wrote:
On 2021/04/10 0:39, Amul Sul wrote:
On Fri, Apr 9, 2021 at 8:51 PM Bharath Rupireddy
wrote:
Hi,
While checking the ExecuteTruncate code for the FOREIGN TRUNCATE
feature, I saw that we filter
. Or we should make the extra info boolean value
instead of int, i.e., it indicates whether ONLY was specified or not.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/04/09 23:10, Bharath Rupireddy wrote:
On Fri, Apr 9, 2021 at 7:06 PM Fujii Masao wrote:
> 4. Tab-completion for TRUNCATE should be updated so that also foreign
tables are displayed.
It will be good to have.
Patch attached.
Tab completion patch LGTM and it works
rflow? If yes, it's should be
replaced with uint64.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
CASCADE option was specified in the original
TRUNCATE command.
Why did you remove the description for DROP_RESTRICT?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/04/13 13:23, Peter Smith wrote:
PSA a patch to fix a typo found on this page [1],
"preapre_end_lsn" -> "prepare_end_lsn"
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/04/13 12:46, Justin Pryzby wrote:
On Tue, Apr 13, 2021 at 12:38:35PM +0900, Fujii Masao wrote:
+ Relation data structures for each
+ foreign tables to be truncated.
"foreign tables" should be "foreign table" because it follows "e
opers.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
a foreign table is an abstraction of an external
data source, ISTM that postgres_fdw should always issue TRUNCATE with
CASCADE. Why do we need to allow RESTRICT to be specified for a foreign table
even though it's an abstraction of an external data source?
Regards,
--
Fujii Masao
Advanced Comp
On 2020/07/27 17:53, Hamid Akhtar wrote:
Applying the patch to the current master branch throws 9 hunks. AFAICT, the
patch is good otherwise.
So you think that the patch can be marked as Ready for Committer?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and
On 2020/07/20 21:21, David Steele wrote:
On 7/20/20 6:02 AM, Fujii Masao wrote:
On 2020/07/20 13:48, Fujii Masao wrote:
On 2020/07/17 20:24, David Steele wrote:
On 7/17/20 5:11 AM, Fujii Masao wrote:
On 2020/07/14 20:30, David Steele wrote:
On 7/14/20 12:00 AM, Fujii Masao wrote
s, we're here to help.
I tried to reattach the thread there. I'll prepare a new patch soon, what
should I do? Just attach it again?
New patch has not been sent yet.
So I marked this as "Waiting on Author" at Commit Fest.
Regards,
--
Fujii Masao
Advanced Computing Techno
On 2020/07/28 20:35, Hamid Akhtar wrote:
There have been no real objections on this patch and it seems to work.
Thanks! So I pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
acked under
SAVEPOINT, RELEASE, DECLARE CURSOR and (I guess) FETCH respectively. But it would also
catch DDL.
Does this sound like something for which a patch would be accepted?
Or, we should extend the existing query normalization to handle also DDL?
Regards,
--
Fujii Masao
Advanced Computing Te
cleanly and works as expected.
Thanks for the review and test!
Since this patch was marked as Ready for Committer, I pushed it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
C_STANDBY; /* connection disallowed on non-hot
standby */
Even if hot_standby is enabled, pmState seems to indicate PM_RECOVERY
until recovery has reached a consistent state. No? So, if my understanding
is right, "FATAL: the database system is up, but hot_standby is off" can
be logged
er to add the comment explaining why toast tables are
excluded from the tab completion for vacuum while they are vacuumable?
The patch looks good to me except that.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Anyway the patch seems not to be applied cleanly, so at least it needs to
be updated to address that.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/07/30 10:46, Michael Paquier wrote:
On Thu, Jul 30, 2020 at 08:44:26AM +0900, Fujii Masao wrote:
Isn't it better to add the comment explaining why toast tables are
excluded from the tab completion for vacuum while they are vacuumable?
Sounds sensible, still it does not apply
hen it's disabled
and the server is restarted, those two entries should be merged into one
at the startup of server? If so, that's problematic because it may take
a long time.
Therefore I think that it's better and simple to just expose the number of
times generic/custom plan wa
On 2020/07/31 21:40, Hamid Akhtar wrote:
<https://commitfest.postgresql.org/29/2634/>
On Mon, Jul 6, 2020 at 10:29 AM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote:
On 2020/07/04 12:22, Pavel Stehule wrote:
>
>
> pá 3. 7. 2020 v 13:02 o
ot; must not be NULL per the specification of
PutMemoryContextStatsTupleStore(), assertion test checking
"context != NULL" should be used here, instead?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/08/17 21:14, Fujii Masao wrote:
On 2020/08/11 15:24, torikoshia wrote:
On 2020-08-08 10:44, Michael Paquier wrote:
On Fri, Jul 31, 2020 at 03:23:52PM -0400, Robert Haas wrote:
On Fri, Jul 31, 2020 at 4:25 AM torikoshia wrote:
And as Fujii-san told me in person, exposing memory
On 2020/08/17 18:34, Hamid Akhtar wrote:
On Mon, Aug 17, 2020 at 2:21 PM Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote:
On 2020/07/31 21:40, Hamid Akhtar wrote:
> <https://commitfest.postgresql.org/29/2634/>
>
> On Mon, Jul 6, 2020 at
or custom plan is better for each query?
I was just thinking that this feature was useful to detect the case where
the query was executed with unpected plan mode. That is, we can detect
the unexpected case where the query that should be executed with generic
plan is actually executed with custom
On 2020/08/18 18:41, torikoshia wrote:
On 2020-08-17 21:19, Fujii Masao wrote:
On 2020/08/17 21:14, Fujii Masao wrote:
On 2020-08-07 16:38, Kasahara Tatsuhito wrote:
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements
confusing thing... Anyway, thanks for your comment!
To avoid further confusion, I attached the rebased version of
the patch that was registered at CF. I'd appreciate it if
you review this version.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarter
On 2020/08/01 5:18, James Coleman wrote:
On Wed, Jul 29, 2020 at 11:24 AM Fujii Masao
wrote:
On 2020/04/03 22:49, James Coleman wrote:
On Thu, Apr 2, 2020 at 5:53 PM David Zhang wrote:
The following review has been posted through the commitfest application:
make installcheck-world
On 2020/08/19 9:43, torikoshia wrote:
On 2020-08-18 22:54, Fujii Masao wrote:
On 2020/08/18 18:41, torikoshia wrote:
On 2020-08-17 21:19, Fujii Masao wrote:
On 2020/08/17 21:14, Fujii Masao wrote:
On 2020-08-07 16:38, Kasahara Tatsuhito wrote:
The following review has been posted through
On 2020/08/19 17:40, torikoshia wrote:
On 2020-08-19 15:48, Fujii Masao wrote:
On 2020/08/19 9:43, torikoshia wrote:
On 2020-08-18 22:54, Fujii Masao wrote:
On 2020/08/18 18:41, torikoshia wrote:
On 2020-08-17 21:19, Fujii Masao wrote:
On 2020/08/17 21:14, Fujii Masao wrote:
On 2020-08
lsenders? ISTM that the latter looks overkill...
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
QUERY PLAN
-----
Seq Scan on t (cost=0.00..32.60 rows=2260 width=8)
Planning Time: 0.064 ms
(2 rows)
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/src/backend
his is still somehow a security hazard, I think
we should revert it. If it stays, I'd like to see restrictions
on who can read the view.
For example, allowing only the role with pg_monitor to see this view?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Developm
g a procsignal that triggers (probably at CFR() time) a backend to
write its own memory usage into pg_memusage/ or something roughly
like that.
Sounds good. Maybe we can also provide the SQL-callable function
or view to read pg_memusage/, to make the analysis easier.
Regards,
--
Fujii Masao
Adva
On 2020/08/20 13:00, David Rowley wrote:
On Thu, 20 Aug 2020 at 03:31, Fujii Masao wrote:
With the patch, for example, whatever "summary" settng is, "buffers on"
displays the planner's buffer usage if it happens.
I forgot to mention earlier, you'll also need
"Shared Read Blocks": 12, +
"Shared Dirtied Blocks": 0, +
"Shared Written Blocks": 0, +
"Local Hit Blocks": 0, +
"Local Read Blocks": 0, +
"Local Dirtied Blocks": 0, +
"Local W
ield for that number.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/08/20 20:01, Fujii Masao wrote:
On 2020/08/19 14:10, Masahiro Ikeda wrote:
On 2020-08-19 13:49, tsunakawa.ta...@fujitsu.com wrote:
From: Masahiro Ikeda
If my understanding is correct, we have to measure the performance
impact first.
Do you know HariBabu is now trying to solve it
On 2020/07/27 15:59, Masahiko Sawada wrote:
On Thu, 23 Jul 2020 at 22:51, Muhammad Usama wrote:
On Wed, Jul 22, 2020 at 12:42 PM Masahiko Sawada
wrote:
On Sat, 18 Jul 2020 at 01:55, Fujii Masao wrote:
On 2020/07/16 14:47, Masahiko Sawada wrote:
On Tue, 14 Jul 2020 at 11:19
On 2020/08/20 22:34, Julien Rouhaud wrote:
On Thu, Aug 20, 2020 at 12:29 PM David Rowley wrote:
On Thu, 20 Aug 2020 at 19:58, Fujii Masao wrote:
On 2020/08/20 13:00, David Rowley wrote:
I forgot to mention earlier, you'll also need to remove the part in
the docs that mentions BU
ncated. It currently includes the effects of replication slots,
* for historical reasons. But that could likely be changed.
*/
TransactionId oldest_considered_running;
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/08/21 12:08, tsunakawa.ta...@fujitsu.com wrote:
From: Fujii Masao
Just idea; it may be worth exposing the number of when new WAL file is
created and zero-filled. This initialization may have impact on
the performance of write-heavy workload generating lots of WAL. If this
number is
On 2020/08/21 12:29, Masahiko Sawada wrote:
On Fri, 21 Aug 2020 at 11:18, Fujii Masao wrote:
On 2020/08/21 10:58, Masahiko Sawada wrote:
Hi,
I've attached the patch for $subject.
s/replications lots/replication slots/
Thanks for the patch!
Also it's better to s/replicat
On 2020/08/21 14:54, Pierre Giraud wrote:
Le 20/08/2020 à 17:41, Fujii Masao a écrit :
On 2020/08/20 22:34, Julien Rouhaud wrote:
On Thu, Aug 20, 2020 at 12:29 PM David Rowley
wrote:
On Thu, 20 Aug 2020 at 19:58, Fujii Masao
wrote:
On 2020/08/20 13:00, David Rowley wrote:
I forgot
On 2020/08/21 23:53, Tom Lane wrote:
Fujii Masao writes:
Pushed. Thanks!
Buildfarm shows this patch has got problems under
-DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-08-21%2011%3A54%3A12
Thanks for
On 2020/08/22 1:04, Fujii Masao wrote:
On 2020/08/21 23:53, Tom Lane wrote:
Fujii Masao writes:
Pushed. Thanks!
Buildfarm shows this patch has got problems under
-DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&am
at displaying also used_bytes was useful,
but this might be inconsistent with the other views' ways.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/08/24 13:13, Fujii Masao wrote:
On 2020/08/24 13:01, torikoshia wrote:
On 2020-08-22 21:18, Michael Paquier wrote:
Thanks for reviewing!
On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote:
OK. Added a regression test on sysviews.sql.
(0001-Added-a-regression-test-for
On 2020/08/24 17:09, Michael Paquier wrote:
On Mon, Aug 24, 2020 at 02:48:50PM +0900, Fujii Masao wrote:
As far as I know, utils/adt is the directory to basically include the files
for a particular type or operator. So ISTM that mcxtfuncs.c doesn't
fit to this directory. Isn't it
On 2020/08/24 21:56, torikoshia wrote:
On 2020-08-24 13:13, Fujii Masao wrote:
On 2020/08/24 13:01, torikoshia wrote:
On 2020-08-22 21:18, Michael Paquier wrote:
Thanks for reviewing!
On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote:
OK. Added a regression test on sysviews.sql
t reason,
but ISTM that also some were kept just accidentally.
For example, regarding unused parameter "encoding" that 0010 patch
tries to remove, commit f0d6f20278 got rid of the use of "encoding"
from generate_normalized_query() but ISTM that it just forgot to
remove that paramete
On 2020/08/25 11:39, Fujii Masao wrote:
On 2020/08/24 21:56, torikoshia wrote:
On 2020-08-24 13:13, Fujii Masao wrote:
On 2020/08/24 13:01, torikoshia wrote:
On 2020-08-22 21:18, Michael Paquier wrote:
Thanks for reviewing!
On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote
the lock, to avoid the race condition described
+* in SyncRepUpdateSyncStandbysDefined().
Attached is the updated version of the patch. I didn't change how to
fix the issue. But I changed the check for fast exit so that it's called
before setting the "mode", to avoid
On 2020/08/27 15:59, Asim Praveen wrote:
On 26-Aug-2020, at 11:10 PM, Fujii Masao wrote:
I added the following comments based on the suggestion by Sawada-san upthread.
Thought?
+* Since this routine gets called every commit time, it's important to
+* exit quickly if
user complaint, I'm inclined to back-patch
this all the way.
As noted in the other thread, there may be some other changes needed
to support long passwords, but this is clearly required.
Yes, some client tools have 100 bytes length restriction for the password.
Regards,
--
Fujii Masao
Adva
On 2020/09/01 10:00, Fujii Masao wrote:
On 2020/09/01 6:24, Tom Lane wrote:
Per the discussion at [1], we're now aware of actual use-cases for
password strings approaching a kilobyte in length. I think this puts
the final nail in the coffin of the idea that passwordFromFile() can
_stat_walwrites
is a collected statistics view, basically its contents should be
kept even in the case of server restart.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/08/28 21:20, Masahiko Sawada wrote:
On Fri, 28 Aug 2020 at 10:33, Fujii Masao wrote:
On 2020/08/27 15:59, Asim Praveen wrote:
On 26-Aug-2020, at 11:10 PM, Fujii Masao wrote:
I added the following comments based on the suggestion by Sawada-san upthread.
Thought
and put all the
You seem to accidentally have removed the empty line here.
-errhint("Target must be \"archiver\" or
\"bgwriter\".")));
+errhint("Target must be \"archiver\" or \"bgwriter\" or
\&qu
On 2020/09/04 11:50, tsunakawa.ta...@fujitsu.com wrote:
From: Fujii Masao
I changed the view name from pg_stat_walwrites to pg_stat_walwriter.
I think it is better to match naming scheme with other views like
pg_stat_bgwriter,
which is for bgwriter statistics but it has the statistics
area, and archive_mode is on.
For some reason, patch failed to apply on current master, even though I don't
see any difference in the code.
I'll attach this thread to the next commitfest, so it doesn't get lost.
Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology
On 2020/09/07 9:58, Masahiro Ikeda wrote:
Thanks for the review and advice!
On 2020-09-03 16:05, Fujii Masao wrote:
On 2020/09/02 18:56, Masahiro Ikeda wrote:
+/* --
+ * Backend types
+ * --
You seem to forget to add "*/" into the above comment.
This issue could
On 2020/08/21 15:25, Masahiko Sawada wrote:
On Fri, 21 Aug 2020 at 00:36, Fujii Masao wrote:
On 2020/07/27 15:59, Masahiko Sawada wrote:
On Thu, 23 Jul 2020 at 22:51, Muhammad Usama wrote:
On Wed, Jul 22, 2020 at 12:42 PM Masahiko Sawada
wrote:
On Sat, 18 Jul 2020 at 01:55
On 2020/09/07 17:59, Fujii Masao wrote:
On 2020/08/21 15:25, Masahiko Sawada wrote:
On Fri, 21 Aug 2020 at 00:36, Fujii Masao wrote:
On 2020/07/27 15:59, Masahiko Sawada wrote:
On Thu, 23 Jul 2020 at 22:51, Muhammad Usama wrote:
On Wed, Jul 22, 2020 at 12:42 PM Masahiko Sawada
On 2020/09/08 10:34, Amit Kapila wrote:
On Mon, Sep 7, 2020 at 2:29 PM Fujii Masao wrote:
IMO it's not easy to commit this 2PC patch at once because it's still large
and complicated. So I'm thinking it's better to separate the feature into
several parts and commit them
ou have any thoughts
about pros and cons between your patch and Sawada-san's?
Regards,
[1]
https://www.postgresql.org/message-id/ca+fd4k4z6_b1etevqamwqhu4rx7xsrn5orl7ohj4b5b6sw-...@mail.gmail.com
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/09/08 19:36, Alexey Kondratov wrote:
On 2020-09-08 05:49, Fujii Masao wrote:
On 2020/09/05 3:31, Alexey Kondratov wrote:
Attached is a patch, which implements a plain 2PC in the postgres_fdw and adds
a GUC 'postgres_fdw.use_twophase'. Also it solves these errors handl
3. If the file is not corrupted and the target is NOT found, the timestamp of
global entry is returned.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/09/09 12:04, Amit Kapila wrote:
On Tue, Sep 8, 2020 at 7:03 PM Magnus Hagander wrote:
On Tue, Sep 8, 2020 at 3:11 PM Fujii Masao wrote:
On 2020/09/08 19:28, Magnus Hagander wrote:
On Tue, Sep 8, 2020 at 8:10 AM Amit Kapila mailto:amit.kapil...@gmail.com>> wrote:
to use the name that each
contributor prefers, for example the name that used in the email signature, etc.
BTW, if possible I'd like to use family-name-first, i.e., "Fujii Masao".
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
onsistent in handling the corrupt file case.
>
FWIW I do agree with this - we should return false here, to make it
return false like in the other data corruption cases. AFAICS that's the
only inconsistency here.
+1, I think that's the place to fix, rather than reversing all the other places.
+1 as I suggested upthread!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2020/09/02 0:14, Tom Lane wrote:
Fujii Masao writes:
The patch looks good to me, except the following minor thing.
+ if (fgets(buf.data + buf.len, buf.maxlen - buf.len - 1, fp) ==
NULL)
IIUC fgets() reads the data with the specified size - 1, so ISTM that -1 of
"buf.m
On 2020/09/09 21:15, Peter Eisentraut wrote:
On 2020-09-09 07:40, Fujii Masao wrote:
Attached is a patch to standardize Japanese names as given-name-first
in the v13 contributors list as before.
Using given-name-first order is our consensus? I was thinking we have not
reached that yet and
On 2020/09/10 1:48, Tom Lane wrote:
Fujii Masao writes:
The patch was back-patched to v13, but v13 release note still has the following
item.
Tighten libpq's overlength-line handling and comment detection for
.pgpass files (Fujii Masao)
This should be changed to the foll
On 2020/09/09 2:00, Alexey Kondratov wrote:
On 2020-09-08 14:48, Fujii Masao wrote:
On 2020/09/08 19:36, Alexey Kondratov wrote:
On 2020-09-08 05:49, Fujii Masao wrote:
On 2020/09/05 3:31, Alexey Kondratov wrote:
Attached is a patch, which implements a plain 2PC in the postgres_fdw and
On 2020/09/08 12:03, Amit Kapila wrote:
On Tue, Sep 8, 2020 at 8:05 AM Fujii Masao wrote:
On 2020/09/08 10:34, Amit Kapila wrote:
On Mon, Sep 7, 2020 at 2:29 PM Fujii Masao wrote:
IMO it's not easy to commit this 2PC patch at once because it's still large
and complicat
On 2020/09/10 2:16, Tom Lane wrote:
Fujii Masao writes:
On 2020/09/10 1:48, Tom Lane wrote:
We could adjust the release-note entry for your patch to say
"Improve comment detection for .pgpass files", or we could decide
it's not worth documenting that part and just
gement outside. This idea was
discussed before as the title "eXtensible Transaction Manager API".
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
401 - 500 of 1911 matches
Mail list logo
