Il lun 21 feb 2022, 20:12 Tom Lane ha scritto:
> I wrote:
> > Florin Irion writes:
> >> For what it's worth, I agree with throwing an ERROR if the placeholder
> is
> >> unrecognized. Initially, I didn't want to change too much the liberty of
> >&
Hi,
Il giorno gio 21 ott 2021 alle ore 08:02 Michael Paquier <
mich...@paquier.xyz> ha scritto:
>
> On Thu, Sep 30, 2021 at 11:54:04PM +0200, Florin Irion wrote:
> > We could also help users get a warning if they set a parameter with the
> > `SET`
> > command. I&
he changes and thank you for committing it!
Cheers,
Florin
--
*Florin Irion*
*www.enterprisedb.com <http://www.enterprisedb.com>*
Cel: +39 328 5904901
Tel: +39 0574 054953
Via Alvise Cadamosto, 47
59100, Prato, PO
Italia
that this should go on and disallow
bogus placeholders as we do for postgres unrecognized settings.
I tested your delta patch with and without parallel mode, and, naturally,
it behaves correctly.
My 2 cents.
+1
Cheers,
Florin Irion
and eventually, it uses them to check if any parameter is recognized,just
as we
do at startup.
Please, let me know what you think.
Cheers,
Florin Irion
reservePrefixWarnUser.patch
Description: Binary data
Il giorno ven 1 ott 2021 alle ore 00:26 Chapman Flack
ha scritto:
>
> On 09/30/21 17:54, Florin Irion wrote:
>
> > We could also help users get a warning if they set a parameter with the
> > `SET` command.
>
> This is funny. For years I have been so confident I kn
Hi,
I adjusted a bit the code and configured my mail client to
send patch attachments appropiately(hopefully). :)
So here is my second version.
Cheers,
Florin IrionFrom 9a50261faad3a7578dab150f1c05b510285e283c Mon Sep 17 00:00:00 2001
From: Florin Irion
Date: Thu, 7 Oct 2021 09:51:29 +0200
Hello,
The function `pg_create_logical_replication_slot()` is documented to have
a `two_phase` argument(note the underscore), but the function instead
requires `twophase`.
```
\df pg_catalog.pg_create_logical_replication_slot
List of functions
-[ RECORD 1
]---+---
On 20/09/22 03:33, Michael Paquier wrote:
> On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote:
>> This was introduced in commit 19890a06.
>>
>> IMHO we should use the documented argument name `two_phase` and change the
>> function to accept it.
>>
>
Thank you!
Il mar 20 set 2022, 12:29 Michael Paquier ha scritto:
> On Tue, Sep 20, 2022 at 08:41:56AM +0200, Florin Irion wrote:
> > OK, patch only for the docs attached.
>
> Thanks, applied.
> --
> Michael
>
10 matches
Mail list logo
