d of the year
[1] (commit 6645ad6bdd81e7d5a764e0d94ef52fae053a9e13).
[1] https://www.postgresql.org/message-id/3859.1545849...@sss.pgh.pa.us
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
about the
> identity of the tuple being updated / deleted.
>
Ouch. That's a wal2json bug. I saw that you already opened an issue.
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
;t be restarted and (b) it can't be parallelized.
AFAICS your proposal doesn't solve them. It would be nice if it can be
solved in future releases (using rsync or another in-house tool is as
fragile as using pg_basebackup).
--
Euler Taveira Timbi
be referring to ?
>
LogicalIncreaseXminForSlot (it is a few lines above). It has been like
that since logical decoding was introduced. The trivial patch fixes
it.
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimen
does not add new features to released
versions or after the feature freeze.
The only point that I noticed was that you chose "control over" but similar
code uses "control in".
--
Euler Taveira http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
th existing behavior, the default value for
> this parameter is `false`.
>
>
Truncate will fail for tables whose foreign keys refer to it. If such a
feature cannot handle foreign keys, the usefulness will be restricted.
Regards,
--
Euler Taveira http://www.2ndQuadrant
On Mon, 5 Oct 2020 at 08:34, Amit Kapila wrote:
> On Mon, May 11, 2020 at 2:41 AM Euler Taveira
> wrote:
> >
> > Hi,
> >
> > While looking at an old wal2json issue, I stumbled on a scenario that a
> table
> > with a deferred primary key is not updata
ended method or something else I am missing?
>
Signals are initially blocked in bgworker. You have to unblock them
(see BackgroundWorkerUnblockSignals) to allow your extension to
customize its signal handlers. See an example in worker_spi test
module.
--
wondering if it would make sense to expose them for extension
> developers. Please see the attached for the simple idea.
>
Although I didn't need similar code on some extensions, code reuse is
always a good goal.
--
Euler Taveira Timbira -
http://w
d you review a
previous discussion [1] about this?
I did a prototype a few years ago. I didn't look at your patch yet.
I'll do in a few weeks. Please add your patch to the next CF [2].
[1] https://www.postgresql.org/message-id/4FD9698F.2090407%40timbira.com
[2] https://commitfest.postgresq
ike Foo.Bar or "foo:bar" (colon have
to be escaped)?
> The filter_clause is used as the contents of a WHERE clause when querying
> the data to generate the COPY statement produced by pg_dump.
>
You are forgetting about --inserts parameter. Could I use
--include-table-data-w
2018-05-22 6:20 GMT-03:00 Kyotaro HORIGUCHI :
> For the reason, I'd like to propose to refactor
> getObjectDescription:OPCLASS_POLICY as the attached patch. The
> same structure is seen for OPCLASS_AMOP.
>
+1.
--
Euler Taveira
are repeatedly running a script, why don't you let pg_basebackup
use temporary replication slots?
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
potent ("try" because if we have a network problem it won't be
possible to remove the replication slot).
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
=bssao9-olcw...@mail.gmail.com#CAAYBy8YU4pXYKDHeQhsA_=FC93yOBZp5j1h=bssao9-olcw...@mail.gmail.com
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
is new syntax would be useful.
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
I prefer another
option that removes the slot if it exists (say,
--drop-slot-if-exists). In this case, I consider this option as new
development.
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
s could explain cached plans x invisible indexes).
> BTW, like you, I seem to remember somebody writing an extension that
> did added a GUC that did exactly this, and demoing it at a conference.
> Maybe Oleg or Teodor?
>
https://github.com/postgrespro/plant
2018-06-20 4:30 GMT-03:00 Haribabu Kommi :
> Attached is a simple patch with implementation. Comments?
>
Why don't you extend the existing function pg_stat_statements_reset()?
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL:
2018-06-22 12:06 GMT-03:00 Robert Haas :
> On Wed, Jun 20, 2018 at 10:19 AM, Euler Taveira wrote:
>> 2018-06-20 4:30 GMT-03:00 Haribabu Kommi :
>>> Attached is a simple patch with implementation. Comments?
>>>
>> Why don't you extend the existing function pg_
your log files (or even use syslog).
--
Euler Taveira
EDB https://www.enterprisedb.com/
used by
cachectx). I think you could remove 'mem' from this variable. My
suggestions are pubcxt or pubnamescxt. Although, I prefer the former, if
other publication elements are added to this context in the future.
--
Euler Taveira
EDB https://www.enterprisedb.com/
ld it be converted into a
...? (See synchronous_standby_names [1] for an example.)
[1] https://www.postgresql.org/docs/current/runtime-config-replication.html
--
Euler Taveira
EDB https://www.enterprisedb.com/
lvaro's proposal.
[1] https://codesearch.debian.net/search?q=PGOutputData&literal=0
--
Euler Taveira
EDB https://www.enterprisedb.com/
---
> +#include "utils/guc_hooks.h"
>
> I think #include'ing guc.h would be more appropriate.
Fixed.
I also updated the pg_createsubscriber documentation that refers to
max_replication_slots.
Since we don't have an agreement about the name, I still kept
max_replication_origins.
--
Eu
On Wed, Feb 5, 2025, at 1:56 AM, Amit Kapila wrote:
> On Wed, Feb 5, 2025 at 8:17 AM Euler Taveira wrote:
> >
> > Under reflection, an accurate name is max_replication_origin_session_setup.
> > A
> > counter argument is that it is a long name (top-5 length).
> >
time, hence,
it is fine to leak memory, the initial commit cleaned up all variables but a
subsequent commit 4867f8a555c apparently didn't. Although it is just a low
impact improvement, it is better to be strict and shut up SASTs.
--
Euler Taveira
EDB https://www.enterprisedb.com/
t adding a crucial information. You mention
consistency but since it is a different class of objects I don't think this
argument holds much water.
--
Euler Taveira
EDB https://www.enterprisedb.com/
ty. I mean has a special value (like -1) that
means same value as max_replication_slots. Is it worth it? (If not, it should
be mentioned in the commit message.)
--
Euler Taveira
EDB https://www.enterprisedb.com/
From 5f9e43ce48b523e3bca8e1ef8ee9a427c676381c Mon Sep 17 00:00:00 2001
From: Euler Ta
detect what version is installed,
hence, some tools cannot have some logic to probe the module version. In a
managed environment, it is hard to figure out the exact version for
non-CREATE-EXTENSION modules, unless it is explicitly informed by the vendor.
[1] https://github.com/eulerto/wal2json/issues/181
--
Euler Taveira
EDB https://www.enterprisedb.com/
n_messages
debug2:checkpointer, debug1:autovacuum
(1 row)
In the above example, it sets log level DEBUG2 to checkpointer process and
DEBUG1 to autovacuum launcher and autovacuum worker processes. The other
processes keep WARNING (default) as log level.
--
Euler Taveira
EDB https://www.enterp
default, DEBUG5:autovacuum' (not
> specifying all possible cases?)
>
No. Good point. I forgot to mention that ALL as backend type could be added.
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Thu, Dec 19, 2024, at 10:31 AM, Peter Eisentraut wrote:
> On 10.12.24 19:41, Euler Taveira wrote:
> > I'm attaching a patch that adds max_replication_origins. It basically
> > replaces
> > all of the points that refers to max_replication_slots on the subscriber. It
a information and (ii) make
sure it won't break. The commit 04c8634c0c4 that added the recovery timeout
option separated the doubled verbose option; it was not intentional. We can
certainly keep them together.
I checked your patch with perltidy 20220613-1 and it looks good to me.
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Mon, Jan 20, 2025, at 7:49 PM, Tom Lane wrote:
> "Euler Taveira" writes:
> > It is kind of annoying to keep version 20230309 around to run perltidy. Do
> > we
> > have any other alternatives?
>
> As it says in src/tools/pgindent/README:
>
> 2) Inst
cal replication) has any use case (maybe someone
inspects these extra records for analysis) but one suggestion (separate patch)
is to make 'logical' synonymous with the new 'replica' behavior (logical
decoding capability). This opens the door to remove 'logical' in future
releases (accepted as synonym but not documented).
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Thu, Aug 15, 2024, at 5:53 PM, Doruk Yilmaz wrote:
> Hello again,
>
> On Tue, Aug 13, 2024 at 12:48 AM Euler Taveira wrote:
> > I'm curious about your use case. Is it just because the internal function
> > has a
> > different signature or your tool is capa
| AC | Epitaciolândia
1400407 | Normandia | RR | Normandia
1504455 | Medicilândia | PA | Medicilândia
1505437 | Ourilândia do Norte | PA | Ourilândia do Norte
1507953 | Tailândia| PA | Tailândia
1700251 | Abreulândia | TO | Abreulândia
1703008 | Babaçulândia| TO | Babaçulândia
(10 rows)
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Wed, Feb 5, 2025, at 9:49 PM, Masahiko Sawada wrote:
> On Wed, Feb 5, 2025 at 4:39 PM Euler Taveira wrote:
> >
> > On Wed, Feb 5, 2025, at 1:56 AM, Amit Kapila wrote:
> >
> > On Wed, Feb 5, 2025 at 8:17 AM Euler Taveira wrote:
> > >
> &g
RSION 2
#defineWAL2JSON_FORMAT_MIN_VERSION 1
+#if PG_VERSION_NUM >= 18
+PG_MODULE_MAGIC_EXT(
+ .name = "wal2json",
+ .version = WAL2JSON_VERSION
+);
+#else
PG_MODULE_MAGIC;
+#endif
[1] https://www.postgresql.org/docs/current/extend-extensions.html
--
Euler Taveira
EDB https://www.enterprisedb.com/
autoversion.patch.nocfbot
Description: Binary data
is appropriate to expose
implementation details about table synchronization in a end user page. If we
can explain it without saying too much about the implementation details, fine.
--
Euler Taveira
EDB https://www.enterprisedb.com/
e related to
> max_logical_replication_workers.
Good point. Looking at the documentation, the old max_replication_slots
parameter was the first one in that section so I decided to use the same order
for the postgresql.conf.sample.
--
Euler Taveira
EDB https://www.enterpr
_SUPPORTED),
errmsg("user \"%s\" cannot replicate into relation with
row-level security enabled: \"%s\"",
GetUserNameFromId(GetUserId(), true),
RelationGetRelationName(rel;
The comments already point out directions. Feel free to write a proposal for
it.
--
Euler Taveira
EDB https://www.enterprisedb.com/
4 seconds.
Again, that's still unacceptable for such an optional feature. Maybe you should
experiment my suggestion in the previous review. You don't need a real run to
prove that pg_createsubscriber is not removing unintended objects.
[1] http://postgr.es/m/6f266ce2-38d4-433f-afc9-b47c48c17...@app.fastmail.com
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Tue, Mar 25, 2025, at 8:07 AM, Shubham Khanna wrote:
> Apologies for the oversight. I have attached the patches now. Please
> find them included here.
I started looking at this patch. When I started reading the commit message, I
didn't understand why the options that provide names to objects ar
ilcation origin names must be no longer than %d
bytes.",
+ MAX_RONAME_LEN)));
s/Repilcation/Replication/
+#define MAX_RONAME_LEN (512)
It is just a cosmetic suggestion but I usually use parentheses when it is an
expression but don't include it for a single nu
e" as type if it is an identifier; it
could be the case for roname if author decided to be strict.
This additional TOAST table has no or rare use. +1 for removing it. It is one
less file, one less table and one less index; in short, one less source of data
corruption. ;)
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Fri, Apr 11, 2025, at 5:26 PM, Jonathan S. Katz wrote:
> Please join us in wishing Jacob much success and few reverts!
Keep up the good work, Jacob!
--
Euler Taveira
EDB https://www.enterprisedb.com/
number of rows inserted since this table was last vacuumed
Those rows were actually inserted. They are physically in the data files. And
that's what matters for the autovacuum algorithm.
--
Euler Taveira
EDB https://www.enterprisedb.com/
or a new page). Hence, in doubt, it is good resource to figure out if it is
end of road for that release.
[1]
https://www.timeanddate.com/countdown/generic?iso=20260406T12&p0=3926&msg=Feature+freeze&font=cursive&csz=1
[2] https://www.postgresql.org/developer/roadmap/
--
SQL command. The WARNING seems
fragile because it doesn't solve the problem. I also don't want to disallow
duplicate indexes; it can break old routines. If we want to do something about
it, I would say let's add a psql meta command or even a new view to show
duplicate indexes. I do think
ype and if there is a difference between
WARNING and default:WARNING (both is a fallback for non-specified backend type
elements).
--
Euler Taveira
EDB https://www.enterprisedb.com/
sure the GUC description is clear about it. It seems the Replication Progress
Tracking chapter needs an update to specify this information too.
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Wed, Feb 5, 2025, at 3:51 PM, Álvaro Herrera wrote:
> On 2024-Dec-17, Euler Taveira wrote:
>
> > Sometimes you need to inspect some debug messages from autovacuum worker but
> > you cannot apply the same setting for backends (that could rapidly fill the
> > log
>
d as part of this patch. The drawback here is that once we
accept -1, we cannot remove it without breaking compatibility.
My preference was 1 but I'm fine with 2 too. Since it is a major
release, it is natural to introduce features that break things.
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Wed, Mar 5, 2025, at 11:53 PM, Fujii Masao wrote:
> On 2025/03/05 9:33, Euler Taveira wrote:
> >> > +Valid BACKENDTYPE values are
> >> > ARCHIVER,
> >> > +AUTOVACUUM, BACKEND,
> >> > +BGWOR
On Thu, Mar 6, 2025, at 6:55 AM, Amit Kapila wrote:
> On Wed, Mar 5, 2025 at 4:38 PM Peter Eisentraut wrote:
> >
> > On 11.02.25 21:25, Euler Taveira wrote:
> > > Here is another patch that only changes the GUC name to
> > > max_replication_origin_session
/* state related to progressive explains */
+ struct PlanState *pe_curr_node;
+ struct Instrumentation *pe_local_instr;
+ dsa_area *pe_a;
Could you add some comments saying what each of these variables are for?
I didn't experiment but I was wondering if there is a way to avoid the
duplicates that you added to avoid the overhead.
--
Euler Taveira
EDB https://www.enterprisedb.com/
want) but can increase the list of options you need
to inform if you want to clean multiple object types. A single option is not
flexible and breaks backward compatibility but it does exactly what you want
with a few characters. In most scenarios, if you want to have a clean
subscriber, you will remove *all* possible objects, hence, a single option is
your choice.
--
Euler Taveira
EDB https://www.enterprisedb.com/
n the second
> record, because max_active_replication_origins appears before
> max_logical_replication_workers in the order.
Fixed.
> 2) I felt max_replication_slots must be max_active_replication_origins
> here in logical-replication.sgml:
Fixed.
--
Euler Taveira
EDB https://ww
ler quiet */
+ return InvalidXLogRecPtr; /* keep compiler quiet */
}
--
Euler Taveira
EDB https://www.enterprisedb.com/
_replication_origins. I'm also
attaching 0002 if we decide that backward compatibility is not a concern so it
removes it and assign 10 as the default value. I'm adding an additional suffix
so CF bot doesn't grab 0002.
--
Euler Taveira
EDB https://www.enterprisedb.com/
From 0998
k so.
[1]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ad4295728e04f4107f4dcbbee4950e526becb95d
[2]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=01126dc8cf2c6e06babf1bbb4dab41a4a96d704f
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Fri, Apr 4, 2025, at 1:38 PM, Antonin Houska wrote:
> Euler Taveira wrote:
>
> > +
> > +
> > +
> > + The FULL parameter is deprecated in favor of
> > + .
> > +
> > +
> > +
> >
> > The wa
= (Node *) n;
+ }
I'm wondering if there is an easy way to avoid these rules.
PROGRESS_COMMAND_VACUUM,
PROGRESS_COMMAND_ANALYZE,
PROGRESS_COMMAND_CLUSTER,
+ PROGRESS_COMMAND_REPACK,
PROGRESS_COMMAND_CREATE_INDEX,
PROGRESS_COMMAND_BASEBACKUP,
PROGRESS_COMMAND_COPY,
It is just a matter of style but I have the habit to include new stuff at the
end.
+-- Yet another code path: REPACK w/o index.
+REPACK clstr_tst USING INDEX clstr_tst_c;
+-- Verify that inheritance link still works
You forgot to remove the USING INDEX here.
I'm still review the other patches (that is basically the implementation of
CONCURRENTLY) and to avoid a long review, I'm sending the 0001 review. Anyway,
0001 is independent of the other patches and should be applied separately.
[1] https://www.merriam-webster.com/dictionary/repack
--
Euler Taveira
EDB https://www.enterprisedb.com/
it lacks an explicit default assignment.
>
> To ensure consistency and make the behavior clearer, I propose explicitly
> initializing the "origin" parameter as well. A patch for this is also attached
> (0002 patch).
LGTM. It seems an oversight from the original commit 366283961ac0.
--
Euler Taveira
EDB https://www.enterprisedb.com/
uppress this warning.
[1] https://github.com/pgbouncer/pgbouncer/issues/1143
--
Euler Taveira
EDB https://www.enterprisedb.com/
401 - 467 of 467 matches
Mail list logo
