Re: Ignore heap rewrites for materialized views in logical replication

2022-05-30 Thread Euler Taveira
be > committed along with a fix. If we are not able to find any reasonable > way then we can think of skipping it. The new test is attached. -- Euler Taveira EDB https://www.enterprisedb.com/ From fe13dc44f210b5f14b97bf9a29a242c2211ba700 Mon Sep 17 00:00:00 2001 From: Euler Taveira Date

Re: Ignore heap rewrites for materialized views in logical replication

2022-05-31 Thread Euler Taveira
me know what you think? Your modification will hang until the test timeout without the patch. That's why I avoided to use wait_for_caught_up and used a loop for fast exit on success or failure. I'm fine with a simple test case like you proposed. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: tablesync copy ignores publication actions

2022-06-07 Thread Euler Taveira
deserves an example. It is an easy-to-understand concept and a good description is better than ~ 80 new lines. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Error from the foreign RDBMS on a foreign table I have no privilege on

2022-06-07 Thread Euler Taveira
example) -- probably not at that point. It is behaving accordingly. However, that error is exposing an implementation detail (FDW has to access the remote table at that phase). I don't think that changing the current design (permission check after planning) for FDWs to provide a good UX is w

Re: Re-order "disable_on_error" in tab-complete COMPLETE_WITH

2022-07-04 Thread Euler Taveira
What do you or others think? No objection. It is a good thing for future backpatches. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: logical replication restrictions

2022-07-04 Thread Euler Taveira
On Wed, Mar 23, 2022, at 6:19 PM, Euler Taveira wrote: > On Mon, Mar 21, 2022, at 10:09 PM, Euler Taveira wrote: >> On Mon, Mar 21, 2022, at 10:04 PM, Andres Freund wrote: >>> On 2022-03-20 21:40:40 -0300, Euler Taveira wrote: >>> > On Mon, Feb 28, 2022, a

Re: Introduce "log_connection_stages" setting.

2022-07-12 Thread Euler Taveira
new GUC. I would suggest log_connection_messages or log_connection (with the 's' in the end -- since it is too similar to the current GUC name, I'm afraid it is not a good name for it). -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Introduce "log_connection_stages" setting.

2022-07-14 Thread Euler Taveira
only need to mention in the commit message that this commit is introducing an incompatibility. Hence, when it is time to write the release notes, the information about the removal and the new replacement will be added. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: logical replication restrictions

2022-08-01 Thread Euler Taveira
should mention the units "(ms)" I'm not sure. It should be documented in the catalogs. It is an important information for user-visible interface. There are a few places in the documentation that the unit is mentioned. > There are some test cases for CREATE SUBSCRIPTION but the

Re: logical replication restrictions

2022-08-01 Thread Euler Taveira
densome for users. That's a good point. Logical replication is per database and it is slightly different from physical replication that is per cluster. In physical replication, you have no choice but to have a GUC. It is very unlikely that someone wants to delay all logical replicas. Therefore, the

Re: logical replication restrictions

2022-08-08 Thread Euler Taveira
e. As you noticed we cannot impose the delay as soon as the COPY finishes because it will take a long time to finish due to possibly lack of workers. Instead, let's wait for the READY state for all tables then apply the delay. I added an explanation for it. I also modified the test a bit to use the n

Re: logical replication restrictions

2022-08-08 Thread Euler Taveira
catchup phase; tablesync workers are not closed as soon as the COPY finishes (which means possibly running out of workers sooner). After all tablesync workers have reached READY state, the apply delay is activated. The documentation was correct; the code wasn't. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: logical replication restrictions

2022-08-10 Thread Euler Taveira
nit). Under reflection, let's use ms as default unit if the user doesn't specify one. I fixed all the other suggestions too. -- Euler Taveira EDB https://www.enterprisedb.com/ From a28987c8adb70d6932558f5e39f9dd4c55223a30 Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Sat, 6 Nov

Re: Allow logical replication to copy tables in binary format

2022-08-10 Thread Euler Taveira
ior (initial sync in binary mode) for a publisher using 14 or 15 and a subscriber using 16. IMO you should only allow it for publisher on 16 or later. * Docs should say that the binary option also applies to initial table synchronization and possibly emphasize some of the restrictions. *

Re: Allow logical replication to copy tables in binary format

2022-08-11 Thread Euler Taveira
On Thu, Aug 11, 2022, at 8:04 AM, Amit Kapila wrote: > On Thu, Aug 11, 2022 at 7:34 AM Euler Taveira wrote: > > > > The reason to use text format is that it is error prone. There are > > restrictions > > while using the binary format. For example, if your schema has di

Re: Allow logical replication to copy tables in binary format

2022-08-11 Thread Euler Taveira
n if the binary option defaults to false, someone can decide to use it for performance reasons). I did a quick test and the failure while using binary mode is not clear. Since you are modifying this code, you could probably provide additional patch(es) to make it clear that there is an

Re: fix typos

2022-08-12 Thread Euler Taveira
Possibly we could also change the messages to say "ID"? ... or say could not drop replication origin %u, in use by PID %d AFAICS there is no "with ID" but there is "with identifier". I personally prefer to omit these additional words; it seem

Re: row filtering for logical replication

2021-09-01 Thread Euler Taveira
www.fastmail.com [3] https://www.postgresql.org/message-id/CAHut%2BPsgRHymwLhJ9t3By6%2BKNaVDzfjf6Y4Aq%3DJRD-y8t1mEFg%40mail.gmail.com -- Euler Taveira EDB https://www.enterprisedb.com/ From 018cdb79733ddf4f0de1e4eace3a172bd685d53c Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Mon, 18 Jan

Re: row filtering for logical replication

2021-09-01 Thread Euler Taveira
needs a more complex surgery. [1] https://github.com/eulerto/wal2json/issues/205 [2] https://github.com/eulerto/wal2json/issues/132 [3] https://github.com/eulerto/wal2json/issues/42 [4] https://www.postgresql.org/message-id/CAFiTN-uW50w0tWoUBg_VYCdvNeCzT%3Dt%3DJzhmiFd452FrLOwMMQ%40mail.gmail.com -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Column Filtering in Logical Replication

2021-09-07 Thread Euler Taveira
5584c1350f5%40www.fastmail.com -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Remove_temp_files_after_crash and significant recovery/startup time

2021-09-10 Thread Euler Taveira
enefits outweigh the issues as I explained in [1]. Service continuity (for the vast majority of cases) justifies turning it on by default. If your Postgres instance is generating millions of temporary files, it seems your setup needs some tuning. [1] https://www.postgresql.org/message-id/CAH

Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

2021-09-12 Thread Euler Taveira
a single function CheckReplicationSlotPermissions in slot.c? This way, > we can get rid of redundant code. Attaching a patch for it. Good catch! Your patch looks good to me. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: TAP test for recovery_end_command

2021-09-12 Thread Euler Taveira
h every > restart-point. Setup a replica and stop it. It triggers a restartpoint during the shutdown. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

2021-09-12 Thread Euler Taveira
On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote: > nitpick: It looks like there's an extra set of parentheses around > errmsg(). Indeed. Even the requirement for extra parenthesis around auxiliary function calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).

Re: TAP test for recovery_end_command

2021-09-13 Thread Euler Taveira
; +ok(-f "$archive_cleanup_command_file", + 'archive_cleanup_command executed on checkpoint'); Is this test reliable? -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Column Filtering in Logical Replication

2021-09-15 Thread Euler Taveira
UENCES IN SCHEMA schema_name, [, ...] ALTER PUBLICATION name DROP TABLE [ ONLY ] table_name [ * ] ALTER PUBLICATION name DROP ALL TABLES IN SCHEMA schema_name, [, ...] ALTER PUBLICATION name DROP ALL SEQUENCES IN SCHEMA schema_name, [, ...] Opinions? -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Trigger position

2021-09-15 Thread Euler Taveira
agree that letters are more flexible than numbers but some users are number-oriented. I'm afraid an extra mechanism to determine the order to fire triggers will confuse programmers if someone decides to use both. Besides that, we have to expend a few cycles to determine the exact trigger execution order. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: logical replication restrictions

2021-09-22 Thread Euler Taveira
some business reason, you have to delay when data is available. There might be other use cases but these are the ones I regularly heard from customers. BTW, I have a WIP patch for this feature. I didn't have enough time to post it because it lacks documentation and tests. I'm

Re: row filtering for logical replication

2021-09-27 Thread Euler Taveira
g the current approach? I think it is an oversight from my side. It used to work the way you mentioned but I changed it. I'll include this change in the next patch. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: two_phase commit parameter used in subscription for a publication which is on < 15.

2021-09-27 Thread Euler Taveira
could probably send all parameters and the output plugin would be responsible to report an error. I think the author decided to not do it because it is not an user-friendly approach. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: how to distinguish between using the server as a standby or for executing a targeted recovery in PG 11?

2021-09-27 Thread Euler Taveira
tarting Postgres. In this case, you have to use a debugger such as gdb /path/to/postgres -p $(pgrep -f 'postgres: startup recovering') -quiet -batch -ex 'p StandbyMode' -ex 'quit' Unfortunately, there is no simple way such as checking if a .signal file exists. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: row filtering for logical replication

2021-07-13 Thread Euler Taveira
gt; 9. src/backend/replication/pgoutput/pgoutput.c - comment typo? 8< > typo: it/that ? > > I think it ought to say "This is the same code as ExecPrepareExpr() > but that is not used because"... Fixed. > 10. src/backend/replication/pgoutput/pgoutput.c - redundant debug logging? > >

Re: row filtering for logical replication

2021-07-13 Thread Euler Taveira
g "START_REPLICATION > SLOT" in get_rel_sync_entry in this code: That's because I didn't copy the TupleDesc in CacheMemoryContext. Greg pointed it too in a previous email [3]. The new patch (v19) includes a fix for it. [1] https://www.postgresql.org/mess

Re: row filtering for logical replication

2021-07-13 Thread Euler Taveira
olumns without not-null constraints in the WHERE clause. The WHERE clause does not allow functions and user-defined operators. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: row filtering for logical replication

2021-07-13 Thread Euler Taveira
NULL constraint conditions are not treated as errors. This feature uses a WHERE clause and behaves like it. I mean, a NULL result does not return the row. See ExecQual(). -- Euler Taveira EDB https://www.enterprisedb.com/

Re: row filtering for logical replication

2021-07-14 Thread Euler Taveira
th (using an additional publication argument or OLD and NEW placeholders to reference old and new rows are feasible ideas). -- Euler Taveira EDB https://www.enterprisedb.com/

Re: row filtering for logical replication

2021-07-14 Thread Euler Taveira
st. If we want to enforce this condition, I suggest that we add it to CREATE PUBLICATION, ALTER PUBLICATION ... ADD|SET TABLE and ALTER TABLE ... REPLICA IDENTITY. Data are being constantly modified; schema is not. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: row filtering for logical replication

2021-07-14 Thread Euler Taveira
On Wed, Jul 14, 2021, at 8:21 AM, Greg Nancarrow wrote: > Some minor v19 patch review points you might consider for your next > patch version: Greg, thanks for another review. I agree with all of these changes. It will be in the next patch. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: row filtering for logical replication

2021-08-24 Thread Euler Taveira
to extract what you changed. Since we're trading patches, I personally appreciate if you can send a patch on the top of the current one. I have some changes too and it is time consuming incorporating changes in the main patch.] -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-06-06 Thread Euler Taveira
On Wed, May 22, 2024, at 12:16 PM, Euler Taveira wrote: > I'll summarize all issues as soon as I finish the review of sync slot > support. I > think we should avoid new development if we judge that the item can be > documented as a limitation for this version. Neverthel

Re: State of pg_createsubscriber

2024-06-18 Thread Euler Taveira
On Tue, Jun 18, 2024, at 12:59 AM, Amit Kapila wrote: > On Mon, May 20, 2024 at 12:12 PM Amit Kapila wrote: > > > > On Sun, May 19, 2024 at 11:20 PM Euler Taveira wrote: > > > > > > On Sun, May 19, 2024, at 2:30 PM, Tom Lane wrote: > > > > &g

Re: speed up a logical replica setup

2024-06-18 Thread Euler Taveira
On Mon, Jun 17, 2024, at 8:04 AM, Peter Eisentraut wrote: > On 07.06.24 05:49, Euler Taveira wrote: > > Here it is a patch series to fix the issues reported in recent > > discussions. The > > patches 0001 and 0003 aim to fix the buildfarm issues. The patch 0002 > &g

Re: State of pg_createsubscriber

2024-06-19 Thread Euler Taveira
like Kuroda-San or me to start some or all? I will open new threads soon if you don't. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-06-25 Thread Euler Taveira
E PUBLICATION > > started and managed to assign an XID only after consistent_lsn. From the > > pgoutput perspective, that's indistinguishable from the transaction starting > > at its first WAL record, after consistent_lsn. The linked "long-standing > > data > > loss bug in initial sync of logical replication" thread doesn't have (a), > > hence its bug. How close is that to accurate? > > > > Yeah, this theory sounds right to me. The key point is that no DML > (processing of WAL corresponding to DML) before CREATE PUBLICATION ... > command would have reached pgoutput level because we would have waited > for it during snapbuild.c. Can we conclude that the race condition > discussed in the other thread won't impact this patch? As Noah said the key point is the CREATE PUBLICATION *before* creating the replication slots -- that wait transactions to complete. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-06-25 Thread Euler Taveira
wise, prepared transactions are sent to the subscriber only when committed, and are then processed immediately by the subscriber. Hence, the replication should be working for prepared transactions even if it created the slot with twophase = false. IIRC the user won't be able to change it later. As Amit said in a previous email, once the command ALTER SUBSCRIPTION ... SET (two_phase = on) is supported, users can change it after running pg_createsubscriber. The other option is to add a command-line option to enable or disable it. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-07-10 Thread Euler Taveira
> # expected: 'failover_slot' I'm wondering if the attached patch is sufficient to move the restart_lsn forward. I experimented several lightweight ideas but none works. BTW the steps to create the failover slot here is similar 040_standby_failover_slots_sync.pl.

Re: improve performance of pg_dump with many sequences

2024-07-10 Thread Euler Taveira
+ Since you apply a fix for pg_sequence_last_value function, you can simplify the query in 0003. CASE is not required. I repeated the same test but not applying 0003. patched (0001 and 0002): real 0m0,290s user 0m0,038s sys 0m0,104s I'm not sure if 0003 is worth. Maybe if you h

Re: improve performance of pg_dump with many sequences

2024-07-10 Thread Euler Taveira
think we have to keep this workaround since older minor > releases of PostgreSQL don't have the fix. Hmm. Right. > What pg_dump command did you test here? Did you dump the sequence data, or > was this --schema-only? time pg_dump -f - -s -d postgres -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-07-11 Thread Euler Taveira
use it will break this test. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-07-11 Thread Euler Taveira
A4eK1%2Bp%2B7Ag6nqdFRdqowK1EmJ6bG-MtZQ_54dnFBi%3D_OO5RQ%40mail.gmail.com [2] https://www.postgresql.org/message-id/OSBPR01MB25521B15BF950D2523BBE143F5D32%40OSBPR01MB2552.jpnprd01.prod.outlook.com -- Euler Taveira EDB https://www.enterprisedb.com/ From a3be65c9bea08d3c7ffd575342a879d37b28

Re: logicalrep_message_type throws an error

2023-07-15 Thread Euler Taveira
the beginning of the function but *before* the message. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: CDC/ETL system on top of logical replication with pgoutput, custom client

2023-07-31 Thread Euler Taveira
uot;:"foo","columns":[{"name":"a","value":13}]} 0/36A057F0 | 454541 | {"action":"C"} 0/36A050C0 | 454540 | {"action":"B"} 0/36A050C0 | 454540 | {"action":"I","schema":"public","table":"foo","columns":[{"name":"a","value":1}]} 0/36A051A0 | 454540 | {"action":"I","schema":"public","table":"foo","columns":[{"name":"a","value":2}]} 0/36A054D8 | 454540 | {"action":"I","schema":"public","table":"foo","columns":[{"name":"a","value":3}]} 0/36A05820 | 454540 | {"action":"C"} (17 rows) Since session C committed first, it is the first transaction available to output plugin (wal2json). Transaction 454541 is the next one that is available because it committed after session C (transaction 454542) and the first transaction that started (session A) is the last one available. You can also notice that the first transaction (454540) is the last one available. Your consumer cannot rely on LSN position or xid to track the progress. Instead, Postgres provides a replication progress mechanism [1] to do it. [1] https://www.postgresql.org/docs/current/replication-origins.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Pgoutput not capturing the generated columns

2023-08-01 Thread Euler Taveira
bably. If it is an option that defaults to false and doesn't impact performance. The request for features should be done in this mailing list. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Idea Feedback: psql \h misses -> Offers Links?

2024-04-19 Thread Euler Taveira
using SGML files. We already did it for SQL commands. Another broader idea is to build an inverted index similar to what Index [1] provides. The main problem with this approach is to create a dependency between documentation build and psql. Maybe there is a reasonable way to obtain the links for each term. [1] https://www.postgresql.org/docs/current/bookindex.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-04-29 Thread Euler Taveira
On Mon, Apr 29, 2024, at 6:56 AM, Amit Kapila wrote: > On Wed, Mar 27, 2024 at 1:47 AM Euler Taveira wrote: > > > > On Tue, Mar 26, 2024, at 4:12 PM, Tomas Vondra wrote: > > > > Perhaps I'm missing something, but why is NUM_CONN_ATTEMPTS even needed? > >

Re: EXPLAN redundant options

2024-05-02 Thread Euler Taveira
pto; ^ postgres=# create user foo with createdb login createdb; ERROR: conflicting or redundant options LINE 1: create user foo with createdb login createdb; ^ -- Euler Taveira EDB https://www.enterprisedb.com/

Re: State of pg_createsubscriber

2024-05-19 Thread Euler Taveira
ed since 1 April. My bad. :( I'll post patches soon to address all of the points. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: speed up a logical replica setup

2024-05-22 Thread Euler Taveira
we need a escape mechanism for the loop (timeout?). I'll summarize all issues as soon as I finish the review of sync slot support. I think we should avoid new development if we judge that the item can be documented as a limitation for this version. Nevertheless, I will share patches so

Re: speed up a logical replica setup

2024-05-23 Thread Euler Taveira
On Thu, May 23, 2024, at 5:54 AM, Amit Kapila wrote: > On Wed, May 22, 2024 at 8:46 PM Euler Taveira wrote: > > > > Following the same line that simplifies the code, we can: (a) add a loop in > > check_subscriber() that waits until walreceiver is available on subscriber

Re: including pid's for `There are XX other sessions using the database`

2022-08-19 Thread Euler Taveira
hba.conf modification) before executing DROP DATABASE. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: is_superuser is not documented

2022-09-09 Thread Euler Taveira
tgres=# \dfS is_superuser List of functions Schema | Name | Result data type | Argument data types | Type +--+--+-+-- (0 rows) postgres=# SHOW is_superuser; is_superuser -- on (1 row) Do you mind writing a patch

Re: logicalrep_message_type throws an error

2023-07-03 Thread Euler Taveira
g a default message type: ERROR: invalid logical replication message type "X" CONTEXT: processing remote data for replication origin "pg_16638" during message type "???" in transaction 796, finished at 0/16266F8 Masahiko, since abc0910e2e0 is your patch mayb

Re: logicalrep_message_type throws an error

2023-07-03 Thread Euler Taveira
; case > > defeats that purpose. I think we should just return "???" from outside > > switch block. > > Yeah. I don't think any gcc -Wswitch options have effect if a default is used so your suggestion is good for wrong/missing message types in the future. > PFA patch. WFM. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: logicalrep_message_type throws an error

2023-07-05 Thread Euler Taveira
be confusing if we provide two representations of the same data (X and 88). Since we already provide "X" I don't think we need "88". Another option, is to remove "X" from apply_dispatch() and add "??? (88)" to logicalrep_message_type(). Opinions? -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Allow specifying a dbname in pg_basebackup connection string

2023-07-05 Thread Euler Taveira
r connection poolers might also benefit from it. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Proposal to have INCLUDE/EXCLUDE options for altering option values

2024-08-26 Thread Euler Taveira
nvinced that this new syntax improves the user experience. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Adding NOTICE for differences between estimated and actual rows

2024-09-05 Thread Euler Taveira
uot;\033[1m\033[35m$1\033[36m$2\033[32m$3\033[33m$4\033[m" while /([|+-]+)|([0-9]+)|([a-zA-Z_]+)|([^\w])/g; and then you can start psql as: $ PAGER="/c/mypager.pl" psql [1] https://stackoverflow.com/questions/5947742/how-to-change-the-output-color-of-echo-in-linux/28938235#28938235 -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Adding NOTICE for differences between estimated and actual rows

2024-09-05 Thread Euler Taveira
On Thu, Sep 5, 2024, at 5:32 PM, Euler Taveira wrote: > $ cat /tmp/pcc.pl > #!/usr/bin/perl -n > print "\033[1m\033[35m$1\033[36m$2\033[32m$3\033[33m$4\033[m" while > /([|+-]+)|([0-9]+)|([a-zA-Z_]+)|([^\w])/g; > > and then you can start psql as: > > $ P

Re: speed up a logical replica setup

2024-07-29 Thread Euler Taveira
load. fast. I don't have a strong preference but if I need to pick one I would choose option (c) or option (d). The option (a) is out of the question. Opinions? [1] https://www.postgresql.org/message-id/b1f0f8c7-8f01-4950-af77-339df3dc4684%40app.fastmail.com [2] https://www.postgresql.o

Re: speed up a logical replica setup

2024-07-29 Thread Euler Taveira
On Mon, Jul 29, 2024, at 6:11 PM, Euler Taveira wrote: > The options are: > > (a) temporary replication slot: requires an additional replication slot. > small payload. it is extremely slow in comparison with the other > options. > (b) logical message: can be consumed by logica

Re: speed up a logical replica setup

2024-07-30 Thread Euler Taveira
On Tue, Jul 30, 2024, at 7:35 AM, Peter Eisentraut wrote: > On 30.07.24 02:05, Euler Taveira wrote: > > I'm attaching a patch that implements option (c). While reading the code > > I noticed that I left a comment that should be removed by commit > > b9639138262. 00

Re: make pg_createsubscriber option names more consistent

2024-07-31 Thread Euler Taveira
scriber and pg_upgrade have a lot of common terminology and > a similar operating mode, so it would make sense to keep this consistent. WFM. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: rare crash - FailedAssertion snapbuild.c Line: 580

2024-08-01 Thread Euler Taveira
which may be useful for analysis). [1] https://www.postgresql.org/support/versioning/ -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Detailed release notes

2024-08-05 Thread Euler Taveira
commit message points to the discussion so it is a good start point if you want to research about that specific feature. If one commit is not sufficient for that item, we can always add multiple commits as we usually do in the release notes comments. [1] https://www.pgbouncer.org/changelog.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Detailed release notes

2024-08-06 Thread Euler Taveira
ually use for the mailing list. https://postgr.es/c/da4017a694d -- Euler Taveira EDB https://www.enterprisedb.com/

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2024-08-12 Thread Euler Taveira
covered by CI [2][3]. [1] https://commitfest.postgresql.org/49/ [2] https://wiki.postgresql.org/wiki/Cfbot [3] http://cfbot.cputube.org/index.html -- Euler Taveira EDB https://www.enterprisedb.com/

Re: Opinion poll: Sending an automated email to a thread when it gets added to the commitfest

2024-08-14 Thread Euler Taveira
f I understand your proposal correctly, there will be another email to the thread if the previous CF was closed and someone opened a new CF entry. Sometimes some CF entries are about the same thread. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: More tests with USING INDEX replident and dropped indexes

2020-06-03 Thread Euler Taveira
lear the relreplident from the relation while dropping the index? relation_mark_replica_identity() already does that but do other things too. Let's move the first code block from relation_mark_replica_identity to another function and call this new function while dropping the index. -- Euler Taveira

Re: REINDEX CONCURRENTLY and indisreplident

2020-06-03 Thread Euler Taveira
a REPLICA IDENTITY USING INDEX without a dropped index is the same as > NOTHING. > > LGTM. I tested in both versions (12, master) and it works accordingly. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: BUG #16481: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events

2020-06-08 Thread Euler Taveira
> This bug was already reported some time ago (#15293) but it slipped through the cracks. I don't think you should simply call ProcessCompletedNotifies [1]. [1] https://www.postgresql.org/message-id/13844.1532468610%40sss.pgh.pa.us -- Euler Taveira http://www.2ndQuadr

pg_restore error message

2020-05-07 Thread Euler Taveira
Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From f3853512e827952402020b2b0f3003ac8c5c9d96 Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Thu, 7 May 2020 18:17:28 -0300 Subject: [PATCH] pg_restore failure message does

Re: Logical replication subscription owner

2020-05-09 Thread Euler Taveira
0.7, LOGIN are documented accordingly. I'm +0.5 to the idea of adding a WARNING when you create/alter a role that has REPLICATION but not LOGIN. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

deferred primary key and logical replication

2020-05-10 Thread Euler Taveira
x27;t envision a problem with a deferred primary key in an after commit scenario. Am I missing something? Just in case, I'm attaching a patch to fix it and also add a test to cover this scenario. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: Problem with logical replication

2020-05-10 Thread Euler Taveira
n.c. I attached a patch with the described solution. I also included a test that covers this scenario. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 37be6d62bf26a20ec3cba8825082ad92fdd1c6d7 Mon Sep 17 00:0

Re: Problem with logical replication

2020-05-12 Thread Euler Taveira
On Tue, 12 May 2020 at 06:36, Masahiko Sawada < masahiko.saw...@2ndquadrant.com> wrote: > On Mon, 11 May 2020 at 16:28, Michael Paquier wrote: > > > > On Sun, May 10, 2020 at 07:08:03PM -0300, Euler Taveira wrote: > > > I attached a patch with the described so

Re: Problem with logical replication

2020-05-15 Thread Euler Taveira
indentation had some diffs. Tom has just reindented the whole > tree, so let's keep things clean. > > LGTM. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-16 Thread Euler Taveira
here is such a distinction. We have some options: (a) leave it as is and document that those 2 options has no effect in pg_dump and possibly add a warning to report if someone uses it with an archive format; (b) exclude owner and tablespace from archive (it breaks compatibility but do e

Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format

2020-05-16 Thread Euler Taveira
On Sat, 16 May 2020 at 16:31, Tom Lane wrote: > > I think (b) would be a break in the archive format, with unclear > consequences, so I'm not in favor of that. > > I came to the same conclusion while inspecting the source code. -- Euler Taveira http:/

Re: proposal: pg_restore --convert-to-text

2019-02-13 Thread Euler Taveira
x27;t specified? If we go to this road, -f option should allow - (stdout) as parameter. > (Yes, it will break the scripts of anyone who is currently scripting > pg_restore to output SQL text. How many people do that?) > I use pg_restore to stdout a lot but I wouldn't bother to specify an

Re: proposal: pg_restore --convert-to-text

2019-02-18 Thread Euler Taveira
up, I took a stab at it. It will prohibit standard output unless '-f -' be specified. -l option also has the same restriction. It breaks backward compatibility and as Tom suggested a variant of this patch (without docs) should be applied to back branches. -- Euler Taveira

Re: proposal: pg_restore --convert-to-text

2019-02-19 Thread Euler Taveira
Em seg, 18 de fev de 2019 às 19:21, Tom Lane escreveu: > > Euler Taveira writes: > > Since no one has stepped up, I took a stab at it. It will prohibit > > standard output unless '-f -' be specified. -l option also has the > > same restriction. > > Hm, don

Re: list append syntax for postgresql.conf

2019-02-20 Thread Euler Taveira
ppen if you have: shared_preload_libraries = 'foo' then shared_preload_libraries += 'bar' and then shared_preload_libraries = 'pg_stat_statements' You have only 'pg_stat_statements' or 'foo, bar, pg_stat_statements'? Suppose you mistype 'bar&#x

Re: BRIN summarize autovac_report_workitem passes datname as relname

2019-02-20 Thread Euler Taveira
Em qua, 20 de fev de 2019 às 15:56, Justin Pryzby escreveu: > > I guess it should be database.namespace.relname ? > Yup. It is an oversight in 7526e10224f0792201e99631567bbe44492bbde4. -- Euler Taveira Timbira - http://www.timbira.com.br/ P

Re: Set fallback_application_name for a walreceiver to cluster_name

2019-02-20 Thread Euler Taveira
remotely as well. It's still possible to specify another > application_name in primary_conninfo explicitly. > I tested it and both patches work as described. Passes all tests. Doc describes the proposed feature. Doc builds without errors. -- Euler Taveira

Re: psql show URL with help

2019-02-22 Thread Euler Taveira
MHO URL should be printed iif psql version is the same as server version. If we want flexibility, let's add an option to enable URL exhibition (always/same) that defaults to same. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consul

Re: psql show URL with help

2019-02-22 Thread Euler Taveira
shouldn't care but it is. Someone could be confused as I said earlier. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: Temporal Table Proposal

2019-02-22 Thread Euler Taveira
t wasn't in the January CF. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Re: Temporal Table Proposal

2019-02-22 Thread Euler Taveira
Em sex, 22 de fev de 2019 às 18:16, Paul Jungwirth escreveu: > > On 2/22/19 11:31 AM, Euler Taveira wrote: > > Em sex, 22 de fev de 2019 às 15:41, Ibrar Ahmed > > escreveu: > >> > >> While working on another PostgreSQL feature, I was thinking that we

Re: logical replication empty transactions

2020-03-03 Thread Euler Taveira
dea I can add it to the patch. Regards, -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: logical replication empty transactions

2020-03-05 Thread Euler Taveira
On Thu, 5 Mar 2020 at 05:45, Amit Kapila wrote: > Euler, can we try to update the patch based on the number of > transactions threshold and see how it works? > > I will do. -- Euler Taveira http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote D

<    1   2   3   4   5   >