Re: remaining sql/json patches

2023-11-15 Thread Erik Rijkers
Op 11/15/23 om 14:00 schreef Amit Langote: Hi, [..] Attached updated patch. The version of 0001 that I posted on Oct 11 to add the error-safe version of CoerceViaIO contained many unnecessary bits that are now removed. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com > [v24-0001-A

Re: proposal: possibility to read dumped table's name from file

2023-11-21 Thread Erik Rijkers
someone. I've tested this, albeit mostly in the initial iterations (*shrug* but a mention is nice) Erik Rijkers -- Daniel Gustafsson

Re: remaining sql/json patches

2023-12-07 Thread Erik Rijkers
Op 12/7/23 om 10:32 schreef Amit Langote: On Thu, Dec 7, 2023 at 12:26 AM Alvaro Herrera wrote: On 2023-Dec-06, Amit Langote wrote: I think I'm inclined toward adapting the LA-token fix (attached 0005), This one needs to be fixed, so done. On Thu, Dec 7, 2023 at 5:25 PM Peter Eisentraut wro

Re: remaining sql/json patches

2023-08-31 Thread Erik Rijkers
l run fine. Thanks, Erik Rijkers I found out that llvmjit_expr.c additions have been broken all along, I mean since I rewrote the JsonExpr evaluation code to use soft error handling back in January or so. For example, I had made CoerceiViaIO evaluation code (EEOP_IOCOERCE ExprEvalStep)

Re: Row pattern recognition

2023-09-02 Thread Erik Rijkers
-09-02 19:59:05.329 CEST 46723 LOG: terminating any other active server processes Erik Rijkers

Re: JSON Path and GIN Questions

2023-09-12 Thread Erik Rijkers
ot;All use of json*() functions preclude index usage." That sentence is missing from the documentation. Erik Rijkers

Re: JSON Path and GIN Questions

2023-09-13 Thread Erik Rijkers
p 9/13/23 om 22:01 schreef David E. Wheeler: On Sep 13, 2023, at 01:11, Erik Rijkers wrote: "All use of json*() functions preclude index usage." That sentence is missing from the documentation. Where did that come from? Why wouldn’t JSON* functions use indexes? I see that the

Re: JSON Path and GIN Questions

2023-09-15 Thread Erik Rijkers
in the fullness of Knowledge of the manual. Yes, this too would be good to explain in the doc where JSON indexes are explained. Erik Rijkers Thanks, David

Re: remaining sql/json patches

2023-09-16 Thread Erik Rijkers
Op 9/14/23 om 10:14 schreef Amit Langote: Hi Amit, Just now I built a v14-patched server and I found this crash: select json_query(jsonb ' { "arr": [ {"arr": [2,3]} , {"arr": [4,5]} ] }' , '$.arr[*].arr ? (@ <= 3)' returning anyarray WITH WRAPPER) --crash ; server closed the co

Re: remaining sql/json patches

2023-09-18 Thread Erik Rijkers
Op 9/18/23 om 05:15 schreef Amit Langote: On Sun, Sep 17, 2023 at 3:34 PM Erik Rijkers wrote: Op 9/14/23 om 10:14 schreef Amit Langote: Hi Amit, Just now I built a v14-patched server and I found this crash: select json_query(jsonb ' { "arr": [ {"arr":

Re: remaining sql/json patches

2023-09-18 Thread Erik Rijkers
Op 9/18/23 om 12:20 schreef Amit Langote: Hi Erik, I am sorry to be bothering you with these somewhat idiotic SQL statements but I suppose somehow it needs to be made more solid. For 60 datatypes, I ran this statement: select json_query(jsonb'{"a":[{"a":[2,3]},{"a":[4,5]}]}', '$.a[*].a?(@

Re: remaining sql/json patches

2023-09-18 Thread Erik Rijkers
Op 9/18/23 om 13:14 schreef Erik Rijkers: Op 9/18/23 om 12:20 schreef Amit Langote: Hi Erik, I am sorry to be bothering you with these somewhat idiotic SQL statements but I suppose somehow it needs to be made more solid. For 60 datatypes, I ran this statement: select json_query(jsonb

Re: remaining sql/json patches

2023-09-19 Thread Erik Rijkers
Op 9/19/23 om 13:56 schreef Amit Langote: On Tue, Sep 19, 2023 at 7:18 PM Alvaro Herrera wrote: 0001: I wonder why you used Node for the ErrorSaveContext pointer instead of the specific struct you want. I propose the attached, for some extra type-safety. Or did you have a reason to do it that

Re: Row pattern recognition

2023-09-22 Thread Erik Rijkers
; see attached .diff file. In these two statements: -- using NEXT -- using AFTER MATCH SKIP TO NEXT ROW result of first_value(price) and next_value(price) are empty. Erik Rijkers this time the pattern matching engine is enhanced: previously it recursed to row direction, which means if the number of ro

Re: Row pattern recognition

2023-09-22 Thread Erik Rijkers
Op 9/22/23 om 10:23 schreef Erik Rijkers: Op 9/22/23 om 07:16 schreef Tatsuo Ishii: Attached is the fix against v6 patch. I will include this in upcoming v7 patch. Attached is the v7 patch. It includes the fix mentioned above.  Also (Champion's address bounced; removed) Sorry, I forg

Re: Row pattern recognition

2023-09-22 Thread Erik Rijkers
: -- using NEXT -- using AFTER MATCH SKIP TO NEXT ROW result of first_value(price) and next_value(price) are empty. Erik Rijkers this time the pattern matching engine is enhanced: previously it recursed to row direction, which means if the number of rows in a frame is large, it could exceed

Re: Row pattern recognition

2023-09-22 Thread Erik Rijkers
Op 9/22/23 om 12:12 schreef Tatsuo Ishii: Op 9/22/23 om 07:16 schreef Tatsuo Ishii: Attached is the fix against v6 patch. I will include this in upcoming v7 patch. Attached is the v7 patch. It includes the fix mentioned above. Also (Champion's address bounced; removed) On my side his adress

Re: remaining sql/json patches

2023-09-27 Thread Erik Rijkers
Op 9/27/23 om 15:55 schreef Amit Langote: On Thu, Sep 21, 2023 at 9:41 PM Amit Langote wrote: I don't knoe, maybe it's worthwhile to fix this (admittedly trivial) fail in the tests? It's been there for a while. Thanks, Erik diff -U3 /home/aardvark/pg_stuff/pg_sandbox/pgsql.json_table/src

Re: proposal \gcsv

2020-03-26 Thread Erik Rijkers
shell one-liners with psql easier/more compact. Thanks, Erik Rijkers

Re: proposal \gcsv

2020-03-28 Thread Erik Rijkers
On 2020-03-28 15:06, Daniel Verite wrote: Erik Rijkers wrote: 2. let the psql command-line option '--csv' honour the value given by psql -F/--field-separator (it does not do so now) or 3. add an psql -commandline option: --csv-field-separator Setting the field separator on t

Re: Add A Glossary

2020-04-03 Thread Erik Rijkers
' 'A Trigger executes' should be 'A trigger executes' 'and other closely related garbage-collection-like processing' should be 'and other processing' 'each of the changes are replayed' should be 'each of the changes is replayed' Should also be a lemmata in the glossary: ACID 'archaic' should maybe be 'obsolete'. That seems to me to be an easier word for non-native speakers. Thanks, Erik Rijkers

Re: Add A Glossary

2020-04-03 Thread Erik Rijkers
On 2020-04-03 22:51, Alvaro Herrera wrote: On 2020-Apr-03, Erik Rijkers wrote: On 2020-04-03 18:45, Alvaro Herrera wrote: > Pushed now. Many thanks to Corey who put the main thrust, and to Jürgen > and Roger for the great help, and to Justin for the extensive review and > Fabie

Re: support for MERGE

2022-01-28 Thread Erik Rijkers
Op 28-01-2022 om 21:27 schreef Alvaro Herrera: MERGE, v10. I am much more comfortable with this version; I have removed a bunch of temporary hacks and cleaned up the interactions with table AM and executor, which is something that had been bothering me for a while. The complete set of changes c

faulty link

2022-02-10 Thread Erik Rijkers
The provided link https://www.postgresql.org/docs/release/ leads to https://www.postgresql.org/docs/release/14.2/ which gives 'Not Found' for me (Netherlands) At least one person on IRC reports it 'works' for them but it seems there still something wrong.. Erik Rijkers

Re: allowing for control over SET ROLE

2022-11-18 Thread Erik Rijkers
Op 18-11-2022 om 19:43 schreef Robert Haas: On Fri, Nov 18, 2022 at 12:50 PM Robert Haas wrote: Here's a rebased v3 to see what cfbot thinks. cfbot is happy, so committed. In grant.sgml, 'actualy permisions' looks a bit unorthodox.

Re: allowing for control over SET ROLE

2022-11-18 Thread Erik Rijkers
Op 18-11-2022 om 22:19 schreef Robert Haas: On Fri, Nov 18, 2022 at 1:50 PM Erik Rijkers wrote: In grant.sgml, 'actualy permisions' looks a bit unorthodox. Fixed that, and the other mistake Álvaro spotted, and also bumped catversion because I forgot that earlier. Sorry to

Re: New docs chapter on Transaction Management and related changes

2022-11-22 Thread Erik Rijkers
'Only top-level transaction IDs are' 'subtransaction ID are' should be 'subtransaction IDs are' In xact.sgml: 'Non-virtual TransactionId (or xid)' should be 'Non-virtual TransactionIds (or xids)' Erik Rijkers

Re: fix old confusing JSON example

2021-04-20 Thread Erik Rijkers
> On 2021.04.16. 10:00 Michael Paquier wrote: > On Sat, Apr 03, 2021 at 02:28:38PM +0200, Erik Rijkers wrote: > > So, that gives information on two operators, and then gives one > > example query for each. Clearly, the second example was meant to > > illustrate

gcc 11.1.0 warnings in llvmjit_expr.c

2021-04-28 Thread Erik Rijkers
build_EvalXFunc(b, mod, "ExecEvalGroupingFunc", | ^~~ llvmjit_expr.c:2460:1: note: in a call to function ‘build_EvalXFuncInt’ 2460 | build_EvalXFuncInt(LLVMBuilderRef b, LLVMModuleRef mod, const char *funcname, | ^~ Erik Rijkers

JSON doc example (matchiness)

2021-05-07 Thread Erik Rijkers
atches when the user does a quick trial. Llet's change it to something like: $.* ? (@ like_regex "^\\d+$") Patch attached. thanks, Erik Rijkers --- ./doc/src/sgml/func.sgml.orig 2021-05-07 21:52:53.577952054 +0200 +++ ./doc/src/sgml/func.sgml 2021-05-07 21:53:33.078578

Re: JSON doc example (matchiness)

2021-05-08 Thread Erik Rijkers
On 5/8/21 3:48 AM, Michael Paquier wrote: On Fri, May 07, 2021 at 10:18:44PM +0200, Erik Rijkers wrote: The JSON doc has this example (to show the need for double backslash): $ ? (@ like_regex "^\\d+$") The example is not wrong exactly, and can be cast to jsonpath, but as-is

Re: OpenSSL 3.0.0 vs old branches

2023-02-08 Thread Erik Rijkers
include a make check, and I think I would have noticed any fails. That system says: OpenSSL> OpenSSL 1.0.1e-fips 11 Feb 2013 FWIW, just now I built & ran check-world for 15 and 16 with PG_TEST_EXTRA=ssl (which I didn't use before). Both finished ok. Erik Rijkers

Re: SQL/JSON revisited

2023-02-20 Thread Erik Rijkers
'[3,4]', '$[*]' returning bigint[] empty object on error); Can you have a look? Thanks, Erik Rijkers PS Log doesn't really have anything interesting: 2023-02-20 14:57:06.073 CET 1336 LOG: server process (PID 1493) was terminated by signal 9: Killed 2023-02-20 14:57:06.073 CET 13

Re: New docs chapter on Transaction Management and related changes

2022-10-13 Thread Erik Rijkers
MMIT PREPARED and + ROLLBACK PREPARED. Two-phase transactions 'The commands' should be 'The commands are' thanks, Erik Rijkers I plan to apply this and backpatch it to all supported versions since these details apply to all versions. These docs should enable our us

date_part/extract parse curiosity

2022-10-20 Thread Erik Rijkers
x from now()) --> 3 This laxness occurs in all releases, and with 'millennium', 'millisecond', and 'microsecond' (at least). Even though it's not likely to cause much real-life headaches, and I hesitate to call it a real bug, perhaps it would be better if it could be a bit stricter. Thanks, Erik Rijkers

Re: Code checks for App Devs, using new options for transaction behavior

2022-10-27 Thread Erik Rijkers
I remember well how it confused me, many years ago. Better, IMHO: 'Once the top-level transaction is reached,' Thanks, Erik Rijkers

Re: SQL/JSON: JSON_TABLE

2021-07-10 Thread Erik Rijkers
On 5/18/21 9:23 PM, Andrew Dunstan wrote: On 5/8/21 2:23 PM, Andrew Dunstan wrote: On 4/12/21 11:34 AM, Erik Rijkers wrote: On 2021.03.27. 02:12 Nikita Glukhov wrote: Attached 47th version of the patches. We're past feature freeze for 14 and alas, JSON_TABLE has not made it. I have t

SQL/JSON: FOR ORDINALITY bug

2022-05-03 Thread Erik Rijkers
a and statement (called 'table 15' in the .pdf) as in the attached bash file. But the result is different: as implemented by 15devel, the column rowseq is always 1. It seems to me that that is wrong; it should count 1, 2, 3 as indeed the example-result column in that pdf shows. What do

Re: SQL/JSON: FOR ORDINALITY bug

2022-05-04 Thread Erik Rijkers
Op 04-05-2022 om 13:55 schreef Andrew Dunstan: On 2022-05-03 Tu 20:39, David G. Johnston wrote: On Tue, May 3, 2022 at 5:27 PM Andrew Dunstan wrote: On 2022-05-03 Tu 11:19, Erik Rijkers wrote: > Hi > > I've copied some statements from the .pdf called:

Re: SQL/JSON: FOR ORDINALITY bug

2022-05-04 Thread Erik Rijkers
Op 04-05-2022 om 21:12 schreef Andrew Dunstan: I don't see how rowseq can be anything but 1.  Each invocation of After some further experimentation, I now think you must be right, David. Also, looking at the DB2 docs:   https://www.ibm.com/docs/en/i/7.2?topic=data-using-json-table     (s

gcc 12.1.0 warning

2022-05-06 Thread Erik Rijkers
bool create_placeholders, bool skip_errors, | ^~~~ (Compiling with gcc 6.3.0 does not complain.) Below are the two configure lines, FWIW. Erik Rijkers # cassert-build: no warning/note ./configure \ --prefix=/home/aardvark/pg_stuff/pg_installations/pgsql.HEAD \ -

Re: First draft of the PG 15 release notes

2022-05-10 Thread Erik Rijkers
x27;Previously the actual schema' 'inforcement' should be 'enforcement' (surely?) 'server slide' should be 'server side' 'Add extensions to define their own' should be 'Allow extensions to define their own' And one strangely unfinished sentence: 'They also can only be' Erik Rijkers

Re: JSON Functions and Operators Docs for v15

2022-05-13 Thread Erik Rijkers
ble so that the more complicated json_table examples can be run easily. Erik Rijkers -- Andrew Dunstan EDB: https://www.enterprisedb.com--- doc/src/sgml/func.sgml.orig 2022-05-14 06:32:28.564537299 +0200 +++ doc/src/sgml/func.sgml 2022-05-14 08:10:05.313313154 +0200

Re: JSON Functions and Operators Docs for v15

2022-05-16 Thread Erik Rijkers
Op 16-05-2022 om 16:49 schreef Andrew Dunstan: [sqljson-dox-rework-2.patch] Two issues, derived from func.sgml: - 1. I noticed that some json functions, for instance json_object(), in their output insert unexpected spaces before the separator-colon: testdb=# select json_object('{a, 1,

Re: JSON Functions and Operators Docs for v15

2022-05-16 Thread Erik Rijkers
Op 16-05-2022 om 20:53 schreef Andrew Dunstan: On 2022-05-16 Mo 13:52, Erik Rijkers wrote: - 2. This example in func.sgml says it gives 't' but on my instance it returns 'f'.  Is the example correct? jsonb_path_exists_tz('["2015-08-01 12:00:00 -05"]&#x

funcs.sgml - wrong example

2022-05-17 Thread Erik Rijkers
funcs.sgml has 42 <@ '{[1,7)}'::int4multirange and calls it true. The attached fixes that. Included are two more changes where actual output differs a bit from what the doc examples show. Erik --- doc/src/sgml/func.sgml.orig 2022-05-17 17:50:40.975410855 +0200 +++ doc/src/sgml/func.sgml

Re: Parse CE and BCE in dates and times

2022-06-13 Thread Erik Rijkers
elect '112-04-30 BCE'::date; ERROR: invalid input syntax for type date: "112-04-30 BCE" LINE 1: select '112-04-30 BCE'::date; The same goes for '112-04-30 AD' (works) and its CE version (errors out). Or is this as expected? Erik Rijkers Best, David.

JSON/SQL: jsonpath: incomprehensible error message

2022-06-26 Thread Erik Rijkers
some improvement can be thought of? Similar messages in release 14 seem to use 'invalid token', which is better: select js from (values (jsonb '{"a":"b"}')) as f(js) where js @? '$ ? (@.a .= "b")'; ERROR: syntax error, unexpected invalid token at or near "=" of jsonpath input thanks, Erik Rijkers

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-28 Thread Erik Rijkers
Op 29-06-2022 om 02:04 schreef Jonathan S. Katz: Hi, 'not advise you to run PostgreSQL 15 Beta 1'should be 'not advise you to run PostgreSQL 15 Beta 2' Erik

Re: JSON/SQL: jsonpath: incomprehensible error message

2022-06-29 Thread Erik Rijkers
Op 29-06-2022 om 15:00 schreef Amit Kapila: On Mon, Jun 27, 2022 at 8:46 PM Andrew Dunstan wrote: On 2022-06-26 Su 11:44, Erik Rijkers wrote: JSON/SQL jsonpath For example, a jsonpath string with deliberate typo 'like_regexp' (instead of 'like_regex'): select js

Re: PostgreSQL 15 beta 2 release announcement draft

2022-06-29 Thread Erik Rijkers
Op 29-06-2022 om 02:04 schreef Jonathan S. Katz: Hi, Attached is a draft of the release announcement for PostgreSQL 15 Beta 2. Please provide feedback on technical accuracy and if there are glaring omissions. Hardly 'glaring' but still: 'Multiples fixes' should be 'Multiple fixes' Pleas

ERROR: operator does not exist: json = json

2022-07-07 Thread Erik Rijkers
'solved' by casting but that's not really the point) Thanks, Erik Rijkers

SQL/JSON documentation JSON_TABLE

2022-07-08 Thread Erik Rijkers
o remove all uses of that compound term, and rewrite the explanations using only the current parameter names (context_item, path_expression, etc). But I wasn't sure and I haven't done any such changes in the attached. Perhaps I'll give it a try during the weekend. Erik Rijkers -

Re: SQL/JSON documentation JSON_TABLE

2022-07-14 Thread Erik Rijkers
On 7/14/22 17:45, Andrew Dunstan wrote: On 2022-07-08 Fr 16:20, Andrew Dunstan wrote: On 2022-07-08 Fr 16:03, Erik Rijkers wrote: Hi, Attached are a few small changes to the JSON_TABLE section in func.sgml. The first two changes are simple typos. Then there was this line

Re: Schema variables - new implementation for Postgres 15

2022-07-21 Thread Erik Rijkers
tgres.sgml:374: element link: validity error : IDREF attribute linkend references an unknown ID "catalog-pg-variable" make: *** [Makefile:135: html-stamp] Error 4 Erik Rijkers Regards Pavel

Re: Schema variables - new implementation for Postgres 15

2022-07-24 Thread Erik Rijkers
7;schema_variable' instead of session_variable: -A schema_variable --variable=schema_variable Surely those should be changed as well. Erik Rijkers--- ./doc/src/sgml/ref/alter_variable.sgml.orig 2022-07-22 12:18:47.905664314 +0200 +++ ./doc/src/sgml/ref/alter_variable.sgml 2022-07-22 12:34:52.92

fix typos

2022-08-01 Thread Erik Rijkers
Recent typos... --- ./doc/src/sgml/ref/drop_extension.sgml.orig 2022-08-01 19:38:18.249729884 +0200 +++ ./doc/src/sgml/ref/drop_extension.sgml 2022-08-01 19:40:33.312359069 +0200 @@ -32,7 +32,7 @@ DROP EXTENSION removes extensions from the database. Dropping an extension causes its

Re: fix typos

2022-08-02 Thread Erik Rijkers
Op 02-08-2022 om 07:28 schreef John Naylor: On Tue, Aug 2, 2022 at 1:05 AM Erik Rijkers <mailto:e...@xs4all.nl>> wrote: > > Recent typos... The part of the sentence inside parentheses is not clear to me, before or after the patch:     Dropping an extension causes its co

Re: Schema variables - new implementation for Postgres 15

2021-09-09 Thread Erik Rijkers
> [schema-variables-20210909.patch] Hi Pavel, The patch applies and compiles fine but 'make check' for the assert-enabled fails on 131 out of 210 tests. (while compiling HEAD checks run without errors for both assert-disabled and assert-enabled) Erik Rijkers te

Re: Schema variables - new implementation for Postgres 15

2021-09-10 Thread Erik Rijkers
On 9/10/21 10:06 AM, Pavel Stehule wrote: Hi čt 9. 9. 2021 v 12:21 odesílatel Erik Rijkers napsal: Hi Pavel, The patch applies and compiles fine but 'make check' for the assert-enabled fails on 131 out of 210 tests. (while compiling HEAD checks run without errors for both asser

Re: SQL/JSON: JSON_TABLE

2021-09-13 Thread Erik Rijkers
On 9/2/21 8:52 PM, Andrew Dunstan wrote: On 7/22/21 3:49 AM, Erik Rijkers wrote: Hi Here are the 4 unchanged patches from v49, to which I added 2 patches, which are small changes wrt usage of  'JsonIs'  versus  'IsJson'. That should make the cfbot green again. Appare

Re: SQL/JSON: JSON_TABLE - pg_stat_statements crash

2021-09-14 Thread Erik Rijkers
On 9/14/21 2:53 PM, Andrew Dunstan wrote: On 9/13/21 5:41 AM, Erik Rijkers wrote: On 9/2/21 8:52 PM, Andrew Dunstan wrote: >> [0001-SQL-JSON-functions-v51.patch] >> [0002-JSON_TABLE-v51.patch] >> [0003-JSON_TABLE-PLAN-DEFAULT-clause-v51.patch] >> [0004-JSON_TAB

Re: proposal: possibility to read dumped table's name from file

2021-10-01 Thread Erik Rijkers
second, separate practical hickup is that schema's are not restored from the dumped $schema.$table includes -- but this can be worked around; for my inputfile1.txt I had to run separately (as seen above, before running the pg_restore): create schema if not exists test; create schema if not exists gutenberg; create server if not exists goethe foreign data wrapper file_fdw; A bit annoying but still maybe all right. Thanks, Erik Rijkers

Re: proposal: possibility to read dumped table's name from file

2021-10-01 Thread Erik Rijkers
On 10/1/21 6:19 PM, Erik Rijkers wrote: On 10/1/21 3:19 PM, Daniel Gustafsson wrote: As has been discussed upthread, this format strikes a compromise wrt simplicity and doesn't preclude adding a more structured config file in the future should If you try to dump/restore a foreign

Re: Triage on old commitfest entries - JSON_PATH

2021-10-03 Thread Erik Rijkers
that obviously can't be right) Although I like the patch & new functionality and Andrew Dunstan has worked to keep it up-to-date, there seems to be very little further discussion. I makes me a little worried that the time I put in will end up sunk in a dead project. Erik Rijkers Prote

Re: Triage on old commitfest entries - JSON_PATH

2021-10-04 Thread Erik Rijkers
Op 04-10-2021 om 14:19 schreef Andrew Dunstan: On 10/3/21 3:56 PM, Erik Rijkers wrote: Op 03-10-2021 om 21:14 schreef Tom Lane: As I threatened in another thread, I've looked through all of the oldest commitfest entries to see which ones should maybe be tossed, Patch    Age in CFs

Re: proposal: possibility to read dumped table's name from file

2021-10-05 Thread Erik Rijkers
Op 05-10-2021 om 14:30 schreef Daniel Gustafsson: Unless there are objections, I think this is pretty much ready to go in. Agreed. One typo: 'This keyword can only be with the exclude keyword.'should be 'This keyword can only be used with the exclude keyword.' t

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-08-03 Thread Erik Rijkers
also support it. I will post a new version of the patch once it is done. +1 I for one am in favor of this 'start'-argument addition. Slightly harder usage, but more precise manipulation. Erik Rijkers Here is a new version of the patch that adds the start parameter to regexp_

Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions

2024-07-05 Thread Erik Rijkers
Op 7/5/24 om 14:35 schreef Amit Langote: Hi Jian, Thanks for the reviews. > [v3-0001-SQL-JSON-Various-improvements-to-SQL-JSON-query-f.patch] i.e., from the patch for doc/src/sgml/func.sgml Small changes: 4x: 'a SQL' should be 'an SQL' ('a SQL' does never occur in the docs; it's alwa

Re: PG 16 draft release notes ready

2023-07-14 Thread Erik Rijkers
) 'SQL JSON paths' should be 'SQL/JSON paths' Erik Rijkers

Re: remaining sql/json patches

2023-07-17 Thread Erik Rijkers
, we might need a readable translation of that in the docs although it might be easier to just get get rid of the term 'json_api_common_syntax'. HTH, Erik Rijkers

Re: remaining sql/json patches

2023-08-04 Thread Erik Rijkers
Op 7/21/23 om 12:33 schreef Amit Langote: Thanks for taking a look. Hi Amit, Is there any chance to rebase the outstanding SQL/JSON patches, (esp. json_query)? Thanks! Erik Rijkers

Re: 2023-08-10 release announcement draft

2023-08-07 Thread Erik Rijkers
Op 8/8/23 om 03:15 schreef Jonathan S. Katz: Please provide your feedback no later than August 10, 2023 0:00 AoE[1]. 'You us' should be 'You use' (2x) Erik

Re: proposal: jsonb_populate_array

2023-08-14 Thread Erik Rijkers
Op 8/14/23 om 14:51 schreef Pavel Stehule:> po 14. 8. 2023 v 11:32 odesílatel Alvaro Herrera > with proposed function I can write > > select jsonb_populate_array(null:date[], > '["2023-07-13","2023-07-14"]'::jsonb) > Not yet committed, but outstanding SQL/JSON patches (v11) will let you do: sel

regexp_replace weirdness amounts to a bug?

2023-08-16 Thread Erik Rijkers
Hello, The following surprised me enough to think it might be a bug: (17devel) select regexp_replace('Abc Def' , '([a-z]) ([A-Z])' , '\1 ' || lower('\2') ); regexp_replace Abc Def (1 row) -- 'Abc Def' got -- &#x

Re: PostgreSQL 16 release announcement draft

2023-08-24 Thread Erik Rijkers
Op 8/24/23 om 16:32 schreef Jonathan S. Katz: On 8/23/23 5:07 PM, David Rowley wrote: On Thu, 24 Aug 2023 at 05:55, Jonathan S. Katz wrote: Hi, When v15 docs have: "27.2.7. Cascading Replication The cascading replication feature allows a standby server to accept replication connections and

Re: PostgreSQL 16 release announcement draft

2023-08-25 Thread Erik Rijkers
Op 8/26/23 om 04:51 schreef Jonathan S. Katz: On 8/24/23 11:17 AM, Erik Rijkers wrote: Op 8/24/23 om 16:32 schreef Jonathan S. Katz: On 8/23/23 5:07 PM, David Rowley wrote: On Thu, 24 Aug 2023 at 05:55, Jonathan S. Katz wrote: Hi, When v15 docs have: "27.2.7. Cascading Replicatio

https://git.postgresql.org/git/postgresql.git/ fails

2023-08-27 Thread Erik Rijkers
I normally pull from https://git.postgresql.org/git/postgresql.git/ but for a few hours now it's been failing (while other git repo's are still reachable). Is it me or is there a hiccup there? thanks, Erik Rijkers

Re: 2024-05-09 release announcement draft

2024-05-06 Thread Erik Rijkers
Op 5/6/24 om 19:44 schreef Jonathan S. Katz: Hi, Please find the draft of the 2024-05-09 release announcement. 'procedures that returns' should be 'procedures that return'

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-16 Thread Erik Rijkers
it might work keep the list smaller. Erik Rijkers

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-19 Thread Erik Rijkers
ntroduces'; just not both...) Thanks, Erik Rijkers

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 19-08-2022 om 17:29 schreef Pavel Stehule: pá 19. 8. 2022 v 15:57 odesílatel Pavel Stehule napsal: Hi I am sending fresh update - enhanced work with composite types - now the used composite type can be enhanced, reduced and stored value is converted to expected format - enhancing find_com

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 20-08-2022 om 15:32 schreef Erik Rijkers: Op 19-08-2022 om 17:29 schreef Pavel Stehule: make check  fails as a result of the errors in the attached session_variables.out. Sorry, that should have been this diffs file, of course (attached). Erikdiff -U3 /home/aardvark/pg_stuff

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 20-08-2022 om 15:41 schreef Pavel Stehule: so 20. 8. 2022 v 15:36 odesílatel Erik Rijkers napsal: Op 20-08-2022 om 15:32 schreef Erik Rijkers: Op 19-08-2022 om 17:29 schreef Pavel Stehule: make check fails as a result of the errors in the attached session_variables.out. Sorry

Re: Schema variables - new implementation for Postgres 15

2022-08-20 Thread Erik Rijkers
Op 20-08-2022 om 20:09 schreef Pavel Stehule: Hi LET public.svar2 = (10, 20, 30); ALTER TYPE public.svar_test_type DROP ATTRIBUTE b; SELECT public.svar; - svar - (10,) + svar +- + (10,16) (1 row) SELECT public.svar2; svar2 - (10,30) (1 row) I h

Re: Schema variables - new implementation for Postgres 15

2022-08-21 Thread Erik Rijkers
Op 21-08-2022 om 09:54 schreef Pavel Stehule: ne 21. 8. 2022 v 6:36 odesílatel Julien Rouhaud napsal: On Sat, Aug 20, 2022 at 08:44:49PM +0200, Erik Rijkers wrote: Op 20-08-2022 om 20:09 schreef Pavel Stehule: should be fixed now> Yep, all tests OK now. Thanks! Erik

Re: Column Filtering in Logical Replication

2022-08-22 Thread Erik Rijkers
Op 22-08-2022 om 10:27 schreef Peter Smith: PSA new set of v2* patches. Hi, In the second file a small typo, I think: "enclosed by parenthesis" should be "enclosed by parentheses" thanks, Erik

Re: Schema variables - new implementation for Postgres 15

2022-08-24 Thread Erik Rijkers
Op 24-08-2022 om 08:37 schreef Pavel Stehule: I fixed these. > [v20220824-1-*.patch] Hi Pavel, I noticed just now that variable assignment (i.e., LET) unexpectedly (for me anyway) cast the type of the input value. Surely that's wrong? The documentation says clearly enough: 'The result

Re: Clarify restriction on partitioned tables primary key / unique indexes

2022-09-02 Thread Erik Rijkers
Op 02-09-2022 om 11:44 schreef David Rowley: Over on [1], there was a question about why it wasn't possible to create the following table: CREATE TABLE foobar( id BIGINT NOT NULL PRIMARY KEY, baz VARCHAR NULL DEFAULT NULL ) PARTITION BY HASH(my_func(id)); The attached attempts to c

json docs fix jsonb_path_exists_tz again

2022-09-02 Thread Erik Rijkers
In funcs.sgml, the value fed into jsonb_path_exists_tz was wrong; fixed as attached. (was inadvertently reverted with the big JSON revert) Erik Rijkers--- doc/src/sgml/func.sgml.orig 2022-09-02 16:16:21.406405542 +0200 +++ doc/src/sgml/func.sgml 2022-09-02 16:17:41.751838806 +0200 @@ -16533,7

Re: New docs chapter on Transaction Management and related changes

2022-09-06 Thread Erik Rijkers
Op 06-09-2022 om 17:16 schreef Simon Riggs: New chapter on transaction management, plus a few related changes. Markup and links are not polished yet, so please comment initially on the topics, descriptions and wording. [xact_docs.v2.patch] Very clear explanations, thank you. Two typos: 'n

Re: PostgreSQL 15 Beta 4 release announcement draft

2022-09-06 Thread Erik Rijkers
Op 07-09-2022 om 03:40 schreef Jonathan S. Katz: Hi, I've attached a draft of the PostgreSQL 15 Beta 4 release announcement. Please review for correctness and if there are any omissions. Please provide feedback on the draft no later than Sep 8, 2022 0:00 AoE. 'Fixes and changes in PostgreSQ

Re: proposal: possibility to read dumped table's name from file

2022-09-08 Thread Erik Rijkers
;" # dump without filter emits no spaces echo -ne ">" pg_dump -F c -f plainfile3 -t table0 -table1 -d testdb2 echo "<" - It's probably a small thing -- but I didn't find it. thanks, Erik Rijkers -- Daniel Gustafsson https://vmware.com/

Re: proposal: possibility to read dumped table's name from file

2022-09-12 Thread Erik Rijkers
with the same filter-file that was used to produce a dump with pg_dump --filter. Is that as designed? It seems a bit counterintuitive. It'd be nice if that could be fixed. Admittedly, the 'same' problem in pg_restore -t, also less than ideal. (A messy bashdemo below) thanks

Re: proposal: possibility to read dumped table's name from file

2022-09-12 Thread Erik Rijkers
Op 12-09-2022 om 16:00 schreef Erik Rijkers: Op 12-09-2022 om 09:58 schreef Daniel Gustafsson: On 9 Sep 2022, at 11:00, Andrew Dunstan wrote: On Sep 9, 2022, at 5:53 PM, John Naylor wrote: [v4-0001-Add-include-exclude-filtering-via-file-in-pg_dump.patch] I noticed that pg_restore

Re: PostgreSQL 16 Beta 1 release announcement draft

2023-05-18 Thread Erik Rijkers
Op 5/19/23 om 06:17 schreef Jonathan S. Katz: Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta Hi, The usual small fry: 'continues to to' should be 'continues to' 'continues to give users to the ability' should be 'continues to give users the ability to' 'pg_

Re: PostgreSQL 16 Beta 1 release announcement draft

2023-05-22 Thread Erik Rijkers
Op 5/21/23 om 19:07 schreef Jonathan S. Katz: On 5/19/23 12:17 AM, Jonathan S. Katz wrote: Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta Please provide feedback no later than May 24, 0:00 AoE. This will give Thanks everyone for your feedback. Here is the updated t

Re: PG 16 draft release notes ready

2023-05-24 Thread Erik Rijkers
Op 5/24/23 om 15:58 schreef Bruce Momjian: On Wed, May 24, 2023 at 12:23:02PM +0700, John Naylor wrote: On Wed, May 24, 2023 at 11:19 AM Bruce Momjian wrote: Typos: 'from standbys servers' should be 'from standby servers' 'reindexedb' should be 'reindexdb' (2x: the next line mentions,

Re: proposal: schema variables

2024-08-01 Thread Erik Rijkers
doc-build fails: a slash tumbled backwards in doc/src/sgml: $ grep 'xref.*.\\>' *.sgml plpgsql.sgml: (see ). That should simply be a forward slash, of course. Thanks, Erik Rijkers Op 8/1/24 om 08:12 schreef Pavel Stehule: Hi fresh rebase + fix format in doc Regards Pavel

Re: new heapcheck contrib module (typos)

2020-06-13 Thread Erik Rijkers
db Is that error as expected? thanks, Erik Rijkers

<    1   2   3   >