Re: Extract numeric filed in JSONB more effectively

2023-08-26 Thread Chapman Flack
On 2023-08-22 08:16, Chapman Flack wrote: On 2023-08-22 01:54, Andy Fan wrote: After we label it, we will get error like this: select (a->'a')::int4 from m; ERROR: cannot display a value of type internal Without looking in depth right now, I would double-check what relabel

Re: UTF8 national character data type support WIP patch and list of open issues.

2023-08-27 Thread Chapman Flack
Hi, Although this is a ten-year-old message, it was the one I found quickly when looking to see what the current state of play on this might be. On 2013-09-20 14:22, Robert Haas wrote: Hmm. So under that design, a database could support up to a total of two character sets, the one that you get

'trusted'/'untrusted' PL in DoD/DISA PostgreSQL STIGs

2024-05-05 Thread Chapman Flack
Hi hackers, More or less by chance, I stumbled on a Security Technical Implementation Guide (STIG, promulgated by the US Dept. of Defense, Defense Information Systems Agency) for PostgreSQL (specific to PG 9.x, so a bit dated). There is a rule in the STIG that pertains to PLs, and seems to get ba

Re: Is there any chance to get some kind of a result set sifting mechanism in Postgres?

2024-05-13 Thread Chapman Flack
On 05/13/24 09:35, aa wrote: > If you call the action of "sifting" ordering, then yes. If you don't call > it ordering, then no. One thing seems intriguing about this idea: normally, an expected property of any ORDER BY is that no result row can be passed down the pipe until all input rows have b

Re: Adding the extension name to EData / log_line_prefix

2024-05-15 Thread Chapman Flack
On 05/15/24 11:50, Tom Lane wrote: > Hmm, cute idea, but it'd only help for extensions that are > NLS-enabled. Which I bet is a tiny fraction of the population. > So far as I can find, we don't even document how to set up > TEXTDOMAIN for an extension --- you have to cargo-cult the But I'd bet, w

Re: Adding the extension name to EData / log_line_prefix

2024-05-15 Thread Chapman Flack
On 05/15/24 13:45, Tom Lane wrote: > if we tell people to write > >PG_MODULE_MAGIC; >#undef TEXTDOMAIN >#define TEXTDOMAIN PG_TEXTDOMAIN("hstore") > > then that's 100% backwards compatible and they don't need any > version-testing ifdef's. OT for this thread, but related: supposing o

Re: add function argument names to regex* functions.

2024-05-15 Thread Chapman Flack
On 05/15/24 15:07, Robert Haas wrote: > is. I believe that if I were reading the documentation, count would be > clearer to me than N, N would probably still be clear enough, and > replace_at wouldn't be clear at all. I'd expect replace_at to be a > character position or something, not an occurrenc

Re: add function argument names to regex* functions.

2024-05-15 Thread Chapman Flack
On 05/15/24 15:31, Robert Haas wrote: > On Wed, May 15, 2024 at 3:23 PM Chapman Flack wrote: >> What would be wrong with [occurrence], for consistency's sake? > > It was proposed and rejected upthread, but that's not to say that I > necessarily endorse the reaso

Re: Reading timestamp values from Datums gives garbage values

2024-05-20 Thread Chapman Flack
On 05/20/24 11:39, Tomas Vondra wrote: > On 5/20/24 16:37, Sushrut Shivaswamy wrote: >> I've tried various types and none of them read the correct value. >> ``` >> ... >> double current_time = DatumGetFloat8(current_timestamp); // prints 0 >> >> int64 time = DatumGetUint64(current_timestamp); // pr

Re: access numeric data in module

2024-09-09 Thread Chapman Flack
On 09/09/24 13:00, Robert Haas wrote: > I don't agree with this reponse at all. It seems entirely reasonable > for third-party code to want to have a way to construct and interpret > numeric datums. Keeping the details private would MAYBE make sense if > the internal details were changing release t

Re: add function argument names to regex* functions.

2024-07-15 Thread Chapman Flack
On 07/15/24 08:02, jian he wrote: > also address Chapman Flack point: > correct me if i am wrong, but i don't think the ISO standard mandates > function argument names. > So we can choose the best function argument name for our purpose? Ah, I may have mistaken which functions t

Re: add function argument names to regex* functions.

2024-07-15 Thread Chapman Flack
On 07/15/24 10:46, Chapman Flack wrote: > Ah, I may have mistaken which functions the patch meant to apply to. > ... > Any choice to use similar argument names in the regexp_* functions would > be a matter of consistency with the analogous ISO functions, not anything > mandated. O

Re: pg_attribute.atttypmod for interval type

2024-07-28 Thread Chapman Flack
On 07/27/24 00:32, Tom Lane wrote: > Interval typmods include a fractional-seconds-precision field as well > as a bitmask indicating the allowed interval fields (per the SQL > standard's weird syntax such as INTERVAL DAY TO SECOND). Looking at > the source code for intervaltypmodout() might be hel

Re: what can go in root.crt ?

2020-06-03 Thread Chapman Flack
On 06/03/20 08:07, Ants Aasma wrote: > I think the "why" the org cert is not root was already made clear, that is > the copmany policy. Thank you, yes, that was what I had intended to convey, and you have saved me finishing a weedsier follow-up message hoping to convey it better. > I don't think

Re: [PATCH] Leading minus for negative time interval in ISO 8601

2020-06-03 Thread Chapman Flack
On 06/03/20 22:46, Tom Lane wrote: > "Isn't quite clear"? ISTM that if the standard intended to allow that, > it'd be pretty clear. I looked through the 8601 spec just now, and > I can't see any indication whatever that they intend to allow "-" before P. Umm, did you see any indication that they

Re: what can go in root.crt ?

2020-06-04 Thread Chapman Flack
On 06/04/20 02:07, Laurenz Albe wrote: > I feel bad about bending the basic idea of certificates and trust to suit > some misbegotten bureaucratic constraints on good security. Can you elaborate on what, in the email message you replied to here, represented a bending of the basic idea of certifica

Re: what can go in root.crt ?

2020-06-04 Thread Chapman Flack
On 06/04/20 11:04, Laurenz Albe wrote: > I was referring to the wish to *not* use a self-signed CA certificate, > but an intermediate certificate as the ultimate authority, based on > a distrust of the certification authority that your organization says > you should trust. Are you aware of any pri

Re: what can go in root.crt ?

2020-06-04 Thread Chapman Flack
On 06/04/20 17:31, Andrew Dunstan wrote: > Do we actually do any of this sort of thing? I confess my impression was > this is all handled by the openssl libraries, we just hand over the > certs and let openssl do its thing. Am I misinformed about that? I haven't delved very far into the code yet (

Re: what can go in root.crt ?

2020-06-04 Thread Chapman Flack
On 06/04/20 18:03, Tom Lane wrote: > It's possible that we could force openssl to validate cases it doesn't > accept now. Whether we *should* deviate from its standard behavior is > a fairly debatable question though. I would not be inclined to do so > unless we find that many other consumers of

Re: what can go in root.crt ?

2020-06-12 Thread Chapman Flack
On 06/12/20 15:13, Bruce Momjian wrote: > On Wed, Jun 3, 2020 at 07:57:16PM -0400, Chapman Flack wrote: >> here is a root.crt file for libpq containing only this exact cert, I >> want libpq to connect only ever to this server with this cert and nothing >> else. It's a p

Re: what can go in root.crt ?

2020-06-12 Thread Chapman Flack
On 06/12/20 16:17, Chapman Flack wrote: > reason. Typically that reason is that it has been placed in a file that > can only be edited by the admin who decides what certs to trust. By > editing it into that file, that responsible person has vouched for it, > and /that/ is why the TLS c

Re: vs for command line tools in the docs

2020-06-21 Thread Chapman Flack
On 06/21/20 11:16, Tom Lane wrote: > ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> docs, I noticed that catalog.sgml uses the tag to refer to >> initdb, while I'd expected it to use . > > I agree that the latter is what we generally use. 'The latter' is in the Subject

Re: Threading in BGWorkers (!)

2020-06-23 Thread Chapman Flack
On 06/22/20 23:38, Tom Lane wrote: > bgworkers, or you could dispatch the threaded work to a non-Postgres-ish > process as PL/Java does. The only advantage I can see of doing work in a > process that's not at arm's-length is to have access to PG computational > or IPC facilities, and none of that

Re: Decomposing xml into table

2020-06-23 Thread Chapman Flack
On 06/23/20 08:57, Thomas Kellerer wrote: > Surafel Temesgen schrieb am 23.06.2020 um 13:59: >>> Did you try the xmltable function? >> >> yes i know it but i am proposing changing given xml data in to >> relational form and insert it to desired table at once > Well, xmltable() does change the XML

Re: Threading in BGWorkers (!)

2020-06-23 Thread Chapman Flack
On 06/23/20 21:44, Andres Freund wrote: > I think that's way harder than what you make it sound here. The locking > for shm_mq doesn't really work inside a process. In contrast to the > single threaded case something like a volatile write to > ParallelMessagePending doesn't guarantee much, because

Re: Threading in BGWorkers (!)

2020-06-23 Thread Chapman Flack
On 06/23/20 22:13, Tom Lane wrote: > 1. elog.c is in itself not-thread-safe, because it uses a static data > structure to track the message being built. > > 2. It uses palloc, another large pile of not-thread-safe infrastructure. ... I'm sure now that I shouldn't have mentioned (1) - muddied wate

Re: Threading in BGWorkers (!)

2020-06-23 Thread Chapman Flack
On 06/23/20 23:08, Tom Lane wrote: > I dunno. It's not even adequate for the use-case of reporting an > error, because waiting till after the current transaction commits > is surely not what should happen in that case. In the case of the kind of exuberantly-threaded language runtime of which Jav

pg_ctl behavior on Windows

2020-07-17 Thread Chapman Flack
Hi, So, I am not a Windows native, and here I am mentoring a GSoC student setting up CI on multiple environments, including Windows. In my own development and testing, by habit I do everything from unprivileged accounts, just spinning up an instance in a temp location, running some tests, and shu

Re: pg_ctl behavior on Windows

2020-07-18 Thread Chapman Flack
On 07/18/20 05:46, Amit Kapila wrote: > I don't think so. I think you can use 'pg_ctl start' to achieve that. > I think the JOBS stuff is primarily required when we use 'register' > operation (aka runs server via service). For example, if you see one > of the Job options "JOB_OBJECT_LIMIT_DIE_ON_U

Re: PG 13 release notes, first draft

2020-05-06 Thread Chapman Flack
On 05/05/20 10:31, Bruce Momjian wrote: > On Tue, May 5, 2020 at 09:20:39PM +0800, John Naylor wrote: >> ... This patch is >> about the server encoding, which formerly needed to be utf-8 for >> non-ascii characters. (I think the client encoding doesn't matter as >> long as ascii bytes are represen

Re: PG 13 release notes, first draft

2020-05-06 Thread Chapman Flack
On 05/06/20 16:01, Chapman Flack wrote: > I had assumed the patch applied to all of the forms U&'\', > U&'\+##', E'\u', and E'\U##' ... annnd that last form needs to have eight #s. (Can't be respelled with 4 ♭s.) -Chap

Re: PG 13 release notes, first draft

2020-05-07 Thread Chapman Flack
On 05/07/20 09:46, Bruce Momjian wrote: > Ah, very good point. New text is: > > Allow Unicode escapes, e.g., E'\u', in databases that do not > use UTF-8 encoding (Tom Lane) > > The Unicode characters must be available in the database encoding. > ... > > I am only using E'\

Re: PG 13 release notes, first draft

2020-05-11 Thread Chapman Flack
On 05/11/20 22:48, Bruce Momjian wrote: > On Mon, May 11, 2020 at 10:07:23PM -0400, Tom Lane wrote: >> Bruce Momjian writes: >>> Allow Unicode escapes, e.g., E'\u', U&'\', to represent any >>> character available in the database encoding, even when the database >>> encoding is

Re: Do I understand commit timestamps correctly?

2020-05-12 Thread Chapman Flack
On 03/23/18 11:40, Alvaro Herrera wrote: > Chapman Flack wrote: >> ? Given a base backup and a bunch of WAL from a cluster that had >> track_commit_timestamps turned off, is it possible (in principle?) >> to do a PITR with the switch turned on, and have the commit_ts >

Re: JSON output from psql

2020-05-13 Thread Chapman Flack
On 05/13/20 16:16, Gurjeet Singh wrote: > On Wed, May 13, 2020 at 1:14 PM Gurjeet Singh wrote: >> >> Arguably, delivering JSON (with its repeating attribute names in every >> element of the array, dquotes and commas) is more network intensive >> than converting the resultset to JSON on [client] si

document? Re: Do I understand commit timestamps correctly?

2020-05-13 Thread Chapman Flack
On 03/23/18 11:29, Chapman Flack wrote: > Can somebody confirm or correct what I (think I)'ve gleaned from > the code? > ... > - The extra machinery turned on by track_commit_timestamp maintains > a cache of recent ones so they can be efficiently queried from SQL >

Re: POC: rational number type (fractions)

2020-05-18 Thread Chapman Flack
On 05/18/20 17:33, Peter Eisentraut wrote: > The numeric type already stores rational numbers. How is this different? > What's the use? Seems like numeric is a base-1 representation. Will work ok for a rational whose denominator factors into 2s and 5s. Won't ever quite represent, say, 1/3,

what can go in root.crt ?

2020-05-25 Thread Chapman Flack
Certificates I get at $work come four layers deep: Self-signed CA cert from "WE ISSUE TO EVERYBODY.COM" Intermediate from "WE ISSUE TO LOTS OF FOLKS.COM" Intermediate from "WE ISSUE TO ORGS LIKE YOURS.COM" End-entity cert for my server. Until today, we had the topmost, self-signe

Re: what can go in root.crt ?

2020-05-25 Thread Chapman Flack
On 05/25/20 15:15, Chapman Flack wrote: > Does that mean it also would fail if I directly put the server's > end-entity cert there? > > Would I have to put all three of WE ISSUE TO ORGS LIKE YOURS, > WE ISSUE TO LOTS, and WE ISSUE TO EVERYBODY in the root.crt file > in or

Re: what can go in root.crt ?

2020-05-25 Thread Chapman Flack
On 05/25/20 22:03, Bruce Momjian wrote: > Did you review the PG documentation about intermediate certificates? > > https://www.postgresql.org/docs/13/ssl-tcp.html#SSL-CERTIFICATE-CREATION AFAICT, there isn't much in that section to apply to my question. > Is there a specific question you h

Re: what can go in root.crt ?

2020-05-25 Thread Chapman Flack
On 05/25/20 23:22, Laurenz Albe wrote: > I don't know if there is a way to get this to work, but the > fundamental problem seems that you have got the system wrong. > > If you don't trust WE ISSUE TO EVERYBODY, then you shouldn't use > it as a certification authority. That's a reasonable viewpoin

Re: what can go in root.crt ?

2020-05-25 Thread Chapman Flack
On 05/26/20 00:07, Alvaro Herrera wrote: >> If the libpq root.crt file can be made to work similarly to a >> Java trustStore, that expands the possible solution space. > > If I understand you correctly, you want a file in which you drop any of > these intermediate CA's cert in, causing the server

Re: what can go in root.crt ?

2020-05-25 Thread Chapman Flack
On 05/26/20 00:07, Isaac Morland wrote: > What about the SSH model? In the Postgres context, this would basically be > a table containing authorized certificates for each user. Upon receiving a > connection attempt, look up the user and the presented certificate and see > if it is one of the author

Re: what can go in root.crt ?

2020-05-26 Thread Chapman Flack
On 05/26/20 02:05, Craig Ringer wrote: > The main reason to put intermediate certificates in the root.crt is that it > allows PostgreSQL to supply the whole certificate chain to a client during Hold on a sec; you're not talking about what I'm talking about, yet. Yes, you have make the chain avail

Re: what can go in root.crt ?

2020-05-26 Thread Chapman Flack
On 05/26/20 09:35, Andrew Dunstan wrote: > The trouble is I think you have it the wrong way round. It makes sense > to give less trust to a non-root CA than to one of its up-chain > authorities, e.g. only trust it for certain domains, or for a lesser > period of time. But it doesn't seem to make m

Re: pie-in-sky idea: 'sensitive' function parameters

2020-05-29 Thread Chapman Flack
Just giving this thread a bump in honor of the mention of sensitive things in logs in the cryptography unconference session. I'm not partisan about any of the particular syntax examples I gave earlier, but it seems like there were two key ingredients: 1. In what is sent from the client to the se

Re: pie-in-sky idea: 'sensitive' function parameters

2020-05-29 Thread Chapman Flack
On 05/29/20 14:51, Robert Haas wrote: > stuff that works today. We have options to log queries before parsing > them. You can't redact sensitive details at that point because you > don't know whether the query contains any such details, or where they > are located. You can't postpone logging the qu

Re: pie-in-sky idea: 'sensitive' function parameters

2020-05-29 Thread Chapman Flack
On 05/29/20 15:26, Tom Lane wrote: > all of the simpler cases I can think of: aside from the ALTER USER > PASSWORD case, there's INSERT INTO accounts(..., creditcardnumber, > ...) VALUES(..., $n, ...). Neither one of those have a nearby UDF > to control it with. I was thinking incrementally ...

Re: House style for DocBook documentation?

2019-01-19 Thread Chapman Flack
Hi, On 01/19/19 08:35, Alvaro Herrera wrote: >> Is there, somewhere, a written-up "house style" for what DocBook 4.2 >> elements to use for which types of content in the manual? >> ... > I don't think we do. I'd suggest to come up with something and then see > if it makes sense to patch the docs

Re: PostgreSQL vs SQL/XML Standards

2019-01-19 Thread Chapman Flack
Working slowly through the documentation, I came upon: For XMLTABLE: - The xmltable function produces a table based on the given XML value, an XPath filter to extract rows, and an optional set of column definitions. ... The mandatory COLUMNS

Re: PostgreSQL vs SQL/XML Standards

2019-01-19 Thread Chapman Flack
On 01/19/19 23:49, Pavel Stehule wrote: > If I remember, described functionality was implemented in early patches, > but was removed to simplify code. To now, there was not a request to do it. > > Unfortunately, the documentation was not fixed. I'll do that, as I'm working in there anyway. :) >

Re: PostgreSQL vs SQL/XML Standards

2019-01-20 Thread Chapman Flack
Hi, On 01/20/19 00:26, Pavel Stehule wrote: >>> column expressions are evaluated once per row, but XPath expression is >>> compiled per row too, if I remember well. >> >> I looked for evidence of that in the code, but did not find it; the >> compilation appears to happen in XmlTableSetColumnFilte

Re: PostgreSQL vs SQL/XML Standards

2019-01-20 Thread Chapman Flack
On 01/20/19 11:55, Pavel Stehule wrote: > input row mean a row of processed relation. The xml value from this row can > be transformed to 0..M output rows. > > The column filter expressions are evaluated once per input rows, default > expressions are evaluated when it is necessary - possibly once

Re: PostgreSQL vs SQL/XML Standards

2019-01-20 Thread Chapman Flack
On 01/20/19 12:48, Pavel Stehule wrote: >> >> Accordingly, I think the paragraph beginning "Unlike regular PostgreSQL >> functions," is more likely to perplex readers than to enlighten them. >> What it says about column_expression does not seem to lead to any useful >> difference from the behavior

Re: Allowing extensions to find out the OIDs of their member objects

2019-01-20 Thread Chapman Flack
On 01/20/19 18:50, Tom Lane wrote: > we make a catalog entry showing that object number three has OID > thus-and-so, and then that catalog entry can be consulted to get > the right OID (by C code that has hard-wired knowledge that object > number three is the function it cares about). This is stil

Re: Allowing extensions to find out the OIDs of their member objects

2019-01-20 Thread Chapman Flack
On 01/20/19 19:43, Tom Lane wrote: >> If the extension script could somehow be informed at CREATE EXTENSION time >> of what its OID is, that would clear the way for ALTER EXTENSION RENAME, no? > > And it remembers that where? Top level answer: up to the extension author. Next level answer: maybe

Re: PostgreSQL vs SQL/XML Standards

2019-01-20 Thread Chapman Flack
On 01/20/19 17:13, Chapman Flack wrote: > On 01/20/19 12:48, Pavel Stehule wrote: >> regular Postgres' functions has evaluated all arguments before own >> execution. I think so this note is related much more to expressions used as >> defaults. > > Sure, but again,

Re: PostgreSQL vs SQL/XML Standards

2019-01-20 Thread Chapman Flack
On 01/20/19 20:07, Chapman Flack wrote: > So it appears that this example does not depend on any special treatment > of the default_expression. > > Is there an example that can be constructed that would depend on the > special treatment (in which case, the PL/Java implemen

Re: House style for DocBook documentation?

2019-01-21 Thread Chapman Flack
On 01/21/19 09:12, Alvaro Herrera wrote: >> (thinks to self half-seriously about an XSL transform for generating >> printed output that could preserve link-texted links, add raised numbers, >> and produce a numbered URLs section at the back) > > Well, if you have the time and inclination, and you

Re: House style for DocBook documentation?

2019-01-21 Thread Chapman Flack
On 01/21/19 12:07, Joshua D. Drake wrote: > Who is really going to "print" our docs? If they do print the > docs, they are likely not going to "type in" a long URL. QR code in footnote (ducks and runs).

Re: House style for DocBook documentation?

2019-01-21 Thread Chapman Flack
On 01/21/19 13:14, Joshua D. Drake wrote: >> Of course, the text would also be clickable, right? I think putting the >> URL in a footnote is good in that case; it works both on screen and on >> paper, which should alleviate JD's concerns. > > Yeah I could see that. I thought about that but was wo

Re: PostgreSQL vs SQL/XML Standards

2019-01-21 Thread Chapman Flack
Hi, In two places in the XMLTABLE implementation (XmlTableFetchRow, iterating through a nodeset returned by the row_expression, and XmlTableGetValue, going through a nodeset returned by the column_expression), the iteration proceeds in index order through xpathobj->nodesetval->nodeTab. The same h

Re: Allowing extensions to find out the OIDs of their member objects

2019-01-21 Thread Chapman Flack
On 01/21/19 18:52, Tom Lane wrote: > I'm probably going to push forward with the OID mapping idea instead. As it happens, I'd been recently thinking[1] about a way that certain SQL/XML functionality could be provided by a pluggable selection of different extensions. And I think a use case like th

Re: Allowing extensions to find out the OIDs of their member objects

2019-01-21 Thread Chapman Flack
On 01/21/19 21:45, Tom Lane wrote: > are concerned, but for cross-extension references it seems a > lot better to be looking for "postgis / function_foo_int_int" > than for "postgis / 3". I wonder if postgis might offer a .h file with FUNCTION_POSTGIS_FOO_INT_INT defined as 3, which extensions int

Re: ArchiveEntry optional arguments refactoring

2019-01-23 Thread Chapman Flack
On 1/23/19 10:12 AM, Dmitry Dolgov wrote: > To make this discussion a bit more specific, I've created a patch of how > it can look like. A little bit of vararg-macro action can make such a design look even tidier, cf. [1]. Or are compilers without vararg macros still in the supported mix? -Chap

Re: ArchiveEntry optional arguments refactoring

2019-01-23 Thread Chapman Flack
On 1/23/19 12:10 PM, Andres Freund wrote: > On 2019-01-23 12:05:10 -0500, Chapman Flack wrote: >> [1] https://github.com/NetBSD/src/blob/trunk/sys/sys/midiio.h#L709 > I'm not really seeing this being more than obfuscation in this case. The > only point of the macro is to

Re: ArchiveEntry optional arguments refactoring

2019-01-23 Thread Chapman Flack
On 1/23/19 12:25 PM, Andres Freund wrote: > On 2019-01-23 12:22:23 -0500, Chapman Flack wrote: >> ArchiveEntry(fout, dbCatId, dbDumpId, .tag = datname, .owner = dba, >> .desc = "DATABASE", .section = SECTION_PRE_DATA, >> .defn = creaQry-

Re: House style for DocBook documentation?

2019-01-25 Thread Chapman Flack
On 01/25/19 09:01, Peter Eisentraut wrote: > On 19/01/2019 21:24, Chapman Flack wrote: >> (thinks to self half-seriously about an XSL transform for generating >> printed output that could preserve link-texted links, add raised numbers, >> and produce a numbered URL

Re: PostgreSQL vs SQL/XML Standards

2019-01-25 Thread Chapman Flack
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested As the reporter of the issues raised in this email thread, I've revie

Re: PostgreSQL vs SQL/XML Standards

2019-01-25 Thread Chapman Flack
On 01/25/19 19:37, Chapman Flack wrote: > There is still nothing in this patch set to address [1], though that > also seems worth doing, perhaps in another patch, and probably not > difficult, perhaps needing only a regex. Heck, it could be even simpler than that. If some XML input has a

Re: PostgreSQL vs SQL/XML Standards

2019-01-25 Thread Chapman Flack
On 01/25/19 22:53, Pavel Stehule wrote: > Documentation review will be harder - I am not a native speaker and I have > not a necessary knowledges of XQuery (probably only you have this > knowledge). The doc patch is enough that I think it would be ideal to somehow attract a native speaker who has

Re: Early WIP/PoC for inlining CTEs

2019-01-29 Thread Chapman Flack
On 1/29/19 3:36 PM, Merlin Moncure wrote: > I hate to bikeshed here, but I think it's better english using that > style of syntax to say, > WITH ctename AS [ MATERIALIZATION { ON | OFF } ] ( query ) I had been just about to also engage in bikeshedding, on grounds that (to me) the MATERIALIZED/NOT

Re: PostgreSQL vs SQL/XML Standards

2019-02-05 Thread Chapman Flack
On 02/01/19 20:20, Michael Paquier wrote: > On Thu, Jan 31, 2019 at 04:26:31PM +0100, Pavel Stehule wrote: >> I'll mark this patch as ready for commiters. > > For now I have moved the patch to the next CF, with the same status. I wonder whether, given the move to next CF, it makes sense to change

Re: PostgreSQL vs SQL/XML Standards

2019-02-10 Thread Chapman Flack
Note: I sent an email last night with updated patches, which was not received because of a spamhaus reputation issue for my email provider. In working that out with my provider, at the moment I cannot send email at all, so I am using this comment to explain why the status went back to "needs re

Re: proposal: variadic argument support for least, greatest function

2019-02-11 Thread Chapman Flack
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested The argument for consistency with other functions that are variadic makes

Re: BUG #15629: Typo in Documentation

2019-02-11 Thread Chapman Flack
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:tested, passed This is a simple documentation change for which I do not see any controve

Re: BUG #15629: Typo in Documentation

2019-02-11 Thread Chapman Flack
hmm, cf app has not seen <5c621f9f.3020...@anastigmatix.net> yet ... changing status back until that happens. The new status of this patch is: Needs review

Re: 2019-02-14 Press Release Draft

2019-02-12 Thread Chapman Flack
On 02/12/19 22:00, Jonathan S. Katz wrote: > Attached is a draft of the press release for the upcoming 2019-02-14 > release. Feedback & suggestions are welcome. Users on PostgreSQL 9.4 should plan to upgrade to a supported version of PostgreSQL as the community will stop releasing fixes for i

Re: list append syntax for postgresql.conf

2019-02-20 Thread Chapman Flack
On 2/20/19 10:54 AM, Joe Conway wrote: >> shared_preload_libraries += 'pg_stat_statements' > > I like the idea, but presume it would apply to any GUC list, not just > shared_preload_libraries? It would be nice if there were some way for extensions to declare GUC lists (the very thing that rec

Re: proposal: variadic argument support for least, greatest function

2019-02-20 Thread Chapman Flack
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Latest patch passes installcheck-world as of d26a810 and does what it

Re: proposal: variadic argument support for least, greatest function

2019-02-21 Thread Chapman Flack
On 02/21/19 11:31, Pavel Stehule wrote: > I wrote doc (just one sentence) and minimal test. Both can be enhanced. Attaching minmax_variadic-20190221b.patch, identical but for s/supports/support/ and s/a/an/ in the doc. Regards, -Chap diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml in

Re: proposal: variadic argument support for least, greatest function

2019-02-21 Thread Chapman Flack
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed On 02/21/19 16:04, Tom Lane wrote: > Pavel Stehule writes: >> I

Re: proposal: variadic argument support for least, greatest function

2019-02-22 Thread Chapman Flack
On 02/22/19 14:57, Pavel Stehule wrote: > I am sending second variant (little bit longer, but the main code is not > repeated) minmax_variadic-20190222-3.patch same as -2 but for doc grammar fix (same fix made in minmax_variadic-20190221b.patch). Regards, -Chap

Re: proposal: variadic argument support for least, greatest function

2019-02-22 Thread Chapman Flack
On 02/22/19 19:31, Chapman Flack wrote: > minmax_variadic-20190222-3.patch same as -2 but for doc grammar fix > (same fix made in minmax_variadic-20190221b.patch). and naturally I didn't attach it. -Chap diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 86ff4e5c9e.

Re: proposal: variadic argument support for least, greatest function

2019-02-22 Thread Chapman Flack
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed The latest patch provides the same functionality without growing

Re: proposal: variadic argument support for least, greatest function

2019-02-23 Thread Chapman Flack
On 02/23/19 01:22, Pavel Stehule wrote: > so 23. 2. 2019 v 4:50 odesílatel Chapman Flack > napsal: >> In transformMinMaxExpr: >> The assignment of funcname doesn't look right. ... it still doesn't. >> Two new errors are elogs. ... >> I am not sure if

Re: proposal: variadic argument support for least, greatest function

2019-02-23 Thread Chapman Flack
On 02/23/19 13:35, Pavel Stehule wrote: > please, see, attached patch It is getting close, for my purposes. There is still this: >> Can the sentence added to the doc be changed to "These functions support >> passing parameters as an array after VARIADIC >> keyword."? That is, s/supports/support/

Re: Remove Deprecated Exclusive Backup Mode

2019-02-26 Thread Chapman Flack
On 2/26/19 2:46 PM, Andres Freund wrote: > Also, there's so much wrong stuff on the wiki that people that know to > look there just don't believe what they read. Should there be a wiki errata page on the wiki? I'm fairly serious ... for those times when you're reading the Foo page on the wiki, a

Re: Record last password change

2018-12-11 Thread Chapman Flack
On 12/11/18 9:56 AM, Tom Lane wrote: > I've heard that if you want to implement a password aging policy, PAM > authentication can manage that for you; but I don't know the details. Interesting idea ... could use pam-pgsql[1] and PAM as the authentication method. Might result in another connection

Re: 'infinity'::Interval should be added

2018-12-13 Thread Chapman Flack
On 12/13/18 04:41, Simon Riggs wrote: > SELECT 'infinity'::timestamp; > works > > SELECT 'infinity'::interval; > ERROR: invalid input syntax for type interval: "infinity" ... and if that is made to work, perhaps then arithmetic should be updated as well, with this producing an infinite interval

Re: Introducing SNI in TLS handshake for SSL connections

2018-12-13 Thread Chapman Flack
On 12/13/18 08:07, Andreas Karlsson wrote: > But I will attach my small patch for this, which I am now opposed to, anyway > so the code exists if a use case turns up in the future (or if it turns out > my reasoning above is incorrect). Here's the same patch with one small copy-pasto fixed. -Chap

Re: 'infinity'::Interval should be added

2018-12-17 Thread Chapman Flack
On 12/17/18 5:37 PM, Simon Riggs wrote: > postgres=# select 'infinity'::timestamp = 'infinity'::timestamp; > ?column? > -- > t I'm not persuaded that's a good idea, and would prefer to see an is_infinite() predicate, and an = operator that complains. But if the above is current behavior,

Re: GraalVM

2018-12-19 Thread Chapman Flack
On 12/19/18 07:42, Massimo Fidanza wrote: > Do you know about GraalVM (https://www.graalvm.org/)? This is a new > polyglot VM that can run in context of Oracle and MySql, I think that > supporting it on Postgresql will be a good thing. PL/Java will run on it now ... just set pljava.libjvm_location

Re: PostgreSQL vs SQL/XML Standards

2018-12-29 Thread Chapman Flack
On 11/12/18 04:58, Pavel Stehule wrote: > It is assigned to January commitfest. When I build this patch against master (4203842), it builds, but breaks make check. The diffs seem only incidental (loss of some error context output), but there are no make check errors building 4203842 unmodified, so

Re: Re: tracking owner of extension-managed objects

2018-12-29 Thread Chapman Flack
On 12/31/15 16:49, Chapman Flack wrote: > Ok, how numerous would be the problems with this: > > - The classid and refclassid columns (in both pg_shdepend and pg_depend) > are currently Oid columns referencing pg_class.oid. The catalog > definition would not preclude putting t

Re: PostgreSQL vs SQL/XML Standards

2018-12-30 Thread Chapman Flack
On 12/30/18 03:23, Pavel Stehule wrote: > I agree with more stronger detail description about difference between > XPath, XPath2 and XQuery. > > Some like "The XPath 1.0 is ancestor of XPath 2.0, that is part of XQuery. > ..." I'll be happy to work on some wording to help detail the differences.

Re: PostgreSQL vs SQL/XML Standards

2018-12-30 Thread Chapman Flack
On 12/30/18 15:18, Pavel Stehule wrote: > ne 30. 12. 2018 v 20:06 odesílatel Chapman Flack > napsal: >> How difficult would it be to make the grammar constructs that currently >> accept "BY REF" (only as noise and ignore it) accept and ignore both BY REF >> an

doc: where best to add ~ 400 words to the manual?

2018-12-30 Thread Chapman Flack
I would like to add material to the manual, detailing the differences between the XPath 1.0 language supported in PG, and the XQuery/XPath 2.0+ expected by the standard. A good preview of what that would look like is the "related to version of XPath" wiki section at [1]. That wiki section (minus

Re: Unable to `make install` on MacOS in the latest master (68a13f28be)

2019-01-03 Thread Chapman Flack
On 1/3/19 10:47 AM, Andrew Alsup wrote: > cp ./*.h '/usr/local/pgsql/include/server'/ > cp: ./dynloader.h: No such file or directory Has dynloader.h somehow ended up as a symbolic link to a file no longer present? Perhaps influenced by commit 842cb9f ? -Chap

Re: Ryu floating point output patch

2019-01-10 Thread Chapman Flack
Does the project have an established view on non-ASCII names in sources or docs? AFAICS [1], the name of the algorithm may be Ryū. -Chap [1] https://dl.acm.org/citation.cfm?id=3192369

<    1   2   3   4   5   6   7   >