Re: Reports on obsolete Postgres versions

2024-03-13 Thread Bruce Momjian
eSQL quarterly maintenance updates. > I think "minor" is a better term since it contrasts with "major". We don't actually supply patches to upgrade minor versions. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: GROUP BY ALL

2023-01-06 Thread Bruce Momjian
way the GROUP BY is for the reader, not for the database server. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Is OpenSSL AES-NI not available in pgcrypto?

2023-01-06 Thread Bruce Momjian
, I think you need to construct a single large query that calls many pgcrypto functions, with a small return result, so the network, parsing, and optimizer overhead are minimal compared to the OpenSSL overhread. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Support for dumping extended statistics

2023-01-06 Thread Bruce Momjian
re any interest from postgres side. There is certainly interest in allowing the optimizer statistics to be dumped and reloaded. This could be used by pg_restore and pg_upgrade. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.co

Re: cutting down the TODO list thread

2023-01-17 Thread Bruce Momjian
ort. Such items should be retired to the Not Worth Doing page. > > [D] marks changes that are done, and will appear in the PostgreSQL 16 release. I think we risk overloading people with too many words above, and they will not read it fully. Can it be simplified? I wonder if some of

Re: cutting down the TODO list thread

2023-01-17 Thread Bruce Momjian
ODO' at all. > > There is also > > https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F#TODOs > > Changing the description of what links to the todo list will probably do more > to reduce confusion than language in the todo list itself. Agreed. -- Bruce Momjian ht

Re: document the need to analyze partitioned tables

2023-01-17 Thread Bruce Momjian
queries may rely on a partitioned table's statistics, you should > collect statistics via the ANALYZE command when it is first populated, > and again whenever the distribution of data in its partitions changes > significantly. Uh, what about autovacu

Re: document the need to analyze partitioned tables

2023-01-17 Thread Bruce Momjian
On Tue, Jan 17, 2023 at 03:00:50PM -0600, Justin Pryzby wrote: > On Tue, Jan 17, 2023 at 03:53:24PM -0500, Bruce Momjian wrote: > > On Thu, Jan 12, 2023 at 03:27:47PM -0800, Nathan Bossart wrote: > > > Here is my take on the wording: > > > > > > Since all

Re: document the need to analyze partitioned tables

2023-01-18 Thread Bruce Momjian
On Wed, Jan 18, 2023 at 11:49:19AM -0600, Justin Pryzby wrote: > On Wed, Jan 18, 2023 at 10:15:18AM +0100, Laurenz Albe wrote: > > On Tue, 2023-01-17 at 16:16 -0500, Bruce Momjian wrote: > > > On Tue, Jan 17, 2023 at 03:00:50PM -0600, Justin Pryzby wrote: > > > > Mayb

Re: document the need to analyze partitioned tables

2023-01-18 Thread Bruce Momjian
On Wed, Jan 18, 2023 at 10:15:18AM +0100, Laurenz Albe wrote: > On Tue, 2023-01-17 at 16:16 -0500, Bruce Momjian wrote: > > On Tue, Jan 17, 2023 at 03:00:50PM -0600, Justin Pryzby wrote: > > > Maybe (all?) the clarification the docs need is to say: > > > "Partit

Unicode grapheme clusters

2023-01-18 Thread Bruce Momjian
bove. tsearch has p_isspecial() calls pg_dsplen() which also uses pg_wchar_table.dsplen. p_isspecial() also has a small table of what it calls "strange_letter", Here is a report about Unicode variation selector and combining characters from May, 2022: https://www.postgresql.o

Re: Moving forward with TDE

2023-03-27 Thread Bruce Momjian
effort > independent of that, of course. I will not be attending Ottawa. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Moving forward with TDE

2023-03-27 Thread Bruce Momjian
On Tue, Mar 28, 2023 at 12:01:56AM +0200, Stephen Frost wrote: > Greetings, > > On Mon, Mar 27, 2023 at 12:38 Bruce Momjian wrote: > > On Wed, Mar  8, 2023 at 04:25:04PM -0500, Stephen Frost wrote: > > Agreed, though the latest efforts include an opti

Re: Moving forward with TDE

2023-03-27 Thread Bruce Momjian
etting from commercial providers until we > implement them ultimately anyway.  This particular argument simply doesn’t > seem > to actually hold the value that proponents of it claim, for us at least, and > we > have clear counter-examples which we can point to and I hope we

Re: Moving forward with TDE

2023-03-27 Thread Bruce Momjian
> While it’s easy to label something as checkbox, I don’t feel we have > been > fair > > No, actually, it isn't.  I am not sure why you are saying that. > > I’m confused as to what is required to label a feature as a “checkbox” feature > then. What did you us

Re: pgindent vs. git whitespace check

2023-03-29 Thread Bruce Momjian
impossible back-patching problem. > > Yeah, that sounds incredibly invasive. I am replying late here but ... We would have to convert all supported branches, and tell all forks to do the same (hopefully at the same time). The new standard would then be for all sing

Re: is_superuser is not documented

2023-03-29 Thread Bruce Momjian
w.html, but the GUC > fields were never updated. > > Is there a reason that it never got merged or was it just forgotten > about? Uh, where are you looking? I see it in the SGML, and in the PG 15 docs: https://www.postgresql.org/docs/current/sql-show.html IS_SUPERUSER

Re: pgindent vs. git whitespace check

2023-03-30 Thread Bruce Momjian
On Wed, Mar 29, 2023 at 08:26:23PM +0200, Daniel Gustafsson wrote: > > On 29 Mar 2023, at 19:18, Bruce Momjian wrote: > > We would have to convert all supported branches, and tell all forks to > > do the same (hopefully at the same time). The new standard would then > >

Re: Images storing techniques

2023-03-30 Thread Bruce Momjian
hon since pgsql doesn't allow you to > interact with the file system).  You might want to read this blog entry: https://momjian.us/main/blogs/pgblog/2017.html#November_6_2017 -- Bruce Momjian https://momjian.us EDB https://enterpris

Re: Partial aggregates pushdown

2023-03-30 Thread Bruce Momjian
ink that is what this patch does. First, am I correct? Second, how far away is this from being committable and/or what work needs to be done to get it committable, either for PG 16 or 17? -- Bruce Momjian https://momjian.us EDB

Negative cache entries for memoize

2023-04-05 Thread Bruce Momjian
this been considered or is it planned? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Negative cache entries for memoize

2023-04-05 Thread Bruce Momjian
On Thu, Apr 6, 2023 at 09:23:31AM +1200, David Rowley wrote: > On Thu, 6 Apr 2023 at 03:12, Bruce Momjian wrote: > > During two presentations, I was asked if negative cache entries were > > created for cases where inner-side lookups returned no rows. > > > > It seems

Re: Partial aggregates pushdown

2023-04-06 Thread Bruce Momjian
g_serialize', aggcombinefn => 'numeric_avg_combine', + aggserialfn => 'numeric_avg_serialize', + aggdeserialfn => 'numeric_avg_deserialize', + aggtranstype => 'internal', aggtransspace => '128' }, Why are these marked as '

Re: Partial aggregates pushdown

2023-04-07 Thread Bruce Momjian
ce => '48' }, > > > > ... > > > > +{ aggfnoid => 'sum_p_numeric', aggtransfn => 'numeric_avg_accum', > > + aggfinalfn => 'numeric_avg_serialize', aggcombinefn => > > +'numeric_avg_combine', > > + aggserialfn => 'numeric_avg_serialize', > > + aggdeserialfn => 'numeric_avg_deserialize', > > + aggtranstype => 'internal', aggtransspace => '128' }, > > > > Why are these marked as 'sum' but use 'avg' functions? > This reason is that sum(int8)/sum(numeric) shares some functions with > avg(int8)/avg(numeric), > and sum_p_int8 is aggpartialfn of sum(int8) and sum_p_numeric is aggpartialfn > of sum(numeric). Ah, I see this now, thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Partial aggregates pushdown

2023-04-07 Thread Bruce Momjian
On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > What I don't want is an error-prone setup where administrators have to > > remember what the per-server settings are. Based on your suggestion, > > let's allow

Re: Partial aggregates pushdown

2023-04-07 Thread Bruce Momjian
On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > >> Uh, what? Why would we not be able to tell from the remote server's > >> version number whether it has this ab

Re: Partial aggregates pushdown

2023-04-07 Thread Bruce Momjian
On Fri, Apr 7, 2023 at 10:53:53PM -0400, Bruce Momjian wrote: > On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > > >> Uh, what? Why would we not be able to

Re: Partial aggregates pushdown

2023-04-08 Thread Bruce Momjian
On Fri, Apr 7, 2023 at 09:16:14PM -0700, Andres Freund wrote: > On 2023-04-07 22:53:53 -0400, Bruce Momjian wrote: > > > postgres_fdw has no business pushing down calls to non-builtin functions > > > unless the user has explicitly authorized that via the existing > > &

Re: Partial aggregates pushdown

2023-04-08 Thread Bruce Momjian
On Sat, Apr 8, 2023 at 10:15:40AM -0400, Bruce Momjian wrote: > On Fri, Apr 7, 2023 at 09:16:14PM -0700, Andres Freund wrote: > > extensions (string) > > > > This option is a comma-separated list of names of PostgreSQL extensions > > that are installed, in compa

Re: Partial aggregates pushdown

2023-04-12 Thread Bruce Momjian
taind in extensions list of the postgres_fdw's foreign server. Yes, good. Did we never push down aggregates before? I thought we pushed down partitionwise aggregates already, and such a check should already be done. If the check isn't there, it should be. > In the next version of this pa

Re: Partial aggregates pushdown

2023-04-12 Thread Bruce Momjian
On Thu, Apr 13, 2023 at 02:12:44AM -0400, Bruce Momjian wrote: > > In the next version of this patch, > > we can pushdown partial aggregate for an user-defined aggregate function > > only > > when the function pass through this check. > > Understood. In summary,

Re: Partial aggregates pushdown

2023-04-13 Thread Bruce Momjian
ser-defined aggregate. So, I will add such check to this > patch. > I think that this modification is easy to do . Good, so our existing code is correct and the patch just needs adjustment. -- Bruce Momjian https://momjian.us EDB https://

Re: run pgindent on a regular basis / scripted manner

2023-04-28 Thread Bruce Momjian
ed by a preprocessor before calling perltidy, and then removed on completion? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

createuser --memeber and PG 16

2023-05-10 Thread Bruce Momjian
s for improvement? At a minium I would like to apply the attached doc patch to PG 16 to improve awkward wording in CREATE ROLE and createuser. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you

Subscription suborigin?

2023-05-10 Thread Bruce Momjian
;t have an origin. If + any, the publisher sends changes regardless of their + origin. + + Is 'suborigin' the right column mame, and if so, should "The origin value" be "The suborigin value"

Re: Subscription suborigin?

2023-05-10 Thread Bruce Momjian
Never mind --- I just realized "sub" is the table prefix. :-( --- On Wed, May 10, 2023 at 03:36:31PM -0400, Bruce Momjian wrote: > This commit: > > commit 366283961a > Author: Amit Kapil

Re: createuser --memeber and PG 16

2023-05-11 Thread Bruce Momjian
On Thu, May 11, 2023 at 02:21:22PM +0200, Daniel Gustafsson wrote: > > On 10 May 2023, at 19:33, Bruce Momjian wrote: > > > I frankly don't > > know why --role matching CREATE ROLE ... ROLE IN was not already > > confusing in pre-PG 16. Any new ideas for imp

Re: Temporary file access API

2022-04-13 Thread Bruce Momjian
t the only table data that will make > its way into the file is for system catalogs. I guess that's not user > data *exactly* but ... are we sure that's how we want to roll here? I don't think we want to be encrypting pg_xact/, so they can get the transaction commit r

Re: Temporary file access API

2022-04-13 Thread Bruce Momjian
On Wed, Apr 13, 2022 at 06:54:13PM -0400, Robert Haas wrote: > On Wed, Apr 13, 2022 at 6:25 PM Bruce Momjian wrote: > > I don't think we want to be encrypting pg_xact/, so they can get the > > transaction commit rate from there. > > I think it would be a good idea to ev

Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas

2022-04-18 Thread Bruce Momjian
7;t know what statement of mine you're talking about here, and > while I don't love using up space for a nonce, it seems to be the way > this encryption stuff works. I don't see that there's a reasonable > alternative, green field or no. Uh, XTS doesn't require a no

effective_io_concurrency and NVMe devices

2022-04-19 Thread Bruce Momjian
ter "effective_io_concurrency" (0 .. 1000) Should we increase its maximum to 64k? Backpatched? (SATA has a maximum queue length of 256.) -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an

Re: orafce: some of the build time generated files are not present in .gitignore and also checked into the repository

2022-04-26 Thread Bruce Momjian
files, but the MSVC build doesn't generate them, so it is just easier to check them in after a make build so MSVC can use them, and another make run will just overwrite them. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: Wrong rows count in EXPLAIN

2022-04-27 Thread Bruce Momjian
g on the data-type-dependent width of > the table rows. > > Without this provision, we'd produce very bad plans for cases > where a newly-populated table hasn't been analyzed yet. We could have a noice mode that warns when a table without statistics is used. -- Bruce Momjia

Re: run pgindent on a regular basis / scripted manner

2023-10-18 Thread Bruce Momjian
all of that, committing is an anxiety-producing activity because any small mistake is quickly revealed to the world. There aren't many things I do in a day where mistakes are so impactful. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Postgres Architecture

2023-10-18 Thread Bruce Momjian
; > I'm going to include the words "architecture" and "replication" so that people > searching the archives in the future have more chance of finding this > conversation.  You can get some of this using foreign data wrappers to other Pos

Re: The documentation for storage type 'plain' actually allows single byte header

2023-10-20 Thread Bruce Momjian
On Fri, Sep 29, 2023 at 06:45:52PM -0400, Tom Lane wrote: > Laurenz Albe writes: > > On Fri, 2023-09-29 at 18:19 -0400, Bruce Momjian wrote: > >> Where did we end with this? Is a doc patch the solution? > > > I don't think this went anywhere, and a doc patch

Re: The documentation for storage type 'plain' actually allows single byte header

2023-10-21 Thread Bruce Momjian
On Fri, Oct 20, 2023 at 09:48:05PM -0400, Bruce Momjian wrote: > Here is the original thread from pgsql-docs: > > > https://www.postgresql.org/message-id/flat/167336599095.2667301.15497893107226841625%40wrigleys.postgresql.org > > The report is about single-byte head

Re: The documentation for storage type 'plain' actually allows single byte header

2023-10-21 Thread Bruce Momjian
On Sat, Oct 21, 2023 at 09:56:13PM -0400, Bruce Momjian wrote: > I did some more research. It turns out that the source slot/planSlot is > populating its pg_attribute information via makeTargetEntry() and it > has no concept of a storage type. > > Digging further, I found that we

Re: Partial aggregates pushdown

2023-10-23 Thread Bruce Momjian
n updated version you can use for future changes? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: run pgindent on a regular basis / scripted manner

2023-10-24 Thread Bruce Momjian
empty. --- |--- gitweb subject length limit |-email limit-| Reported-by: Diagnosed-by: Bug: Discussion: Author: Reviewed-by: Tested-by: Backpatch-through: -- Bruce Momjian https://momjian.us EDB

Re: Document aggregate functions better w.r.t. ORDER BY

2023-10-24 Thread Bruce Momjian
lly will be seen during a cursory reading.  Plus, > array_agg is the go-to function for doing this kind of experimentation. I like this idea, though the examples seemed too detailed so I skipped them. Here is the trimmed-down patch I would like to apply. -- Bruce Momjian https://momji

Re: Document aggregate functions better w.r.t. ORDER BY

2023-10-25 Thread Bruce Momjian
rder, as having an optional order by. The floating example seems too obscure to mention in our function docs. I can put a sentence in the syntax docs, but is there value in explaining that to users? How it that helpful? Example? -- Bruce Momjian https://momjian.us EDB

Re: Partial aggregates pushdown

2023-10-25 Thread Bruce Momjian
unction is defined on the remote server. The default is false. What does that marked sentence mean? What is match? Are one or both of these remote? It sounds like you are checking the local aggregate against the remote partial aggregate, but I don't see any co

Re: Document aggregate functions better w.r.t. ORDER BY

2023-10-25 Thread Bruce Momjian
dy got rid of > the > avg()s but the sum()s are still present, so just those two). Ah, yes, sum() removed. Updated patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important

Re: Document aggregate functions better w.r.t. ORDER BY

2023-10-25 Thread Bruce Momjian
essions must appear in > argument list > LINE 2: SELECT string_agg(DISTINCT l, ';' ORDER BY l, ';' DESC) FROM... > > But both expressions in the argument list (el and semicolon) do appear in the > ORDER BY... I think ORDER BY has to match DISTINCT columns, while

Re: Partial aggregates pushdown

2023-10-26 Thread Bruce Momjian
local server. > But, in v30, there is no code which checks the partial aggregate function has > the same OID as the aggregate function in local server. > So I modified the code of is_builtin_aggpartialfunc_shippable(). > Also, I modified wording postgres-fdw.sgml. Yes, that is what I needed. Attached is

Re: Document aggregate functions better w.r.t. ORDER BY

2023-10-26 Thread Bruce Momjian
-- > + {4,3,2,1} > + Okay, good, switched in the attached patch. > We get enough complaints regarding "apparent ordering" that I would like to > add: > > As a reminder, while some DISTINCT processing algorithms produce sorted output > as a side-effect, only by sp

Re: Document aggregate functions better w.r.t. ORDER BY

2023-10-26 Thread Bruce Momjian
On Thu, Oct 26, 2023 at 03:09:26PM -0700, David G. Johnston wrote: > On Thu, Oct 26, 2023 at 2:56 PM Bruce Momjian wrote: > > On Wed, Oct 25, 2023 at 10:34:10PM -0700, David G. Johnston wrote: > > I would reword the existing note to be something like: > > >

Re: Document parameter count limit

2023-10-26 Thread Bruce Momjian
On Wed, Nov 23, 2022 at 02:33:27PM -0600, Justin Pryzby wrote: > On Wed, Nov 23, 2022 at 12:35:59PM -0700, David G. Johnston wrote: > > On Wed, Nov 23, 2022 at 11:47 AM Tom Lane wrote: > > > > > Bruce Momjian writes: > > > > Does this come up enough to docu

Re: Document parameter count limit

2023-10-26 Thread Bruce Momjian
On Thu, Oct 26, 2023 at 06:56:40PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Here is a patch to add this. > > "function arguments" seems like a completely wrong description > (and if we do want to document that limit, it's 100). > > "query

Re: Document aggregate functions better w.r.t. ORDER BY

2023-10-26 Thread Bruce Momjian
On Thu, Oct 26, 2023 at 03:44:14PM -0700, David G. Johnston wrote: > On Thu, Oct 26, 2023 at 3:36 PM Bruce Momjian wrote: > > No sneaking.  ;-)  It would be bad to document this unevenly because it > sets expectations in other parts of the system if we don't mention i

Re: Document parameter count limit

2023-10-26 Thread Bruce Momjian
On Thu, Oct 26, 2023 at 04:17:19PM -0700, David G. Johnston wrote: > On Thu, Oct 26, 2023 at 4:13 PM David G. Johnston > wrote: > > On Thu, Oct 26, 2023 at 4:08 PM Tom Lane wrote: > > Bruce Momjian writes: > > Ah, I was confused.  I documented bo

Re: Partial aggregates pushdown

2023-10-26 Thread Bruce Momjian
I think the updated docs will help people understand how the patch works. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: request clarification on pg_restore documentation

2023-10-27 Thread Bruce Momjian
Does anyone have a suggestion on how to handle this issue? The report is a year old. --- On Thu, Oct 6, 2022 at 10:28:15AM -0400, Bruce Momjian wrote: > On Thu, Sep 29, 2022 at 02:30:13PM +, PG Doc comments f

Re: [PATCH] minor bug fix for pg_dump --clean

2023-10-27 Thread Bruce Momjian
accepted, but now I can see > that it is clearly useless. > > > > So I think mainly what we ought to do here is to adjust the > > documentation to make it clearer that --clean is not guaranteed > > to work without errors unless the target database has the same > >

Re: [PATCH v1] [doc] polish the comments of reloptions

2023-10-27 Thread Bruce Momjian
mall price to pay for allowing better > * plans to be introduced concurrently without interfering with users. > * > - * Setting parallel_workers is safe, since it acts the same as > - * max_parallel_workers_per_gather which is a USERSET parameter that doesn't > - * affect existing plans or queri

Re: doc: New cumulative stats subsystem obsoletes comment in maintenance.sgml

2023-10-27 Thread Bruce Momjian
and advance >      relfrozenxid; otherwise, only pages that have > been modified Done in master. > However, also replace the remaining instance of "a semi-accurate count" with > "an eventually-consistent count". > ...it is an eventually-consistent count updated by

Re: remove useless comments

2023-10-28 Thread Bruce Momjian
t; + * is there, then share/ probably is too. > */ > } Patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Why is DEFAULT_FDW_TUPLE_COST so insanely low?

2023-10-28 Thread Bruce Momjian
'22'::numeric) > + -> Foreign Scan on public.fpagg_tab_p3 t1_2 > + Output: t1_2.a, t1_2.*, t1_2.b > + Remote SQL: SELECT a, b, c FROM public.pagg_tab_p3 ORDER BY a > ASC NULLS LAST > +(23 rows) > > SELECT a, count(t1) FROM pag

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
ot; as "this makes > > sense, but this is currently a limitation that might be lifted > > later". > > FWIW I understand it the same way. I would like to apply the attached patch to master. Looking at your adjustments for ERRCODE_FEATURE_NOT_SUPPORTED to ERRCODE_INVALID_PA

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 08:38:26PM -0400, Bruce Momjian wrote: > I would like to apply the attached patch to master. Looking at your > adjustments for ERRCODE_FEATURE_NOT_SUPPORTED to > ERRCODE_INVALID_PARAMETER_VALUE, I only changed the cases where it would > be illogical to i

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 09:39:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > My apologies, wrong patch attached, right one attached now. > > I think this one is fine as-is: > > /* Only single-byte delimiter strings are supported. */ > if (strl

Re: COPY TO (FREEZE)?

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 09:54:05PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Sat, Oct 28, 2023 at 09:39:53PM -0400, Tom Lane wrote: > >> Not thrilled by the wording here. > > > I think it is modeled after: > > > errmsg("COPY

Re: COPY TO (FREEZE)?

2023-10-29 Thread Bruce Momjian
On Sun, Oct 29, 2023 at 02:50:37PM +0800, Mingli Zhang wrote: > I guess you want to write “cannot be used with COPY TO” You are 100% correct. Updated patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only

Re: COPY TO (FREEZE)?

2023-10-29 Thread Bruce Momjian
On Mon, Oct 30, 2023 at 05:07:48AM +0800, Mingli Zhang wrote: > > Bruce Momjian 于2023年10月30日周一03:35写道: > > On Sun, Oct 29, 2023 at 02:50:37PM +0800, Mingli Zhang wrote: > > I guess you want to write “cannot be used with COPY TO” > > You are 100% correct.

Re: COPY TO (FREEZE)?

2023-10-30 Thread Bruce Momjian
On Mon, Oct 30, 2023 at 03:16:58PM +0900, Kyotaro Horiguchi wrote: > At Sun, 29 Oct 2023 15:35:02 -0400, Bruce Momjian wrote in > > You are 100% correct. Updated patch attached. > > - errmsg("COPY force not null only availabl

Re: Why is DEFAULT_FDW_TUPLE_COST so insanely low?

2023-10-30 Thread Bruce Momjian
ck. I think you just go and change it. Your number is better than what we have, and if someone wants to suggest a better number, we can change it later. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: COPY TO (FREEZE)?

2023-10-30 Thread Bruce Momjian
On Mon, Oct 30, 2023 at 02:29:05PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > That is a good point. I reviewed more of the messages and added > > capitalization where appropriate, patch attached. > > This is starting to look pretty good. I have one more though

Re: [PATCH] postgresql.conf.sample comment alignment.

2023-10-31 Thread Bruce Momjian
p them all aligned) > - etc. > > I'm not saying replacing the tabs with spaces isn't a good idea - I > also agree probably it is, but that's a different problem to the > alignments I was trying to correct with the patch Patch applied to master. Perhaps someday we w

Re: The documentation for storage type 'plain' actually allows single byte header

2023-10-31 Thread Bruce Momjian
On Sat, Oct 21, 2023 at 09:59:04PM -0400, Bruce Momjian wrote: > On Sat, Oct 21, 2023 at 09:56:13PM -0400, Bruce Momjian wrote: > > I did some more research. It turns out that the source slot/planSlot is > > populating its pg_attribute information via makeTargetEntry() and it >

Re: Document parameter count limit

2023-10-31 Thread Bruce Momjian
On Thu, Oct 26, 2023 at 11:04:47PM -0400, Bruce Momjian wrote: > On Thu, Oct 26, 2023 at 04:17:19PM -0700, David G. Johnston wrote: > > On Thu, Oct 26, 2023 at 4:13 PM David G. Johnston > > > > wrote: > > > > On Thu, Oct 26, 2023 at 4:08 PM Tom Lane wrot

Re: Should fix a comment referring to stats collector?

2023-10-31 Thread Bruce Momjian
the explanation! > > > Maybe it should just say "K may be chosen at ANALYZE time". > > It seems clearer than current one. Change made in master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Official Windows Installer and Documentation

2023-10-31 Thread Bruce Momjian
ke pg_basebackup has (though obviously pg_upgrade is procedural). I have developed the attached patch to remove RUNAS and SET PATH, neither of which appear anywhere else in our docs. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com

Re: Official Windows Installer and Documentation

2023-10-31 Thread Bruce Momjian
On Tue, Oct 31, 2023 at 11:16:29AM -0400, Bruce Momjian wrote: > On Wed, Jul 27, 2022 at 09:28:51PM -0700, David G. Johnston wrote: > > On Wed, Jul 27, 2022 at 8:22 PM Tom Lane wrote: > > > > I wrote: > > > If EDB isn't adequately filling in

Re: doc: Make selectivity example match wording

2023-10-31 Thread Bruce Momjian
is helpful. > > "This value does get scaled in the non-unique case" again could be more > specific ("since here all values are unique, otherwise the calculation > uses num_distinct" perhaps?). But past that quibble I'm good. Patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Add lasterrno setting for dir_existsfile()

2023-10-31 Thread Bruce Momjian
On Sat, Aug 13, 2022 at 02:46:24PM +0530, Bharath Rupireddy wrote: > On Sat, Aug 13, 2022 at 4:34 AM Bruce Momjian wrote: > > > > On Fri, Aug 12, 2022 at 06:22:01PM -0400, Bruce Momjian wrote: > > > On Mon, Jan 10, 2022 at 12:19:28AM +0800, Wei Sun wrote: > > > &g

Re: Question about non-blocking mode in libpq

2023-10-31 Thread Bruce Momjian
t I would like to apply to all supported versions. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml index 64b2910fee..d

Re: Question about non-blocking mode in libpq

2023-10-31 Thread Bruce Momjian
On Tue, Oct 31, 2023 at 01:58:34PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I modified your patch, attached, that I would like to apply to all > > supported versions. > > This seems to have lost the information about what to do if these > functions fail. I

Re: Moving forward with TDE [PATCH v3]

2023-10-31 Thread Bruce Momjian
nd should be split up a bit more > to > make things more granular and easier to review, but I wanted to get this > update > out. This lacks temp table file encryption, right? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Moving forward with TDE [PATCH v3]

2023-10-31 Thread Bruce Momjian
On Tue, Oct 31, 2023 at 04:32:38PM -0500, David Christensen wrote: > On Tue, Oct 31, 2023 at 4:30 PM Bruce Momjian wrote: > Temporary /files/ are handled in a different patch set and are not included > here (not sure of the status of integrating at this point). I  believe that > this

Re: Question about non-blocking mode in libpq

2023-10-31 Thread Bruce Momjian
On Tue, Oct 31, 2023 at 09:11:06PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Okay, I added "_successful_ calls", attached. I am not sure what else > > to add. > > What I'm objecting to is removal of the bit about "if they need to be > called

Re: Question about non-blocking mode in libpq

2023-11-01 Thread Bruce Momjian
On Tue, Oct 31, 2023 at 10:16:07PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Oct 31, 2023 at 09:11:06PM -0400, Tom Lane wrote: > >> What I'm objecting to is removal of the bit about "if they need to be > >> called again". That pro

Re: "box" type description

2023-11-01 Thread Bruce Momjian
ause the output has no space * I spelled out "point" instead of "pt" * "line" has two very different input formats so I listed both (more different than others like boolean) * I didn't see the need to say "datatype" for LSN and UUID * I improved the tx

Re: Confused about stream replication protocol documentation

2023-11-01 Thread Bruce Momjian
ver can send > + WAL data is sent as a series of CopyData messages > + (See and linkend="protocol-message-formats"/>). > + (This allows other information to be intermixed; in particular the > server can send >an ErrorResponse message if it enco

Re: document deviation from standard on REVOKE ROLE

2023-11-01 Thread Bruce Momjian
QL, > +this will also revoke privileges granted by other roles. > + > > > John, should this 2020 patch still be applied? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: document deviation from standard on REVOKE ROLE

2023-11-01 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 07:49:25PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Oct 30, 2020 at 02:03:48PM -0400, John Naylor wrote: > >> +In the SQL standard, REVOKE only revokes the > >> privilege > >> +as granted by the invoking role.

Re: Why is DEFAULT_FDW_TUPLE_COST so insanely low?

2023-11-01 Thread Bruce Momjian
suit better. > > No takers on the additional testing so I've pushed the patch that > increases it to 0.2. Great! Thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Three commit tips

2023-11-02 Thread Bruce Momjian
ot;$(wc -l < /tmp/$$)" -gt 1 ] thenecho "pgindent failure in master branch, exiting." 1>&2 cat /tmp/$$ exit 1 fi -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: "box" type description

2023-11-02 Thread Bruce Momjian
ed; see pg_snapshot)< Do we want to add "deprecated" in the output. > pg_brin_bloom_summary, pg_brin_minmax_multi_summary, pg_mcv_list and many: > > I'm uncertain whether these types, which lack an input syntax (but > have an output format), qualify as

Re: Possible typo in nodeAgg.c

2023-11-02 Thread Bruce Momjian
* work mem anyway. > + * hash_mem anyway. Can someone comment on this? Is the text change correct? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

<    5   6   7   8   9   10   11   12   13   14   >