Re: Comment typo in tableam.h

2019-07-11 Thread Brad DeJong
More typos in tableam.h along with a few grammar changes. v1-more-typos-in-tableam.h.patch Description: Binary data

Re: PostgreSQL vs SQL Standard

2018-06-30 Thread Brad DeJong
On Sat, Jun 9, 2018 at 8:37 PM, Andrew Gierth wrote: > I think I got all the issues I currently know of, but there may be > more, and others may disagree with my classification of issues or the > rationales for violating the spec. Any feedback? Related to, but I think distinct from "Trailing

Re: Postgres 11 release notes

2018-06-30 Thread Brad DeJong
I suggest the following edits for the PostgreSQL beta 2 release announcement. I did not provide the edits as a patch because I can't find the source of /about/news/1867. - This release contains ... as well as bug fixes that were reported ... + This release contains ... as well as fixes for bugs th

grammar - src/backend/access/heap/README.tuplock

2018-07-21 Thread Brad DeJong
The sentences in question currently read ... Finally, SELECT FOR KEY SHARE obtains a shared lock which only prevents tuple removal and modifications of key fields. This last mode implements a mode just strong enough to implement RI checks, i.e. it ensures that tuples do not go away from under a ch

Re: Constraint documentation

2018-06-25 Thread Brad DeJong
On 25/06/18 17:45, Lætitia Avrot wrote: > + > + > + Check constraint are not designed to enforce business rules across tables. > + Avoid using check constraints with function accessing other tables and Subject/verb agreement - either "A check constraint is ..." or "Check constraint

Re: Constraint documentation

2018-06-26 Thread Brad DeJong
On Tue, Jun 26, 2018 at 4:24 AM, Vik Fearing wrote: > Looks good to me. I'll second that. Looks good to me too.

Re: Re[3]: doc - improve description of default privileges

2018-09-14 Thread Brad DeJong
On 2018-09-12 Tom Lane wrote ... > The reviewer does that, indicating signoff. Thanks. I have now changed the status to "Ready for Committer".