Re: Possible fails in pg_stat_statements test

2022-03-20 Thread Anton A. Melnikov
Hello! Here is the second version of the patch rebased onto the current master. No logical changes. All other attached files from previous letter are actual. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit

Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

2021-12-21 Thread Anton A. Melnikov
didn't find any evident problems. Contrib installcheck said: test pg_stat_statements ... ok 163 ms test oldextversions ... ok 46 ms With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Possible fails in pg_stat_statements test

2022-01-14 Thread Anton A. Melnikov
ry, calls, rows, wal_records, and replace the contrib/pg_stat_statements/expected/pg_stat_statements.out with attached pg_stat_statements-fast.out With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company commit 3f4659a8d8a390bb24fbc6f

Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

2021-10-18 Thread Anton A. Melnikov
On 07.10.2021 15:31, Andrei Zubkov wrote: > There is an issue with this patch. It's main purpose is the ability to > calculate values of pg_stat_statements view >  [...] > Does addition of resettable min/max metrics to the > pg_stat_statemets view seems reasonable here? Hello, Andrey! I think it

Re: ResourceOwner refactoring

2024-01-16 Thread Anton A. Melnikov
, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: ResourceOwner refactoring

2024-01-16 Thread Anton A. Melnikov
On 16.01.2024 14:54, Heikki Linnakangas wrote: Fixed, thanks. mark_pgdllimport.pl also highlighted two new variables in walsummarizer.h, fixed those too. Thanks! Have a nice day! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-02-24 Thread Anton A. Melnikov
600/ [2] https://github.com/ut-osa/txfs [3] https://en.wikipedia.org/wiki/Transactional_NTFS[4] https://www.postgresql.org/docs/devel/wal-internals.html With the best wishes! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-03-07 Thread Anton A. Melnikov
ly, that'd be just like the way we use FPI for data pages copied during a backup. I'm not sure about any of that, though, it's just an idea, not tested. Sorry, i didn't understand the question about log. Would you explain me please what kind of log did you mention and wher

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-03-08 Thread Anton A. Melnikov
yours, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2023-03-16 Thread Anton A. Melnikov
e it easier for a committer to understand the state There are two different patch variants and some discussion expected. So moved them to the next CF. With the best wishes! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit 6f3ab7b6b5562aaf68ccfdd6dd

Re: [BUG] Logical replica crash if there was an error in a function.

2023-03-16 Thread Anton A. Melnikov
with "my" variable $result and suggestion to correct comment (by vignesh C) Both fixed in v4. Now there are no any pending questions, so moved it to RFC. With the best regards! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit 16beb57

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2024-03-14 Thread Anton A. Melnikov
On 14.03.2024 03:19, Alexander Korotkov wrote: Pushed. Thanks! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Add the ability to limit the amount of memory that can be allocated to backends.

2024-03-14 Thread Anton A. Melnikov
On 13.03.2024 10:41, Anton A. Melnikov wrote: Here is a version updated for the current master. During patch updating i mistakenly added double counting of deallocatated blocks. That's why the tests in the patch tester failed. Fixed it and squashed fix 0002 with 0001. Here is fixed ve

Re: Bug in nbtree optimization to skip > operator comparisons (or < comparisons in backwards scans)

2024-03-22 Thread Anton A. Melnikov
ot; in the last arg does not match the previous code before 06b10f80ba and the current comment above. Would be very grateful for clarification. With the best regards! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Bug in nbtree optimization to skip > operator comparisons (or < comparisons in backwards scans)

2024-03-22 Thread Anton A. Melnikov
On 22.03.2024 11:02, Pavel Borisov wrote: Attached is a fix. Thanks! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [PATCH] kNN for btree

2024-04-02 Thread Anton A. Melnikov
Hi, Andrey! On 31.03.2024 12:22, Andrey M. Borodin wrote: On 15 Jan 2024, at 13:11, Anton A. Melnikov wrote: If there are any ideas pro and contra would be glad to discuss them. Hi, Anton! This is kind of ancient thread. I've marked CF entry [0] as "Needs review" and y

Re: effective_multixact_freeze_max_age issue

2024-04-04 Thread Anton A. Melnikov
too. Additional check for relminxid allows to disable agressive scan at all if it is invalid. But i'm not sure if such a check is needed here. Please take it into account. With kindly regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companyc

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2024-03-10 Thread Anton A. Melnikov
took a fresh look at this patch i noticed a simple way to extract write_time and sync_time counters for restartpoints too. What do you think, is there a sense to do this? With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Add the ability to limit the amount of memory that can be allocated to backends.

2024-03-13 Thread Anton A. Melnikov
On 12.03.2024 16:30, Aleksander Alekseev wrote: Just wanted to let you know that v20231226 doesn't apply. The patch needs love from somebody interested in it. Thanks for pointing to this! Here is a version updated for the current master. With the best regards, -- Anton A. Melnikov Pos

Re: [BUG] Logical replica crash if there was an error in a function.

2022-12-10 Thread Anton A. Melnikov
eund Thank you for reminding! There was a conflict when applying v2 on current master. Rebased v3 is attached. Best wishes! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit 07eaa674953ed700a53174410a6e1eb81151d7e8 Author: Anton A. Melnikov D

[BUG] pg_upgrade test fails from older versions.

2022-12-18 Thread Anton A. Melnikov
is, i propose to replace any specific GRANT and REVOKE in the result dumps with ALL. This also made in the patch attached. Would be glad to any remarks. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit e2c917694acc7

Re: [PATCH] Backport perl tests for pg_upgrade from 322becb60

2022-12-18 Thread Anton A. Melnikov
Hello! On 09.12.2022 08:19, Michael Paquier wrote: On Mon, Aug 01, 2022 at 01:02:21AM +0300, Anton A. Melnikov wrote: As far as i understand from this thread: https://www.postgresql.org/message-id/flat/Yox1ME99GhAemMq1%40paquier.xyz, the aim of the perl version for the pg_upgrade tests is to

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-21 Thread Anton A. Melnikov
upgrade.pl a small-ish hook in the shape of a new environment variable pointing to a file adds some custom filtering rules? Yes. Made a hook that allows to proceed an external text file with additional filtering rules and example of such file. Please take a look o

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-23 Thread Anton A. Melnikov
; END LOOP; END; $$; Average execution time for three times: _ |N of query: | 1 | 2 | 3 | 4 | | |Avg time, ms: | 58 | 1076 | 51 | 33 | | Raw results in timing.txt Best wishes, -- An

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-23 Thread Anton A. Melnikov
oid AND a.atttypid = 'aclitem'::regtype ORDER BY 1 LOOP EXECUTE 'ALTER TABLE ' || quote_ident(rec.rel) || ' ALTER COLUMN ' || quote_ident(rec.col) || ' SET DATA TYPE text'; END LOOP; END; $$; gives the average time of 36 ms at t

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-25 Thread Anton A. Melnikov
Hello! On 23.12.2022 05:42, Michael Paquier wrote: On Thu, Dec 22, 2022 at 09:59:18AM +0300, Anton A. Melnikov wrote: 2) v2-0002-Additional-dumps-filtering.patch + # Replace specific privilegies with ALL + $dump_contents =~ s/^(GRANT\s|REVOKE\s)(\S*)\s/$1ALL /mgx; This should not

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-27 Thread Anton A. Melnikov
in the external files. I would like to try realize this, better in a separate thread. If there are no other considerations could you close the corresponding record on the January CF, please? With the best wishes! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-27 Thread Anton A. Melnikov
On 27.12.2022 16:50, Michael Paquier wrote: If there are no other considerations could you close the corresponding record on the January CF, please? Indeed, now marked as committed. - Thanks a lot! Merry Christmas! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The

Re: [BUG] Logical replica crash if there was an error in a function.

2023-01-07 Thread Anton A. Melnikov
tter message: +# This would crash on the subscriber if not fixed +$node_publisher->safe_psql('postgres', "INSERT INTO tab1 VALUES (3, 4)"); + +my $result = $node_subscriber->wait_for_log( + "ERROR: relation \"error_name\" does not exis

Re: [BUG] Logical replica crash if there was an error in a function.

2023-04-05 Thread Anton A. Melnikov
Hello! On 03.04.2023 21:49, Tom Lane wrote: "Anton A. Melnikov" writes: Now there are no any pending questions, so moved it to RFC. I did not think this case was worth memorializing in a test before, and I still do not. I'm inclined to reject this patch. Earlier, when

Re: [BUG] Logical replica crash if there was an error in a function.

2023-04-06 Thread Anton A. Melnikov
On 05.04.2023 17:35, Tom Lane wrote: "Anton A. Melnikov" writes: On 03.04.2023 21:49, Tom Lane wrote: I did not think this case was worth memorializing in a test before, and I still do not. I'm inclined to reject this patch. Could you help me to figure out, please. The

Re: Making Vars outer-join aware

2023-05-04 Thread Anton A. Melnikov
context->rt_index >= 0 && context->new_index >= 0) + var->varnullingrels = adjust_relid_set(var->varnullingrels, + context->rt_index, + With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Possible fails in pg_stat_statements test

2022-03-29 Thread Anton A. Melnikov
i suppose there is a non-zero probability that such error can occur in the one-shot test as well. The sequence given in the first letter helps to catch this failure quickly. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgre

Re: Possible fails in pg_stat_statements test

2022-03-31 Thread Anton A. Melnikov
new counter is the right idea. Indeed. Then there is a very simple solution for this particular case as wal_records counter may only sometime becomes greater but never less. The corresponding patch is attached. With best regards, -- Anton A. Melnikov Postgr

Re: Some performance degradation in REL_16 vs REL_15

2023-10-16 Thread Anton A. Melnikov
n. Thanks for your interest! With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: remaining sql/json patches

2023-10-16 Thread Anton A. Melnikov
7;) ); INSERT INTO test_jsonb_constraints VALUES ('[]'); one expected to see an error like that: ERROR: new row for relation "test" violates check constraint "test_constraint" DETAIL: Failing row contains ([], null, [1, 2]). not "INSERT 0 1" With

Re: remaining sql/json patches

2023-10-17 Thread Anton A. Melnikov
[] (1 row) And at the moment i havn't found any side effects of that fix. Please point me if i'm missing something. With the best wishes! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

003_check_guc.pl crashes if some extensions were loaded.

2023-11-01 Thread Anton A. Melnikov
LE' = ANY (pg_settings_get_flags(name)) AND - name <> 'config_file' + name <> 'config_file' AND name NOT LIKE '%.%' ORDER BY 1"); With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Ru

Re: 003_check_guc.pl crashes if some extensions were loaded.

2023-11-01 Thread Anton A. Melnikov
On 02.11.2023 01:53, Michael Paquier wrote:> On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote: Found that src/test/modules/test_misc/t/003_check_guc.pl will crash if an extension that adds own GUCs was loaded into memory. So it is now impossible to run a check-world w

Re: Some performance degradation in REL_16 vs REL_15

2023-11-15 Thread Anton A. Melnikov
. Probably something wrong with my pc, but now i can not figure out what's wrong. Would be very grateful for any advice or comments to clarify this problem. With the best wishes! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company REL_10_STABL

Should timezone be inherited from template database?

2023-11-26 Thread Anton A. Melnikov
please. Is this normal, predictable behavior? Would be very grateful! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Should timezone be inherited from template database?

2023-11-26 Thread Anton A. Melnikov
GRANT) are not copied from the template database. Clear. Thank you very much! With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2023-12-03 Thread Anton A. Melnikov
e glad for any comments and and concerns. With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit 5711c09dbfbe02586a247a98e0ae41cd71a221a3 Author: Anton A. Melnikov Date: Sun Dec 3 12:49:11 2023 +0300

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2023-12-25 Thread Anton A. Melnikov
On 25.12.2023 02:38, Alexander Korotkov wrote: Pushed! Thanks a lot! With the best regards! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Some performance degradation in REL_16 vs REL_15

2023-10-12 Thread Anton A. Melnikov
. How do you think, is there any cause for concern here? And is it worth spending time bisecting for the commit where this degradation may have occurred? Would be glad for any comments and concerns. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The

Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

2022-01-24 Thread Anton A. Melnikov
, make check-world and CI gives no error and patch seems to be closely to become RFC. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

2022-02-07 Thread Anton A. Melnikov
ue of reset request flag into the aux view to give feedback to the external application that reset was requested. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [BUG] Logical replica crash if there was an error in a function.

2022-11-14 Thread Anton A. Melnikov
en checking for specific error messages. Seems it is possible to do a test without these remarks. The attached test uses existing nodes and checks the specific error message. Additionally i've tried to reduce overall number of nodes previously used in this test in a similar way. Would be

Make a 100_bugs.pl test more faster.

2022-11-16 Thread Anton A. Melnikov
Hello! The previous discussion was here: https://www.postgresql.org/message-id/flat/b570c367-ba38-95f3-f62d-5f59b9808226%40inbox.ru On 15.11.2022 04:59, Tom Lane wrote: "Anton A. Melnikov" writes: Additionally i've tried to reduce overall number of nodes previously used in

Re: [BUG] Logical replica crash if there was an error in a function.

2022-11-16 Thread Anton A. Melnikov
buildfarm animals are going to run the tests in the future. On 15.11.2022 04:59, Tom Lane wrote: "Anton A. Melnikov" writes: On 02.11.2022 21:02, Tom Lane wrote: I don't think the cost of that test case is justified by the tiny probability that it'd ever catch anyt

Re: [PATCH] Add peer authentication TAP test

2022-11-24 Thread Anton A. Melnikov
x27; May be disable this test for windows like in 001_password.pl and 002_saslprep.pl? Best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit e4491b91729b307d29ce0205b455936b3a538373 Author: Anton A. Melnikov Date: Fri Nov 25 07:40:11

Re: [PATCH] Add peer authentication TAP test

2022-11-24 Thread Anton A. Melnikov
d. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company2022-11-25 09:55:49.731 MSK [7648] LOG: starting PostgreSQL 16devel, compiled by Visual C++ build 1929, 64-bit 2022-11-25 09:55:49.735 MSK [7648] LOG: listening on IPv4 addre

Re: [PATCH] Add peer authentication TAP test

2022-11-24 Thread Anton A. Melnikov
On 25.11.2022 10:34, Michael Paquier wrote: On Fri, Nov 25, 2022 at 10:13:29AM +0300, Anton A. Melnikov wrote: The test fails almost at the beginning in reset_pg_hba call after modification pg_hba.conf and node reloading: #t/003_peer.pl .. Dubious, test returned 2 (wstat 512, 0x200) #No

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2022-12-07 Thread Anton A. Melnikov
Hello! On 06.12.2022 21:44, Andres Freund wrote: Hi, On 2022-09-19 01:29:21 +0300, Anton A. Melnikov wrote: Corrected patch is attached (v2-0001-Fix-burst-checkpoint_req-growth.patch). This patch doesn't pass the main regression tests tests successfully: https://cirrus-ci.com

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-01-30 Thread Anton A. Melnikov
es: xlog.c:2507:1: warning: no previous prototype for ‘pg_update_control_file’ [-Wmissing-prototypes] 2507 | pg_update_control_file() Fixed it with #include "utils/fmgrprotos.h" to xlog.c and add PG_FUNCTION_ARGS to pg_update_control_file(). With the best wishes, -- Anton A. Melnikov

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-01-31 Thread Anton A. Melnikov
error will occur there, then we might use the workaround from the first variant of the patch. A thought in passing: if UpdateMinRecoveryPoint() performance is an issue, maybe we should figure out how to use fdatasync() instead of fsync(). May be choose it in accordance with GUC wal_sync_method?

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-02-13 Thread Anton A. Melnikov
arify it for me, please? If the performance of UpdateMinRecoveryPoint() wasn't a problem we could just use fsync in all platforms. Sincerely yours, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-02-14 Thread Anton A. Melnikov
Hi, Thomas! On 14.02.2023 06:38, Anton A. Melnikov wrote: Also i did several experiments with fsync=on and found more appropriate behavior: The stress test with sizeof(ControlFileData) = 512+8 = 520 bytes failed in a 4,5 hours, but the other one with ordinary sizeof(ControlFileData) = 296 not

Re: [BUG] Logical replica crash if there was an error in a function.

2022-10-09 Thread Anton A. Melnikov
ttached patch does it. Best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit bfaa02ac7a7cbeb793747be71962a7799c60c21c Author: Anton A. Melnikov Date: Sun Oct 9 11:56:20 2022 +0300 Fix logical replica crash if there was an error in

Re: effective_multixact_freeze_max_age issue

2022-10-18 Thread Anton A. Melnikov
hed tries to do this. -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit f27ea4e61a7680452b56a7c11b1dcab1c0b81c6b Author: Anton A. Melnikov Date: Fri Oct 14 11:57:22 2022 +0300 Split 'too far in the past checks' in vacuum_set_x

Re: effective_multixact_freeze_max_age issue

2022-10-24 Thread Anton A. Melnikov
t a warning but a notice message before OldestXmin WARNING and possible real problems in the future. Maybe it can be useful in a such kind? With best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Question about "compound" queries.

2022-10-24 Thread Anton A. Melnikov
ol with ERROR: cannot insert multiple commands into a prepared statement. What are their advantages? And what is the proper name for such queries? "Compound" or something else? Would be very grateful for clarification. Best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Question about "compound" queries.

2022-10-25 Thread Anton A. Melnikov
server just deal with it.  It works because the system needs to do those kinds of things anyway so, why not make it user-facing, even if most uses would find its restrictions makes it undesirable to use. David J. All the best, -- Anton A. Melnikov Postgres Professional: http

Re: [PATCH] Backport perl tests for pg_upgrade from 322becb60

2022-11-01 Thread Anton A. Melnikov
With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companydiff --git a/src/bin/pg_upgrade/.gitignore b/src/bin/pg_upgrade/.gitignore index 2d3bfeaa50..05200a09f1 100644 --- a/src/bin/pg_upgrade/.gitignore +++ b/src/bin/pg_upgrade/.gitignore @

Re: make MaxBackends available in _PG_init

2022-05-05 Thread Anton A. Melnikov
arbitrary GUC here. And maybe not bad to add Assert(size > 0) in RequestAddinShmemSpace() to see that the size calculation in contrib was wrong. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: make MaxBackends available in _PG_init

2022-05-12 Thread Anton A. Melnikov
other. http://cfbot.cputube.org/patch_38_3614.log With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

[PATCH] Fix pg_upgrade test from v10

2022-06-01 Thread Anton A. Melnikov
ments and concerns. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit aa96ef028482fc026850363c776145687cc60fc4 Author: Anton A. Melnikov Date: Thu Jun 2 03:35:26 2022 +0300 Fix test for pg_upgrade from 10x versions.

Re: [PATCH] Fix pg_upgrade test from v10

2022-06-05 Thread Anton A. Melnikov
f the in-core facility, as it > has its own module and logic to check after the case of cross-version > upgrades (see PGBuild/Modules/TestUpgradeXversion.pm).. Michael, thanks a lot for your 2c. With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com

Re: [PATCH] Fix pg_upgrade test from v10

2022-07-04 Thread Anton A. Melnikov
from? See also 20220122183749.go23...@telsasoft.com, where I proposed some of the same things. Thanks a lot, i've add some code for 14+ from https://www.postgresql.org/message-id/flat/20220122183749.GO23027%40telsasoft.com to the attached patch. With best regards, -- Anton A.

Re: Possible fails in pg_stat_statements test

2022-07-09 Thread Anton A. Melnikov
approach, and the patch looks good to me. Committed. Thanks a lot! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-07-31 Thread Anton A. Melnikov
de_adapt.sql regression <$newbindir>/psql: symbol lookup error: <$newbindir>/psql: undefined symbol: PQmblenBounded Tests from 15-stable and from itself work as expected. Question about similar error was here: https://www.postgresql.org/message-id/flat/BN0PR20MB3912AA107FA6E90FB6B0A034FD9F9%40

[PATCH] Backport perl tests for pg_upgrade from 322becb60

2022-07-31 Thread Anton A. Melnikov
tries to apply all the *.patch files to the master branch, one after another. For branches other than master, I suggest to name the patches *.txt or similar. So, i made a .txt extension for patch, but i would really like to set a patch tester on it. Is there any way to do this? With best regar

Re: [PATCH] Fix pg_upgrade test from v10

2022-07-31 Thread Anton A. Melnikov
60). Yes, the backport idea seems to be interesting. I wrote more about this in a new thread: https://www.postgresql.org/message-id/e2b1f3a0-4fda-ba72-5535-2d0395b9e68f%40inbox.ru as the current topic has nothing to do with the backport of TAP tests. With best regards, -- Anton A. Melnikov Po

Don't process multi xmax in FreezeMultiXactId() if it is already marked as invalid.

2024-06-14 Thread Anton A. Melnikov
true; + return InvalidTransactionId; + } + if (!MultiXactIdIsValid(multi) || HEAP_LOCKED_UPGRADED(t_infomask)) With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Maybe don't process multi xmax in FreezeMultiXactId() if it is already marked as invalid?

2024-06-17 Thread Anton A. Melnikov
On 14.06.2024 10:45, Anton A. Melnikov wrote: The src/backend/access/heap/README.tuplock says about HEAP_XMAX_INVALID bit that "Any tuple with this bit set does not have a valid value stored in XMAX." Found that FreezeMultiXactId() tries to process such an invalid multi xmax and may

Re: Making Vars outer-join aware

2023-07-23 Thread Anton A. Melnikov
y varnos during custom_scan->scan.plan.targetlist creation and leave the сustom_scan->custom_scan_tlist = NIL rather than changing them later using ChangeVarNodes(). This resulted in a noticeable code simplification. Thanks a lot for pointing on it! Sincerely yours, -- Anton A. Melnikov Postgr

[BUG] Crash on pgbench initialization.

2023-07-23 Thread Anton A. Melnikov
e.g. if shared_buffers = 10MB and max_worker_processes = 40. Then the command "pgbench --initialize postgres" will lead to crash. See the backtrace attached. There is a fix in the patch applied. Please take a look on it. With the best regards, -- Anton A. Melnikov Postgres Professi

Re: [BUG] Crash on pgbench initialization.

2023-07-25 Thread Anton A. Melnikov
On 25.07.2023 06:24, Andres Freund wrote: Thanks Anton / Victoria for the report and fix. Pushed. Thanks! Have a nice day! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-07-30 Thread Anton A. Melnikov
earlier than August 2 evening] With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company alg_level_up.pdf Description: Adobe PDF document

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-07-30 Thread Anton A. Melnikov
Sorry, attached the wrong version of the file. Here is the right one. Sincerely yours, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company alg_level_up.pdf Description: Adobe PDF document

Use XLOG_CONTROL_FILE macro everywhere?

2024-04-18 Thread Anton A. Melnikov
this. Would be glad if take a look on it. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres CompanyFrom 2692683142c98572114c32f696b55c6a642dd3e9 Mon Sep 17 00:00:00 2001 From: "Anton A. Melnikov" Date: Fri, 19 Apr 2024 06:1

Re: Use XLOG_CONTROL_FILE macro everywhere?

2024-04-20 Thread Anton A. Melnikov
On 20.04.2024 09:36, Daniel Gustafsson wrote: Anton: please register this patch in the Open commitfest to ensure it's not forgotten about. Done. Daniel and Michael thank you! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Use XLOG_CONTROL_FILE macro everywhere?

2024-04-24 Thread Anton A. Melnikov
On 24.04.2024 12:02, Peter Eisentraut wrote: On 19.04.24 05:50, Anton A. Melnikov wrote: May be better use this macro everywhere in C code? I don't know.  I don't find XLOG_CONTROL_FILE to be a very intuitive proxy for "pg_control". Then maybe replace XL

Re: Use XLOG_CONTROL_FILE macro everywhere?

2024-04-24 Thread Anton A. Melnikov
On 24.04.2024 12:19, Daniel Gustafsson wrote: On 24 Apr 2024, at 11:13, Anton A. Melnikov wrote: On 24.04.2024 12:02, Peter Eisentraut wrote: On 19.04.24 05:50, Anton A. Melnikov wrote: May be better use this macro everywhere in C code? I don't know. I don't find XLOG_CONTROL_FI

Re: Refactoring backend fork+exec code

2024-04-27 Thread Anton A. Melnikov
Hello! Maybe add PGDLLIMPORT to extern bool LoadedSSL; and extern struct ClientSocket *MyClientSocket; definitions in the src/include/postmaster/postmaster.h ? With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Refactoring backend fork+exec code

2024-05-01 Thread Anton A. Melnikov
On 28.04.2024 22:36, Heikki Linnakangas wrote: Peter E noticed and Michael fixed them in commit 768ceeeaa1 already. Didn't check that is already fixed in the current master. Sorry! Thanks for pointing this out! With the best wishes, -- Anton A. Melnikov Postgres Professional:

Re: psql: fix variable existence tab completion

2024-05-05 Thread Anton A. Melnikov
like [1]. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company [1] https://www.postgresql.org/message-id/960764.1643751...@sss.pgh.pa.usFrom 455bec0d785b0f5057fc7e91a5fede458cf8fd36 Mon Sep 17 00:00:00 2001 From: "Anto

Re: psql: fix variable existence tab completion

2024-05-07 Thread Anton A. Melnikov
10, then it makes sense to look for more complex solutions that will fix a backslash substitutions. If no such complaints, then it is better to make a workaround in test. With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

[BUG] Logical replica crash if there was an error in a function.

2022-08-21 Thread Anton A. Melnikov
>>> SQL statement "call public.rebuild_rule_set_selector()" PL/pgSQL function public.rul_rule_set_trg() line 4 at CALL processing remote data for replication origin "pg_16401" during "INSERT" for replication target relation

Re: [BUG] Logical replica crash if there was an error in a function.

2022-08-21 Thread Anton A. Melnikov
Hello! On 21.08.2022 17:33, Anton A. Melnikov wrote: Hello! Here is a fix for the bug first described in: https://www.postgresql.org/message-id/flat/adf0452f-8c6b-7def-d35e-ab516c80088e%40inbox.ru Sorry, there was a wrong patch in the first letter. Here is a right version. With best

Re: [BUG] Logical replica crash if there was an error in a function.

2022-08-30 Thread Anton A. Melnikov
repcmd.sql attached with primary port and execute it: psql -f repcmd.sql 3) On master execute command: INSERT INTO test VALUES ('1'); With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit 4de66e1b1ffaeaacdd72f3e7278

May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2022-09-06 Thread Anton A. Melnikov
ies to fix it. With best regards. -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company022-09-04 21:09:45.160 MSK [2424110] LOG: Start CFS version 0.54 supported compression algorithms pglz,zlib encryption disabled GC enabled 2022-09-04 21:09:45.1

Re: [BUG] Logical replica crash if there was an error in a function.

2022-09-08 Thread Anton A. Melnikov
Hello! Added a TAP test for this case. On 30.08.2022 10:09, Anton A. Melnikov wrote: Hello! The patch was rebased on current master. And here is a simplified crash reproduction: 1) On primary with 'wal_level = logical' execute:  CREATE TABLE public.test (id int NOT NULL, v

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2022-09-18 Thread Anton A. Melnikov
q | 109 With best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit d5a58d8585692be0d24db9414859088e3e7f7dad Author: Anton A. Melnikov Date: Tue Sep 6 12:18:56 2022 +0300 Remove burst growth of the checkpoint_req on re

Re: Making Vars outer-join aware

2023-05-29 Thread Anton A. Melnikov
ds, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Companycommit cc1724759b898efc703867a83d38173e4b2794b5 Author: Anton A. Melnikov Date: Mon May 29 13:52:42 2023 +0300 Return false from bms_is_member() if checked value is negative. diff --git a/sr

Re: Use XLOG_CONTROL_FILE macro everywhere?

2024-09-03 Thread Anton A. Melnikov
ace for this? In v2 moved some definitions from xlog_internal to xlogdefs and removed including xlog_internal.h from the postmaster.c. Please, take a look on it. With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres CompanyFrom 0b1435492e293ee5553a69c

Re: psql: fix variable existence tab completion

2024-09-04 Thread Anton A. Melnikov
On 04.09.2024 23:26, Tom Lane wrote: Pushed. I shall now watch the buildfarm from a safe distance. Thanks! I'll be ready to fix possible falls. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: Use XLOG_CONTROL_FILE macro everywhere?

2024-09-07 Thread Anton A. Melnikov
patch that tries to do this based on the your first patch. Would be glad to hear your opinion. With the best wishes, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres CompanyFrom 4b6a12f6eaac98ee22dd63d64431968357905d77 Mon Sep 17 00:00:00 2001 From: &qu

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2024-09-16 Thread Anton A. Melnikov
frequently (13 seconds apart) 2024-09-16 16:38:47.888 MSK [193733] HINT: Consider increasing the configuration parameter "max_wal_size". And num_timed + num_requested will become greater than num_done. Would be nice to find some simpler and faster way. With the best regards, --

Re: psql: fix variable existence tab completion

2024-07-20 Thread Anton A. Melnikov
the last couple years. Agreed that no reason to save workarounds for non-supported systems. Here is the patch that removes fixes for Buster bug mentioned above. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postg

  1   2   >