Re: dropdb --force

2019-05-16 Thread Anthony Nowocien
Also works fine according to my testing. Documentation is also clear. Thanks for this useful patch.

Re: dropdb --force

2019-06-24 Thread Anthony Nowocien
Hi, patch no longer applies (as of 12beta2). postgres@ubuntudev:~/pg_testing/source/postgresql-12beta2$ patch -p1 < drop-database-force-20190310_01.patch patching file doc/src/sgml/ref/drop_database.sgml patching file doc/src/sgml/ref/dropdb.sgml patching file src/backend/commands/dbcommands.c H

Re: progress report for ANALYZE

2019-07-02 Thread Anthony Nowocien
Hi, In monitoring.sgml, "a" is missing in "row for ech backend that is currently running that command[...]". Anthony On Tuesday, July 2, 2019, Julien Rouhaud wrote: > On Fri, Jun 21, 2019 at 8:52 PM Alvaro Herrera wrote: >> >> Here's a patch that implements progress reporting for ANALYZE. > > P

Re: Conflict handling for COPY FROM

2019-07-03 Thread Anthony Nowocien
Hi, I'm very interested in this patch and would like to give a review within a week. On the feature side, how about simply using the less verbose "ERRORS" instead of "ERROR LIMIT" ? On Wed, Jul 3, 2019 at 1:42 PM Surafel Temesgen wrote: > Hi Alexey, > Thank you for looking at it > > On Tue, Jul

Re: Conflict handling for COPY FROM

2019-07-14 Thread Anthony Nowocien
Hi, sorry for answering a bit later than I hoped. Here is my review so far: Contents == This patch starts to address in my opinion one of COPY's shortcoming, which is error handling. PK and exclusion errors are taken care of, but not (yet?) other types of errors. Documentation is upd