Re: speed up a logical replica setup

2022-03-01 Thread Andreas Karlsson
On 2/21/22 13:09, Euler Taveira wrote: DESIGN The conversion requires 8 steps. 1. Check if the target data directory has the same system identifier than the source data directory. 2. Stop the target server if it is running as a standby server. (Modify recovery parameters requires a restart.)

Re: Blocking I/O, async I/O and io_uring

2020-12-07 Thread Andreas Karlsson
On 12/8/20 3:55 AM, Craig Ringer wrote: A new kernel API called io_uring has recently come to my attention. I assume some of you (Andres?) have been following it for a while. Andres did a talk on this at FOSDEM PGDay earlier this year. You can see his slides below, but since they are from Janu

Re: Discarding DISCARD ALL

2020-12-23 Thread Andreas Karlsson
On 12/23/20 3:47 PM, Vladimir Sitnikov wrote: Simon>It seems strange to me that we put this work onto the pooler, forcing Simon>poolers to repeatedly issue the same command What if poolers learn to manage connections and prepared statements better? Then poolers won't have to reset the session ev

Re: proposal - support tsv output format for psql

2020-12-23 Thread Andreas Karlsson
On 12/23/20 7:18 AM, Pavel Stehule wrote:> I am playing with clipboard on Linux, and I found a way, how to redirect psql output to clipboard via wl-copy or xclip and then to Libre Office. Now it looks so best format is tsv select * from pg_database \g (format=tsv) | wl-paste -t application/x-l

Re: Discarding DISCARD ALL

2020-12-23 Thread Andreas Karlsson
On 12/23/20 6:49 PM, Simon Riggs wrote: The whole premise of the patch is tighter integration, with the server providing the facilities that poolers need. I am all for that. Ideally I would want builtin connection pooling but short term I think the way forward is most likely tighter integratio

Re: zstd compression for pg_dump

2021-01-10 Thread Andreas Karlsson
On 1/4/21 3:53 AM, Justin Pryzby wrote: About 89% smaller. Did a quick code review of the patch. I have not yet taken it for a spin yet and there are parts of the code I have not read yet. ## Is there any reason for this diff? -cfp*fp = pg_malloc(sizeof(cfp)); +cfp*f

Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]

2021-03-05 Thread Andreas Karlsson
On 3/4/21 4:40 PM, Tom Lane wrote: I wonder if a 2-D integer array wouldn't be a better idea, ie {{startpos1,length1},{startpos2,length2},...}. My experience with working with parallel arrays in SQL has been unpleasant. Hm, I can see your point but on the other hand I can't say my experiences

Re: [PATCH] pg_ownerships system view

2021-03-08 Thread Andreas Karlsson
On 3/7/21 1:08 AM, Joel Jacobson wrote: Attached is a suggestion of adding a convenience view, allowing quickly looking up all objects owned by a given user. This definitely seems like a useful feature. I know I am guilty of creating tables as the wrong role more than one time. Andreas

Re: abstract Unix-domain sockets

2020-11-09 Thread Andreas Karlsson
On 11/9/20 9:04 AM, Peter Eisentraut wrote: On 2020-11-09 07:08, Michael Paquier wrote: As abstract namespaces don't have permissions, anyone knowing the name of the path, which should be unique, can have an access to the server. Do you think that the documentation should warn the user about tha

Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests

2020-11-10 Thread Andreas Karlsson
On 11/3/20 10:22 AM, Magnus Hagander wrote: On Thu, Sep 24, 2020 at 5:17 AM Michael Paquier wrote: No objections from here to remove that from the core tests. It is worth noting that Debian Code Search hints that this is used in some extensions: https://codesearch.debian.net/search?q=TG_RELNAM

Re: Different results between PostgreSQL and Oracle for "for update" statement

2020-11-20 Thread Andreas Karlsson
On 11/20/20 9:57 AM, Andy Fan wrote: Thank you for your attention. Your suggestion would fix the issue.  However The difference will cause some risks when users move their application from Oracle to PostgreSQL. So I'd like to think which behavior is more reasonable. I think PostgreSQL's behav

Re: Different results between PostgreSQL and Oracle for "for update" statement

2020-11-20 Thread Andreas Karlsson
On 11/20/20 3:25 PM, Andy Fan wrote:> On Fri, Nov 20, 2020 at 9:37 PM Andreas Karlsson <mailto:andr...@proxel.se>> wrote: On 11/20/20 9:57 AM, Andy Fan wrote: > Thank you for your attention. Your suggestion would fix the issue.  However > The difference wil

What to do about the broken btree_gist for inet/cidr?

2020-11-27 Thread Andreas Karlsson
Hi, As discussed in this thread (https://www.postgresql.org/message-id/201010112055.o9bktzf7011...@wwwmaster.postgresql.org) btree_gist is broken for the inet and cidr types. The reason is that it uses convert_network_to_scalar() to make a lossy GiST index, but convert_network_to_scalar() thr

Re: trailing junk in numeric literals

2021-01-16 Thread Andreas Karlsson
On 1/16/21 2:02 PM, Vik Fearing wrote: I am in favor of such a change so that we can also accept 1_000_000 which currently parses as "1 AS _000_000" (which also isn't compliant because identifiers cannot start with an underscore, but I don't want to take it that far). It would also allow us to h

Re: CTAS command tags

2021-01-22 Thread Andreas Karlsson
On 1/22/21 2:19 PM, Darafei "Komяpa" Praliaskouski wrote: Having row count right away is very useful in CTAS in analytical and GIS usage scenarios. I can see that, but would it not work if it was: CREATE TABLE AS 1 Disclaimer: I have not looked at the code so maybe there is some good reason

Re: some unused parameters cleanup

2020-08-25 Thread Andreas Karlsson
On 8/25/20 7:42 PM, Bruce Momjian wrote: On Tue, Aug 25, 2020 at 12:59:31PM -0400, Tom Lane wrote: Peter Eisentraut writes: Here is a series of patches to remove some unused function parameters. In each case, the need for them was removed by some other code changes over time but the unusedness

Re: INSERT ON CONFLICT and RETURNING

2020-09-03 Thread Andreas Karlsson
On 9/3/20 6:52 PM, Konstantin Knizhnik wrote: But frankly speaking I still didn't find answer for my question in this thread: what are the dangerous scenarios with ON CONFLICT DO NOTHING/SELECT. Yes, record is not exclusively locked. But I just want to obtain value of some column which is not a

Re: Adding CI to our tree

2021-10-21 Thread Andreas Karlsson
On 10/21/21 5:55 PM, Matthias van de Meent wrote: On Sat, 2 Oct 2021 at 17:05, Tom Lane wrote: Andres Freund writes: It's not like this forces you to use cirrus or anything. For people that don't want to use CI, It'll make cfbot a bit more effective (because people can adjust what it tests a

Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS

2018-04-08 Thread Andreas Karlsson
On 04/08/2018 05:27 AM, Craig Ringer wrote:> More below, but here's an idea #5: decide InnoDB has the right idea, and go to using a single massive blob file, or a few giant blobs. FYI: MySQL has by default one file per table these days. The old approach with one massive file was a maintenance

Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS

2018-04-09 Thread Andreas Karlsson
On 04/09/2018 02:16 PM, Craig Ringer wrote: I'd like a middle ground where the kernel lets us register our interest and tells us if it lost something, without us having to keep eight million FDs open for some long period. "Tell us about anything that happens under pgdata/" or an inotify-style p

Re: unused_oids script is broken with bsd sed

2018-04-25 Thread Andreas Karlsson
On 04/25/2018 04:59 PM, David Fetter wrote: While we're improving things, there's not really a reason this program should need to be run from any particular spot. It can detect where it is and act on that information. +1 I would appreciate this change, and if Stats does not feel like adding i

Re: unused_oids script is broken with bsd sed

2018-04-26 Thread Andreas Karlsson
On 04/26/2018 01:37 PM, John Naylor wrote:> Patch 0002 is my attempt at this. Not sure how portable this is. It's also clunkier than before in that you need to tell it where to find Catalog.pm, since it seems Perl won't compile unless "use lib" points to a string and not an expression. Suggestion

Re: Declaring a strict function returns not null / eval speed

2019-10-20 Thread Andreas Karlsson
On 10/1/19 9:38 AM, Andres Freund wrote: We spend a surprising amount of time during expression evaluation to reevaluate whether input to a strict function (or similar) is not null, even though the value either comes from a strict function, or a column declared not null. Now you can rightfull

Re: WIP: expression evaluation improvements

2019-10-24 Thread Andreas Karlsson
On 10/23/19 6:38 PM, Andres Freund wrote: In the attached *prototype* patch series there's a lot of incremental improvements (and some cleanups) (in time, not importance order): You may already know this but your patch set seems to require clang 9. I get the below compilation error which is pr

Re: Feature: temporary materialized views

2019-03-11 Thread Andreas Karlsson
On 3/8/19 2:38 AM, Michael Paquier wrote: On Thu, Mar 07, 2019 at 10:45:04AM +0200, David Steele wrote: I think a new patch is required here so I have marked this Waiting on Author. cfbot is certainly not happy and anyone trying to review is going to have hard time trying to determine what to r

Re: Feature: temporary materialized views

2019-03-14 Thread Andreas Karlsson
On 3/14/19 9:13 AM, Mitar wrote:> I just want to make sure if I understand correctly. But my initial proposal/patch is currently waiting first for all patches for the refactoring to happen, which are done by amazing Andreas? This sounds good to me and I see a lot of progress/work has been done an

Re: GIN indexes on an = ANY(array) clause

2019-03-14 Thread Andreas Karlsson
On 3/13/19 5:38 PM, Tom Lane wrote: regression=# select amopopr::regoperator from pg_amop where amopfamily = 2745; amopopr --- &&(anyarray,anyarray) @>(anyarray,anyarray) <@(anyarray,anyarray) =(anyarray,anyarray) (4 rows) and none of those are obviously rela

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Andreas Karlsson
On 3/19/19 11:19 AM, Fred .Flintstone wrote: PostgreSQL pollutes the file system with lots of binaries that it is not obvious that they belong to PostgreSQL. Such as "/usr/bin/createdb", etc. It would be better if these files were renamed to be prefixed with pg_, such as pg_createdb. Or even be

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Andreas Karlsson
On 3/20/19 8:19 PM, Andres Freund wrote: On 2019-03-20 15:15:02 -0400, Jonathan S. Katz wrote: If we are evaluating this whole symlink / renaming thing, there could be arguments for a "pgsql" alias to psql (or vice versa), but I don't think "pg_sql" makes any sense and could be fairly confusing.

Re: PostgreSQL pollutes the file system

2019-03-21 Thread Andreas Karlsson
On 3/21/19 7:07 AM, Chris Travers wrote: 1.  createuser/dropuser are things that I don't consider good ways of creating users anyway.  I think we should just consider removing these binaries.  The SQL queries are better, more functional, and can be rolled back as a part of a larger transaction.

Re: PostgreSQL pollutes the file system

2019-03-27 Thread Andreas Karlsson
On 3/27/19 2:51 PM, Tomas Vondra wrote: I think the consensus in this thread (and the previous ancient ones) is that it's not worth it. It's one thing to introduce new commands with the pg_ prefix, and it's a completely different thing to rename existing ones. That has inherent costs, and as Tom

Re: PostgreSQL pollutes the file system

2019-03-27 Thread Andreas Karlsson
On 3/27/19 3:26 PM, Tomas Vondra wrote: That is true, of course. But are there actual examples of such conflicts in practice? I mean, are there tools/packages that provide commands with a conflicting name? I'm not aware of any, and as was pointed before, we'd have ~20 years of history on any new

Re: DWIM mode for psql

2019-03-31 Thread Andreas Karlsson
On 3/31/19 10:52 PM, Thomas Munro wrote:> Building on the excellent work begun by commit e529cd4ffa60, I would like to propose a do-what-I-mean mode for psql. Please find a POC patch attached. It works like this: postgres=# select datnaam from pg_database where ooid = 12917; ERROR: column "da

Re: \describe*

2018-01-26 Thread Andreas Karlsson
On 01/26/2018 03:49 PM, David Fetter wrote:> They are indeed terse and cryptic, and what's worse, they're not available to clients other than psql, so I propose that we do what at least MySQL, Oracle, and DB2 do and implement DESCRIBE as its own command. Especially handy would be a variant DESCR

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2018-01-30 Thread Andreas Karlsson
On 01/21/2018 10:36 PM, Mark Rofail wrote: == The @>> operator A previous version of your patch added the "anyelement <<@ anyarray" operator to avoid having to build arrays, but that part was reverted due to a bug. I am not expert on the gin code, but as far as I can tell it

Re: [HACKERS] GnuTLS support

2018-01-30 Thread Andreas Karlsson
On 01/26/2018 03:54 AM, Peter Eisentraut wrote: On 1/25/18 20:10, Michael Paquier wrote: Peter, could you change ssl_version() and ssl_cipher() in sslinfo at the same time please? I think that those should use the generic backend-side APIs as well. sslinfo depends heavily on OpenSSL, OK, but if

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2018-01-30 Thread Andreas Karlsson
On 01/26/2018 03:28 AM, Stephen Frost wrote: I'm a big fan of this patch but it doesn't appear to have made any progress in quite a while. Is there any chance we can get an updated patch and perhaps get another review before the end of this CF...? Sorry, as you may have guessed I do not have t

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2018-02-03 Thread Andreas Karlsson
On 02/01/2018 04:17 PM, Mark Rofail wrote: since its a polymorphic function it only passes if the `anyarray` is the same type of the `anyelement` so we are sure they are the same type. Can't we get the type from the anyarray ? the type is already stored in ` arr_type`. In theory, yes, but I s

Re: JIT compiling with LLVM v9.1

2018-02-03 Thread Andreas Karlsson
On 02/02/2018 10:48 AM, Pierre Ducroquet wrote: I have successfully built the JIT branch against LLVM 4.0.1 on Debian testing. This is not enough for Debian stable (LLVM 3.9 is the latest available there), but it's a first step. I've split the patch in four files. The first three fix the build is

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2018-02-05 Thread Andreas Karlsson
The patch looks good to me now other than some smaller issues, mostly in the documentation. If you fix these I will set it as ready for committer, and let a committer chime in on the casting logic which we both find a bit ugly. == Comments The only a bit bigger issue I see is the error messag

Warning when building man pages

2018-02-05 Thread Andreas Karlsson
Hi, I get a warning when building the man pages on Debian testing. The warning is in the documentation for CREATE POLICY and as caused by the three footnotes in the sql-createpolicy-summary table. I do not understand our documentation pipeline well enough to know what the proper fix would be

Re: JIT compiling with LLVM v9.1

2018-02-05 Thread Andreas Karlsson
p;vi) { ^ 1 warning generated. psqlscanslash.l: In function ‘psql_scan_slash_option’: psqlscanslash.l:550:8: warning: variable ‘lexresult’ set but not used [-Wunused-but-set-variable] int final_state; ^ Andreas On 02/05/2018 11:39 AM, Pierre Ducroquet wrote: On Sunday, Febru

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2018-02-06 Thread Andreas Karlsson
On 02/06/2018 11:15 AM, Mark Rofail wrote: A new patch including all the fixes is ready. Can you give the docs another look. I re-wrapped, re-indented  and changed all `Foreign Key Arrays` to `Array Element Foreign Keys` for consistency. Looks good to me so set it to ready for committer. I s

Re: JIT compiling with LLVM v10.0

2018-02-08 Thread Andreas Karlsson
On 02/07/2018 03:54 PM, Andres Freund wrote: I've pushed v10.0. The big (and pretty painful to make) change is that now all the LLVM specific code lives in src/backend/jit/llvm, which is built as a shared library which is loaded on demand. It does not seem to be possible build without LLVM anym

Re: JIT compiling with LLVM v9.1

2018-02-15 Thread Andreas Karlsson
On 02/05/2018 10:44 PM, Pierre Ducroquet wrote: psqlscanslash.l: In function ‘psql_scan_slash_option’: psqlscanslash.l:550:8: warning: variable ‘lexresult’ set but not used [-Wunused-but-set-variable] int final_state; ^ I'm not sure Andres's patches have anything to do w

Re: function calls optimization

2019-10-31 Thread Andreas Karlsson
On 10/31/19 3:45 PM, Tom Lane wrote: Andres Freund writes: On October 31, 2019 7:06:13 AM PDT, Andrzej Barszcz wrote: Any pros and cons ? Depends on the actual way of implementing this proposal. Think we need more details than what you idea here. We've typically supposed that the cost

Re: Performance improvement for queries with IN clause

2019-11-09 Thread Andreas Karlsson
On 11/8/19 2:52 PM, Rafia Sabih wrote: Now, my question is shouldn't we always use this list in sorted order, in other words can there be scenarios where such a sorting will not help? I am talking about only the cases where the list consists of all constants and could fit in memory. Basically,

Re: [PATCH] Tiny optimization.

2019-11-23 Thread Andreas Karlsson
On 11/22/19 10:58 PM, Ranier Vilela wrote: Remove redutant test. Yeah, this test does look redundant since we already check for if parent is NULL earlier in the function. Any optimizing compiler should see this too, but it is still a good idea to remove it for code clarity. Andreas

Minor white space typo in documentation

2019-11-24 Thread Andreas Karlsson
Hi, When reading the syntax documentation for SELECT I noticed a missing space in "[ OVERRIDING { SYSTEM | USER} VALUE ]". Andreas diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml index f995a7637f1..e829c61642d 100644 --- a/doc/src/sgml/ref/insert.sgml +++ b/doc/src/sg

Re: Add .editorconfig

2019-12-11 Thread Andreas Karlsson
I have not used .editorconfig that much, but would it makes sense to add the below? [*] end_of_line = lf -- Andreas Karlsson

Re: More issues with expressions always false (no patch)

2019-12-19 Thread Andreas Karlsson
On 12/20/19 1:01 AM, Ranier Vilela wrote:> First case: src \ backend \ executor \ nodeSubplan.c (line 507) if (node-> hashtable) node-> hastable is assigned with NULL at line 498, so the test will always fail. Second case: Here the case is similar, but worse. src \ backend \ executor \ node

Re: More issues with expressions always false (no patch)

2019-12-20 Thread Andreas Karlsson
On 12/20/19 1:54 AM, Andreas Karlsson wrote: On 12/20/19 1:01 AM, Ranier Vilela wrote:> First case: Third case: \ src \ backend \ utils \ cache \ relcache.c (line 5190) if (relation-> rd_pubactions) It will never be executed, because if relation-> rd_pubactions is true, the functio

Re: More issues with expressions always false (no patch)

2020-01-08 Thread Andreas Karlsson
On 12/20/19 10:34 PM, Tom Lane wrote: I think the "useless" free is cheap insurance against a permanent memory leak, as well as more like the coding in nearby functions like RelationGetIndexAttrBitmap. I wouldn't change it. Good point, if there is a pattern it is good to follow it. But I am pr

Re: Zedstore - compressed in-core columnar storage

2019-04-11 Thread Andreas Karlsson
On 4/11/19 10:46 AM, Konstantin Knizhnik wrote: This my results of compressing pbench data using different compressors: Configuration Size (Gb) Time (sec) no compression 15.31 92 zlib (default level)2.37284 zlib (best speed) 2.43191 postgres internal lz3.

Re: PostgreSQL pollutes the file system

2019-04-12 Thread Andreas Karlsson
On 4/12/19 5:14 PM, Chris Travers wrote: 1. naming things is surprisingly hard.  How sure are we that we can do this right?  Can we come up with a correct name for initdb?  Maybe pg_createcluster? The Debian packagers already use pg_createcluster for their script which wraps initdb, and while

Re: PostgreSQL vs SQL/XML Standards

2018-10-25 Thread Andreas Karlsson
On 10/25/2018 03:53 PM, Chapman Flack wrote: On 10/25/18 10:39 AM, Tom Lane wrote: I think getting out from under libxml2's idiosyncrasies and security lapses would be great, but is there a plausible alternative out there? Depends on whether anything in [1] sounds plausible. The libraries we

Re: date_trunc() in a specific time zone

2018-10-29 Thread Andreas Karlsson
On 10/29/2018 04:18 PM, Vik Fearing wrote: A use case that I see quite a lot of is needing to do reports and other calculations on data per day/hour/etc but in the user's time zone. The way to do that is fairly trivial, but it's not obvious what it does so reading queries becomes just a little b

Re: date_trunc() in a specific time zone

2018-10-29 Thread Andreas Karlsson
On 10/29/2018 04:36 PM, Tom Lane wrote: Andreas Karlsson writes: Hm, I am not sure if I see any major win from writing date_trunc('day', timestamptz '2001-02-16 20:38:40+00', 'Australia/Sydney') instead of date_trunc('day', timestamptz '2001-02-1

Re: [RFC] Removing "magic" oids

2018-11-21 Thread Andreas Karlsson
On 11/21/18 1:07 AM, Andres Freund wrote: Let's see what I broke :/ There is a small typo in the old release notes. Andreas diff --git a/doc/src/sgml/release-9.1.sgml b/doc/src/sgml/release-9.1.sgml index 3407d8ad739..a522e7e0225 100644 --- a/doc/src/sgml/release-9.1.sgml +++ b/doc/src/sgml/re

Re: Need of maintaining unsupported release notes in HEAD?

2018-11-21 Thread Andreas Karlsson
On 11/21/18 2:51 AM, Haribabu Kommi wrote:> Attached patch removes all the older release notes sgml files from HEAD. And also going forward, how about removing one major version file whenever that is unsupported from HEAD? comments? I have found these old notes useful multiple times in the pa

Re: Remove Deprecated Exclusive Backup Mode

2018-11-27 Thread Andreas Karlsson
On 11/27/18 3:46 PM, Stephen Frost wrote: I'm concerned, seriously, that people don't have anywhere near the concern about the recovery side of things as they do about the backup side of things and that's really concerning. I agree with your larger point, but in this case the two breakages do

Re: Remove Deprecated Exclusive Backup Mode

2018-11-27 Thread Andreas Karlsson
On 11/27/18 4:11 PM, Stephen Frost wrote: I agree with your larger point, but in this case the two breakages do not seem equal. As far as I gather the removal of recovery.conf will in practice result in a longer downtime when your recovery scripts breaks but not any data loss. While if we remove

Re: JIT compiling with LLVM v9.1

2018-02-15 Thread Andreas Karlsson
On 02/15/2018 06:23 PM, Andres Freund wrote: 2) When I build with --with-cassert I expect the assertions to be there, both in the binaries and the bitcode. Is that just a bug or is there any thought behind this? Not sure what you mean by that. NDEBUG and cassert are independent mechanisms, no?

Re: Put genbki.pl output into src/include/catalog/ directly

2024-03-13 Thread Andreas Karlsson
On 2/8/24 8:58 AM, Peter Eisentraut wrote: I think keeping the two build systems aligned this way will be useful for longer-term maintenance. Agreed, so started reviewing the patch. Attached is a rebased version of the patch to solve a conflict. AndreasFrom 2069c6d6e2ef2bc37c5af0df12c558ead8

Re: Put genbki.pl output into src/include/catalog/ directly

2024-03-13 Thread Andreas Karlsson
On 3/13/24 12:41 PM, Andreas Karlsson wrote: On 2/8/24 8:58 AM, Peter Eisentraut wrote: I think keeping the two build systems aligned this way will be useful for longer-term maintenance. Agreed, so started reviewing the patch. Attached is a rebased version of the patch to solve a conflict

Re: RADIUS tests and improvements

2023-01-03 Thread Andreas Karlsson
On 1/3/23 04:11, Thomas Munro wrote: Here's a draft patch to tackle a couple of TODOs in the RADIUS code in auth.c. Nice to see someone working on this! I know of one company which could have used the configurable timeout for radius because the 3 second timeout is too short for 2FA. I think t

Re: RADIUS tests and improvements

2023-01-03 Thread Andreas Karlsson
On 1/3/23 22:03, Andreas Karlsson wrote: On 1/3/23 04:11, Thomas Munro wrote: Here's a draft patch to tackle a couple of TODOs in the RADIUS code in auth.c. Nice to see someone working on this!. Another thing: shouldn't we set some wait event to indicate that we are waiting

Re: RADIUS tests and improvements

2023-01-03 Thread Andreas Karlsson
On 1/3/23 22:16, Thomas Munro wrote: On Wed, Jan 4, 2023 at 10:07 AM Andreas Karlsson wrote: Another thing: shouldn't we set some wait event to indicate that we are waiting the RADIUS server or is that pointless during authentication since there are no queries running anyway? I init

Re: SERIAL datatype column skipping values.

2020-03-11 Thread Andreas Karlsson
On 3/11/20 11:15 AM, Prabhat Sahu wrote: Hi all, Please check the below behavior for the "SERIAL" datatype. [...] In this above case, the serial column "c2" is skipping the value "4" in select output. Is this an expected behavior? Curious, it seems like DEFAULT expressions of a table are ex

Re: ssl passphrase callback

2020-03-15 Thread Andreas Karlsson
On 2/18/20 11:39 PM, Andrew Dunstan wrote: This should fix the issue, it happened when I switched to using a pre-generated cert/key. # Review The patch still applies and passes the test suite, both with openssl enabled and with it disabled. As for the feature I agree that it is nice to expo

Re: Unicode normalization SQL functions

2020-03-19 Thread Andreas Karlsson
On 3/19/20 3:41 PM, Peter Eisentraut wrote: What is that status of this patch set?  I think we have nailed down the behavior, but there were some concerns about certain performance characteristics.  Do people feel that those are required to be addressed in this cycle? Personally I would rathe

Re: [PATCH] Incremental sort (was: PoC: Partial sort)

2020-03-22 Thread Andreas Karlsson
On 3/21/20 1:56 AM, Tomas Vondra wrote: I've looked at v38 but it seems it's a bit broken by some recent explain changes (mostly missing type in declarations). Attached is v39 fixing those issues, and including a bunch of fixes based on a review - most of the changes is in comments, so I've inste

Re: [PATCH] Incremental sort (was: PoC: Partial sort)

2020-03-22 Thread Andreas Karlsson
On 3/23/20 1:33 AM, James Coleman wrote: So on the face of it we have a bit of a no-win situation. The function tuple_sort_method_name returns a const, but lappend wants a non-const. I'm not sure what the project style preference is here: we could cast the result as (char *) to drop the const qua

Re: ssl passphrase callback

2020-03-22 Thread Andreas Karlsson
On 3/22/20 1:08 AM, Andrew Dunstan wrote: Latest patch attached, I think all comments have been addressed. I propose to push this later this coming week if there are no more comments. I do not have any objections. Andreas

Re: btree_gist into core?

2022-01-24 Thread Andreas Karlsson
On 1/19/22 09:30, Peter Eisentraut wrote: So, first of all, would people agree with this course of action? I don't have a lot of experience with this module, so I don't know if there are any lingering concerns about whether it is mature enough as a built-in feature. While it I like the idea

Re: Allow parallel plan for referential integrity checks?

2022-02-10 Thread Andreas Karlsson
On 2/7/22 11:26, Frédéric Yhuel wrote: Attached is a (naive) patch that aims to fix the case of a FK addition, but the handling of the flag CURSOR_OPT_PARALLEL_OK, generally speaking, looks rather hackish. Thanks, for the patch. You can add it to the current open commitfest (https://commitfes

Re: GISTSTATE is too large

2021-05-30 Thread Andreas Karlsson
reas >From 63158a51add9cbd43ca7d5d6219cd6127657f25f Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date: Sun, 30 May 2021 15:11:35 +0200 Subject: [PATCH] Shrink GISTSTATE --- src/backend/access/gist/gist.c | 58 ++--- src/backend/access/gist/gistscan.c | 4 +- src/backend/access/gist/gis

Re: ICU locale validation / canonicalization

2023-02-09 Thread Andreas Karlsson
On 2/9/23 23:09, Jeff Davis wrote: I do like the ICU format locale IDs from a readability standpoint. "en_US@colstrength=primary" is more meaningful to me than "en-US-u-ks- level1" (the equivalent language tag). And the format is specified[1], even though it's not an independent standard. But I t

Re: ICU locale validation / canonicalization

2023-02-09 Thread Andreas Karlsson
On 2/10/23 02:22, Jeff Davis wrote: We will still allow the ICU format locale IDs for input; we would just convert them to BCP47 before storing them in the catalog. And there's an inverse function, so it's easy enough to offer a view that shows the ICU format locale IDs in addition to the BCP 47

Re: Trigger position

2021-09-15 Thread Andreas Karlsson
On 9/15/21 1:40 PM, Tom Lane wrote: Marcos Pegoraro writes: Alphabetical order of triggers sometimes makes me write a_Recalc or z_Calc to be sure it´ll be the first or the last trigger with same event of that table Oracle and SQL Server have FOLLOWS and PRECEDES when defining trigger executi

Re: pgcrypto support for bcrypt $2b$ hashes

2021-09-30 Thread Andreas Karlsson
On 9/28/21 11:58 PM, Daniel Fone wrote: On 29/09/2021, at 2:33 AM, Daniel Gustafsson wrote: I don't see why not, the best first patches are those scratching an itch. If you feel up for it then give it a go, I - and the rest of pgsql-hackers - can help if you need to bounce ideas. I’m glad you

Re: pgcrypto support for bcrypt $2b$ hashes

2021-10-02 Thread Andreas Karlsson
On 10/2/21 5:48 AM, Daniel Fone wrote: I don’t get these compiler warnings and I can’t find any settings to use that might generate them. I’m compiling on macOS 11.6 configured with `--enable-cassert --enable-depend --enable-debug CFLAGS=-O0` I’ve optimistically updated the patch to hopefully

Re: add operator ^= to mean not equal (like != and <>)

2021-08-10 Thread Andreas Karlsson
On 8/10/21 10:27 AM, 孙诗浩(思才) wrote: Before send patch review, I want to konw whether the postgres maintainer will approve my changes. So, please give me some advice. Welcome! I do not think that is a feature which will get much interest from the developers since it is unclear to me what the

Re: Special-case executor expression steps for common combinations

2024-06-20 Thread Andreas Karlsson
On 10/12/23 11:48 AM, Daniel Gustafsson wrote: Thoughts? I have looked at the patch and it still applies, builds and passes the test cases and I personally think these optimizations are pretty much no-brainers that we should do and it is a pity nobody has had the time to review this patch.

Re: Special-case executor expression steps for common combinations

2024-06-20 Thread Andreas Karlsson
On 6/20/24 5:22 PM, Andreas Karlsson wrote: On 10/12/23 11:48 AM, Daniel Gustafsson wrote: Thoughts? I have looked at the patch and it still applies, builds and passes the test cases and I personally think these optimizations are pretty much no-brainers that we should do and it is a pity

Re: [PoC] Implementation of distinct in Window Aggregates

2023-07-10 Thread Andreas Karlsson
On 3/12/23 09:17, Ankit Kumar Pandey wrote: Attaching updated patch with a fix for an issue in window function. I have also fixed naming convention of patch as last patch had incompatible name. Hi, This patch does not apply to master. Could you rebase it and submit it as one patch which app

Re: Fix for recursive plpython triggers

2024-05-08 Thread Andreas Karlsson
On 5/4/24 10:16 PM, Tom Lane wrote: This fixes bug #18456 [1]. Since we're in back-branch release freeze, I'll just park it for the moment. But I think we should shove it in once the freeze lifts so it's in 17beta1. There is a similar issue with the return type (at least if it is a generic rec

Should we move the resowner field from JitContext to LLVMJitContext?

2024-06-05 Thread Andreas Karlsson
helpful. See the attached patch. AndreasFrom e3b55e00aee578a46298447463e0984aa3a230f7 Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date: Wed, 5 Jun 2024 10:13:23 +0200 Subject: [PATCH] Move resowner from common JitContext to LLVM specific Only the LLVM specific code uses it since resource owners

Re: Let's make PostgreSQL multi-threaded

2023-06-13 Thread Andreas Karlsson
On 6/13/23 10:20, Konstantin Knizhnik wrote: The fact that it is flushed out upon reconnection can not help much: what if backends are not going to disconnect? This is why many connection pools have a maximum connection lifetime which can be configured. So in practice flushing all caches on d

Re: Let's make PostgreSQL multi-threaded

2023-06-14 Thread Andreas Karlsson
On 6/14/23 09:01, Kyotaro Horiguchi wrote: At Wed, 14 Jun 2023 08:46:05 +0300, Konstantin Knizhnik wrote in But I do not think that it is somehow related with using threads instead of process. The question whether to use private or shared cache is not directly related to threads vs. process ch

Re: Does a cancelled REINDEX CONCURRENTLY need to be messy?

2023-06-29 Thread Andreas Karlsson
On 6/29/23 11:13, Thom Brown wrote: I get the feeling that this is deliberate, and perhaps an attempt to mitigate locking issues, or some other explanation, but the rationale isn't immediately apparent to me if this is the case. I have always assumed the reason is that there might be other tra

Re: Some questions about PostgreSQL’s design.

2024-08-22 Thread Andreas Karlsson
On 8/22/24 10:50 AM, 陈宗志 wrote: I disagree with the point made in the article. The article mentions that ‘prevents the kernel from reordering reads and writes to optimize performance,’ which might be referring to the file system’s IO scheduling and merging. However, this can be handled within the

Re: pgstattuple: fix free space calculation

2024-08-23 Thread Andreas Karlsson
On 8/23/24 12:02 PM, Rafia Sabih wrote:> On the other hand, this got me thinking about the purpose of this space > information. If we want to understand that there's still some space for the tuples in a page, then using PageGetExactFreeSpace is not doing justice in case of heap page, because we

Minor refactor: Use more consistent names for the labels of PG_Locale_Strategy

2024-08-28 Thread Andreas Karlsson
propose a new naming scheme: PG_STRATEGY_[_] I am open for other suggestions of course like keeping the PG_LOCALE_* prefix, but in any case I think we should make the enum labels consistent. AndreasFrom b0a3711081b2664cf6e58ec63ac446a56cc3ff80 Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date

Re: Little cleanup of ShmemInit function names

2024-08-28 Thread Andreas Karlsson
On 8/7/24 2:08 PM, Heikki Linnakangas wrote: The attached patches rename them to follow the usual naming convention. The InitLocks() function is refactored a bit more, splitting the per-backend initialization to a separate InitLockManagerAccess() function. That's why it's in a separate commit.

Re: PATCH: Add hooks for pg_total_relation_size and pg_indexes_size

2024-08-28 Thread Andreas Karlsson
On 8/9/24 6:59 PM, Abdoulaye Ba wrote:> The primary use case for this hook is to allow extensions to account for additional storage mechanisms that are not covered by the default PostgreSQL relation size calculations. For instance, in our project, we are working with an external i

Re: Remaining dependency on setlocale()

2024-08-28 Thread Andreas Karlsson
On 8/9/24 8:24 PM, Jeff Davis wrote: On Fri, 2024-08-09 at 13:41 +0200, Andreas Karlsson wrote: I am leaning towards that we should write our own pure ascii functions for this. That makes sense for a lot of call sites, but it could cause breakage if we aren't careful. Since we d

Re: tiny step toward threading: reduce dependence on setlocale()

2024-08-28 Thread Andreas Karlsson
ybe I should start a new thread though. AndreasFrom 9715b6f429907a9f284284e697727bfc7b4082e7 Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date: Wed, 14 Aug 2024 00:52:53 +0200 Subject: [PATCH v2 5/5] Remove pg_collate_deterministic() and check field directly There is no clear benefit from

Re: Little cleanup of ShmemInit function names

2024-08-28 Thread Andreas Karlsson
On 8/28/24 7:26 PM, Heikki Linnakangas wrote: Hmm, I don't see the issue. It's an uncommon sentence structure, but it was there before this patch, and it's correct AFAICS. If you grep for "which see ", you'll find some more examples of that. Not sure if it is correct or not but from some googl

Re: pgstattuple: fix free space calculation

2024-08-30 Thread Andreas Karlsson
On 8/29/24 4:53 PM, Frédéric Yhuel wrote: So I think we should just use PageGetExactFreeSpace(). I agree, I feel that is the least surprising behavior because we currently sum tiny amounts of free space that is unusable anyway. E.g. imagine one million pages with 10 free bytes each, that look

  1   2   3   >