Hi Joel,
> I've compiled a list of all* PostgreSQL EXTENSIONs in the world:
The list is great. Thanks for doing this!
Just curious, is it a one-time experiment or you are going to keep the
list in an actual state similarly to awesome-* lists on GitHub, or ...
?
--
Best regards,
Al
use case for logical replication.
Also, I suspect that implementing it may be a bit challenging. What if we
focus on table-level replication for now?
--
Best regards,
Aleksander Alekseev
properly.
Just curious, what is your index for, and how you are going to handle
crash recovery?
--
Best regards,
Aleksander Alekseev
Hi Joe,
> What about scanning for "PG_MODULE_MAGIC"?
An extension can be written without using C at all. BTW some extensions [1]
are written in Rust these days.
[1]: https://github.com/timescale/timescaledb-toolkit
--
Best regards,
Aleksander Alekseev
t)
> identical.
Sure, I don't insist on implementing table-level replication first.
It's up to you. My point was that it's not necessary to implement
everything at once.
--
Best regards,
Aleksander Alekseev
> to be told where the postgresql.conf actually is.
>
> The attached patch implements this as an option.
>
> [...]
Good catch!
Could you also implement a TAP test for the new code?
--
Best regards,
Aleksander Alekseev
would be difficult to bypass it in the first
implementation?
--
Best regards,
Aleksander Alekseev
k the previous behavior for the users who may
rely on it. I suggest keeping it simple, i.e. the way it is now. What I
think we could do instead is explicitly document this behavior in [1].
[1]: https://www.postgresql.org/docs/current/functions-datetime.html
--
Best regards,
Aleksander Alekseev
Hi hackers,
> It took me a while to understand the meaning of -c. Maybe
> changing it to --restore-target-wal will make it easier to
> understand.
+1, I "stumbled" while reading this too at first.
--
Best regards,
Aleksander Alekseev
d. I'm running MacOS Monterey 12.2.1 @ x64.
I didn't investigate further. Do we assume that `make installcheck` suppose
to pass with a different postgresql.conf options?
--
Best regards,
Aleksander Alekseev
ponding patch.
--
Best regards,
Aleksander Alekseev
fix-flacky-tests.patch
Description: Binary data
jsonb_object_keys(jsonb_object_agg(mycolumn, true)))
FROM ...
This works but doesn't seem to be the greatest user experience. I
would like to submit a patch that adds array_unique_agg() function
unless anyone has strong objections to this feature.
--
Best regards,
Aleksander Alekseev
Pavel, Sergei,
> SELECT array_agg(DISTINCT ...) doesn't help?
It works, many thanks!
--
Best regards,
Aleksander Alekseev
arge part of the documentation is commented and marked as TBA
(Column Filters, Combining Different Kinds of Filters). Could you please
clarify if it's a work-in-progress patch? If it's not, I believe the
commented part should be removed before committing.
--
Best regards,
Aleksander Alekseev
Hi again,
> The second sentence seems to be redundant.
Actually, I'm wrong on this one.
>
--
Best regards,
Aleksander Alekseev
oved before committing.
> >
>
> I think we can remove any Column Filters related information
> (placeholders), if that patch gets committed, we can always extend the
> existing docs.
>
Here is an updated version of the patch.
--
Best regards,
Aleksander Alekseev
v2-0001-Update-the-
Hi hackers,
> I don't see what else can be done either. Here is the corresponding patch.
Here is an updated patch that includes the commit message.
--
Best regards,
Aleksander Alekseev
v2-0001-Use-synchronous_commit-on-in-test_setup.sql.patch
Description: Binary data
arations I suggest keeping simply "3" here.
--
Best regards,
Aleksander Alekseev
r
share your development branch on GitHub?
I agree with Bruce it would be great to deliver this in PG15. Please
let me know if you believe it's unrealistic for any reason so I will
focus on testing and reviewing other patches.
For now, I'm changing the status of the patch to "Waiting on Author".
--
Best regards,
Aleksander Alekseev
eep English capitalization rules.
--
Best regards,
Aleksander Alekseev
Hi Tom.
Yeah, there's plenty of precedent for that coding if you look around.
> I've not read the whole patch, but this snippet seems fine to me
> if there's also an #undef at the end of the function.
>
No, there is no #undef. With #undef I don't mind it either.
[1]: https://www.postgresql.org/list/
--
Best regards,
Aleksander Alekseev
Hi Dave,
> Message to list pgsql-hackers held for moderation due to 'Size 1MB (1061796
> bytes) is larger than threshold 1000KB (1024000 bytes)', notice queued for 2
> moderators
Thanks! Does anyone know if cfbot understands .patch.gz and/or .tgz ?
--
Best regards,
Aleksander Alekseev
ink:
Any chance we could include the reason in the message? I foresee that
otherwise such kinds of questions will be asked over and over again.
--
Best regards,
Aleksander Alekseev
Hi again,
> Any chance we could include the reason in the message? I foresee that
> otherwise such kinds of questions will be asked over and over again.
A link to the list of common reasons should work too.
--
Best regards,
Aleksander Alekseev
--
Best regards,
Aleksander Alekseev
ussion now as well.
IMO v16-0001 and v16-0002 are in pretty good shape and are as much as
we are going to deliver in PG15. I'm going to change the status of the
CF entry to "Ready for Committer" somewhere this week unless someone
believes v16-0001 and/or v16-0002 shouldn't be merged.
--
Best regards,
Aleksander Alekseev
like `select row_to_json(i)
from int8_tbl i(x,y)` is not necessarily the correct one, at least it
doesn't look right to me.
So unless anyone has strong objections against the proposed fix or can
propose a better patch, I would suggest merging it.
--
Best regards,
Aleksander Alekseev
16 here.
[1]:
https://postgr.es/m/caj7c6tpdoybyrncaeyndkbkto0wg2xsdydutf0nxq+vfkmt...@mail.gmail.com
--
Best regards,
Aleksander Alekseev
eb interface. These comments were not addressed in v21.
--
Best regards,
Aleksander Alekseev
st regards,
Aleksander Alekseev
v1-0001-Remove-workarounds-to-format-u-int64-s.patch
Description: Binary data
Hi Pavel,
> Probably you can do (long long) instead of (long long int). It is shorter and
> this is used elsewhere in the code.
Thanks! Here is the updated patch. I also added Reviewed-by: and
Discussion: to the commit message.
--
Best regards,
Aleksander Alekseev
v2-0001-Remove-worka
Here is a complete patchset with some additional changes by me.
--
Best regards,
Aleksander Alekseev
v3-0001-Remove-workarounds-to-format-u-int64-s.patch
Description: Binary data
v3-0002-Remove-workarounds-to-format-int64-s-in-pg_checks.patch
Description: Binary data
am would
not harm either. In any case, the committer can easily exclude these
changes from the patch, if necessary.
--
Best regards,
Aleksander Alekseev
e
changes by me and Japin, and doesn't touch PO files.
--
Best regards,
Aleksander Alekseev
v4-0001-Remove-workarounds-to-format-u-int64-s.patch
Description: Binary data
be handled in a better way and deliver this change in the
next CF. However, if no one will be able to suggest a better
alternative, I think we should continue making progress here. The
32-bit XIDs are a major inconvenience for many users.
--
Best regards,
Aleksander Alekseev
ck` and I
verified manually that the file inclusion 1) works 2) write proper error
messages to the logfile when the included file doesn't exist or has wrong
permissions.
--
Best regards,
Aleksander Alekseev
Hi hackers,
> It passes `make installcheck` ...
`make installcheck-world`, of course. Sorry for the confusion.
--
Best regards,
Aleksander Alekseev
we
should discuss it a bit more. Although personally I doubt that we can
do much better than that, and as I recall this particular change was
explicitly requested by several people.
--
Best regards,
Aleksander Alekseev
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Personally, I don't often encounter the problem that Alexande
t possible to detect an impossible timestamptz's for users who
wants stricter semantics? If there is a way I think it's worth
documenting as well.
[1]: https://en.wikipedia.org/wiki/Moscow_Time#Past_usage
[2]:
https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-ZONECONVERT
--
Best regards,
Aleksander Alekseev
xtend this functionality for other types as
well.
Thoughts?
[1]:
https://www.postgresql.org/message-id/CANP8%2BjLT8r03LJsw%3DdUSFxBh5pRB%2BUCKvS3BUT-dd4JPRDb3tg%40mail.gmail.com
--
Best regards,
Aleksander Alekseev
more importantly,
extendable. In the future, we could add additional (optional) methods
for particular scenarios, like partial decompression.
Does it sound like a reasonable approach?
--
Best regards,
Aleksander Alekseev
it work with
partitioned or inherited tables? Or with logical replication? With
pg_dump? With COPY?
So all in all, -1. This being said, I very much appreciate your
attempt to improve PostgreSQL. However next time before writing the
code I suggest submitting an RFC first.
--
Best regards,
Aleksander Alekseev
he SQL syntax itself
extendable. To my knowledge, this is still a wanted feature [1]. In theory,
that would allow you to implement the feature you want in an extension.
[1]: https://wiki.postgresql.org/wiki/Todo#Exotic_Features
--
Best regards,
Aleksander Alekseev
you think so.
--
Best regards,
Aleksander Alekseev
ostgresql.org/message-id/flat/8A38B86D9187B34FA18766E261AB3AEA0D2072%40sageograma.GEO-I.local
[2]:
https://www.postgresql.org/message-id/flat/CAJ7c6TPx7N-bVw0dZ1ASCDQKZJHhBYkT6w4HV1LzfS%2BUUTUfmA%40mail.gmail.com
--
Best regards,
Aleksander Alekseev
I don't think there are many
cases when you have a table with tens of columns you want to hide. SELECT *
EXCEPT should work just fine for 1 or 2 columns. For other cases, you can
simply create a VIEW.
--
Best regards,
Aleksander Alekseev
answer this.
--
Best regards,
Aleksander Alekseev
h allow user query input we must
> handle the case.
Sure, no worries. And my apologies if my feedback seemed a little harsh.
I'm sure our goal is mutual - to make PostgreSQL even better than it
is now. Finding a consensus occasionally can take time though.
--
Best regards,
Aleksander Alekseev
ed offlist by Sven
Klemm. Investigated and fixed by me.
[1]: https://github.com/timescale/timescaledb/actions/runs/1343346998
--
Best regards,
Aleksander Alekseev
v1-0001-memory-corruption-fix.patch
Description: Binary data
easonable, no?
What confuses me is the fact that we have two procedures that do the
same thing. Maybe one is redundant.
--
Best regards,
Aleksander Alekseev
/CAJ7c6TP0AowkUgNL6zcAK-s5HYsVHVBRWfu69FRubPpfwZGM9A%40mail.gmail.com
--
Best regards,
Aleksander Alekseev
v1-0001-refactoring-MakeTupleTableSlot.patch
Description: Binary data
Hi Michael,
> Do you have something in mind here?
Yep. This is not a priority though, thus I created a separate CF entry:
https://commitfest.postgresql.org/35/3371/
--
Best regards,
Aleksander Alekseev
.
> [...]
OK, I will need some time to figure out the actual difference between
these two functions and to submit an updated version of the patch.
--
Best regards,
Aleksander Alekseev
Hi hackers,
> I'm going to mark it as "Ready for Committer" unless anyone objects.
I updated the status of the patch.
To clarify, Alexander and I replied almost at the same time. The
drawbacks noted by Alexander are fixed in the v2 version of the patch.
--
Best regards,
Aleksander Alekseev
tps://blog.timescale.com/blog/how-and-why-to-become-a-postgresql-contributor/
--
Best regards,
Aleksander Alekseev
ypo in pg_trgm.c. The corrected patch is
attached. Assuming the new version will not upset cfbot, I would call
the patch "Ready for Committer".
--
Best regards,
Aleksander Alekseev
prng-17.patch
Description: Binary data
a bit busy with various things at the moment, so (hopefully) I will
submit the actual code review in the follow-up email.
--
Best regards,
Aleksander Alekseev
v11-0001-Move-a-few-ResourceOwnerEnlarge-calls-for-safety.patch
Description: Binary data
v11-0002-Make-resowners-more-easily-extensible.p
Hi Heikki,
> I will submit the actual code review in the follow-up email
The patchset is in a good shape. I'm changing the status to "Ready for
Committer".
--
Best regards,
Aleksander Alekseev
Hello everyone,
I would like to let you know that unfortunately these patches don't apply
anymore. Also personally I'm a bit confused by the last message that has 0001-
and 0003- patches attached but not the 0002- one.
ts. I fixed that too.
I believe it's "Ready for Committer".
--
Best regards,
Aleksander Alekseev
diff --git a/src/backend/utils/adt/jsonb.c b/src/backend/utils/adt/jsonb.c
index 0f70180164..fb907f2a73 100644
--- a/src/backend/utils/adt/jsonb.c
+++ b/src/backend/utils/adt/j
7;t sound right to me to accept any input as a general rule but
sometimes return errors nevertheless. That API would be complicated for
the users. Thus I suggest to accept any garbage and try our best to
interpret it.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
n
> a more complicated case I suspect people will have a hard time
> figuring out what the source of that error message is. It seems like
> it would be better to say something about casting or converting in the
> error message, to give users a clue.
I agree. How about "unable to cast jsonb value to %typename%"?
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
type jsonb to
bool", etc.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
eger to jsonb
> LINE 1: select 123::int4::jsonb;
> ```
>
> I suggest to follow the same template, i.e. "cannot cast type jsonb to
> bool", etc.
On second thought this message is misleading. We can cat jsonb to bool,
the problem is that the document is not a bool value.
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
LGTM.
The new status of this patch is: Ready for Committer
ld be great to have
covering indexes support for GiST as well. Please don't forget to add
the thread to the nearest commitfest entry. I'm looking forward for the
next versions of your patch!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
on and definition online?
Vim + Ctags. Editors like Sublime Text and Visual Studio Code have
features like "goto definition" out-of-the-box.
If you have any other questions please don't hesitate to ask!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
LGTM.
The new status of this patch is: Ready for Committer
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Here are a few minor issues:
```
+/*
+ * Checks if 'str' sta
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I can confirm this code works. However, since this is quite a
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
I can confirm that these patches don't break anything; the co
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
This patch seems to be in a pretty good shape. There is a roo
hether tests should include hashing
non-ASCII characters as well.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
s code that repeats 3 times can be moved to a separate
procedure?
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
w I left a
TODO mark in the comment.
TWIMC the full report can be found here:
https://afiskon.ru/s/3c/736207c9d2_valgrind-2018-02-20.tgz
--
Best regards,
Aleksander Alekseev
diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp
index af03051260..accf989047 100644
--- a/src/tools/valgrind
e-tap-tests --enable-cassert --enable-debug \
--enable-nls --with-perl --with-tcl --with-gssapi --with-ldap
```
The system is Arch Linux x64, GCC version is 7.3.0.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
are
> welcomed!
To my best knowledge currently there are no other students interested in
this particular work.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Hello David,
> Just a few days left until the last Commitfest for the PG11 release begins!
>
> I'm planning to fill the CFM role, unless there are objections.
Thank you for volunteering!
I would like to be CFM assistant, if you need one :)
--
Best regards,
Aleksander Alekseev
be used not only from the backend.
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4eda0a64705
[2]: https://postgr.es/m/20150806070902.ge12...@awork2.anarazel.de
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Unfortunately according to http://commitfest.cputube.org/ this patch does
the "Improve geometric types" patch doesn't apply.
I already notified the author. I'll try to write a script that exports
data from this site as well to make cross-checking easier.
If there is anything else I can help you with, just let me know.
--
Best regards,
Aleksande
l | 2018-01-10 08:54:00
Raw data is attached.
[1]: https://github.com/afiskon/py-autoreviewer
--
Best regards,
Aleksander Alekseev
data.sql.gz
Description: application/gzip
signature.asc
Description: PGP signature
ect array_to_json(array_agg(row_to_json(tbl))) from tbl;
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
optimization... don't remember exact words and who
said this.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
y this answers you question. If you have other questions please
don't hesitate to ask!
[1]: https://github.com/postgrespro/zson
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
WS deploys it. (Assuming there is a PostgreSQL core developer
interested in this particular task and he or she has time to spare.)
It is my understanding that waiting a few years is not an option in your
case. This is why I'm proposing an alternative solution.
--
Best regards,
Aleksa
It seems that this patch doesn't apply anymore, see
http://commitfest.cputube.org/
The new status of this patch is: Waiting on Author
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hello Michael,
It looks like that this patch doesn't apply anymore:
http://
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Unfortunately this patch doesn't apply anymore: http://commitfest.cputube.org
ne (UTC+3) right now
though so I'm going to make it tomorrow.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
used and are not fully
implemented in most existing libraries.
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
sql.org/wiki/GSoC_2018
Which one you are most interested in?
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
me/eax/examples/thrift/tests/BinaryProtocol.scala#L15
[2]:
https://postgr.es/m/CA%2BSXE9sP1iHNp9_DFJzdbE0cszAA-QF8d-8GAUyoCA4q9KCsGw%40mail.gmail.com
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
Hello Christos,
> Do you have any project related insights as to what I should put in
> there?
Nope :) I believe Andrey Borodin and Atri Sharma have (added to CC).
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
x27;t know that. In this case I will be happy to see any sorts of
projects related to Protobuf or any other binary format - Thrift, Avro,
Cap'n'Proto, MessagePack, etc!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
ve pg_filedump will be most likely executed
on the system which doesn't has a PostgreSQL package installed. And it's
distributed separately just for this reason I believe.
[1]: https://git.postgresql.org/gitweb/?p=pg_filedump.git;a=summary
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
ther people vote for the links:
https://news.ycombinator.com/
https://www.reddit.com/r/PostgreSQL/
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
se
don't hesitate to ask!
--
Best regards,
Aleksander Alekseev
signature.asc
Description: PGP signature
1 - 100 of 934 matches
Mail list logo
