Memory leak fix in rmtree.c

2024-02-06 Thread Ильясов Ян
Hello hackers, Just like some of my colleagues I've been using Svace* and I think I've found a bug in src/common/rmtree.c . In 64th line function returns false in case it couldn't open a directory, but the memory, that have been allocated for char** dirnames is not freed. The patch that has a fi

RE: Memory leak fix in rmtree.c

2024-02-06 Thread Ильясов Ян
> dirnames isn't allocated at this point, it's palloc'd after this return > statement on line 67. > > -- > Daniel Gustafsson I am sorry, I pointed on the wrong branch. I see that in master it is really in line 67th , and the allocation goes well. But in REL_16_STABLE the allocation is in line 58th

RE: Memory leak fix in rmtree.c

2024-02-06 Thread Ильясов Ян
I agree with your argument. Thank you for your time. Kind regards, Ian Ilyasov Juniour Software Developer at Postgres Professional

Integer undeflow in fprintf in dsa.c

2024-02-20 Thread Ильясов Ян
Hello hackers, Using Svace* I think I've found a little bug in src/backend/utils/mmgr/dsa.c. This bug is presented in REL_12_STABLE, REL_13_STABLE, REL_14_STABLE, REL_15_STABLE, REL_16_STABLE and master. I see that it was introduced together with dynamic shared memory areas in the commit 13df76a5