Re: tab complete for COPY populated materialized view TO

On Wed, 9 Apr 2025 at 14:45, Fujii Masao wrote: > > > > On 2025/04/09 18:25, Kirill Reshke wrote: > > On Wed, 9 Apr 2025 at 13:23, jian he wrote: > >> > >> hi. > >> > >> we allow the "COPY table TO" command to copy rows from materialized > >> views in [1]. > >> The attached patch is to add a tab

Re: SQLFunctionCache and generic plans

In the department of no-good-deed-goes-unpunished ... I noticed that avocet and trilobite (two of our CLOBBER_CACHE_ALWAYS animals) have started to fail on the deadlock-parallel isolation test, with symptoms that look like they're timing out. Poking at it here with a somewhat faster machine (a Ma

Re: Cleaning up ERRCODE usage in our XML code

On 14.09.24 21:14, Tom Lane wrote: +Section: Class 10 - XQuery Error + +# recent SQL versions define quite a few codes in this class, but for now +# we are only using this generic one +10608EERRCODE_INVALID_ARGUMENT_FOR_XQUERY invalid_argument_for_xquery Coul

Re: Feature freeze

On Tue, Apr 8, 2025 at 10:13 PM Daniel Gustafsson wrote: > > I find both of the above needlessly confusing when we instead could use UTC > which is a more universally understood concept. Indeed, that's what the "U" stands for, after all. :-) -- John Naylor Amazon Web Services

Re: pgsql: Make cancel request keys longer

(moving to pgsql-hackers) On 09/04/2025 12:39, Peter Eisentraut wrote: On 09.04.25 10:53, Heikki Linnakangas wrote: On 08/04/2025 22:41, Heikki Linnakangas wrote: On 08/04/2025 20:06, Peter Eisentraut wrote: While I was looking at this, I suggest to make the first argument void *.  This is co

Re: Remove unnecessary static type qualifiers

On Wed, Apr 9, 2025 at 12:25 PM Japin Li wrote: > > On Wed, 09 Apr 2025 at 10:34, Junwang Zhao wrote: > > On Wed, Apr 9, 2025 at 5:22 AM David Rowley wrote: > >> > >> On Wed, 9 Apr 2025 at 03:46, Peter Eisentraut wrote: > >> > To avoid creating an array on the stack, you could maybe write it wi

Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c

Hi, While working on another patch, I find that tablecmds.c now has three ways to check the validity of catalog tuples. i. if (tuple != NULL) ii. if (!tuple) iii. if (HeapTupleIsValid(tuple) In tablecmds.c, most checks use macro HeapTupleIsValid. For code readability, I changed the first and th

Re: Add missing PGDLLIMPORT markings

> On 9 Apr 2025, at 12:02, Peter Eisentraut wrote: -extern const pg_be_sasl_mech pg_be_oauth_mech; +extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech; +1 on this. > Btw., this new variable in memutils.h > >extern dsa_area *area; > > could probably do with a less generic name? Good

<    1   2