Hi!
I have read the discussion and would like
to share my humble opinion. I believe that
a visually appealing way to display the
output on the screen is to ensure symmetry
in the length of asterisks and description lines.
I imagine someone looking at the screen and
focusing on symmetrical details.
On Mon, Mar 31, 2025 at 11:11:47AM -0400, Corey Huinker wrote:
> In light of v11-0001 being committed as 4694aedf63bf, I've rebased the
> remaining patches.
I spent the day preparing these for commit. A few notes:
* I've added a new prerequisite patch that skips the second WriteToc() call
for
Hi!
I have read the discussion and would like
to share my humble opinion. I believe that
a visually appealing way to display the
output on the screen is to ensure symmetry
in the length of asterisks and description lines.
I imagine someone looking at the screen and
focusing on symmetrical details.
On Mon, Mar 31, 2025 at 1:49 PM Tom Lane wrote:
> Robert Haas writes:
> > But why isn't it just as valuable to have two decimal places for the
> > estimate? I theorize that the cases that are really a problem here are
> > those where the row count estimate is between 0 and 1 per row, and
> > roun
On Fri, Mar 21, 2025 at 8:40 AM torikoshia wrote:
> Rebased it again.
Hi,
I apologize for not having noticed this thread sooner. I just became
aware of it as a result of a discussion in the hacking Discord server.
I think this has got a lot over overlap with the progressive EXPLAIN
patch from Ra
On Mon, Mar 31, 2025 at 8:27 AM David Rowley wrote:
>
> On Sat, 29 Mar 2025 at 05:46, Ashutosh Bapat
> wrote:
> > PFA patches. 0001 and 0002 are the same as the previous set. 0003
> > changes the initial hash table size to the length of ec_derives.
>
> I'm just not following the logic in making i
Hello again,
> ERROR: could not attach to dynamic shared area
In addition to that refactoring issue, the current patch had a race
condition in pg_stat_progress_explain to access the DSA of a process
running a query that gets aborted.
While discussing with Robert we agreed that it would be wiser
On 2025-Mar-31, Daniel Gustafsson wrote:
> Given where we are in the cycle, it seems to make sense to stick to using the
> schedule we already have rather than invent a new process for generating it,
> and work on that for 19?
No objections to that. I'll see about getting this committed during m
On Tue, Apr 1, 2025 at 1:55 AM Robert Haas wrote:
> As a general principle, I have found that it's usually a sign that
> something has been designed poorly when you find yourself wanting to
> open a relation, get exactly one piece of information, and close the
> relation again. That is why, today,
On Tue, 1 Apr 2025 at 04:40, Christoph Berg wrote:
> - Storage: Disk Maximum Storage: NkB
> + Storage: Memory Maximum Storage: NkB
> -> Function Scan on generate_series a (actual time=N.N..N.N rows=N.N
> loops=N)
We'll probably just need to bump that 2000 row count to something a
bit
On 2025/02/03 19:31, Jim Jones wrote:
Hi Kirill
On 31.01.25 11:46, Kirill Gavrilov wrote:
Sorry for the long silence. I fixed the indentation and a trailing
whitespace. Should look fine now.
The patch applies cleanly, the documentation is clear, and all tests pass.
It is possible to cha
Alexander Pyhalov writes:
> I've looked through it and made some tests, including ones which
> caused me to create separate context for planing. Was a bit worried
> that it has gone, but now, as fcache->fcontext is deleted in the end
> of function execution, I don't see leaks, which were the initi
On Mon, Mar 31, 2025 at 11:52 AM Masahiko Sawada
wrote:
> On Sat, Mar 29, 2025 at 9:49 AM David G. Johnston
> wrote:
> >
> > On Wed, Mar 26, 2025 at 8:28 PM Sutou Kouhei wrote:
> >>
> >>
> >> The attached v39 patch set uses the followings:
> >>
> >> 0001: Create copyto_internal.h and change COP
Dear PostgreSQL Developers,
I have identified a potential integer overflow issue in the binary search
implementation within the DSA size class lookup code.
Issue Description
In the current implementation, the calculation of mid is performed as:
uint16 mid = (max + min) / 2;
Since both max and m
On Mon, Mar 31, 2025 at 8:13 PM jian he wrote:
> On Mon, Mar 31, 2025 at 11:27 PM Fujii Masao
>
> >
> > The copy.sgml documentation should clarify that COPY TO can
> > be used with a materialized view only if it is populated.
> >
> "COPY TO can be used only with plain tables, not views, and does
On Mon, Mar 31, 2025 at 9:12 PM jian he wrote:
> On Tue, Apr 1, 2025 at 6:22 AM David G. Johnston
> wrote:
> >
> > On Tue, Mar 18, 2025 at 9:04 PM jian he
> wrote:
> >>
> >>
> >> new patch attached.
> >>
> >
> > I've done v4 with a delta patch.
>
> your v4-0001-v3-0001-substring.patch is not th
Hi all,
tzdata 2025b has been released on 3/22[1]. Do we need to update the
tzdata.zi file on HEAD and backbranches?
Regards,
[1] https://data.iana.org/time-zones/tzdb/NEWS
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
but it found an actual bug:
>
> /build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/interfaces/libpq/fe-auth-oauth-curl.c:
> In function ‘register_socket’:
> /build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/interfaces/libpq/fe-auth-oauth-curl.c:1317:20:
Hi, Alexander!
On 30.03.2025 00:59, Alexander Korotkov wrote:
Hi, Alena!
On Sat, Mar 29, 2025 at 9:03 PM Alena Rybakina
wrote:
On 29.03.2025 14:03, Alexander Korotkov wrote:
One thing I have to fix: we must do
IncrementVarSublevelsUp() unconditionally for all expressions as Vars
could be de
Re: David Rowley
> Any chance you could share the output of:
>
> explain (analyze,buffers off,costs off) select sum(n) over() from
> generate_series(1,2000) a(n);
PostgreSQL 18devel on x86-linux, compiled by gcc-14.2.0, 32-bit
=# explain (analyze,buffers off,costs off) select sum(n) over() from
On 31.03.2025 22:09, Robert Haas wrote:
Oh, right. I've never really understood why we round off to integers,
but the fact that we don't allow row counts < 1 feels like something
pretty important. My intuition is that it probably helps a lot more
than it hurts, too.
We definitely shouldn’t re
Hi,
With commit c120550edb86, If we got the cleanup lock on the page,
lazy_scan_prune() marks dead item IDs directly to LP_UNUSED. So the
following check with has_lpdead_items made the periodic FSM vacuum in
the one-pass strategy vacuum no longer being triggered:
if (got_cleanup_lock
From: David Rowley
Subject: Re: pgsql: Add memory/disk usage for Window aggregate nodes in EXPLAIN.
Date: Tue, 1 Apr 2025 11:09:11 +1300
Message-ID:
> On Tue, 1 Apr 2025 at 09:40, Christoph Berg wrote:
>> =# explain (analyze,buffers off,costs off) select sum(n) over() from
>> generate_series(1
On Tue, 1 Apr 2025 at 06:31, jian he wrote:
>
> On Mon, Mar 31, 2025 at 4:05 PM Kirill Reshke wrote:
>
> Thanks for doing the benchmark.
Few comments to improve the comments, error message and remove
redundant assignment:
1) How about we change below:
/*
* partition's rowtype might differ from
On 3/31/25 19:35, Robert Haas wrote:
But why isn't it just as valuable to have two decimal places for the
estimate? I theorize that the cases that are really a problem here are
those where the row count estimate is between 0 and 1 per row, and
rounding to an integer loses all precision.
Issues I'
On Mon, 31 Mar 2025 at 23:43, Álvaro Herrera wrote:
>
> Hi
>
> FWIW I don't think the on_exit_nicely business is in final shape just
> yet. We're doing something super strange and novel about keeping track
> of an array index, so that we can modify it later. Or something like
> that, I think? T
On Mon, Mar 31, 2025 at 5:04 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Thu, Mar 27, 2025 at 2:29 PM Amit Kapila wrote:
>
> >
> > I suspect that this can happen in PG17 as well, but I need to think
> > more about it to make a reproducible test case.
>
> After further analysis, I was able to reproduce t
On Mon, Mar 31, 2025 at 3:12 PM Melanie Plageman
wrote:
>
> On Mon, Mar 31, 2025 at 6:03 PM Masahiko Sawada wrote:
> >
> > With commit c120550edb86, If we got the cleanup lock on the page,
> > lazy_scan_prune() marks dead item IDs directly to LP_UNUSED. So the
> > following check with has_lpdead_
Jianghua Yang 于2025年4月1日周二 04:29写道：
> Dear PostgreSQL Developers,
>
> I have identified a potential integer overflow issue in the binary search
> implementation within the DSA size class lookup code.
> Issue Description
>
> In the current implementation, the calculation of mid is performed as:
>
Hi, Alena!
On Tue, Apr 1, 2025 at 2:11 AM Alena Rybakina
wrote:
> Yes, I agree with that - this is precisely why we need to call
IncrementVarSublevelsUp() unconditionally for all types.
>
> As you mentioned earlier, Var nodes can be nested more deeply, and
skipping this step could lead to incorre
On Tue, Apr 1, 2025 at 6:22 AM David G. Johnston
wrote:
>
> On Tue, Mar 18, 2025 at 9:04 PM jian he wrote:
>>
>>
>> new patch attached.
>>
>
> I've done v4 with a delta patch.
>
> Decided to standardize on calling the SQL Similar To regular expression
> escape replaceable "escape" everywhere.
>
On Mon, Mar 31, 2025 at 10:33 PM Nathan Bossart
wrote:
> On Mon, Mar 31, 2025 at 11:11:47AM -0400, Corey Huinker wrote:
> Regarding whether pg_dump should dump statistics by default, my current
> thinking is that it shouldn't, but I think we _should_ have pg_upgrade
> dump/restore statistics by de
On Mon, Mar 31, 2025 at 11:27 PM Fujii Masao
wrote:
>
> Regarding the patch, here are some review comments:
>
> + errmsg("cannot copy from
> materialized view when the materialized view is not populated"),
>
> How about including the object name for c
On Mon, Mar 31, 2025 at 4:05 PM Kirill Reshke wrote:
>
> Hi!
> I reviewed v7. Maybe we should add a multi-level partitioning case
> into copy2.sql regression test?
>
sure.
> I also did quick benchmarking for this patch:
>
> DDL
>
> create table ppp(i int) partition by range (i);
>
> genddl
Hi,
I am working on a feature adjacent to the connection service functionality
and noticed some issues with the tests introduced in this thread. Basically
they incorrectly invoke the append perl function by passing multiple
strings to append when the function only takes one string to append. This
Re: To Daniel Gustafsson
> > Add support for OAUTHBEARER SASL mechanism
>
> Debian still has this experimental port with a GNU userland and a
> FreeBSD kernel called kfreebsd.
Sorry this part was nonsense, kfreebsd was actually terminated and
obviously I didn't even read the port's name. The fail
Hi,
Thank you for looking into this!
On Mon, 31 Mar 2025 at 17:42, Melanie Plageman
wrote:
>
> On Sun, Mar 30, 2025 at 10:01 AM Nazir Bilal Yavuz wrote:
> >
> > > Some review feedback on your v4: I don't think we need the
> > > rs_have_free_buffer per_buffer_data. We can just check
> > > have_f
On Mon, Mar 31, 2025 at 6:03 PM Masahiko Sawada wrote:
>
> With commit c120550edb86, If we got the cleanup lock on the page,
> lazy_scan_prune() marks dead item IDs directly to LP_UNUSED. So the
> following check with has_lpdead_items made the periodic FSM vacuum in
> the one-pass strategy vacuum
On Tue, 1 Apr 2025 at 09:40, Christoph Berg wrote:
> =# explain (analyze,buffers off,costs off) select sum(n) over() from
> generate_series(1,2048) a(n);
> QUERY PLAN
>
> On 28 Mar 2025, at 19:12, Alvaro Herrera wrote:
>
> On 2025-Mar-28, Tom Lane wrote:
>
>> I think instead of going this direction, we really need to create a
>> separately-purposed script that simply creates "one of everything"
>> without doing anything else (except maybe loading a little data)
On Tue, Mar 18, 2025 at 9:04 PM jian he wrote:
>
> new patch attached.
>
>
I've done v4 with a delta patch.
Decided to standardize on calling the SQL Similar To regular expression
escape replaceable "escape" everywhere.
Instead of fully documenting the obsolete syntax I added a note explaining
Masahiko Sawada writes:
> tzdata 2025b has been released on 3/22[1]. Do we need to update the
> tzdata.zi file on HEAD and backbranches?
Yup, eventually, but I don't normally worry about it until we are
approaching a release date. tzdata changes often come in bunches
around the spring and fall e
On 2025-04-01 04:24, Robert Haas wrote:
On Fri, Mar 21, 2025 at 8:40 AM torikoshia
wrote:
Rebased it again.
Hi,
I apologize for not having noticed this thread sooner.
Thank you for your checking! No worries.
I just became
aware of it as a result of a discussion in the hacking Discord ser
Hello community,
I recently encountered a deadlock in postgresql while performing concurrent
INSERT statements on the same table in two separate sessions.
The error message explicitly mentions that the deadlock occurred while
inserting an index tuple.
There were no explicit transactions (BEGIN/
On Fri, Mar 28, 2025 at 10:06 PM Peter Eisentraut wrote:
>
> On 24.03.25 04:26, jian he wrote:
> > rebase, and some minor code comments change.
>
> I have committed this.
>
In an earlier thread, I also posted a patch for supporting virtual
generated columns over domain type.
The code is somehow si
On Wed, 26 Mar 2025 at 16:32, Daniel Gustafsson wrote:
> > On 26 Mar 2025, at 17:15, Tom Lane wrote:
> >
> > Daniel Gustafsson writes:
> >> Thanks for review! Pushed after making the above changes and taking it
> for
> >> another CI run.
> >
> > CF entry should be marked closed no?
>
> Yep, ju
On Mon, Mar 31, 2025 at 6:46 PM Andrei Lepikhov wrote:
> On 3/31/25 11:03, Richard Guo wrote:
> > I reviewed this patch and I have some concerns about the following
> > code:
> >
> > if (extra->inner_unique &&
> > (inner_path->param_info == NULL ||
> > bms_num_members(inner
On Mon, Mar 31, 2025 at 5:07 PM Ashutosh Bapat
wrote:
>
The bug related to materialized views has been fixed and now the test
passes even if we compare statistics from dumped and restored
databases. Hence removing 0003. In the attached patchset I have also
addressed Vignesh's below comment
On Thu
> We’ve prepared two test patches on top of current master to address
both issues:
> ...
> * 0002-Implement-batching-for-cascade-replication.patch – test patch
to implement possible batching approach in xlogreceiver.c with timer.
Currently it uses GUC variables to allow testing of different bat
Hi,
On Mon, Mar 24, 2025 at 08:41:20AM +0900, Michael Paquier wrote:
> On Wed, Mar 19, 2025 at 04:00:49PM +0800, Xuneng Zhou wrote:
> > Hi,
> > Moving the other two provides a more complete view of the settings. For
> > newcomers(like me) to the codebase, seeing all three related values in one
> >
On 2025-Mar-31, jian he wrote:
> hi.
> in notnull-notvalid.patch
>
> + if (coninfo->contype == 'c')
> + keyword = "CHECK CONSTRAINT";
> + else
> + keyword = "INVALID NOT NULL CONSTRAINT";
> we have a new TocEntry->desc kind.
Yeah, I wasn't sure that this change made much actual sense. I think i
Peter Eisentraut writes:
> I'm not sure what to do with this. If setlocale() and newlocale()
> indeed behave differently in what set of locale names they accept, then
> technically we ought to test both of them, since we do use both of them
> later on. Or maybe we push on with the effort to g
Re: Andres Freund
> > Yes. Also, none of this has addressed my complaint about the extent
> > of the build and install dependencies. Yes, simply not selecting
> > --with-libcurl removes the problem ... but most packagers are under
> > very heavy pressure to enable all features of a package.
And
On Sun, 2 Feb 2025 00:15:25 -0500
Tom Lane wrote:
> Yugo Nagata writes:
> > This might be avoidable if the binary is made carefully to check the
> > existing
> > of objects, but I think it is useful if an extension module function can
> > check
> > the current extension version. So, I would li
On Thu, 16 Jan 2025 09:41:35 -0800
Jeff Davis wrote:
> On Thu, 2025-01-16 at 14:53 +0900, Yugo NAGATA wrote:
> > Instead of generating complete patterns considering every case-
> > varying characters,
> > two clauses considering only the first case-varying character are
> > generated.
>
> Did yo
Hi,
While working on [1], I found the internal error "tuple concurrently updated"
is raised by simple_heap_update and other similar functions, and the comments
on them says "Any failure is reported via ereport()". However, I could not
understand
the intension of this comments because I suppose th
On 3/31/25 01:01, Rahila Syed wrote:
> ...
>
>
> > I will improve the comment in the next version.
> >
>
> OK. Do we even need to pass nelem_alloc to hash_get_init_size? It's not
> really used except for this bit:
>
> + if (init_size > nelem_alloc)
> + element_
Hi Florents,
> Here's a v3 with some (hopefully) better test cases.
Thanks for the new version of the patch.
```
+encoded_len = pg_base64_encode(src, len, dst);
+
+/* Convert Base64 to Base64URL */
+for (uint64 i = 0; i < encoded_len; i++) {
+if (dst[i] == '+')
+d
Hi,
On Sat, Mar 29, 2025 at 07:14:16AM +0900, Michael Paquier wrote:
> On Fri, Mar 28, 2025 at 09:00:00PM +0200, Alexander Lakhin wrote:
> > Please try the following query:
> > BEGIN;
> > SET LOCAL stats_fetch_consistency = snapshot;
> > SELECT * FROM pg_stat_get_backend_wal(pg_backend_pid());
Th
On 3/31/25 05:33, David Rowley wrote:
I can't say definitively that we won't find a reason in the future
that we should set inner_unique for SEMI/ANTI joins, so I don't follow
the need for the Assert.
Maybe you're seeing something that I'm not. What do you think will
break if both flags are true
Hi!
I reviewed v7. Maybe we should add a multi-level partitioning case
into copy2.sql regression test?
I also did quick benchmarking for this patch:
DDL
create table ppp(i int) partition by range (i);
genddl.sh:
for i in `seq 0 200`; do echo "create table p$i partition of ppp for
values
On Sat, Mar 29, 2025 at 2:42 AM Alvaro Herrera wrote:
>
> On 2025-Mar-28, jian he wrote:
>
> > i think your patch messed up with pg_constraint.conislocal.
> > for example:
> >
> > CREATE TABLE parted (id bigint default 1,id_abc bigint) PARTITION BY LIST
> > (id);
> > alter TABLE parted add CONSTR
On 3/27/25 01:58, David Rowley wrote:
I suspect the fix for this might be a bit invasive to backpatch. Maybe
it's something we can give a bit more clear thought to after the
freeze is over.
One more issue I think may be addressed (or just considered) here is the
following:
CREATE TABLE parted
On Thu, Mar 27, 2025 at 2:40 PM Andres Freund wrote:
>
> Hi,
Hi Andres,
> On 2025-03-27 14:02:03 +0100, Jakub Wartak wrote:
> >setup_additional_packages_script: |
> > -#apt-get update
> > -#DEBIAN_FRONTEND=noninteractive apt-get -y install ...
> > +apt-get update
> > +DEBIAN_
On Thu, Mar 27, 2025 at 2:15 PM Álvaro Herrera wrote:
> Hello
Good morning :)
> I think you should remove numa_warn() and numa_error() from 0001.
> AFAICS they are dead code (even with all your patches applied), and
> furthermore would get you in trouble regarding memory allocation because
> sr
On Mon, 31 Mar 2025 at 22:03, Richard Guo wrote:
> I reviewed this patch and I have some concerns about the following
> code:
>
> if (extra->inner_unique &&
> (inner_path->param_info == NULL ||
> bms_num_members(inner_path->param_info->ppi_serials) <
> list_length(ext
On Mon, Mar 31, 2025 at 6:39 PM David Rowley wrote:
> On Mon, 31 Mar 2025 at 22:03, Richard Guo wrote:
> > I reviewed this patch and I have some concerns about the following
> > code:
> >
> > if (extra->inner_unique &&
> > (inner_path->param_info == NULL ||
> > bms_num_member
On 2025/03/30 5:01, Andrew Dunstan wrote:
On 2025-03-29 Sa 2:58 PM, David G. Johnston wrote:
On Sat, Mar 29, 2025 at 11:56 AM Andrew Dunstan wrote:
I don't believe that the premise supports the conclusion.
Regardless, I do support this patch and probably any similar ones proposed in
> The proposed patch extracts the code dealing with bytea from varlena.c
> into a separate file, as proposed previously [1]. It merely changes
> the location of the existing functions. There are no other changes.
Rebased.
--
Best regards,
Aleksander Alekseev
From 86776455a7b82f8cad6b984d3ddd67fc
>
> Anyway, my feeling about it is that \copy parsing is a huge hack
> right now, and I'd rather see it become less of a hack, that is
> more like other psql commands, instead of getting even hackier.
>
I wasn't as horrified as Tom, but it did have the feeling of it solving
half the problem.
We c
On 2025/03/31 22:45, Yugo Nagata wrote:
I prefer this approach clarifying that consistency and subtransaction overflow
are separate concepts in the documentation.
Here are minor comments on the patch:
Thanks for the review!
- case CAC_NOTCONSISTENT:
- if (EnableHo
Junwang Zhao writes:
> On Mon, Mar 31, 2025 at 5:58 AM Tom Lane wrote:
>> In v18, it's somewhat annoying that the typcache doesn't cache
>> the typarray field; we would not need a separate get_array_type()
>> lookup if it did. I doubt there is any real reason for that except
>> that pg_type.typa
On 2025-03-31 Mo 1:16 PM, Andrew Dunstan wrote:
Thanks. Here are patches that contain (my version of) all the
cleanups. With this I get a clean restore run in my test case with no
error messages.
This time with patches
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprised
On Fri, Mar 28, 2025 at 2:42 PM Alvaro Herrera wrote:
> Maybe the real problem here is that making the (valid) child constraint
> no longer local when the parent constraint is not valid is not sensible,
> precisely because pg_dump won't be able to produce good output. That
> sounds more workable
>
> The second is that the pg_upgrade test (when run with
>> olddump/oldinstall) compares the before and after dumps, and if the
>> "before" version is 17, then it will not have the relallfrozen argument
>> to pg_restore_relation_stats. We might need a filtering step in
>> adjust_new_dumpfile?
>>
>
Hi,
On Mon, Mar 31, 2025 at 11:27:50AM +0200, Jakub Wartak wrote:
> On Thu, Mar 27, 2025 at 2:40 PM Andres Freund wrote:
> >
> > > +Size
> > > +pg_numa_get_pagesize(void)
> [..]
> >
> > Should this have a comment or an assertion that it can only be used after
> > shared memory startup? Because be
On Mon, 31 Mar 2025 20:00:57 +0900
Yugo Nagata wrote:
> Hi,
>
> I found that multiple sessions concurrently execute CREATE OR REPLACE FUNCTION
> for a same function, the error "tuple concurrently updated" is raised. This is
> an internal error output by elog, also the message is not user-friendl
On Mon, Mar 24, 2025 at 2:18 AM Ashutosh Sharma wrote:
> Thank you, Robert and Tom, for sharing your valuable insights, and
> apologies for the slight delay in my response. From the discussion,
> what I understand is that we aim to extend the current DROP ROLE
> syntax to include the CASCADE/RESTR
Hi,
On Mon, 31 Mar 2025 at 16:37, Aidar Imamov wrote:
>
> Hi!
>
> I've reviewed the latest version of the patches and found a few things
> worth
> discussing. This is probably my final feedback on the patches at this
> point.
> Maybe Joseph has something to add.
Thank you so much for the reviews
On Wed, Mar 26, 2025 at 8:28 PM Sutou Kouhei wrote:
>
> > ---
> > +static const CopyFromRoutine CopyFromRoutineTestCopyFormat = {
> > +.type = T_CopyFromRoutine,
> > +.CopyFromInFunc = CopyFromInFunc,
> > +.CopyFromStart = CopyFromStart,
> > +.CopyFromOneRow = Copy
Hi
FWIW I don't think the on_exit_nicely business is in final shape just
yet. We're doing something super strange and novel about keeping track
of an array index, so that we can modify it later. Or something like
that, I think? That doesn't sound all that nice to me. Elsewhere it
was suggested
On 3/31/25 12:18, Richard Guo wrote:
On Mon, Mar 31, 2025 at 6:46 PM Andrei Lepikhov wrote:
Nested Loop
-> Seq Scan on t t2
-> Nested Loop
-> Seq Scan on t t1
-> Subquery Scan on t3
Filter: ((t2.a = t3.a) AND (t1.b = t3.b))
-> Se
> On Mar 31, 2025, at 16:42, Bertrand Drouvot
> wrote:
> I think we can simply move the pgstat_fetch_stat_backend() call at the end
> of pgstat_fetch_stat_backend_by_pid(), like in the attached. With this in
> place
> the issue is fixed on my side.
Thanks for the patch, I’ll check all that next
Hi.
Tom Lane писал(а) 2025-03-30 19:10:
I spent some time reading and reworking this code, and have
arrived at a patch set that I'm pretty happy with. I'm not
sure it's quite committable but it's close:
0005: This extracts the RLS test case you had and commits it
with the old non-failing be
Good day,
14.03.2025 17:30, Tomas Vondra wrote:
> Hi,
>
> I've briefly looked at this patch this week, and done a bit of testing.
> I don't have any comments about the correctness - it does seem correct
> to me and I haven't noticed any crashes/issues, but I'm not familiar
> with the WALBufMappin
Hi Kuroda-san and Amit,
On Fri, Mar 28, 2025 at 09:02:29AM +, Hayato Kuroda (Fujitsu) wrote:
> Dear Amit,
>
> >
> > Right, I think this is a better idea.
I like it too and the bonus point is that this injection point can be used
in more tests (more use cases).
A few comments:
About v
Hello,
I've been biten by psql's \copy lack of variable expansion, in a limited-access
docker-inside-VM context where COPY is not a viable option and hardwired names
are not desirable. The attached patch allows \copy to use variable's values in
place of table and file names:
```psql
\set table
hi.
in notnull-notvalid.patch
+ if (coninfo->contype == 'c')
+ keyword = "CHECK CONSTRAINT";
+ else
+ keyword = "INVALID NOT NULL CONSTRAINT";
we have a new TocEntry->desc kind.
so the following related code within src/bin/pg_dump also needs change
Hi Tom,
On Mon, Mar 31, 2025 at 5:58 AM Tom Lane wrote:
>
> I spent some time looking at the v17 patchset. There were some pretty
> strange things in it --- why were some of the variants of array_sort()
> marked as volatile, for example?
I think this was due to some copy-paste of the code nearb
On Fri, Mar 28, 2025 at 11:43 PM Alvaro Herrera wrote:
>
> On 2025-Mar-28, Tom Lane wrote:
>
> > I think instead of going this direction, we really need to create a
> > separately-purposed script that simply creates "one of everything"
> > without doing anything else (except maybe loading a little
Hi,
SPI_execute_snapshot() has a argument called "fire_triggers". If this is false,
AFTER triggers are postponed to end of the query. This is true in normal case,
but set to false in RI triggers.
This is introduced by 9cb84097623e in 2007. It is aimed to fire check triggers
after all RI updates
Thanks for this valuable testing. I think this is actually a really
good idea for how to test something like this, because the regression
tests contain lots of different queries that do lots of weird things.
On Sun, Mar 30, 2025 at 8:23 PM torikoshia wrote:
> I haven't looked into the code yet, b
On 2025/03/31 22:44, torikoshia wrote:
Here are some comments on the documentation.
Thanks for the review!
The following description in high-availability.sgml also seems to misuse the
word 'consistent':
When the parameter is set to true on a
standby server, it will begin accepting
On Thu, Mar 27, 2025 at 10:08 AM Richard Guo wrote:
> On Thu, Mar 27, 2025 at 10:53 PM Tom Lane wrote:
> > Richard Guo writes:
> > > I'm planning to push this patch soon, barring any objections.
>
> > FWIW, I have not reviewed it at all.
>
> Oh, sorry. I'll hold off on pushing it.
As a general
On Tue, Mar 11, 2025 at 5:58 AM Ilia Evdokimov
wrote:
> In the stats_ext regression test, there is a function
> check_estimated_rows that returns actual rows as an integer. Currently,
> none of the test cases produce a non-zero fractional part in actual rows.
>
> The question is: should this funct
Robert Haas writes:
> But why isn't it just as valuable to have two decimal places for the
> estimate? I theorize that the cases that are really a problem here are
> those where the row count estimate is between 0 and 1 per row, and
> rounding to an integer loses all precision.
Currently, the pla
On Tue, Mar 25, 2025 at 8:12 PM Sami Imseih wrote:
> So this comes down to forking the Postgres code to do the job. What I
>> had in mind was a slightly different flow, where we would be able to
>> push custom node attributes between the header parsing and the
>> generation of the extension code
On Thu, Feb 27, 2025 at 10:43 PM Greg Sabino Mullane wrote:
> I know I'm coming late to this, but I would like us to rethink having
> statistics dumped by default.
+1. I think I said this before, but I don't think it's correct to
regard the statistics as part of the database. It's great for
pg_u
Wow, blast from the past.
First, I no longer have this use case.
Second, the PGSSLCERT, PGSSLKEY, and other relevant environmental
variables should make most clients able to be "fairly easily" switched
from one server to another.
Third, the only real use case where this feature would be criti
Hi,
On Mon, 31 Mar 2025 at 21:15, Melanie Plageman
wrote:
>
> On Mon, Mar 31, 2025 at 12:27 PM Nazir Bilal Yavuz wrote:
> >
> > I worked on an alternative approach, I refactored code a bit. It does
> > not traverse the list two times and I think the code is more suitable
> > to use read streams
1 - 100 of 101 matches
Mail list logo
