Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

2025-02-28 Thread Shubham Khanna
On Tue, Feb 25, 2025 at 4:50 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Shubham, > > Thanks for updating the patch. Few comments. > > 01. CreateSubscriberOptions > ``` > + boolcleanup_existing_publications; /* drop all > publications */ > ``` > > My previous comment [1] #1 did

Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

2025-02-28 Thread Shubham Khanna
On Fri, Feb 21, 2025 at 10:18 AM Ashutosh Bapat wrote: > > On Wed, Feb 19, 2025 at 4:23 PM Hayato Kuroda (Fujitsu) > wrote: > > > > Dear Shubham, > > > > Thanks for updating the patch! > > > > > I have added a test case for non-dry-run mode to ensure that > > > replication slots, subscriptions, a

bug when apply fast default mechanism for adding new column over domain with default value

2025-02-28 Thread jian he
hi. While looking at ATExecAddColumn, I saw there are two DomainHasConstraints, which are cache unfriendly, then I think I found a bug for applying fast default over domain with default value. bug demo: create domain int_domain3 as int check(value > 1) default 11; create domain int_domain4 as in

Re: Should work_mem be stable for a prepared statement?

2025-02-28 Thread Sami Imseih
> I'm also not convinced that the argument requires us to solve > the problem by re-planning. It would work just as well to stamp > each PlannedStmt with the value that the planner used and > refer to that in the executor instead of looking directly at the GUC. hmm, if work_mem influences the pla

Re: Licence preamble update

2025-02-28 Thread Noah Misch
On Fri, Feb 28, 2025 at 12:07:26PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Thu, Feb 27, 2025 at 04:56:05PM +, Dave Page wrote: > >> --- a/COPYRIGHT > >> +++ b/COPYRIGHT > >> @@ -1,5 +1,5 @@ > >> PostgreSQL Database Management System > >> -(formerly known as Postgres, then as Postgre

Re: bug when apply fast default mechanism for adding new column over domain with default value

2025-02-28 Thread Tom Lane
jian he writes: > then I think I found a bug for applying fast default over domain with > default value. Yeah, that's definitely a bug: it worked correctly in versions before we invented the attmissingval mechanism. > column b type is domain int_domain3, which has a constraint. > As a result, ad

Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?

2025-02-28 Thread Lukas Fittl
On Sun, Jun 2, 2024 at 1:08 AM Andres Freund wrote: > At some point this patch switched from rdtsc to rdtscp, which imo largely > negates the point of it. What lead to that? >From what I can gather, it appears this was an oversight when David first reapplied the work on the instr_time changes t

Re: Adding NetBSD and OpenBSD to Postgres CI

2025-02-28 Thread Nazir Bilal Yavuz
Hi, On Fri, 28 Feb 2025 at 19:26, Thomas Munro wrote: > > On Tue, Feb 18, 2025 at 11:33 AM Thomas Munro wrote: > > Maybe we could try this? > > > > https://man.netbsd.org/mount_tmpfs.8 > > https://man.openbsd.org/mount_tmpfs.8 > > NetBSD's test_world: 10:30 -> 3:23 > OpenBSD test_world: 15:45 -

Re: describe special values in GUC descriptions more consistently

2025-02-28 Thread Nathan Bossart
On Tue, Feb 25, 2025 at 02:42:17PM +0300, Ilia Evdokimov wrote: > I´ve addressed all your comments on the v9 patch for updating the > descriptions of auto_explain.log_min_duration and > auto_explain.log_parameter_max_length. Just wanted to check if you had a > chance to take another look. Let me kn

<    1   2