Re: RFC: Allow EXPLAIN to Output Page Fault Information

2025-02-08 Thread Jelte Fennema-Nio
On Mon, 27 Jan 2025 at 10:05, torikoshia wrote: > Therefore, I believe it would be reasonable to report the raw values > as-is, as they should still be useful for understanding storage I/O > activity. Sounds reasonable. Below some feedback on the patch. It's all really minor. The patch looks gre

Re: Why doesn't GiST VACUUM require a super-exclusive lock, like nbtree VACUUM?

2025-02-08 Thread Michail Nikolaev
Hello, everyone! Just some commit messages + few cleanups. Best regards, Mikhail. v8-0002-Fix-index-only-scan-race-condition-in-GiST-implem.patch Description: Binary data v8-0003-Improve-buffer-handling-for-killed-items-in-GiST-.patch Description: Binary data v8-0004-Fix-index-only-scan-rac

Re: Showing applied extended statistics in explain Part 2

2025-02-08 Thread Tomas Vondra
On 1/24/25 11:17, Andrei Lepikhov wrote: > On 11/1/24 12:22, Tatsuro Yamada wrote: >> Hi All, >> >> I apologize for not being able to continue development due to various >> circumstances. >> The attached file is the rebased patch. >> I will now catch up on the discussion and try to revise the pa

Re: proposal - plpgsql - support standard syntax for named arguments for cursors

2025-02-08 Thread Tom Lane
Pavel Stehule writes: > I propose to enhancing to ANSI/SQL standard syntax for named arguments > `argname => value` Is there any reason to think that that's actually in the standard? I poked around in SQL:2021 a little and couldn't find anything about cursors with arguments at all.

Improve pgindent exclude handling: ignore empty lines

2025-02-08 Thread Zsolt Parragi
Hello, We ran into an issue where pgindent stopped reformatting anything with our custom exclude file, and after some investigation we found the empty line accidentally inserted into the exclude file. Pgindent currently treats empty lines as valid exclusions and creates an empty regex from them.

Re: proposal - plpgsql - support standard syntax for named arguments for cursors

2025-02-08 Thread Japin Li
On Sat, 08 Feb 2025 at 16:34, Julien Rouhaud wrote: > Hi, > > On Sat, Feb 08, 2025 at 07:47:23AM +0100, Pavel Stehule wrote: >> Hi >> >> when I worked on strict expr check patch I found so syntax for named >> arguments of cursors supports only our legacy proprietary syntax `argname >> := value` >

Re: pgbench with partitioned tables

2025-02-08 Thread Álvaro Herrera
On 2025-Feb-07, Melanie Plageman wrote: > Okay, I've stared at this a bit, and it seems basically fine the way > it is (I might add a bit more whitespace, clean up the commit message, > etc). So I'm interested in committing it. I will admit that having > never committed anything to pgbench, I'm a

Re: proposal - plpgsql - support standard syntax for named arguments for cursors

2025-02-08 Thread Julien Rouhaud
Hi, On Sat, Feb 08, 2025 at 07:47:23AM +0100, Pavel Stehule wrote: > Hi > > when I worked on strict expr check patch I found so syntax for named > arguments of cursors supports only our legacy proprietary syntax `argname > := value` > > https://www.postgresql.org/docs/current/plpgsql-cursors.html

Re: access numeric data in module

2025-02-08 Thread Ed Behn
I've created a patch (attached) to implement the changes discussed below. This change moves the definition of the NumericVar structure to numeric.h. Function definitions for functions used to work with NumericVar are also moved to the header as are definitions of functions used to convert NumericV

Re: Final result (display) collation?

2025-02-08 Thread Jeff Davis
On Tue, 2024-12-17 at 20:36 -0500, Tom Lane wrote: > Jeff Davis writes: > > Crazy idea: what if we treated the top-level ORDER BY as special? > > This seems like an amazing kluge, and it's not even clear that > there's any field demand for it. I had a discussion with Vik, and he suggested somet

Fix punctuation errors in PostgreSQL documentation

2025-02-08 Thread 斉藤登
Hi, I am a member of the project translating PostgreSQL documentation into Japanese. For the translation, I check the number of sentences by periods. I found some issues in the original English documentation that I believe need to be corrected. Could you please review the attached patch file? Be

Re: proposal - plpgsql - support standard syntax for named arguments for cursors

2025-02-08 Thread Pavel Stehule
so 8. 2. 2025 v 22:25 odesílatel Tom Lane napsal: > Pavel Stehule writes: > > so 8. 2. 2025 v 20:25 odesílatel Tom Lane napsal: > >> Is there any reason to think that that's actually in the standard? > > > I think the possibility to use named arguments in OPEN statements is a > > PostgreSQL pro

Re: Expanding HOT updates for expression and partial indexes

2025-02-08 Thread Laurenz Albe
On Thu, 2025-02-06 at 22:24 +, Burd, Greg wrote: > Attached find a patch that expands the cases where heap-only tuple (HOT) > updates are possible > without changing the basic semantics of HOT. This is accomplished by > examining expression > indexes for changes to determine if indexes requir

Re: proposal - plpgsql - support standard syntax for named arguments for cursors

2025-02-08 Thread Pavel Stehule
Hi so 8. 2. 2025 v 11:27 odesílatel Japin Li napsal: > On Sat, 08 Feb 2025 at 16:34, Julien Rouhaud wrote: > > Hi, > > > > On Sat, Feb 08, 2025 at 07:47:23AM +0100, Pavel Stehule wrote: > >> Hi > >> > >> when I worked on strict expr check patch I found so syntax for named > >> arguments of curs

Re: Get rid of WALBufMappingLock

2025-02-08 Thread Alexander Korotkov
On Fri, Feb 7, 2025 at 1:39 PM Alexander Korotkov wrote: > Good, thank you. I think 0001 patch is generally good, but needs some > further polishing, e.g. more comments explaining how does it work. Two things comes to my mind worth rechecking about 0001. 1) Are XLogCtl->InitializeReserved, XLogC

Re: proposal - plpgsql - support standard syntax for named arguments for cursors

2025-02-08 Thread Pavel Stehule
Hi so 8. 2. 2025 v 20:25 odesílatel Tom Lane napsal: > Pavel Stehule writes: > > I propose to enhancing to ANSI/SQL standard syntax for named arguments > > `argname => value` > > Is there any reason to think that that's actually in the standard? > I poked around in SQL:2021 a little and couldn'

Re: Test to dump and restore objects left behind by regression

2025-02-08 Thread Michael Paquier
On Fri, Feb 07, 2025 at 07:11:25AM +0900, Michael Paquier wrote: > Okay, thanks for the feedback. We have been relying on diff -u for > the parts of the tests touched by 0001 for some time now, so if there > are no objections I would like to apply 0001 in a couple of days. This part has been appl

Re: proposal - plpgsql - support standard syntax for named arguments for cursors

2025-02-08 Thread Tom Lane
Pavel Stehule writes: > so 8. 2. 2025 v 20:25 odesílatel Tom Lane napsal: >> Is there any reason to think that that's actually in the standard? > I think the possibility to use named arguments in OPEN statements is a > PostgreSQL proprietary feature. > And usage of cursors in PL/pgSQL is based o

Re: On non-Windows, hard depend on uselocale(3)

2025-02-08 Thread Peter Eisentraut
Checking the status of this thread ... The patches that removed the configure checks for _configthreadlocale(), and related cleanup, have been committed. The original patch to "Tidy up locale thread safety in ECPG library" is still outstanding. Attached is a rebased version, based on the po