Re: Memory leak in WAL sender with pgoutput (v10~)

2024-12-03 Thread Michael Paquier
On Tue, Dec 03, 2024 at 02:45:22PM +0100, Alvaro Herrera wrote: > We can put the new member at the end of the struct, it shouldn't damage > anything even if they're using this struct -- which I find pretty > unlikely. The only way that could break anything is if somebody is > allocating/using arra

Re: Enhancing Memory Context Statistics Reporting

2024-12-03 Thread Rahila Syed
Hi, > > > > 4) I wonder if the function needs to return PID. I mean, the caller > > knows which PID it is for, so it seems rather unnecessary. > > > > Perhaps it can be used to ascertain that the information indeed belongs > to > > the requested pid. > > > > I find that a bit ... suspicio

Re: Doc: typo in config.sgml

2024-12-03 Thread Bruce Momjian
On Tue, Dec 3, 2024 at 09:05:45PM +0100, Peter Eisentraut wrote: > On 26.11.24 20:04, Bruce Momjian wrote: > > %.pdf: %.fo $(ALL_IMAGES) > > - $(FOP) -fo $< -pdf $@ > > + LANG=C $(FOP) -fo $< -pdf $@ 2>&1 | \ > > + awk 'BEGIN { warn = 0 } { print }/not available in font/ { warn = 1 } >

Re: CRC32C Parallel Computation Optimization on ARM

2024-12-03 Thread John Naylor
On Mon, Dec 4, 2023 at 2:27 PM Xiang Gao wrote: > > [v8 patch] I have a couple quick thoughts on this: 1. I looked at a couple implementations of this idea, and found that the constants used in the carryless multiply are tied to the length of the blocks. With a lookup table we can do the 3-way a

Re: Better error message when --single is not the first arg to postgres executable

2024-12-03 Thread Nathan Bossart
Thanks to Álvaro and Tom for reviewing. On Tue, Dec 03, 2024 at 01:01:29PM -0500, Tom Lane wrote: > +/* special must-be-first options for dispatching to various subprograms */ > +typedef enum Subprogram > +{ > + SUBPROGRAM_CHECK, > + ... etc > > "Subprogram" doesn't quite seem like the ri

Re: Doc: typo in config.sgml

2024-12-03 Thread Peter Eisentraut
On 26.11.24 20:04, Bruce Momjian wrote: %.pdf: %.fo $(ALL_IMAGES) - $(FOP) -fo $< -pdf $@ + LANG=C $(FOP) -fo $< -pdf $@ 2>&1 | \ + awk 'BEGIN { warn = 0 } { print }/not available in font/ { warn = 1 } \ + END { if (warn != 0) print("\nFound characters that cannot be

Re: Doc: typo in config.sgml

2024-12-03 Thread Peter Eisentraut
On 03.12.24 04:13, Bruce Momjian wrote: On Mon, Dec 2, 2024 at 09:33:39PM -0500, Tom Lane wrote: Bruce Momjian writes: Now that we have a warning about non-emittable characters in the PDF build, do you want me to put back the Latin1 characters in the SGML files or leave them as HTML entities?

Remove remnants of "snapshot too old"

2024-12-03 Thread Heikki Linnakangas
I spotted some more remnants of the "snapshot too old" feature that was removed in v17. Barring objections, I will commit the attached patch to tidy up. -- Heikki Linnakangas Neon (https://neon.tech) From a24f69e0bcf38721e5ffe2c7b65f9901fa8b079d Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas

Re: CREATE SCHEMA ... CREATE DOMAIN support

2024-12-03 Thread Tom Lane
Peter Eisentraut writes: > On 30.11.24 20:08, Tom Lane wrote: >> ... I think we ought to nuke >> that concept from orbit and just execute the schema elements in the >> order presented. I looked at several iterations of the SQL standard >> and cannot find any support for the idea that CREATE SCHEM

Re: crash with synchronized_standby_slots

2024-12-03 Thread Amit Kapila
On Tue, Dec 3, 2024 at 10:34 PM Alvaro Herrera wrote: > > On 2024-Nov-29, Amit Kapila wrote: > > BTW it occurs to me that there might well be some sort of thundering > herd problem if every process needs to run the check_hook when a SIGHUP > is broadcast, and they'll all be waiting on that particu

Re: Memory leak in WAL sender with pgoutput (v10~)

2024-12-03 Thread Amit Kapila
On Wed, Dec 4, 2024 at 7:39 AM Zhijie Hou (Fujitsu) wrote: > > On Wednesday, December 4, 2024 8:55 AM Michael Paquier > wrote: > > > > > Amit has concerns with other code paths that could be > > similarly leaking. I'm not sure if this is worth waiting too long > > based on how local the fix for

Re: Cannot find a working 64-bit integer type on Illumos

2024-12-03 Thread Thomas Munro
On Wed, Dec 4, 2024 at 4:04 PM Thomas Munro wrote: > Thanks! Pushed. Let's see what the build farm says. A couple of armv7 animals seemed to die in the Perl tests. Huh. Well I know that Perl was sensitive to this stuff but it passed on 32 bit CI (x86). I will try to reproduce that on local A

<    1   2