RE: Rework subscription-related code for psql and pg_dump

Dear Michael, > I've looked at that again and let this as-is, then applied all this > cleanup. I missed your e-mail but it's ok to keep the output style for two_phase. Thanks a lot for working on it! Best regards, Hayato Kuroda FUJITSU LIMITED

Re: Memory leak in WAL sender with pgoutput (v10~)

On Tue, Dec 3, 2024 at 2:12 AM Alvaro Herrera wrote: > > On 2024-Dec-02, Amit Kapila wrote: > > > Even, if we want a new context for some localized handling, we should > > add that in PGOutputData rather than a local context as the proposed > > patch is doing at the very least for HEAD. > > I don'

Re: on_error table, saving error info to a table

On Tue, Nov 5, 2024 at 6:30 PM Nishant Sharma wrote: > > Thanks for the v2 patch! > > I see v1 review comments got addressed in v2 along with some > further improvements. > > 1) v2 Patch again needs re-base. > > 2) I think we need not worry whether table name is unique or not, > table name can be

Re: Doc: typo in config.sgml

On Tue, Nov 26, 2024 at 02:04:15PM -0500, Bruce Momjian wrote: > On Tue, Nov 26, 2024 at 12:41:37PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > On Tue, Nov 26, 2024 at 11:43:02AM -0500, Tom Lane wrote: > > >> I don't think this patch is doing anything I want at all. > > > > > Gee, I ki

Re: Doc: typo in config.sgml

On Tue, Nov 5, 2024 at 10:08:17AM +0100, Peter Eisentraut wrote: > On 02.11.24 14:18, Bruce Momjian wrote: > > On Sat, Nov 2, 2024 at 12:02:12PM +0900, Tatsuo Ishii wrote: > > > > Yes, we _allow_ LATIN1 characters in the SGML docs, but I replaced the > > > > LATIN1 characters we had with HTML ent

Re: meson missing test dependencies

On Mon, Dec 02, 2024 at 01:50:57PM +0300, Nazir Bilal Yavuz wrote: > On Mon, 2 Dec 2024 at 13:11, Peter Eisentraut wrote: >> Is there any reason this was not done yet? > > This looks useful. I am not sure why this was not done before. Do you think that it would be possible to automate the additi

Re: Rework subscription-related code for psql and pg_dump

On Sat, Nov 30, 2024 at 12:54:19PM +0900, Michael Paquier wrote: > - if (strcmp(subinfo->subtwophasestate, two_phase_disabled) != 0) > + if (subinfo->subtwophasestate != LOGICALREP_TWOPHASE_STATE_DISABLED) > appendPQExpBufferStr(query, ", two_phase = on"); > > I'm not feeling strongly

Re: code contributions for 2024, WIP version

On Mon, Dec 02, 2024 at 04:10:22PM -0500, Robert Haas wrote: > Donning my asbestos underwear, I remain yours faithfully, Thanks for taking the time to compile all that. That's really nice. -- Michael signature.asc Description: PGP signature

Re: Remove useless casts to (void *)

Thomas Munro writes: > Why do we bother with a "Pointer" type? The idiomatic way to do > byte-oriented pointer arithmetic is to cast to char *, or uint8_t* > etc, which doesn't require the reader to go and figure out what stride > that non-standard type name implies. I think getting rid of Point

Re: Doc: typo in config.sgml

Bruce Momjian writes: > Now that we have a warning about non-emittable characters in the PDF > build, do you want me to put back the Latin1 characters in the SGML > files or leave them as HTML entities? I think going forward we're going to be putting in people's names in UTF8 --- I was certainly

Re: Make tuple deformation faster

On Mon, 2 Dec 2024 at 23:24, David Rowley wrote: > I spent all day today reviewing and fixing up a few missing comments > for the v5 patch series. I'm quite happy with these now. If nobody > else wants to look or test, I plan on pushing these tomorrow (Tuesday > UTC+13). If anyone wants me to dela

Re: [PoC] Reducing planning time when tables have many partitions

On Mon, Dec 2, 2024 at 2:22 PM Yuya Watari wrote: > > 4. Discussion > > First of all, tables 1, 2 and the figure attached to this email show > that likely and unlikely do not have the effect I expected. Rather, > tables 3, 4, 5 and 6 imply that they can have a negative effect on > queries A and B

RE: Introduce XID age and inactive timeout based replication slot invalidation

Dear Nisha, Thanks for updating the patch! > Fixed. It is reasonable to align with other timeout parameters by > using milliseconds as the unit. It looks you just replaced to GUC_UNIT_MS, but the documentation and postgresql.conf.sample has not been changed yet. They should follow codes. Anyway,

Re: Memory leak in WAL sender with pgoutput (v10~)

On Tue, Dec 03, 2024 at 08:49:41AM +0100, Alvaro Herrera wrote: > That cannot be backpatched, though. Extra code churn is always annoying across stable branches, so I'd rather avoid it if we can. -- Michael signature.asc Description: PGP signature

Re: Memory leak in WAL sender with pgoutput (v10~)

On 2024-Dec-03, Peter Smith wrote: > Perhaps the patch can use foreach_ptr macro instead of foreach? That cannot be backpatched, though. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Thou shalt not follow the NULL pointer, for chaos and madness await thee at

<    1   2