> On 31 Oct 2024, at 06:48, Thomas Munro wrote:
> I guess at a minimum a copy of the licence would need to appear somewhere
That's my interpretation of it as well.
> perhaps under src/backend/jit/llvm?
Since SectionMemoryManager.h is in src/backend/jit I wonder if it should be a
placed in a se
On Mon, Feb 5, 2024 at 11:58 PM Kyotaro Horiguchi
wrote:
>
> At Fri, 2 Feb 2024 14:42:46 +0100, Thomas Munro
> wrote in
> > On Fri, Feb 2, 2024 at 12:56 PM Yugo NAGATA wrote:
> > > On Fri, 2 Feb 2024 11:18:18 +0100
> > > Thomas Munro wrote:
> > > > One simple way to address that would be to ma
On 23/09/2024 04:39, jian he wrote:
static void
RelationClearRelation(Relation relation)
{
Assert(RelationHasReferenceCountZero(relation));
Assert(!relation->rd_isnailed);
/*
* Relations created in the same transaction must never be removed, see
* RelationFlushRelation
Hi,
I noticed a couple of typos in code. "the the" should have been "the",
attached patch has the changes for the same.
Regards,
Vignesh
diff --git a/src/backend/executor/execExprInterp.c b/src/backend/executor/execExprInterp.c
index 6a7f18f6de..30c5a19aad 100644
--- a/src/backend/executor/execEx
Jacob Champion wrote:
> On Thu, Oct 17, 2024 at 10:51 PM Antonin Houska wrote:
> > * oauth_validator_library is defined as PGC_SIGHUP - is that intentional?
>
> Yes, I think it's going to be important to let DBAs migrate their
> authentication modules without a full restart. That probably deser
I ran some tests and verified that the patch works with previous versions
of PG12 and PG17
1. Verified with publications with generated columns and without generated
columns on patched code and subscriptions on PG12 and PG17
Observations:
a. If publication is created with publish_generated_colu
Hi,
On 10/30/24 3:49 PM, Jelte Fennema-Nio wrote:
On Wed, 30 Oct 2024 at 19:04, Jesper Pedersen
wrote:
Having LSN would be nice, but to break all existing implementations, no.
Having to specify with startup parameters how a core message format
looks like sounds like a bad idea to me,
It woul
Thanks for the review!
On Thu, Oct 31, 2024 at 2:13 PM Masahiko Sawada wrote:
>
>
> Some small suggestions:
>
> + vmbits = visibilitymap_set(vacrel->rel, blkno, buf,
> + InvalidXLogRecPtr,
> + vmbuffer, InvalidTra
Hi,
Even though there has not been a lot of discussion on this, here is a
rebased patch. I have also added it to the upcoming commitfest.
On Sat, Jan 13, 2024 at 09:20:40AM +0100, Michael Banck wrote:
> On Fri, Jan 12, 2024 at 04:13:27PM +0100, Jelte Fennema-Nio wrote:
> > But I'm not sure that
On Tue, Oct 29, 2024 at 10:20:03AM -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > There are a bunch of (void *) casts in the code that don't make sense to
> > me. I think some of these were once necessary because char * was used
> > in place of void * for some function arguments. And so
On Thu, Oct 31, 2024 at 11:10:09AM +0900, Michael Paquier wrote:
> So it looks rather OK seen from here, as you are proposing.
After a second lookup, bumped CATALOG_VERSION_NO, then applied.
--
Michael
signature.asc
Description: PGP signature
Heikki Linnakangas writes:
> I was finally able to reproduce this, by running the failing pg_regress
> tests concurrently with repeated "vacuum full pg_database" calls. It's
> curious that 'prion' failed on the first run after the commit, I was not
> able to reproduce it by just running the unm
On Thu, Oct 31, 2024 at 9:09 PM Amit Langote wrote:
>
>
> I think we should insist that the join key collation and the partition
> collation are exactly the same and refuse to match them if they are
> not.
>
> + {
> + Oid colloid = exprCollation((Node *) expr);
> +
> +
On Wed, Oct 30, 2024 at 5:06 AM Robert Haas wrote:
> On Tue, Sep 24, 2024 at 11:20 PM Richard Guo wrote:
> > The reason is that it is very tricky to set the size estimates for a
> > grouped join relation. For a non-grouped join relation, we know that
> > all its paths have the same rowcount esti
On Thu, Oct 31, 2024 at 01:01:39PM -0700, Noah Misch wrote:
> On Thu, Oct 31, 2024 at 05:00:02PM +0300, Alexander Lakhin wrote:
> > I've accidentally discovered an incorrect behaviour caused by commit
> > 4eac5a1fa. Running this script:
>
> Thanks. This looks important.
>
> > parallel -j40 --lin
On Oct 31, 2024, at 15:41, David E. Wheeler wrote:
> Other Options?
> --
>
> I kind of like Option 2, as it would allow us to eventually support
> non-`CREATE EXTENSION` modules as extensions, too. I imagine distributing,
> say `auto_explain` in an extension directory of its own, w
Here's two backtraces from gdb from this function:
CREATE OR REPLACE FUNCTION test2(graph matrix)
RETURNS bigint LANGUAGE plpgsql AS
$$
BEGIN
perform set_element(graph, 1, 1, 1);
RETURN nvals(graph);
end;
$$;
https://gist.githubusercontent.com/michelp/d02e3e30071044345
On Thu, Oct 24, 2024 at 11:32 AM Tom Lane wrote:
> I wrote:
> > ... I'm still writing up
> > details, but right now I'm envisioning completely separate sets of
> > rules for the prosupport case versus the no-prosupport case.
>
> So here is the design I've come up with for optimizing R/W expanded
On Thu, Oct 31, 2024 at 10:26:01AM -0400, Tom Lane wrote:
> I'd be okay with adding it in a form where the default behavior
> is to do no additional checking. Whether that's worth maintaining
> is hard to say though.
In terms of maintenance, it would be nice if we are able to minimize
the code ad
On 10/31/24 21:00, Alena Rybakina wrote:
On 29.10.2024 05:47, Andrei Lepikhov wrote:
I played around with the examples a bit and couldn't figure out
something. When I added the same values to different columns - firstly
in a, later in b, the order of the columns for sort operation doesn't
ch
On Thu, Oct 31, 2024 at 3:16 AM vignesh C wrote:
> Thanks for committing this patch, here is a rebased version of the
> remaining patches.
>
Hi Vignesh, thanks for the rebased patches.
Here are my review comments for patch v1-0001.
==
Commit message.
1.
The commit message text is stale, so
On Tue, Oct 29, 2024 at 9:59 PM Robert Haas wrote:
> On Wed, Sep 25, 2024 at 3:03 AM Richard Guo wrote:
> > On Wed, Sep 11, 2024 at 10:52 AM Tender Wang wrote:
> > > 1. In make_one_rel(), we have the below codes:
> > > /*
> > > * Build grouped base relations for each base rel if possible.
> > >
101 - 122 of 122 matches
Mail list logo
