Re: RFC: Logging plan of the running query

2024-10-28 Thread torikoshia
Hi I've recently resumed work on this proposal. I was revising tests that use the injection point, but given that there was a recent talk at PGConf.EU about further features based on this proposal [1], I thought it might be of interest to some. Therefore, I'll share a patch that removes the i

Re: Vacuum statistics

2024-10-28 Thread Alexander Korotkov
On Sun, Aug 25, 2024 at 6:59 PM Alena Rybakina wrote: > I didn't understand correctly - did you mean that we don't need SRF if > we need to display statistics for a specific object? > > Otherwise, we need this when we display information on all database > objects (tables or indexes): > > while ((e

Re: Alias of VALUES RTE in explain plan

2024-10-28 Thread Andrei Lepikhov
On 28/10/2024 20:19, Ashutosh Bapat wrote: On Mon, Oct 28, 2024 at 10:17 AM Andrei Lepikhov wrote: On 10/28/24 03:15, Yasir wrote: By design of my solution, I was not taking it as a bug. But now, I agree with your opinion. I think the case provided by Ashutosh was initially correct, and noth

Re: define pg_structiszero(addr, s, r)

2024-10-28 Thread Ranier Vilela
Em seg., 28 de out. de 2024 às 11:33, Heikki Linnakangas escreveu: > On 18/09/2024 21:57, Bertrand Drouvot wrote: > > On Wed, Sep 18, 2024 at 10:03:21AM +0200, Peter Eisentraut wrote: > >> On 18.09.24 06:16, Bertrand Drouvot wrote: > >>> +#define pg_structiszero(addr, s, r) >

Re: Alias of VALUES RTE in explain plan

2024-10-28 Thread Tom Lane
Andrei Lepikhov writes: > My goal is to understand why the implementation follows this pattern. As > I see, previously, we had consistent behaviour, according to which we > removed the pulling-up subquery's alias as well. And I want to know, is > it really the only way to break this behavior? M

Re: define pg_structiszero(addr, s, r)

2024-10-28 Thread Tom Lane
Ranier Vilela writes: > It seems to me that [reversing the loop direction] is more optimized. That's far from clear: you're ignoring the possibility that memory access logic is better optimized for forward scanning than reverse scanning. I'd stick with the forward scan without some extremely det

Re: Fix C23 compiler warning

2024-10-28 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > Alvaro Herrera writes: >> Ah, yeah. That was 2.71 actually: >> https://postgr.es/m/3838336.1657985...@sss.pgh.pa.us >> 1.72 seems to have been released with some fixes from that one. Per >> that thread, the related problem you noticed was with m4, and apparently >> it was bec

RE: Pgoutput not capturing the generated columns

2024-10-28 Thread Zhijie Hou (Fujitsu)
On Monday, October 28, 2024 2:54 PM Hayato Kuroda (Fujitsu) wrote: > > > 02. 031_column_list.pl > > ``` > -# TEST: Generated and dropped columns are not considered for the column > list. > +# TEST: Dropped columns are not considered for the column list. > # So, the publication having a column

Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR)

2024-10-28 Thread Tom Lane
Alexander Lakhin writes: > 27.10.2024 20:41, Tom Lane wrote: >>> In the no-good-deed-goes-unpunished department: buildfarm member >>> hamerkop doesn't like this patch [1]. The diffs look like > I've managed to reproduce the issue with the core.autocrlf=true git setting > (which sets CR+LF line e

Re: sunsetting md5 password support

2024-10-28 Thread Greg Sabino Mullane
On Sat, Oct 26, 2024 at 11:55 AM Nathan Bossart wrote: > rebased > Patch applied without issue and looks good to me. Cheers, Greg

Re: Reduce one comparison in binaryheap's sift down

2024-10-28 Thread Nathan Bossart
On Mon, Oct 28, 2024 at 12:40:20PM -0400, Robert Haas wrote: > Hmm, so at present we compare the parent to the left child and to the > right child. If it's smaller than neither, everything is OK. If it's > smaller than one, we swap it with that one. If it's smaller than both, > we compare the left

Re: sunsetting md5 password support

2024-10-28 Thread Tom Lane
Jim Nasby writes: > Patch itself looks good, but it does leave me wondering if cleartext should > also be deprecated? Not much point unless we also deprecate all of the other auth methods that require cleartext password transmission, which from a quick scan include PAM, BSD, LDAP, and RADIUS. S

Re: Vacuum statistics

2024-10-28 Thread Jim Nasby
> On Oct 28, 2024, at 2:07 PM, Alexander Korotkov wrote: > >> I suppose that if we turn off statistics collection for a certain object, we >> can miss it. In addition, the user may not enable the parameter for the >> object in time, because he will forget about it. > > I agree with this poin

Re: sunsetting md5 password support

2024-10-28 Thread Jim Nasby
> On Oct 28, 2024, at 3:21 PM, Greg Sabino Mullane wrote: > > On Sat, Oct 26, 2024 at 11:55 AM Nathan Bossart > wrote: >> rebased > > Patch applied without issue and looks good to me. Patch itself looks good, but it does leave me wondering if cleartext should

Re: trying again to get incremental backup

2024-10-28 Thread Michael Banck
Hi, So I am a bit confused about the status of the tar format support, and after re-reading the thread (or at least grepping it for ' tar '), this wasn't really much discussed here either. On Wed, Jun 14, 2023 at 02:46:48PM -0400, Robert Haas wrote: > - We only know how to operate on directories,

Re: RFC: Extension Packaging & Lookup

2024-10-28 Thread David E. Wheeler
Greetings Postgres humans, There was much discussion of this proposal at PGConf.eu last week, between Gabriele Bartolini, Peter Eisentraut, Christoph Berg, and Andres Freund (all Cc’d here), and me, among others. We agreed, in principle, to an approach to this feature. Overa

Re: define pg_structiszero(addr, s, r)

2024-10-28 Thread Peter Smith
On Thu, Sep 19, 2024 at 4:57 AM Bertrand Drouvot wrote: > > Hi, > > On Wed, Sep 18, 2024 at 10:03:21AM +0200, Peter Eisentraut wrote: > > On 18.09.24 06:16, Bertrand Drouvot wrote: > > > +#define pg_structiszero(addr, s, r) > > >

<    1   2