Re: On disable_cost

2024-10-05 Thread David Rowley
On Sun, 6 Oct 2024 at 06:29, Alena Rybakina wrote: > > On 04.10.2024 00:52, David Rowley wrote: > > Append > >-> Index Only Scan using lp1_a_idx on lp1 lp_1 > >-> Sort > > Disabled: true > > Sort Key: lp_2.a > > -> Seq Scan on lp2 lp_2 > To be honest, I don’

Re: On disable_cost

2024-10-05 Thread David Rowley
On Sun, 6 Oct 2024 at 08:35, Tom Lane wrote: > BTW, getting off the question of EXPLAIN output for a moment, > I don't understand why disable_cost is still a thing. The > one remaining usage seems trivial to replace, as attached. I didn't notice that any of these remained. I agree we should get

Re: GetRelationPath() vs critical sections

2024-10-05 Thread Andy Fan
Thomas Munro writes: > On Thu, Sep 5, 2024 at 3:58 AM Andres Freund wrote: >> Obviously we could add a version of GetRelationPath() that just prints into a >> caller provided buffer - but that's somewhat awkward API wise. > > For the record, that's exactly what I did in the patch I proposed to >

Re: Eager aggregation, take 3

2024-10-05 Thread Richard Guo
On Sat, Oct 5, 2024 at 6:23 PM Richard Guo wrote: > > On Fri, Sep 27, 2024 at 11:53 AM Richard Guo wrote: > > Here is an updated version of this patch that fixes the rowcount > > estimate issue along this routine. (see set_joinpath_size.) > > I have worked on inventing some heuristics to limit th

Re: New PostgreSQL Contributors

2024-10-05 Thread Alexander Korotkov
On Fri, Oct 4, 2024 at 4:55 PM Christoph Berg wrote: > > All, > > The PostgreSQL Contributor Page > (https://www.postgresql.org/community/contributors/) includes people who have > made substantial, long-term contributions of time and effort to the PostgreSQL > project. The PostgreSQL Contributors

Re: On disable_cost

2024-10-05 Thread Tom Lane
BTW, getting off the question of EXPLAIN output for a moment, I don't understand why disable_cost is still a thing. The one remaining usage seems trivial to replace, as attached. regards, tom lane diff --git a/src/backend/optimizer/path/costsize.c b/src/backend/optimizer/

Re: Refactoring postmaster's code to cleanup after child exit

2024-10-05 Thread Dagfinn Ilmari Mannsåker
Heikki Linnakangas writes: > On 05/10/2024 01:03, Thomas Munro wrote: > >> It's possible that Windows copied the Linux behaviour for AF_UNIX, >> given that it probably has something to do with the WSL project for >> emulating Linux, but IDK. > > Sadly Windows' IO::Socket::UNIX hasn't been impleme

Re: New PostgreSQL Contributors

2024-10-05 Thread Amit Kapila
On Fri, Oct 4, 2024 at 7:25 PM Christoph Berg wrote: > > The PostgreSQL Contributor Page > (https://www.postgresql.org/community/contributors/) includes people who have > made substantial, long-term contributions of time and effort to the PostgreSQL > project. The PostgreSQL Contributors Team reco

Re: New PostgreSQL Contributors

2024-10-05 Thread Andrey M. Borodin
> On 4 Oct 2024, at 18:55, Christoph Berg wrote: > > Thank you and congratulations to all! Well deserved, congratulations! Best regards, Andrey Borodin.

Re: New PostgreSQL Contributors

2024-10-05 Thread vignesh C
On Fri, 4 Oct 2024 at 19:25, Christoph Berg wrote: > > All, > > The PostgreSQL Contributor Page > (https://www.postgresql.org/community/contributors/) includes people who have > made substantial, long-term contributions of time and effort to the PostgreSQL > project. The PostgreSQL Contributors Te

Re: Refactoring postmaster's code to cleanup after child exit

2024-10-05 Thread Heikki Linnakangas
On 05/10/2024 01:03, Thomas Munro wrote: On Sat, Oct 5, 2024 at 7:41 AM Heikki Linnakangas wrote: My test for dead-end backends opens 20 TCP (or unix domain) connections to the server, in quick succession. That works fine my system, and it passed cirrus CI on other platforms, but on FreeBSD it

Re: On disable_cost

2024-10-05 Thread Shayon Mukherjee
On Sat, Oct 5, 2024 at 1:37 AM David Rowley wrote: > On Sat, 5 Oct 2024 at 03:03, Robert Haas wrote: > > I tend to gravitate > > toward displaying things exactly as they exist internally because I've > > had so many bad experiences with having to try to reverse-engineer the > > value stored inte

Re: New PostgreSQL Contributors

2024-10-05 Thread Roberto Mello
On Fri, Oct 4, 2024 at 10:08 AM Greg Sabino Mullane wrote: > Congratulations to all! This seems the sort of thing we should crosspost > to -general and/or -announce, no? > > Congratulations to all! +1 on Greg's suggestion. Roberto

Re: On disable_cost

2024-10-05 Thread Tom Lane
David Rowley writes: > I'd encourage anyone else on the sidelines who has an opinion on how > to display the disabled-ness of a plan node in EXPLAIN to speak up > now, even if it's just a +1 to something someone has already written. > It would be nice to see what more people think. FWIW, I do not

Re: On disable_cost

2024-10-05 Thread Alena Rybakina
Hi! On 04.10.2024 00:52, David Rowley wrote: One thing the patch did cause me to find is the missing propagation of disabled_nodes in make_sort(). It was very obviously wrong with the patched EXPLAIN output and wasn't so obvious with the current output, so perhaps you could look at this patch as