Re: Partitioned tables and [un]loggedness

2024-08-31 Thread Junwang Zhao
On Thu, May 2, 2024 at 2:07 PM Michael Paquier wrote: > > On Thu, Apr 25, 2024 at 08:55:27AM +0900, Michael Paquier wrote: > > On Wed, Apr 24, 2024 at 04:43:58PM -0700, David G. Johnston wrote: > >> My point is that if you feel that treating logged as a copy-able property > >> is OK then doing the

Re: Add tests for PL/pgSQL SRFs

2024-08-31 Thread Tom Lane
Paul Jungwirth writes: > While working on inlining non-SQL SRFs [1] I noticed we don't have tests for > when a PL/pgSQL > function requires materialize mode but doesn't have a result TupleDesc. Here > is a patch adding tests > for that, as well as some other conditions around SRF calls with `S

JIT: The nullness of casetest.value can be determined at the JIT compile time.

2024-08-31 Thread Xing Guo
Hi hackers, The nullness of casetest.value can be determined at the JIT compile time. We can emit fewer codes by utilizing this property. The attached patch is trying to fix it. Best Regards, Xing From e366f50ec5fff46b537994c0ff4babe6646a97e5 Mon Sep 17 00:00:00 2001 From: Xing Guo Date: Sat, 31

Re: ANALYZE ONLY

2024-08-31 Thread Michael Harris
Thanks David I had not read that wiki page well enough, so many thanks for alerting me that I had to create a commitfest entry. I already had a community account so I was able to login and create it here: https://commitfest.postgresql.org/49/5226/ I was not sure what to put for some of the fie

Re: ANALYZE ONLY

2024-08-31 Thread Michael Harris
Hello Atsushi & Melih Thank you both for your further feedback. On Thu, 29 Aug 2024 at 21:31, Melih Mutlu wrote: > I believe moving "[ ONLY ]" to the definitions of table_and_columns below, as > you did with "[ * ]", might be better to be consistent with other places (see > [1]) Agreed. I hav

Re: not null constraints, again

2024-08-31 Thread Tender Wang
Alvaro Herrera 于2024年8月31日周六 11:59写道: > Hello > > Here I present another attempt at making not-null constraints be > catalogued. This is largely based on the code reverted at 9ce04b50e120, > except that we now have a not-null constraint automatically created for > every column of a primary key,

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-08-31 Thread Bharath Rupireddy
Hi, Thanks for looking into this. On Fri, Aug 30, 2024 at 8:13 AM Peter Smith wrote: > > == > Commit message > > 1. > ... introduces a GUC allowing users set inactive timeout. > > ~ > > 1a. You should give the name of the new GUC in the commit message. Modified. > 1b. /set/to set/ Reworde

Re: generic plans and "initial" pruning

2024-08-31 Thread Junwang Zhao
Hi, On Thu, Aug 29, 2024 at 9:34 PM Amit Langote wrote: > > On Fri, Aug 23, 2024 at 9:48 PM Amit Langote wrote: > > On Wed, Aug 21, 2024 at 10:10 PM Robert Haas wrote: > > > On Wed, Aug 21, 2024 at 8:45 AM Amit Langote > > > wrote: > > > > * The replanning aspect of the lock-in-the-executor d

Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

2024-08-31 Thread Jelte Fennema-Nio
On Sat, 31 Aug 2024 at 06:04, Alexander Lakhin wrote: > At the same time, mylodon confirmed my other finding at [1] and failed [2] > with: > -ERROR: canceling statement due to statement timeout > +ERROR: canceling statement due to user request > > [1] > https://www.postgresql.org/message-id/4d

Re: type cache cleanup improvements

2024-08-31 Thread Andrei Lepikhov
On 29/8/2024 11:01, Alexander Korotkov wrote: On Mon, Aug 26, 2024 at 11:26 AM Alexander Korotkov Secondly, I'm not terribly happy with current state of type cache. The caller of lookup_type_cache() might get already invalidated data. This probably OK, because caller probably hold locks on depen

Re: index prefetching

2024-08-31 Thread Tomas Vondra
Hi, Here's an updated (and pretty fundamentally reworked) patch to add prefetching to regular index scans. I'm far happier with this approach than with either of the two earlier ones, and I actually think it might even be easier to combine this with the streaming read (which the patch does not use