Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

2024-08-17 Thread Jelte Fennema-Nio
On Fri, 16 Aug 2024 at 19:44, Jacob Champion wrote: > Keeping in mind that I'm responding to the change from 3 to 3: Let me start with the fact that I agree we **shouldn't** change 3 to 3. And the proposed patch also specifically doesn't. > https://github.com/search?q=PQprotocolVersi

Re: Opinion poll: Sending an automated email to a thread when it gets added to the commitfest

2024-08-17 Thread Thomas Munro
On Sat, Aug 17, 2024 at 11:36 AM David Rowley wrote: > I don't really object, but I think a better aim would be to merge > CFbot with CF so that we could get to those places from the CF entry. Ack. Some progress is happening on that front, working with Jelte and Magnus off-list...

Re: Speed up Hash Join by teaching ExprState about hashing

2024-08-17 Thread Tels
Hello David, you wrote: v4 patch attached. If nobody else wants to look at this then I'm planning on pushing it soon. Had a very brief look at this bit caught my attentioon: + EEO_CASE(EEOP_HASHDATUM_NEXT32_STRICT) + { + FunctionCallInfo fcin

Re: Opinion poll: Sending an automated email to a thread when it gets added to the commitfest

2024-08-17 Thread Daniel Verite
Jelte Fennema-Nio wrote: > I'd like to send an automatic mail to a thread whenever it gets added > to a commitfest Instead of sending a specific mail, what about automatically adding a mail header like: X-CommitFest-Entry: to every outgoing mail

Re: Restart pg_usleep when interrupted

2024-08-17 Thread Sami Imseih
> time. I wouldn't say I'm diametrically opposed to this patch, but I do > think we need to carefully consider whether it's worth the extra code. FWIW, besides the patch that Bertrand is proposing [1], there is another parallel vacuum case being discussed to allow for parallel heap scan [2]. Be

gitmaster server problem?

2024-08-17 Thread Bruce Momjian
About 20 minutes ago I starting getting gitmaster pull errors: $ git pull ssh://g...@gitmaster.postgresql.org/postgresql.git ssh: connect to host gitmaster.postgresql.org port 22: Connection timed out fatal: Could not read from remote repository. Pl

Re: gitmaster server problem?

2024-08-17 Thread Matthias van de Meent
On Sat, 17 Aug 2024 at 18:41, Bruce Momjian wrote: > > About 20 minutes ago I starting getting gitmaster pull errors: > > $ git pull ssh://g...@gitmaster.postgresql.org/postgresql.git > ssh: connect to host gitmaster.postgresql.org port 22: Connection > timed > out >

Re: Remove dependence on integer wrapping

2024-08-17 Thread Joseph Koshakow
Hi, I wanted to take this opportunity to provide a brief summary of outstanding work. > Also there are several trap-producing cases with date types: > SELECT to_date('1', 'CC'); > SELECT to_timestamp('10,999', 'Y,YYY'); > SELECT make_date(-2147483648, 1, 1); This is resolved with

Re: gitmaster server problem?

2024-08-17 Thread Joe Conway
On 8/17/24 13:59, Matthias van de Meent wrote: On Sat, 17 Aug 2024 at 18:41, Bruce Momjian wrote: About 20 minutes ago I starting getting gitmaster pull errors: $ git pull ssh://g...@gitmaster.postgresql.org/postgresql.git ssh: connect to host gitmaster.postgresql.org port 22:

Re: Building with meson on NixOS/nixpkgs

2024-08-17 Thread Wolfgang Walther
Tristan Partin: On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote: [..] commit a00fae9d43e5adabc56e64a4df6d332062666501 Author: Heikki Linnakangas Date:   2024-07-27 13:53:08 +0300     Fallback to uuid for ossp-uuid with meson [..] I think this is a redundant change with commit 2416fdb

Re: Building with meson on NixOS/nixpkgs

2024-08-17 Thread Wolfgang Walther
Tristan Partin: On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote: commit 4d8de281b5834c8f5e0be6ae21e884e69dffd4ce Author: Heikki Linnakangas Date:   2024-07-27 13:53:11 +0300     Fallback to clang in PATH with meson [..] I think this is a bad change unfortunately - this way clang and l

Re: Remove dependence on integer wrapping

2024-08-17 Thread Joseph Koshakow
>>> SET temp_buffers TO 10; >>> >>> CREATE TEMP TABLE t(i int PRIMARY KEY); >>> INSERT INTO t VALUES(1); >>> >>> #4 0x7f385cdd37f3 in __GI_abort () at ./stdlib/abort.c:79 >>> #5 0x5620071c4f51 in __addvsi3 () >>> #6 0x562007143f3c in init_htab (hashp=0x562008facb20, nelem=610

Re: Restart pg_usleep when interrupted

2024-08-17 Thread Thomas Munro
On Wed, Aug 14, 2024 at 9:30 AM Nathan Bossart wrote: > Another concern is the huge number of PqMsg_Progress messages sent by > parallel workers with that approach. In Bertrand's tests, he was seeing > nearly 350K interrupts for a ~19 minute vacuum (~300 interrupts per > second). That seems a bi

Re: Restart pg_usleep when interrupted

2024-08-17 Thread Thomas Munro
On Sun, Aug 18, 2024 at 11:12 AM Thomas Munro wrote: > I guess both of these issues go away in practice if > CF #5118 goes in. To be more precise, if you just keep doing pg_usleep() the issue goes away, and likewise for posix_fallocate() it goes away... But if you switch to WaitLatchUs() so you

Re: Remove dependence on integer wrapping

2024-08-17 Thread Alexander Lakhin
Hello Joe, 17.08.2024 22:16, Joseph Koshakow wrote: Hi, I wanted to take this opportunity to provide a brief summary of outstanding work. > Also there are several trap-producing cases with date types: > SELECT to_date('1', 'CC'); > SELECT to_timestamp('10,999', 'Y,YYY'); > SELE